summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* mp4 types in omnibox only for chrome, not chromiumfbarchard@chromium.org2009-07-221-0/+3
| | | | | | | | | | | | The types are still claimed as supported because layout tests require them, but the extensions will not map to mimetypes, so typing them into the omnibox will download instead of trying to play the video. The fixes for canPlayType that kyle is doing will fix some of this, and we'll also need to update the media in the layouttests. So that portion of mimetype will be deferred BUG=17323 TEST=in the omni box type in the name of an mp4 and it should work in chrome, but not in chromium. Review URL: http://codereview.chromium.org/155835 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21261 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use new xdg-settings "check" feature to determine whether we are the ↵mdm@chromium.org2009-07-222-18/+19
| | | | | | | | | | | default browser. BUG=17093 TEST=in GNOME, let Firefox set itself as the default after Chrome has set itself; Chrome should then detect that it is no longer the default Review URL: http://codereview.chromium.org/155889 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21260 0039d316-1c4b-4281-b951-d872f2087c98
* Add a unit test for ProcessWatcher::EnsureProcessTerminated().thestig@chromium.org2009-07-222-0/+59
| | | | | | Review URL: http://codereview.chromium.org/155799 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21259 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the include from "base/gfx/platform_canvas.h" to ↵ajwong@chromium.org2009-07-2210-64/+4
| | | | | | | | | | | | "skia/ext/platform_canvas.h" BUG=None TEST=None Review URL: http://codereview.chromium.org/159057 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21258 0039d316-1c4b-4281-b951-d872f2087c98
* Add back a test which I removed, as it is failing again.eroman@chromium.org2009-07-221-0/+3
| | | | | | | | | | | Baseline must have changed with last merge. BUG=17326 TBR=paul Review URL: http://codereview.chromium.org/155903 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21257 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Center the tab text by its meanline, rather than halfway between its ↵estade@chromium.org2009-07-221-1/+3
| | | | | | | | | | | | ascent and descent. The tab text was previously one pixel too high. With this patch it matches Windows. I think before Evan's recent font size patch, this issue was hidden by favorable rounding. Review URL: http://codereview.chromium.org/159169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21256 0039d316-1c4b-4281-b951-d872f2087c98
* When a web contents drag has a URL but no title, make up a title for it.estade@chromium.org2009-07-221-14/+30
| | | | | | | | | BUG=17393 TEST=drag nntp thumbnail to bookmark bar Review URL: http://codereview.chromium.org/155900 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21255 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create new tabs for middle clicks on bookmark items when the user ↵estade@chromium.org2009-07-221-0/+6
| | | | | | | | | | | releases off the item. BUG=14518 TEST=see bug Review URL: http://codereview.chromium.org/155902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21254 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity fixes to keep coverity quiet.sra@chromium.org2009-07-226-9/+35
| | | | | | | | | | | | | | | | | Only the first issue is remotely interesting. * Possibility (low) of using NULL SinkStream* courgette tool 'gen1a' command. * Added initializers for all class members to several constructors. * return 0 at end of from wmain. BUG=none TEST=existing Review URL: http://codereview.chromium.org/155820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21253 0039d316-1c4b-4281-b951-d872f2087c98
* make 'test_shell' target depend on everything needed to pass layout_testsdpranke@google.com2009-07-225-14/+28
| | | | | | | | | | | | | | | | | This adds project dependencies to test_shell so that all (and only?) the targets needed for the layout_tests to run cleanly are built. On most platforms this is test_shell, npapi_test_plugin, and test_worker, and on the Mac this adds the layout_test_helper binary as well also, this moves image_diff from chrome/tools/test to tools/ R=mmentovai@google.com, darin@google.com BUG=none TEST=none Review URL: http://codereview.chromium.org/149714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21252 0039d316-1c4b-4281-b951-d872f2087c98
* Split NSSDecryptor out into platform specific files.willchan@chromium.org2009-07-2216-574/+817
| | | | | | | | | | This lets Linux not bother to initialize NSS in the same way as the rest, but instead use the NSS symbols linked into the library, thereby preventing the NSS_Shutdown related bugs. BUG=http://crbug.com/13929 TEST=Case 1: Start chrome. Use firefox import utility. Browse to some https site. Shouldn't crash. Case 2: Start chrome. Browse to some https site. Use firefox import utility. Continue browsing https sites. Shouldn't crash. Review URL: http://codereview.chromium.org/159165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21251 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add windowless plugin plumbingpiman@google.com2009-07-226-28/+85
| | | | | | | Review URL: http://codereview.chromium.org/159128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21250 0039d316-1c4b-4281-b951-d872f2087c98
* Add <if> blocks to xtb files in the simplest possible way. This currentlytc@google.com2009-07-221-1/+18
| | | | | | | | | | | | only supports checking the OS, but we can add more information if necessary. BUG=16884 Review URL: http://codereview.chromium.org/159148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21249 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add command-line flag to allow debugging of sandboxed processespiman@google.com2009-07-224-4/+20
| | | | | | | Review URL: http://codereview.chromium.org/159124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21248 0039d316-1c4b-4281-b951-d872f2087c98
* Creating a unique user-agent string for ChromeOS builds, so that metrics can ↵evan@chromium.org2009-07-225-9/+152
| | | | | | | | | be aggregated separately from standard Chrome on Linux Review URL: http://codereview.chromium.org/155101 Patch from Chris Masone <cmasone@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21247 0039d316-1c4b-4281-b951-d872f2087c98
* Try again: Add proxy config (using gnome-network-preferences)mattm@chromium.org2009-07-227-55/+142
| | | | | | | | | BUG=11507 TEST=Open options, click change proxy, gnome-network-preferences should launch.  If gnome isn't installed or running, LinuxProxyConfig wiki page should load. Review URL: http://codereview.chromium.org/155792 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21246 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline some layout-tests which changed in upstream webkit r46412.ericroman@google.com2009-07-2210-48/+44
| | | | | | | | BUG=http://crbug.com/17326 Review URL: http://codereview.chromium.org/159159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21245 0039d316-1c4b-4281-b951-d872f2087c98
* Addressing minor review comments in ExtensionProcessManager post-submit.finnur@chromium.org2009-07-221-0/+3
| | | | | | | | | BUG=None TEST=None (no significant changes) Review URL: http://codereview.chromium.org/159073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21244 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring to share MockAudioOutputStream implementations across 3 platformshclam@google.com2009-07-2220-197/+191
| | | | | | | | | | | | | Re-trying the previous CL. The last change got reverted because of valgrind failure. TBR=scherkus Original CL: http://codereview.chromium.org/155471 Review URL: http://codereview.chromium.org/159167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21242 0039d316-1c4b-4281-b951-d872f2087c98
* Implement bookmark editor. No tree display or hierarchy movement, butjrg@chromium.org2009-07-219-64/+1191
| | | | | | | | | | | | | | | | | | name/url editing works. Get to the edotir from a context menu (Edit, Add Page). Also Implement Open All Bookmarks menu item. BUG=http://crbug.com/8381, http://crbug.com/17006 TEST=Add some bookmarks. Right-click on a bookmark and pick Edit. Test editing the name and URL. Make sure you can't add a bogus URL. Right-click on a bookmark or the bar and Add Page. Fill in name and URL fields to add a new bookmark. Right-click Open All Bookmarks and make sure it hoses your machine. Review URL: http://codereview.chromium.org/155874 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21241 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where error pages inserted HTML from a template but thearv@google.com2009-07-212-18/+25
| | | | | | | | | | | | | | | | | | string from the template was used with JST instead of the i18n template and therefore it did not get recursively processed. Also make sure we can support recursive handling of setting innerHTML with the i18n template engine. BUG=17377 TEST=Navigate to http://ponderer.org/tests/redirect-loop.py The error page should show: The webpage at http://ponderer.org/tests/redirect-loop.py has ... Review URL: http://codereview.chromium.org/155884 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21240 0039d316-1c4b-4281-b951-d872f2087c98
* Use a <button> that looks like a link to prevent right click and middle click.arv@google.com2009-07-211-2/+8
| | | | | | | | | | | BUG=9591 TEST=Go to the history page and make sure that "Delete history for this day" still works and that it does not allow opening the "link" in a new window. Review URL: http://codereview.chromium.org/155892 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21239 0039d316-1c4b-4281-b951-d872f2087c98
* Use local copies of files from bug tracker (URL still in comments); avoids ↵dkegel@google.com2009-07-213-7/+131
| | | | | | | | wget dependency Review URL: http://codereview.chromium.org/159175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21238 0039d316-1c4b-4281-b951-d872f2087c98
* Linux packaging updates.mdm@chromium.org2009-07-211-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/155828 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21237 0039d316-1c4b-4281-b951-d872f2087c98
* Update expected test failures after WebKit merge r46143:46194paul@chromium.org2009-07-211-0/+8
| | | | | | | | | | TBR=darin TEST=none BUG=none Review URL: http://codereview.chromium.org/155896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21236 0039d316-1c4b-4281-b951-d872f2087c98
* Change URLRequest to return net::ERR_INVALID_URL on redirects to invalid urls.willchan@chromium.org2009-07-214-0/+21
| | | | | | | | | BUG=http://crbug.com/17126 TEST=net_unittests Review URL: http://codereview.chromium.org/159034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21234 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Fixes button state on pressed back/forward buttons and toolbar ↵erg@google.com2009-07-212-17/+25
| | | | | | | | | | | | | | | | | items. This patch fixes two related problems: 1) Holding down back/forward now stay pressed while the menu is shown. 2) Buttons on the "toolbar" now emulate GTK's toolbar behaviour of only showing the border on hover. http://crbug.com/17308 http://crbug.com/17340 Review URL: http://codereview.chromium.org/159154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21233 0039d316-1c4b-4281-b951-d872f2087c98
* Sometimes it's possible for a DOMUI to request images that don't exist ↵glen@chromium.org2009-07-211-1/+5
| | | | | | | | | | | (theme provider could specify null, or no custom image is provided). Move DCHECK protection into real code. BUG=17257 TEST=Run purify as described in bug. Review URL: http://codereview.chromium.org/159146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21232 0039d316-1c4b-4281-b951-d872f2087c98
* Fix context menu on download item.thakis@chromium.org2009-07-211-3/+3
| | | | | | | | | BUG=none TEST=Click arrow part of download item. A context menu should appear. Review URL: http://codereview.chromium.org/159174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21231 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Two fixes for the tab leak:jhawkins@chromium.org2009-07-213-16/+4
| | | | | | | | | | | * The tab strip handles the lifetime of the tab widget, so don't try to increase the ref count in order to destroy the widget later. * Use DeleteSoon when deleting the dragged tab in order to give gtk a chance to clean up its ref counts added during the drag operation. BUG=12863 TEST=Extensive tab dragging. No crashes and the Linux UI valgrind bot should stay green. Review URL: http://codereview.chromium.org/159166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21230 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test for chrome\installer\util\versionsra@chromium.org2009-07-212-0/+83
| | | | | | | | | BUG=none TEST=this Review URL: http://codereview.chromium.org/155842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21229 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Make GtkThemeProvider own the gtk label widget. The widget is not ↵jhawkins@chromium.org2009-07-212-5/+7
| | | | | | | | | | added to a container, so we don't have the convenience of having it destroyed by the container. BUG=none TEST=Watch the Linux UI valgrind bot get a little greener. Review URL: http://codereview.chromium.org/159157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21228 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes a number of things that are warnings in the Mac compiler.gspencer@google.com2009-07-2145-582/+616
| | | | | | | | | It fixes at least two real bugs, one in the tar generator, and one in stream_bank.h. Review URL: http://codereview.chromium.org/159168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21227 0039d316-1c4b-4281-b951-d872f2087c98
* Making some crash signature more generic. huanr@chromium.org2009-07-211-2/+2
| | | | | | Review URL: http://codereview.chromium.org/155886 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21225 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge r46143:46194paul@chromium.org2009-07-211-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/159164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21224 0039d316-1c4b-4281-b951-d872f2087c98
* Modified generate-texture to turn off texture filtering when run in seleniumvangelis@google.com2009-07-213-2/+16
| | | | | | | | so that we get consistent results. Also bumped up the pdiff threshold for 2d sample on the mac to its previous number to get the test to pass until we fix it. Review URL: http://codereview.chromium.org/155885 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21223 0039d316-1c4b-4281-b951-d872f2087c98
* Make middle-clicking on GTK tabs not count for closing if you release off of ↵brettw@chromium.org2009-07-211-1/+6
| | | | | | | | | | the tab itself. BUG=none TEST=none Review URL: http://codereview.chromium.org/159158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21221 0039d316-1c4b-4281-b951-d872f2087c98
* New Linux baselines for dotted/dashed CSS borders, changed by ↵senorblanco@chromium.org2009-07-21219-110/+110
| | | | | | | | | | | http://bugs.webkit.org/show_bug.cgi?id=27388 . BUG=http://crbug.com/474 TEST=After sheriff rolls DEPS, Linux buildbots should be greener. Review URL: http://codereview.chromium.org/155877 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21220 0039d316-1c4b-4281-b951-d872f2087c98
* New Windows baselines for dotted/dashed CSS borders, changed upstream bysenorblanco@chromium.org2009-07-21221-119/+119
| | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=27388 BUG=http://crbug.com/474 TEST=Windows webkit bots should be greener after sheriff rolls DEPS. Review URL: http://codereview.chromium.org/155880 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21219 0039d316-1c4b-4281-b951-d872f2087c98
* deleting old file which we had issues with gcl commits onfbarchard@chromium.org2009-07-211-326/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21217 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r21117 as it caused reliability failures.estade@chromium.org2009-07-2129-217/+356
| | | | | | | | | | Also included in this revert: r21165, r21180, and a couple valgrind suppression edits TBR=huanr Review URL: http://codereview.chromium.org/155876 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21216 0039d316-1c4b-4281-b951-d872f2087c98
* fix warnings treated as errors on line 94 and 97 that are allowed on try ↵fbarchard@chromium.org2009-07-211-0/+7
| | | | | | | | | | | server, but not buildbot. doh BUG=17304 TEST=buildbot has different warnings than try server. this patch reenables the qtfaststart build with 2 warnings fixed. Review URL: http://codereview.chromium.org/155834 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21215 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Merge the recent activities into one list and show more itemsarv@google.com2009-07-214-119/+184
| | | | | | | | | | | | | | | | | | when the section is larger. Make the window menu look and behave more like a tooltip. Return more recently closed windows and tabs when using the NNTP. BUG=16539, 16835, 14963 TEST=Hide and show the tips section. More items (if there are more items) should be shown. Hover over a closed window and the tooltip should look like a tooltip on Vista/Win7 Review URL: http://codereview.chromium.org/155865 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21214 0039d316-1c4b-4281-b951-d872f2087c98
* Skia merge 278:279agl@chromium.org2009-07-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21213 0039d316-1c4b-4281-b951-d872f2087c98
* svn wont allow commit of file. renaming to _ to avoid svn.fbarchard@chromium.org2009-07-211-0/+326
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21212 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for RevocableStore leakdkegel@google.com2009-07-211-0/+17
| | | | | | | | | | Fix a missing ... in a suppression for an infrequent warning BUG=16625,17385 TEST=watch mac valgrind unit test bot go green Review URL: http://codereview.chromium.org/159150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21211 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor tar code to support long names.gman@google.com2009-07-217-65/+189
| | | | | | | | | | | | | | | | | | | | The previous code only support names up to 99 chars. This one supports up to 1024. The code actually supports 32bit length but given that Linux, OSX and other only support 255 I set it 1024. Why 1024? Because Windows actually supports 255 wchar characters which when converted to utf-8 could be up to 1024 bytes. I'm not 100% sure the format is correct. I could not find any docs on the format, Just reverse engineered it. Looking at hex dumps by both 7zip and gnu tar it was pretty clear what it does including zeroing many of the standard fields. Review URL: http://codereview.chromium.org/159129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21210 0039d316-1c4b-4281-b951-d872f2087c98
* Delete bad sleep based testsgman@google.com2009-07-211-21/+0
| | | | | | | | | | | If you need the tests, refractor them to follow the guidelines instead of having them fail intermittently http://big.corp.google.com/~joejoejoe/testing/2008/05/episode-90-sleeping-synchronization_27.html Review URL: http://codereview.chromium.org/159117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21209 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for keys not working when plugin has focus in pingpong sample.apatrick@google.com2009-07-211-15/+4
| | | | | | | | http://code.google.com/p/o3d/issues/detail?id=67 Review URL: http://codereview.chromium.org/155872 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21208 0039d316-1c4b-4281-b951-d872f2087c98
* Make GTK file dialog box modal for parent window, instead of for the entireestade@chromium.org2009-07-215-7/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | application. This works by adding the top-level GtkWindow objects, such as BrowserWindowGtk and BookmarkManagerGtk, to their own unique window groups. Without this change, all top-level windows are added to a default application-wide window group. This ensures that all grabs created with gtk_grab_add(...) only affect the window group of the grabbed widget, as opposed to the entire application. Note that gtk_window_set_modal(...) is implemented with gtk_grab_add(...) and therefore is only modal to a specific window group. In order for this to work correctly, changes were also made to the info bubble and render widget popup (<select> tag) code. Since these widgets also call gtk_grab_add(...), they must be added to the top level window group to work correctly. Test 1: - Open two new chrome window: A and B - Open "Save file as..." dialog in window A - Verify that window A does not respond to keyboard or mouse events. - Verify that window B does responde to keyboard and mouse events. - Open "Save file as..." dialog in window B - Verify that window B does not respond to keyboard or mouse events. - Cancel dialog on window A. - Verify that window A starts responding to keyboard and mouse events. - Cancel dialog on window B. - Verify that window B starts responding to keyboard and mouse events. Test 2: - Verify that <select> tag allows for correct selection of items. Test 3: - Click bookmark star and verify that info bubble works correctly. BUG=8727 TEST=none patch by Mohit Muthanna Cheppudira <mohit.muthanna [at] gmail> original review url: <http://codereview.chromium.org/155852> Review URL: http://codereview.chromium.org/159147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21207 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 06:15:07 +0000