| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
rather than being derived from it. This reduces the spaghetti somewhat. Also decouples the notion of a native view hierarchy from the location in TabContents::PageHasOSDD where the template URL fetcher is spawned. The Template URL Fetcher now simply retains a reference to the TabContents that created it. If the TabContents is destroyed before the fetch completes, we just discard the data retrieved without adding a keyword.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
own TabContentsView implementation.
BUG=14469
TEST=none
Review URL: http://codereview.chromium.org/146010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crome/browser/gtk/gtk_chrome_link_button.cc needs stdlib.h for free and malloc
on gcc-4.3
patch by Joel Stan <joel.stan@gmail.com>
original review: http://codereview.chromium.org/147002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in the tree.
Review URL: http://codereview.chromium.org/144016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of manually formatting it.
BUG=14878
TEST=Open a new window with at least 2 tabs. Close it and go to the
NTP and it should say "2 tabs" under recently closed.
Review URL: http://codereview.chromium.org/144022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=covered by test case.
BUG=13809 (http://crbug.com/13809)
Review URL: http://codereview.chromium.org/146008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
moves over the window.
BUG=none
TEST=Open two browser windows with multiple tabs. Make sure the windows overlap. Drag a tab from the top-level window into the frame of the other window. The lower window should be raised after a delay.
Review URL: http://codereview.chromium.org/146004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
This is (cleaned up) code from Breakpad's /client/linux/handler/minidump_generator.cc.
Review URL: http://codereview.chromium.org/146001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/145015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
but didn't update the code that compensated for their previously-different heights.
BUG=13812
Review URL: http://codereview.chromium.org/145017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/145025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/144021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The decoder needs a concept of state to know when it should just stop attempting to decode. This is because ffmpeg will sometimes gives spurious frames back, which plays badly with the time presentation timestamp calculation logic.
Review URL: http://codereview.chromium.org/132013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not implemented but it is time to get this submitted and iron out the
remaining issues.
BUG=13362
TEST=Start chrome with --new-new-tab-page and look at play arouind with
the new tab page.
Review URL: http://codereview.chromium.org/132027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the call stack.
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/145007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov,amanda
BUG=14951 (http://crbug.com/14951)
TEST=covered by test case
Review URL: http://codereview.chromium.org/144017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
This is code from Breakpad's /client/linux/handler/minidump_generator.cc.
Review URL: http://codereview.chromium.org/144002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/144009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/145022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Ignore the expected_crashes_ since Linux doesn't have crash_service.
Review URL: http://codereview.chromium.org/144014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the PNG library, and it turns on some functionality that O3D needs for manipulating PNG files: It removes the definition of PNG_NO_WRITE_FILLER, PNG_NO_READ_FILLER, PNG_NO_SEQUENTIAL_READ_SUPPORTED, and PNG_NO_INFO_IMAGE from pngusr.h so that the functions used by O3D to read images progressively and for filler bytes for pixel expansion (RGB -> RGBX) are available.
BUG=none
TEST=successful trybot run for all platforms.
Review URL: http://codereview.chromium.org/140074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13838
TEST=Open two browser windows. Drag one of the tabs into the other tabstrip. The first browser window should disappear and the browser should not crash.
Review URL: http://codereview.chromium.org/145019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14113
TEST=the navigation hotkeys now work in fullscreen mode. Make sure the follownig all work:
{ GDK_Left, IDC_BACK, GDK_MOD1_MASK },
{ GDK_BackSpace, IDC_BACK, GdkModifierType(0) },
{ XF86XK_Back, IDC_BACK, GdkModifierType(0) },
{ GDK_Right, IDC_FORWARD, GDK_MOD1_MASK },
{ GDK_BackSpace, IDC_FORWARD, GDK_SHIFT_MASK },
{ XF86XK_Forward, IDC_FORWARD, GdkModifierType(0) },
{ GDK_r, IDC_RELOAD, GDK_CONTROL_MASK },
{ GDK_F5, IDC_RELOAD, GdkModifierType(0) },
{ GDK_F5, IDC_RELOAD, GDK_CONTROL_MASK },
{ XF86XK_Reload, IDC_RELOAD, GdkModifierType(0) },
{ XF86XK_Refresh, IDC_RELOAD, GdkModifierType(0) },
key: { button, action, modifier }, where MOD1 = alt
Review URL: http://codereview.chromium.org/145020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=14946 (http://crbug.com/14946)
TEST=covered in test case
Review URL: http://codereview.chromium.org/145021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/14518
TEST=middle click on an infobar link, it should open in a new tab
Review URL: http://codereview.chromium.org/145013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The BrowserWindow creates the task manager UI directly, which uses the TaskManager to populate itself.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and added accessors.
Review URL: http://codereview.chromium.org/140080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/145001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=paul
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/144011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Test=none
BUG=none
Review URL: http://codereview.chromium.org/144007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NOTIMPLEMENTED() to the console.
http://crbug.com/14935
Review URL: http://codereview.chromium.org/145011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the current Autocomplete edit box and by using Gtk clipboard, it will paste and search it.
BUG=14800 (http://crbug.com/14800)
TEST=Selected text from view and right clicked copied. Went to the omnibox and right clicked > Paste and Go. It navigated to the page successfully.
Review URL: http://codereview.chromium.org/140050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
down to it so the window was never laid out when it was initially created.
http://crbug.com/14637
TEST=first run bubble should not be black
Review URL: http://codereview.chromium.org/145006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is off. Only paint the custom frame png if the custom frame is
on.
This fixes a bug where the blue gradient wans't applied on the window-decoration version.
Review URL: http://codereview.chromium.org/145005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions.enable pref was not being honored. Add tests.
This is intended to be submitted after:
http://codereview.chromium.org/132003
BUG=13467
TEST=Added unit tests
Review URL: http://codereview.chromium.org/132045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12258
TEST=unittests
Review URL: http://codereview.chromium.org/140015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/144005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is mainly intended to be pulled to the 3.0 branch. It won't be submitted until another corresponding change to
undo the damage is ready.
BUG=13467
TEST=Added unit tests
Review URL: http://codereview.chromium.org/132003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11441
TEST=Try the non-standard browser keys on a keyboard that has them. I.e. the back and forward button on a Thinkpad.
Review URL: http://codereview.chromium.org/140081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
Review URL: http://codereview.chromium.org/144004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The following tests needs to be rebaselined:
The following tests are marked as pass:
Review URL: http://codereview.chromium.org/141057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/14786
TEST=set bookmark bar to show by default. open a new browser window. There should be no weird vertical scrolling at the bottom of the page.
Review URL: http://codereview.chromium.org/145002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser window. This fixes a visual bug where the border looked
disconnected with the background. This matches what Windows does.
BUG=14884
Review URL: http://codereview.chromium.org/140078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be so that resize animations are not janktastic. TabOverviewContainer
only draws in the parts that are actually used so that it appears as
though the window is smaller than it is. This was needed as
moving/resizing bounds is way too expensive.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/132059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since the "remove" item always causes selection to change, we don't have to worry about trying to call remove twice with the same context menu.
TEST=see bug. Also, no new crashes on linux.
BUG=14443
Review URL: http://codereview.chromium.org/132048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[re-retry, seeing if reliability bots like it]
* use a new ChannelHandle type when passing IPC channels over IPC
The current POSIX code assumes that one end of a channel is always a new
child process (a renderer). For plugins we need to be able to construct
channels between each of the browser, plugin, and renderer.
This change augments the messages related to creating channels to allow
passing in a base::FileDescriptor containing the socket. The intent is
that the browser process, as the initial interchange between plugin and
renderer, creates the socketpair() on their behalf and hands each their
respective end of the connection.
* register channel endpoint names in the global pipe map
The plugin code assumes it can map from a string to a channel endpoint
at basically any time. So whenever we get a channel endpoint over IPC,
we install it in a global map of channel endpoints.
Review URL: http://codereview.chromium.org/113157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
_NET_CLIENT_LIST_STACKING.
BUG=14004
TEST=Drag tabs in and out of tabstrip in xmonad window manager.
Review URL: http://codereview.chromium.org/141061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18949 0039d316-1c4b-4281-b951-d872f2087c98
|