summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Test startup of new tab page with a complex theme.mirandac@chromium.org2009-08-104-21/+62
| | | | | | | | | BUG= http://crbug.com/18767 TEST= none Review URL: http://codereview.chromium.org/165168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22925 0039d316-1c4b-4281-b951-d872f2087c98
* Only have middle click lower the window if we hit the titlebar ortc@google.com2009-08-101-1/+3
| | | | | | | | | | | | window edge. Middle clicking a link on the page shouldn't do this. BUG=15430 Review URL: http://codereview.chromium.org/164257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22924 0039d316-1c4b-4281-b951-d872f2087c98
* Correct the order of the methods in webframe_impl.cc to match how they aredarin@chromium.org2009-08-102-818/+809
| | | | | | | | | | | | | | | | declared in webframe_impl.h. The methods were quite jumbled up making it hard to know where to add new methods and making the code harder to read. This patch only involved shifting methods around in the files. There are not substantive changes in this CL. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/164244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22922 0039d316-1c4b-4281-b951-d872f2087c98
* Changes SessionService to make sure a Pickle is deleted before thesky@chromium.org2009-08-101-5/+10
| | | | | | | | | | | | | | memory the pickle was created from is deleted. I don't think the current code actually causes a problem as Pickle's destructor won't attempt to delete the memory in this case, but I'm adding this to make it clear the Pickle should be deleted and prevent any future problems. BUG=none TEST=none Review URL: http://codereview.chromium.org/165241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22921 0039d316-1c4b-4281-b951-d872f2087c98
* Add Breakpad to the Mac GYP build.maf@google.com2009-08-101-0/+7
| | | | | | Review URL: http://codereview.chromium.org/165204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22920 0039d316-1c4b-4281-b951-d872f2087c98
* Adding two more layout test failures to test expectations.senorblanco@chromium.org2009-08-101-0/+2
| | | | | | | | | | BUG=18896,9798 TEST=green is good. TBR=dglazkov Review URL: http://codereview.chromium.org/165240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22918 0039d316-1c4b-4281-b951-d872f2087c98
* Rework visited link updating mechanism to be more robust.dglazkov@chromium.org2009-08-103-24/+69
| | | | | | | | | | | | | | | | | | This is a follow-up to http://src.chromium.org/viewvc/chrome?view=rev&revision=22540, which eliminated one crash, but still left behind another, this time due to racing between history backend and WebView creation. The solution is to make sure no visited-link-related messages are sent to the rendering process until we know for sure it is created. BUG=17555 TEST=VisitedLinkeRelayTest.WebViewReadiness R=darin Review URL: http://codereview.chromium.org/165210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22917 0039d316-1c4b-4281-b951-d872f2087c98
* Enable skia asserts. They were disabled some time ago due tosenorblanco@chromium.org2009-08-105-24/+17
| | | | | | | | | | | | http://crbug.com/6372, which has since been fixed. Some existing asserts were failing due to having been untested, and were fixed in this CL. BUG=http://crbug.com/6373. TEST=unit tests, layout tests, etc do not assert Review URL: http://codereview.chromium.org/165223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22916 0039d316-1c4b-4281-b951-d872f2087c98
* Fix svn:ignore.maruel@chromium.org2009-08-100-0/+0
| | | | | | | | | | I forgot to fix it in revision 22853. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22915 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools heap profiler: implement showing objects count & size as percents.mnaganov@chromium.org2009-08-101-5/+109
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22914 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an error in revision 22853.maruel@chromium.org2009-08-100-0/+0
| | | | | | | | | | That cause the 'S' status to show up in svn status. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22913 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests of svg/W3C-SVG-1.1/filters-example-01-b.svg and ↵hamaji@chromium.org2009-08-1010-7/+639
| | | | | | | | | | | | | | svg/W3C-SVG-1.1/struct-group-03-t.svg. Windows' svg/W3C-SVG-1.1/filters-example-01-b.svg isn's so good. There are a ugly room between black strokes and white painting of characters. Maybe this is a real bug. Other pngs seem to be similar to WebKit's expected images. BUG=10307 TEST=none Review URL: http://codereview.chromium.org/165233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22912 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wrong expected data for ↵ukai@chromium.org2009-08-106-35/+3
| | | | | | | | | | | | | LayoutTests/svg/W3C-SVG-1.1/struct-image-07-t.svg. smiley.png should be shown with xml:base on image and xml:base on parent. BUG=10281 TEST=none Review URL: http://codereview.chromium.org/165234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22911 0039d316-1c4b-4281-b951-d872f2087c98
* A Chrome-side fix for Issue 18232.hbono@chromium.org2009-08-101-5/+8
| | | | | | | | | | This change enables the code which displays a context menu when Chrome receives a key event for a menu key or control+F10 keys also on Linux. Even though this change makes Chrome display a context menu when we type control+F10 keys, it cannot make Chrome display a context menu when we type a menu key because WebKit maps a GDK_Menu to a VKEY_MENU. To fix this problem, we need to change WebKit to map a GDK_Menu to a VKEY_APP. BUG=18232 "[Linux] Menu key doesn't work" TEST=Press a menu key (or control+F10 keys), and verify a context menu is displayed. Review URL: http://codereview.chromium.org/164131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22910 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests with symbols that were not in fonts on buildbot.ukai@chromium.org2009-08-1024-48/+65
| | | | | | | | | | | | | | | | | | LayoutTests/css2.1/t0805-c5519-brdr-r-01-e.html LayoutTests/css2.1/t0905-c5525-fltblck-00-d-ag.html LayoutTests/css2.1/t0905-c414-flt-fit-01-d-g.html LayoutTests/css2.1/t0905-c5525-flthw-00-c-g.html LayoutTests/css2.1/t0905-c5526-flthw-00-c-g.html Looks correctly showing non-ascii symbols. BUG=10314 TEST=none Review URL: http://codereview.chromium.org/164248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22909 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline test results of svg/W3C-SVG-1.1/animate-elem-78-t.hamaji@chromium.org2009-08-107-68/+394
| | | | | | | | | | As we didn't support animation of SVG, the original expected image was wrong. BUG=none TEST=none Review URL: http://codereview.chromium.org/165232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22908 0039d316-1c4b-4281-b951-d872f2087c98
* A blind fix for Issue 18837 (and a build fix for VS2008)hbono@chromium.org2009-08-101-7/+10
| | | | | | | | | | | | | To read this crash dump, this issue is caused by my mistake that this jumplist.cc calls "icon_urls_.front()" for an empty list. This change added some checks that verifies a std::list has one or more items. This change also fixes linker errors because of conflicted symbols: CLSID_DestinationList and CLSID_EnumerableObjectCollection, which is caused by my mistake that I forgot removing "EXTERN_C" keywords when I moved them into an anonymous namespace. This change removes the "EXTERN_C" keywords for VS2008. BUG=18837 "Crash - JumpList::OnFavIconDataAvailable(int,bool,scoped_refptr<RefCountedVector<unsigned char> >,bool,GURL)" TEST=Show JumpList on Windows 7. TEST=Build Chromium with VS2008. Review URL: http://codereview.chromium.org/159853 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22907 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline test results for css2.1/t0803-c5505-mrgn-02-c.hamaji@chromium.org2009-08-107-5/+13
| | | | | | | | | | | We must not see the vertical scrollbar. So, the original expected image was wrong. BUG=9916 TEST=none Review URL: http://codereview.chromium.org/164246 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22906 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline LayoutTests/editing/selection/5136696.html.yutak@chromium.org2009-08-107-6/+35
| | | | | | | | BUG=10476 TEST=none Review URL: http://codereview.chromium.org/165231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22905 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline the test results of svg/W3C-SVG-1.1/animate-elem-39-t.hamaji@chromium.org2009-08-105-5/+79
| | | | | | | | | | | | This happened because the name of SVG nodes are changed (RenderImage => RenderSVGImage). BUG=10463 BUG=10998 TEST=none Review URL: http://codereview.chromium.org/165228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22904 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline LayoutTests/svg/W3C-SVG-1.1/pservers-grad-11-b.svgukai@chromium.org2009-08-107-3/+92
| | | | | | | | | | | Diffs only font metrics BUG=10282 TEST=none Review URL: http://codereview.chromium.org/164245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22903 0039d316-1c4b-4281-b951-d872f2087c98
* Skia merge 309:310yusukes@google.com2009-08-109-5/+5
| | | | | | | | | BUG=18333 TEST=none TBR=agl Review URL: http://codereview.chromium.org/164234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22902 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline LayoutTests/editing/pasteboard/4989774.html.yutak@chromium.org2009-08-107-6/+23
| | | | | | | | | | | This test is affected by an upstream change (NBSPs turning to spaces). See <http://code.google.com/p/chromium/issues/detail?id=15132#c5>. BUG=15132 TEST=none Review URL: http://codereview.chromium.org/164243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22901 0039d316-1c4b-4281-b951-d872f2087c98
* GRIT: add support for 'js_map_format' needed for DevTools l10n.mnaganov@chromium.org2009-08-107-5/+176
| | | | | | | | | WebKit Inspector is localized using a JS file containing the following map: localizedStrings[<english text>] = <translated text>; Review URL: http://codereview.chromium.org/164066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22900 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline layout test editing/selection/4983858.hamaji@chromium.org2009-08-107-6/+25
| | | | | | | | | | | This is working just like Safari. BUG=15132 TEST=none Review URL: http://codereview.chromium.org/164242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22899 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline LayoutTests/editing/pasteboard/5089327.htmlukai@chromium.org2009-08-107-1/+42
| | | | | | | | | | | It pastes the content with blue color as expected. BUG=9159 TEST=none Review URL: http://codereview.chromium.org/165225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22898 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline test results for editing/inserting/editable-html-element.hamaji@chromium.org2009-08-107-5/+32
| | | | | | | | | | It is working like Safari. BUG=15132 TEST=none Review URL: http://codereview.chromium.org/164239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22897 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to WebFrame from the WebKit API.darin@chromium.org2009-08-1089-1710/+1385
| | | | | | | | | | | | | | | I tried to avoid unnecessary changes in this CL to help make it easier to review. As part of this CL, glue/webtextinput* are folded into WebFrame / WebFrameImpl. R=dglazkov BUG=10034 TEST=none Review URL: http://codereview.chromium.org/164225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22896 0039d316-1c4b-4281-b951-d872f2087c98
* Renaming the class ShelfItemDialog to URLPicker, and ShelfItemDialogDelegate ↵thakis@chromium.org2009-08-107-453/+456
| | | | | | | | | | | to URLPickerDelegate. BUG=None TEST=None Review URL: http://codereview.chromium.org/164149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22895 0039d316-1c4b-4281-b951-d872f2087c98
* Modified the browser controller so that it can revert the location bar when ↵yusukes@google.com2009-08-101-0/+17
| | | | | | | | | | | | | | | | a user pressed RELOAD, FORWARD, or BACK buttons. Note that this change does not revert the bar when Command+r is pressed. That's intentional. Please see the comment #7 by pkasting in http://crbug.com/15464 . Windows change: http://codereview.chromium.org/155908 Linux change: http://codereview.chromium.org/164137 BUG=18710 TEST=The same as http://codereview.chromium.org/155908 (except the F5 stuff since Chromium Mac seems not to support F5 reload?) Review URL: http://codereview.chromium.org/164145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22894 0039d316-1c4b-4281-b951-d872f2087c98
* add "remove" to download item context menu on macthakis@chromium.org2009-08-103-65/+102
| | | | | | | | | BUG=60 TEST=Download something, open context menu, click "remove" -- item should be removed from shelf. It leaves a hole behind right now (bug 17831), will fix that later. Review URL: http://codereview.chromium.org/160444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22893 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 'tools' list to 'scons_settings' so we'll still get thesgk@google.com2009-08-101-0/+1
| | | | | | | | | | necessary 'chromium_builders' module when GYP gets updated to use a more generic default. BUG=none TEST=none Review URL: http://codereview.chromium.org/164216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22892 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed some warnings in bitmap_png.ccbradnelson@google.com2009-08-105-5/+23
| | | | | | | | | | | | | | Switched to using the latest nacl and using their gyp files. Added a copy/rename step so that o3dConverter gets the dll it needs for other build steps. BUG=None TEST=None TBR=gspencer Review URL: http://codereview.chromium.org/164238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22891 0039d316-1c4b-4281-b951-d872f2087c98
* Now that chromium's common.gypi sets /MP when building under vs2008,bradnelson@google.com2009-08-101-5/+0
| | | | | | | | | | | | | | it shouldn't be assumed that /MP should be set for O3D. In particular this can disrupt O3D being build on the buildbot infrastructure which uses VS2005 builders. BUG=None TEST=None TBR=gspencer Review URL: http://codereview.chromium.org/164237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22890 0039d316-1c4b-4281-b951-d872f2087c98
* Changing run hook for gyp so that depth as at the right level.bradnelson@google.com2009-08-091-1/+1
| | | | | | | | | | | | | | | Unlike gyp files, the hooks are run at the level the .gclient file is at. So you want --depth=. (not ..) This was causing the path to the platform sdk used in chromium's common.gypi to be wrong. BUG=None TEST=None TBR=gspencer Review URL: http://codereview.chromium.org/164236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22889 0039d316-1c4b-4281-b951-d872f2087c98
* Add a big more structure to the extensions docs.aa@chromium.org2009-08-096-146/+76
| | | | | | TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22888 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the extension doc page titles and flicker a bit.aa@chromium.org2009-08-094-8/+10
| | | | | | TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22887 0039d316-1c4b-4281-b951-d872f2087c98
* vector.end() is out of range, need to erase (end() - 1)jnd@chromium.org2009-08-091-24/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22886 0039d316-1c4b-4281-b951-d872f2087c98
* On GTK, middle-click on the title bar (and the window frame in general) willevan@chromium.org2009-08-091-2/+5
| | | | | | | | | | | | lower the window. This is Chromium's custom titlebar, not the one provided by the window manager. BUG=15430 Review URL: http://codereview.chromium.org/165123 Patch from Nigel Tao <nigeltao@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22885 0039d316-1c4b-4281-b951-d872f2087c98
* When importing bookmarks from Firefox, filter out the default bookmarks.evan@chromium.org2009-08-091-6/+3
| | | | | | | | | | | The existing code attempted to do this but it had a bug. BUG=18530 Review URL: http://codereview.chromium.org/165094 Patch from Doug Muir <dmuir@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22884 0039d316-1c4b-4281-b951-d872f2087c98
* Provides implementation of DragDropTypes for GTK.sky@chromium.org2009-08-094-13/+52
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22882 0039d316-1c4b-4281-b951-d872f2087c98
* Add html/canvas directory to WebCore include paths, because it was added ↵dglazkov@chromium.org2009-08-091-0/+1
| | | | | | | | | | | | upstream. TBR=jorlow BUG=none TEST=none Review URL: http://codereview.chromium.org/164233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22881 0039d316-1c4b-4281-b951-d872f2087c98
* Add return type parameters to Bookmark APIs. And resulting doc changesrafaelw@chromium.org2009-08-094-25/+89
| | | | | | | | BUG=18714 Review URL: http://codereview.chromium.org/164219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22880 0039d316-1c4b-4281-b951-d872f2087c98
* Add return type to docs for getRectgman@google.com2009-08-081-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22872 0039d316-1c4b-4281-b951-d872f2087c98
* fix for gccgman@google.com2009-08-081-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22871 0039d316-1c4b-4281-b951-d872f2087c98
* Completely disable DOM Storage UI test until ↵jorlow@chromium.org2009-08-081-0/+6
| | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=28094 is in. Until then, this will be flaky and crash the browser. TBR=jam BUG=none TEST=none Review URL: http://codereview.chromium.org/165211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22870 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds client.toDataURL which gets the contentsgman@google.com2009-08-0835-149/+572
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of the client area as a data url (which is a base64 encoded string of a png file) data urls are part of the HTML5 standard and supported by firefox, safari and chrome. http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvas-todataurl That means you can now do this var dataURL = client.toDataURL(); // make an IMG tag display the screenshot someImgTag.src = dataURL; // use the IMG tag to draw into a canvas someCanvasContext.drawImage(someImageTag, ...); It also means there is no need for the test builds anymore "test-dbg-d3d", "test-opt-d3d" etc as toDataURL is part of the public API and can therefore always be used to take screenshots in any build. I updated the selenium code to use it. There are a few issues: 1) The GL version has the same limitations as taking a screenshot before. Namely that the client area must be on screen. We need to fix this. 2) We need to add support for origin-clean. See https://tracker.corp.google.com/story/show/180334 Review URL: http://codereview.chromium.org/164130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22869 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the ui test based layout tests for DOM Storage.jorlow@chromium.org2009-08-081-8/+3
| | | | | | | | | | TBR=jam TEST=none BUG=none Review URL: http://codereview.chromium.org/164227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22868 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for GL path not clearing texturesgman@google.com2009-08-082-33/+30
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22867 0039d316-1c4b-4281-b951-d872f2087c98
* half fix for mac.gman@google.com2009-08-082-4/+9
| | | | | | | | | For some reason when getting values back out of a luminance texture the signs are all ABSed out even though the texture displays correctly git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22866 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-11 01:36:56 +0000