| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
inactive/active.
BUG=None
TEST=Run the focus manager unit-tests.
Review URL: http://codereview.chromium.org/164448
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Fix bookmark sync background color
- Make hidden elements not take up space at the bottom of the NNTP
- Simplify sync and set as home page
- Fix issue where middle clicking on the sync link opened a new tab
BUG=19538
TEST=None
Review URL: http://codereview.chromium.org/178065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16747
TEST=Should not be able to resize or zoom the dialog.
Review URL: http://codereview.chromium.org/179070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/20561
Review URL: http://codereview.chromium.org/173648
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=victorw
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
help readers make the right decision in when to use which.
BUG=None
R=brettw
Review URL: http://codereview.chromium.org/179060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20696
TEST=click a mailto: link, it should open your default MUA
Review URL: http://codereview.chromium.org/177040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test_shell.
AppCache library:
* Added AppCacheInterceptor, which is derived from URLRequest::Interceptor.
Chrome:
* Each UserProfile instantiates a ChromeAppCacheService, which is derived from an appcache library class.
* Each ChromeURLRequestContext associated with that profile has a reference to that instance.
* ResourceDispatcherHost pokes AppCacheInterceptor when initiating URLRequests and when returning the response head.
TestShell:
* Added SimpleAppCacheSystem which bundles together appcache lib components for use in a single process with an UI and IO thread.
* TestShellWebKit instantiates and initializes an instance of the above, aimed at at temp directory that will get cleaned up when the test run is over.
* SimpleResourceLoaderBridge pokes the system when initiating URLRequests and when returning the response head.
TEST=none, although many existing tests exercise this stuff
BUG=none
Review URL: http://codereview.chromium.org/173406
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
After a change in another place this change is now safe to make.
TEST=Covered by ui_tests.
BUG=none
Review URL: http://codereview.chromium.org/173650
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This makes it easier to run directly from the build archive for testing.
Review URL: http://codereview.chromium.org/182049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It often fails in the assertion which verify the contents of the Internet
Zone Identifier ADS. Flushing it doesn't solve the problem entirely
due to Windows file semantics (only using the exactly same handle would
be a 100% fix), but it is simple and should have a high effect-to-effort ratio.
Review URL: http://codereview.chromium.org/177057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
buttons (rather than the command line).
TBR=aa,rafaelw
Review URL: http://codereview.chromium.org/181041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the layout test flakiness dashboard.
BUG=10308
Review URL: http://codereview.chromium.org/181040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=aa,rafaelw
Review URL: http://codereview.chromium.org/173651
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also added some comments and cleaned up some code.
BUG=20693
TEST=Run unit tests. Also make sure back/forward buttons (and menus) \
work correctly.
Review URL: http://codereview.chromium.org/179043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows a class to hand out weak pointers to itself that will be nulled out
automatically when the class instance is destroyed.
I have provided two ways for a class to implement weak pointers. It can either
subclass SupportsWeakPtr (like subclassing RefCounted) or it can be composed of
WeakPtrFactory (like having a ScopedRunnableMethodFactory member).
Eventually, I'd like to make it possible to pass a WeakPtr<T> as the first
parameter to NewRunnableMethod. This will make ScopedRunnableMethodFactory
obsolete and should help cleanup some code.
One feature that makes the implementation here a bit more complicated is that
it is possible to pass a WeakPtr<U> to a method that takes a WeakPtr<T>
provided U "is a" T. This proved useful in RenderView, which can then give
out weak references to both itself as well as to an interface it implements.
This informed the design of WeakPtr, causing it to have a T* ptr_ member
instead of stashing that pointer within the ref counted WeakReference object.
R=brettw
BUG=none
TEST=weak_ptr_unittest.cc
Review URL: http://codereview.chromium.org/183026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ager
BUG=20825
TEST=none
Review URL: http://codereview.chromium.org/176066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
are marked flaky but haven't failed recently.
BUG=13907
BUG=10316
BUG=10326
BUG=10353
BUG=10355
BUG=10368
BUG=10403
BUG=9798
BUG=9797
BUG=11810
BUG=18794
TEST=green layout test buildbots
Review URL: http://codereview.chromium.org/183030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=yusukes
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/176065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(First landed in r24790, reverted in r24802.)
I'm landing this patch because it breaks page_cycler_intl2 on Linux and I don't
know why. I want to watch the bots when they fail.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes issues where the thumbnail on the NTP wasn't showing.
BUG=18380
TEST=Make sure that the following pages show thumbnails on the new tab
page:
http://digg.com/?\
http://code.google.com/p/chromium/issues/list?can=2&q=&sort=-id&colspec=ID+Stars+Pri+Area+Type+Status+Summary+Modified+Owner
http://code.google.com/p/chromium/issues/list?can=2&q=&sort=-id&colspec=ID%20Stars%20Pri%20Area%20Type%20Status%20Summary%20Modified%20Owner
Review URL: http://codereview.chromium.org/178061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that are listed for entire directories.
TBR since the dashboard is broken and my gmail is down,
so I can't reasonably do a code review soon.
TBR=arv@chromium.org
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/182047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This follows the Mac model where all the installer binaries are generated at
the same time.
Review URL: http://codereview.chromium.org/181036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8281
TEST=none.
Review URL: http://codereview.chromium.org/181037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=20822
TEST=none
Review URL: http://codereview.chromium.org/183034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
On windows they do this by having the two views overlap. We can't so instead move the bottom 4 pixels of padding from the toolbar widget into the bookmark bar widget. When the bookmark bar is closed/hidden, it still shows those 4 pixels. When it opens, it is able to make use of those 4 pixels. Since we get 4 extra pixels, we can make the overall height of the bookmark bar 4 pixels less.
BUG=18570
Review URL: http://codereview.chromium.org/178029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in the source.
Review URL: http://codereview.chromium.org/178011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- new folder button should properly size
- the window should resize correctly
Folder name:
- the the label should auto size correctly and keep the edit field next to it
- the buttons should auto size and say right aligned.
TEST=both windows should work as listed (already were localized, just fixing sizing issues), try resizing edit bookmark and confirm buttons, titled, edits, size as expected.
BUG=20527
Review URL: http://codereview.chromium.org/180059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and display_height in preparation for letting the user
choose the backbuffer size.
The issue is the current "render_width" and "render_height"
really mean display_width and display_height where as
the true "render_width" and "render_height" need to be
different.
Review URL: http://codereview.chromium.org/179058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
when presented with Chrome built with -O1.
(The gdb lives in /usr/local/valgrind-10771/bin, so should not interfere
with the system gdb.)
Review URL: http://codereview.chromium.org/178042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
// These tests went red with r47922 change to FontLinux, possibly need rebaselining.
BUG_MICHAELN LINUX : LayoutTests/fast/text/drawBidiText.html = FAIL
BUG_MICHAELN LINUX : LayoutTests/fast/text/international/bidi-control-chars-treated-as-ZWS.html = FAIL
BUG_MICHAELN LINUX : LayoutTests/fast/text/international/bidi-listbox-atsui.html = FAIL
TBR=yusukes,victorw
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also refactor URI list/named url packing code.
BUG=19008
Review URL: http://codereview.chromium.org/175036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20807,20808,20814
TEST=More green runs on the Mac UI valgind bots
Review URL: http://codereview.chromium.org/177056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run the view unit-tests.
See original review:
http://codereview.chromium.org/165512/show
Review URL: http://codereview.chromium.org/180061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm just making the order of the methods match the
order of declaration again.
BUG=nonde
TEST=none
Review URL: http://codereview.chromium.org/175042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of tests over all the builders.
BUG=none
TEST=manual
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/175047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Sheriffs: warning, dangerous patch)
On Chronos, with the slower CPU, it appears that page scrolling
sigificantly lags the mouse cursor sometimes. Some amount of lag will
always happen, but it appears that we are queuing old mouse positions.
This patch makes it so that we don't ACK a mouse move event if there
is a resulting paint pending. Current we get something like this:
Renderer: Browser:
<------- HandleInputEvent --------
(handles the event and defers
the painting)
-------- ACK ------------------->
(has a mouse move saved up)
... HandleInputEvent ---------
(painting starts)
----------- PaintRect ------------->
<----...
At this point, we buffered a mouse position while painting. If we
don't ACK the event until we have finished painting, we can get a more
up-to-date event.
This will need careful observation of the perf bots to check that
nothing bad happens.
http://codereview.chromium.org/173285
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
marked flaky but haven't failed recently.
BUG=10453
BUG=9798
BUG=18802
TEST=green layout test buildbots
Review URL: http://codereview.chromium.org/179066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
task manager to GDK_WINDOW_TYPE_HINT_NORMAL. This allows the
dialogs to go behind browser windows in metacity.
I did it for these two dialogs mainly because they have links
to web pages. The links should be able to open on top of the
dialog.
Review URL: http://codereview.chromium.org/179014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on the mac.
Review URL: http://codereview.chromium.org/183031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16326,16579,17795,17966,20653,20778,20805
TEST=greenish valgrind bots
Review URL: http://codereview.chromium.org/180060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=rohitrao
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/179067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/177055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
test_shell close.
Review URL: http://codereview.chromium.org/175049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Themes.
http://crbug.com/20629
Review URL: http://codereview.chromium.org/181022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
more than one tab. Don't use animation on new tab button
BUG=none
TEST=NTB shows up correctly and doesn't show during drags.
Review URL: http://codereview.chromium.org/174579
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that have passed for all configurations that they were listed for, for at least 100 runs.
TEST=ran through layout test try bots
BUG=10464,10476,9798,11832,11898,18206
Review URL: http://codereview.chromium.org/181027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25048 0039d316-1c4b-4281-b951-d872f2087c98
|