| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Random files in V8Bindings were getting rebuilt when I touched process_util.h. I tracked it down to stats_table.h and shared_memory.h. This change cuts down some dependencies there; more could be removed if we made some of our FooHandle typedefs into abstract data types instead.
Review URL: http://codereview.chromium.org/7307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NSURL<->GKURL conversions any longer. Make a couple changes to DragData
just to get it to build, since we don't care about drag and drop right now.
Provide key codes for the Mac based on Apple's 1992 docs on the subject.
Review URL: http://codereview.chromium.org/8070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is called.
http://code.google.com/p/chromium/issues/detail?id=3639
Review URL: http://codereview.chromium.org/7854
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7880
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Change RenderThemeWin.cpp so that pressed buttons have priority over
focused buttons. I.e., if a button is focused and pressed, we should
draw it pressed.
2) In classic mode, add the black border for focused buttons and properly
add the dotted focus rect.
http://crbug.com/135
Review URL: http://codereview.chromium.org/8071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
with character encoding override, but it seems that it's better to fix them separately.
BUG=3315
Review URL: http://codereview.chromium.org/7647
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7855
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The purpose of this layout test is to verify that certain malformed JS attribute doesn't cause crash.
V8 passes.
The outputs differ because v8 additionally throws a syntaxerror exception.
Review URL: http://codereview.chromium.org/7861
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
developer0420.
I updated it to always have reload enabled, as you sometimes want to reload while a page is loading.
BUG=204
TBR=ben
Review URL: http://codereview.chromium.org/8016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adobe Acrobat 9.0 loads a dll called bib.dll. Usually
it unloads it 30 seconds after the last instance of the
plugin goes away, or when the browser process goes away.
To know if the browser process goes away, it subclasses
the main browser window. It seems to work fine in firefox,
but it does not work in chrome.
Also the 30 seconds delay does not work because we close
the plugin process too fast (10 seconds) after the last
instance of the plugin is closed.
bib.dll is then unloaded by ExitProcess, which causes
a crash in bib.dll.
We could wait ~35 seconds after the last instance before
closing the process, but it might be problematic with
upgrades and could result in plugin process outliving the
brower process.
This current patch just kills the process before ExitProcess,
so it does not cause a crash and display an error message
to the user. This is not a fix, this is just a usuability
improvement.
As far as I know we are still waiting for help from
the Adobe team on this issue. They would need to find
a way to unload bib.dll cleanly in chrome.
BUG: 1385045
Review URL: http://codereview.chromium.org/8015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Passes tests (once you enable them by removing DISABLED_).
Probably want to add a mock https server so we can leave those tests enabled when we check in.
Had to add full duplex support to TCPClientSocket on Linux
to avoid kludgy plumbing issues.
Also had to add dummy implementation of
X509Certificate::~X509Certificate to prevent link error.
Rediffed to current trunk, addressed all review issues.
Review URL: http://codereview.chromium.org/4049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7875
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7874
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7873
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
webkit.xcodeproj:port out of the "all" Mac build temporarily to accommodate
PLATFORM(MAC) killing in progress.
Review URL: http://codereview.chromium.org/7870
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7867
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Wow, this was actually used to refer to src/chrome.
Review URL: http://codereview.chromium.org/7859
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
branch until the 'split window' change has landed.
Review URL: http://codereview.chromium.org/7857
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7856
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8201
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This will facilitate changing where the main sconstruct lives.
Review URL: http://codereview.chromium.org/7847
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
support.
R=ojan
Review URL: http://codereview.chromium.org/8047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window is restored.
Turns out the messages we receive prior to becoming restored/minimized etc are not sufficient to restore the button to its appropriate state. Since this is specific to the implementation of these controls, I have provided a solution specific to them.
http://crbug.com/3559
Review URL: http://codereview.chromium.org/7803
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
from any build directory, not just when building in 'base'.
Make base_unittests explicitly depend on the file so it will
rebuild if we ever change the list of exported symbols.
Review URL: http://codereview.chromium.org/7853
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
SCons Windows build.
Review URL: http://codereview.chromium.org/7852
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to storing it from the update in order to avoid breaking
due to changes in the format.
Review URL: http://codereview.chromium.org/7851
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7842
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=mbelshe
Review URL: http://codereview.chromium.org/8045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=3639
Review URL: http://codereview.chromium.org/8044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts r3706 which reverted r3700.
Review URL: http://codereview.chromium.org/7845
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This contains the file list and correct compilation flags for the files.
This doesn't yet link, but is only missing one custom builder.
Review URL: http://codereview.chromium.org/8041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This reverts r3700 which broke the WebKit waterfall for this test.
Review URL: http://codereview.chromium.org/7844
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Bug 3424: If you download an EXE which takes a while to start and you switch tabs before it does, then when you come back to the tab it would truncate the dangerous download on the right because we have never cached the size of the label. We now perform a SizeLabelToMinWidth() in the constructor of DownloadItem for dangerous downloads to make sure the calculation has taken place when needed.
2) Bug 3424: Once I fixed the problem above, I also noticed that the Save and Discard buttons would not show since the cached button sizes are 0 because the view animation took place while the shelf was hidden (while the shelf had no parent). By triggering a Layout of the shelf after setting the bounds, this triggers the buttons to draw appropriately.
3) Bug 3459: The remaining work was to fix the truncation on the bottom of the dangerous download view by taking the size of the progress icon for non-dangerous downloads into account. Ideally, we should increase the size of a non-dangerous download view if the warning icon or the buttons on the dangerous download view cause the size to increase, but I find that unlikely and it should be easy to fix if we come across that.
Review URL: http://codereview.chromium.org/7843
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason gcc wasn't happy with these implicit conversions:
webkit/port/platform/chromium/CursorChromium.cpp:88: error: conversion from 'WebCursor::Type' to non-scalar type 'WebCore::Cursor' requested
But making them explicit works.
Review URL: http://codereview.chromium.org/8028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3704 0039d316-1c4b-4281-b951-d872f2087c98
|