| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This way it provides more specific error code for the user.
TEST=Covered by net_unittests.
http://crbug.com/20405
Review URL: http://codereview.chromium.org/197050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16591
TEST=History UI test
Review URL: http://codereview.chromium.org/198011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Different strings, pretty much the same deal.
- One case removes the radio buttons.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/198038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/197063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of closing.
This is an attempt to fix a crash bug.
TEST=no
BUG=21201
Review URL: http://codereview.chromium.org/197054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Repro steps:
- open a gmail tab and get someone to message you such that the tab title keeps changing
- put that tab to the right of a bunch of other tabs
- close a bunch of the tabs to the left of gmail
Each time you close a tab you have about a 10% chance of reproing.
The solution is essentially copy-pasted from the windows tabstrip.
The Browser change is somewhat unrelated. I noticed the comment "Do not dereference |contents|" and that we were in fact dereferncing |contents|, so I worked around it.
BUG=13811
Review URL: http://codereview.chromium.org/199054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the Google Talk voice & video plugin.
BUG=none
TEST=video chats should work with recent versions of the Google Talk voice and video chat plugin.
Review URL: http://codereview.chromium.org/199061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
together and rounding them so they look like back/forward. Gives them mouse-over highlighting.
BUG=18571
TEST=buttons still work.
Review URL: http://codereview.chromium.org/202023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=5027
TEST=none
Review URL: http://codereview.chromium.org/194051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
change in the extension shelf.
BUG=21269
BUG=21270
BUG=21274
TEST=none
Review URL: http://codereview.chromium.org/192041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20711, 20726
TEST=tab titles look better when long
Review URL: http://codereview.chromium.org/196065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference between repaint areas is due to the difference in repaint logic. Safari/Mac port uses NSView's native
rectangle collection/unification, and we just unify all into one damage rect.
R=jparent
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/201063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=19393
TBR=huanr
Review URL: http://codereview.chromium.org/201064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
top.
BUG=20936
TEST=none
Review URL: http://codereview.chromium.org/194042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes an FTP transaction hang when we wait for server's response
and the server apparently waits for us.
TEST=See bug.
http://crbug.com/21127
Review URL: http://codereview.chromium.org/192042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
mapping function rather than NPAPI change.
Note that shared memory objects currently lose identity when they cross a process boundary. If an object is sent across a boundary and back, there are now two objects representing the same handle in a single process. This can be fixed.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/194049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/193049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/192052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I want to test the theory that the issues we are observing here
are actually a race condition.
- The race condtion would be related with 2 operations that
are not thread safe:
1- check/creation of the map
2- search/insert on the map
I would like to air this CL on dev channel for a week and
observe the crash rate.
BUG=11789
Review URL: http://codereview.chromium.org/199052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by net_unittests.
BUG=none
Review URL: http://codereview.chromium.org/197052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The background tabs think they are visible causing paints to
be executed. These steal the backing store from the visible tab
Please read the bug for more info.
BUG=20831
TEST= see bug for steps
Review URL: http://codereview.chromium.org/199010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/194057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NO CODE CHANGE
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cancel the request.
BUG=20930
TEST=unittests
Review URL: http://codereview.chromium.org/193043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none. just internal cleanup of a todo
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/196064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
feature was broken by one of the recent WebKit rolls.
Review URL: http://codereview.chromium.org/202021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CustomHomePagesModelTest.ModelChangedNotification on Mac.
BUG=http://crbug.com/17452
TEST=Test should not be flaky.
Review URL: http://codereview.chromium.org/193058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix seg fault in deleting view from RemoveTabAtIndex
* move initialization of tabbed page to NativeControlCreated
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/196055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=See bug.
http://crbug.com/21006
Review URL: http://codereview.chromium.org/197044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference between repaint areas is due to the difference in repaint logic. Safari/Mac port uses NSView's native
rectangle collection/unification, and we just unify all into one damage rect.
R=jparent
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/195028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=rafaelw
BUG=none
TEST=use mappy extension
Review URL: http://codereview.chromium.org/199059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BTW, thanks Microsoft.
TEST=links on 32 bits OS
BUG=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/200060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Cmd-F to repeat a search.
BUG=http://crbug.com/18762
BUG=http://crbug.com/20273
TEST=See test cases in bugs. Both should work now.
Review URL: http://codereview.chromium.org/200050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=asargent
Review URL: http://codereview.chromium.org/196052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=check the File menu in english to check what is seen
BUG=19928
Review URL: http://codereview.chromium.org/200057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Update ignore for icu directory change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Nuke some methods that now live in WebKit.
BUG=21277
Review URL: http://codereview.chromium.org/199055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8198
TEST=net-purify test passes on Windows
TBR=erikkay
Review URL: http://codereview.chromium.org/196061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Need to figure out why settings are inavailable through InspectorController.
For now, just stub them.
BUG=http://crbug.com/21277
TEST=none
Review URL: http://codereview.chromium.org/196060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc
In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a).
Also updated is the test results for net_util_unittests.
This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there).
BUG=8198
TEST=On all platforms, all the targets are built fine.
Review URL: http://codereview.chromium.org/172031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=rafaelw
Review URL: http://codereview.chromium.org/192051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Likely will work now thanks to maruel!!!
BUG=None
TEST=None
TBR=gregoryd
Review URL: http://codereview.chromium.org/194053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/192050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
minor painting issues.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/199050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the request was for realloc(ptr, 0). Calling realloc(ptr, 0)
is valid, and we should delete ptr and return NULL.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/194040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch by Joel Stanley <joel@jms.id.au>
Review URL: http://codereview.chromium.org/197055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20882
Review URL: http://codereview.chromium.org/199053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is based on the logic in the Firefox code.
It passes existing tests and one new test.
TEST=covered by new unit test
Review URL: http://codereview.chromium.org/200052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25697 0039d316-1c4b-4281-b951-d872f2087c98
|