summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Moved most functionality of video renderer into a base class ↵ralphl@chromium.org2009-02-249-0/+606
| | | | | | | | | (video_renderer_base) and implemented mock filter will full functionality execpt that it never draws anything. Review URL: http://codereview.chromium.org/20343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10239 0039d316-1c4b-4281-b951-d872f2087c98
* Re-re-roll use of ongoing logs to gather stability metricsjar@chromium.org2009-02-241-3/+1
| | | | | | | | | | | | | | This was rolled back to try to use only the initial logs to gather statibility stats, because we were having trouble capturing data in ongoing logs. We now resolved the problem (which was actually only on the stability branch), so we'll roll back to using this method and verify it in the dev branch. tbr=mal Review URL: http://codereview.chromium.org/27061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10238 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of data source for media playerhclam@chromium.org2009-02-244-47/+326
| | | | | | | | | | | | | | | | Implementation of DataSourceImpl for the media player pipeline in Chrome. DataSourceImpl delegates resource loading request to Chrome from the media pipeline. It also performs asynchronous file reading of the media file and coordinates the progress update of resource loading. This change completes the implementation of construction, initialization of data source, asynchronous file reading and coordinations of streaming progress updates between different threads. This change does not contains delegation of resource loading to RenderView and registration of a streaming resource client. Review URL: http://codereview.chromium.org/20375 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10237 0039d316-1c4b-4281-b951-d872f2087c98
* HtmlDialogContentsDelegate should not subclass views::WindowDelegate, for ↵ben@chromium.org2009-02-247-18/+28
| | | | | | | | | | | portability reasons (views isn't used on Mac or Linux). Instead, add modal/title getting methods to HtmlDialogContentsDelegate directly, and have the UI (HtmlDialogView) call to these in the Modal/ModelessHtmlDialogDelegate in its implementation of views::WindowDelegate instead. TEST=open any page and test that Page->Create application shortcuts still works. visit any site that uses Gears and make sure the Gears Allow/Deny dialog still comes up. Review URL: http://codereview.chromium.org/27074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10236 0039d316-1c4b-4281-b951-d872f2087c98
* mark a couple more tests as failing:tc@google.com2009-02-241-0/+2
| | | | | | | | | | | these two tests are failing on the windows build bot TBR=eseidel Review URL: http://codereview.chromium.org/27078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10235 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break due to misplaced ifdef.mmoss@chromium.org2009-02-241-1/+2
| | | | | | | Review URL: http://codereview.chromium.org/27075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10234 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Merge! (chrome part)eseidel@chromium.org2009-02-246-13/+46
| | | | | | Review URL: http://codereview.chromium.org/27028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10233 0039d316-1c4b-4281-b951-d872f2087c98
* The find bar should be owned and managed from the BrowserView, not the ↵finnur@google.com2009-02-2435-836/+747
| | | | | | | | | | | | | | | | | | | | | | | | WebContentsView, since it's part of the "chrome". Design Doc: http://dev.chromium.org/developers/design-documents/find-bar Things done: - Pulled all of the find bar stuff out of WebContentsView* since it's no longer needed. - Moved OnFindReply delegate method from RenderViewHostDelegate::View to RenderViewHostDelegate, since it's no longer implemented on the view. - Moved find control methods to WebContents. - Added recent find result state to WebContents. - Updated the UI tests to accommodate the changes in the state that is broadcast when results are discovered. - Updated the find bar layout to obtain its bounding box from the BrowserView, which knows about toolbars, bookmark bars etc. - Updated the find bar itself to handle the fact that it can be displayed for multiple different tabs. - Moved the find bar manipulation methods for testing from TabProxy to BrowserProxy, since the find bar is now a feature of the window, not the tab. - view.h: Don't lay out child views again if they have a layout manager, it already updated them. TEST=Find box should work as before. BUG=3245 Review URL: http://codereview.chromium.org/27025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10231 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling tests that are failing.kuchhal@chromium.org2009-02-241-11/+13
| | | | | | | | | BUG=7983 Review URL: http://codereview.appspot.com/21058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10230 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux build break.estade@chromium.org2009-02-241-2/+3
| | | | | | | | tbr=jhawkins Review URL: http://codereview.chromium.org/28052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10229 0039d316-1c4b-4281-b951-d872f2087c98
* Multiple fixes for broken Linux SHARED=1 build. This gets things building, ↵mmoss@chromium.org2009-02-2311-9/+52
| | | | | | | | | but the resulting 'chrome' binary crashes on start-up (test_shell seems to work better). Review URL: http://codereview.chromium.org/27054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10228 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux shared build breakage due to undefined references.mmoss@chromium.org2009-02-231-2/+6
| | | | | | | | | | | | | | | This compiles an empty file so we can generate the libplugin target needed by other targets. This whole file does compile (see r9934), but it doesn't link because of undefined refs to files which aren't compiling yet (e.g. npobject_proxy stuff). But we need some sources to build an empty lib, otherwise scons fails to link in skia (when linking with no source files, the -L flag is left off the linker command, so libs in the build directory can't be found). Review URL: http://codereview.chromium.org/27019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10227 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BaseDownloadItemModel and its inheritors.estade@chromium.org2009-02-2314-131/+112
| | | | | | | | | * Move BaseDownloadItemModel to download_item_model.h. Previously it was in a windows-specific file in chrome/browser/views/. * Move SavePageModel to download_item_model.{cc,h}. Review URL: http://codereview.chromium.org/28033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10226 0039d316-1c4b-4281-b951-d872f2087c98
* Obey the XDG base directory spec and use ~/.config/chromium on Linux.evan@chromium.org2009-02-232-13/+19
| | | | | | | | | As discussed here: http://groups.google.com/group/chromium-dev/browse_thread/thread/41e9154311779e1a Review URL: http://codereview.chromium.org/27069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10225 0039d316-1c4b-4281-b951-d872f2087c98
* Fix more gcc 4.3 warnings.evan@chromium.org2009-02-232-10/+13
| | | | | | Review URL: http://codereview.chromium.org/28045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10224 0039d316-1c4b-4281-b951-d872f2087c98
* Clear out the vbox before adding a new widget.erg@google.com2009-02-232-13/+28
| | | | | | | | | | | | This prevents the weird issue where gtk tries to pack both views into the box. It isn't optimal, though. This solution leaves the area blank since it clears the old renderer as soon as the new one is created instead of waiting until the new renderer has something to display. Review URL: http://codereview.chromium.org/27057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10223 0039d316-1c4b-4281-b951-d872f2087c98
* Make plugin_installer.cc compile on Posix.jhawkins@chromium.org2009-02-234-8/+4
| | | | | | Review URL: http://codereview.chromium.org/31001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10222 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a download regression.estade@chromium.org2009-02-231-5/+10
| | | | | | | | FilePath::Extension() returns ".extension" whereas file_util::GetExtensionFromFilename() returns just "extension" Review URL: http://codereview.chromium.org/27071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10221 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Fullscreen mode UI.""kuchhal@chromium.org2009-02-238-1/+340
| | | | | | | | | This reverts commit 243e461e4a659a6e8008befc2c76a55680860f01. Review URL: http://codereview.appspot.com/21057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10220 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome not starting up by implementing a straw-man, lieing versionerg@google.com2009-02-232-8/+79
| | | | | | | | | | | | | | of FileVersionInfoLinux. This will need to be ripped out later on, but we need it for now because we can't just return NULL on CreateFileVersionInfoForCurrentModule(), because the interfaces only expect a NULL on being unable to open a file. Review URL: http://codereview.chromium.org/27070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10218 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fullscreen mode UI."kuchhal@chromium.org2009-02-238-340/+1
| | | | | | | | | This reverts commit d108cc705611554de13712935ec11942dd390a5d. Review URL: http://codereview.appspot.com/21056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10217 0039d316-1c4b-4281-b951-d872f2087c98
* Update header ref to new location.jrg@chromium.org2009-02-231-4/+4
| | | | | | Review URL: http://codereview.chromium.org/27063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10215 0039d316-1c4b-4281-b951-d872f2087c98
* Fullscreen mode UI.pkasting@chromium.org2009-02-238-1/+340
| | | | | | | | | | This requires a change that is currently out for review from sky. BUG=534 TEST=App menu should have a "full screen mode" entry; going into fullscreen mode should display a bubble at the top of the screen, which should slide away after a few seconds; mousing to the screen top will show the bubble again, and clicking the link inside should exit fullscreen mode. Review URL: http://codereview.chromium.org/28012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10214 0039d316-1c4b-4281-b951-d872f2087c98
* Discard crash data during first run of a new version.jar@chromium.org2009-02-236-5/+55
| | | | | | | | | | | | | | | Avoid confusion associated with uploading crash data from an old version during the first run of a new version. Carlos: Please confirm that you're fine with discarding metrics about installer and Render in Sbox. Evan: Please confirm that I got all the usage/crash stats. r=cpu,evanm,mal Review URL: http://codereview.chromium.org/28017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10211 0039d316-1c4b-4281-b951-d872f2087c98
* Make plugin_process_host.cc and child_process_host.cc compile on Posix.jhawkins@chromium.org2009-02-239-136/+161
| | | | | | Review URL: http://codereview.chromium.org/27018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10210 0039d316-1c4b-4281-b951-d872f2087c98
* And this backs down DEPS.sky@google.com2009-02-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10209 0039d316-1c4b-4281-b951-d872f2087c98
* the lI tried to land the clipboard change locally (it was landed upstream ↵sky@google.com2009-02-233-9/+0
| | | | | | | | | | | | | | too), but updating DEPS seems to have hosed Mac, so I'm reverting. BUG=none TEST=none TBR=tc Review URL: http://codereview.chromium.org/28037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10208 0039d316-1c4b-4281-b951-d872f2087c98
* Ups deps to bring in latest webkit.sky@google.com2009-02-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10207 0039d316-1c4b-4281-b951-d872f2087c98
* I'm expanding this to fix a couple of bugs in determining the file name forsky@google.com2009-02-233-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | dragging images: . It's possible for the extension to be empty, resulting in a bad file name, for example, 'foo.' or just '.'. . We weren't restricting the size of the file to MAX_PATH. . We weren't removing characters that are invalid for file system names. It's possible to put this code up in OSExchangeData rather than here, but it feels best to centralize it here so that we don't have to worry about bad file names leaking into other code. I tried hard to write a layout test for this, but it seems we don't really use the file name in test shell so that I couldn't get coverage. BUG=7023 TEST=none Review URL: http://codereview.chromium.org/20504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10206 0039d316-1c4b-4281-b951-d872f2087c98
* Add IPv6 support to net::GetHostAndPort.ericroman@google.com2009-02-233-30/+42
| | | | | | Review URL: http://codereview.chromium.org/28015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10205 0039d316-1c4b-4281-b951-d872f2087c98
* Roll r96 of google-url, which exposes "url_parse::ParseAuthority".ericroman@google.com2009-02-231-1/+1
| | | | | | Review URL: http://codereview.chromium.org/28031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when dns prefetching was being shut down without being started.phajdan.jr@chromium.org2009-02-233-6/+7
| | | | | | | | | | | | | | | | This happened when BrowserMain exited before the point when we initialized dns prefetching, but after BrowserProcessImpl was created. We do shutdown of dns prefetching in ~BrowserProcessImpl. Example way to trigger the crash: open a saved HTML page while Chrome is already running. Change ShutdownDnsPrefetch to EnsureDnsPrefetchingShutdown which does nothing if dns prefetching has not been initialized. This is the simplest way to prevent the crash and we don't want to complicate the startup sequence even more. BUG=7900 Review URL: http://codereview.chromium.org/27048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10201 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline an SVG test. The "spoke" of the wheel pointing NE has the upper ↵sidchat@google.com2009-02-233-4/+2
| | | | | | | | edge anti-aliased in a slightly different shade. The rest looks fine. Review URL: http://codereview.chromium.org/28032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10200 0039d316-1c4b-4281-b951-d872f2087c98
* Add ProxyResolverV8 class.darin@chromium.org is the original author of ↵ericroman@google.com2009-02-2319-1/+920
| | | | | | | | 'proxy_resolver_v8.cc' and 'proxy_resolver_script.h'. Review URL: http://codereview.chromium.org/21391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10199 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to ProxyService for downloading a PAC script on behalf of the ↵ericroman@google.com2009-02-236-53/+778
| | | | | | | | ProxyResolver. A ProxyResolver can select this new behavior by subclassing ProxyResolver with |does_fetch = false|. A consequence of this change is that proxy resolve requests are maintained in a queue by ProxyService (rather than implicitly in a queue on the PAC thread's message loop). This simplifies cancellation.This solves issue 7461, and is work-in-progress towards {2764, 74}BUG=7461 Review URL: http://codereview.chromium.org/21328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10197 0039d316-1c4b-4281-b951-d872f2087c98
* Build third_party/WebKit/WebKit/chromium on Linux.darin@chromium.org2009-02-232-0/+24
| | | | | | | | R=tony Review URL: http://codereview.chromium.org/28030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10196 0039d316-1c4b-4281-b951-d872f2087c98
* roll third_party/WebKitdarin@chromium.org2009-02-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10195 0039d316-1c4b-4281-b951-d872f2087c98
* Change layout test expectations on linux: mark a failing test as failing and ↵estade@chromium.org2009-02-231-2/+4
| | | | | | | | | | a passing test as passing. In r10137 I took out the wrong test. Review URL: http://codereview.chromium.org/27044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10192 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bogus end-of-file comment.pkasting@chromium.org2009-02-231-1/+1
| | | | | | Review URL: http://codereview.chromium.org/28008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10191 0039d316-1c4b-4281-b951-d872f2087c98
* A few minor changes to WidgetWin:pkasting@chromium.org2009-02-235-16/+29
| | | | | | | | | * Add a Show() method to match Hide(), and use it in existing code. This abstracts the specifics of this a bit and will be convenient for fullscreen UI. * Safe Hide() (and, for speed, Close()) behind IsWindow() checks just like CloseNow(), which I'll need for some tricky window-closing code in the fullscreen UI. (Right now, Hide() will eventually fail an assertion if you call it when the widget is no longer a window, which seems unnecessarily harsh.) Review URL: http://codereview.chromium.org/27017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10190 0039d316-1c4b-4281-b951-d872f2087c98
* Make the "cocoa" group and actual enclosing group so the files contained ↵pinkerton@chromium.org2009-02-231-24/+24
| | | | | | | | within are relative to it, not the grandparent browser director. Review URL: http://codereview.chromium.org/27051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10189 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some tiny grd issues:pkasting@chromium.org2009-02-231-3/+3
| | | | | | | | | * Misspelling in description * "Help" had no accelerator key * "Clear browsing data..." unnecessarily used a non-first-letter accelerator Review URL: http://codereview.chromium.org/27015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10188 0039d316-1c4b-4281-b951-d872f2087c98
* Fix references to moved filespinkerton@chromium.org2009-02-232-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10187 0039d316-1c4b-4281-b951-d872f2087c98
* Move Cocoa-specific files into the cocoa folderpinkerton@chromium.org2009-02-235-9/+9
| | | | | | Review URL: http://codereview.chromium.org/28028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10186 0039d316-1c4b-4281-b951-d872f2087c98
* Lie on the priority change and saw we did it w/ a comment about why we won'tthomasvl@chromium.org2009-02-231-1/+4
| | | | | | | | be able to, but w/ the current api and higher layers, it's much more work to fully clean that up. Review URL: http://codereview.chromium.org/28029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10185 0039d316-1c4b-4281-b951-d872f2087c98
* Add new vcproj for contents of third_party/WebKit/WebKit/chromiumdarin@chromium.org2009-02-234-0/+203
| | | | | | | | R=maruel Review URL: http://codereview.chromium.org/27040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10184 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a build break caused by r10178.hbono@chromium.org2009-02-231-1/+1
| | | | | | | | | | r10178 compares an int value 'written' with a size_t value 'sizeof(num_open_files)' in "base/process_util_unittest.cc" and it caused a compilation error on Mac and Linux. As a quick fix, this change casts the int value 'written' to size_t. TBR=xji Review URL: http://codereview.chromium.org/28019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10179 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 6099 -- bad display of multi-line English message in pop ↵xji@chromium.org2009-02-2310-23/+289
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ups. (http://crbug.com/6099) Currently, in RTL locales, a pure *multi-line* English message is displayed as right aligned and has RTL directionality (such as the ending punctuation appears at the very left). Single-line message works fine. I do not know why, but simply putting LRE-PDF around a multi-line English text which has the following flags DT_WORDBREAK | DT_RTLREADING wont render the English message as LTR. We have to remove the DT_RTLREADING to render multi-line English message correctly in LTR direction. The fix is that in RTL locales, for JavaScript message, if the message is pure English, the alignment is set to be left-aligned, and the directionality is set to be left-to-right. If the message is mixed BiDi text, the alignment and the directionality is determined by the directionality of the first character with strong directionality in the text. JavaScript message is a MessageBoxView, and the message is a view::Label. Both MessageBoxView and Label are used by Chrome's UI as well. If the message is one of Chrome UI's, the alignment and directionality of the message should be taken from that of the UI's. In order to distinguish where the message comes from, a new flag kFlagWebMessage is introduced in MessageBoxView, and a new argument is introduced in Label::SetHorizontalAlignment() to control whether the alignment need to be flipped or not for RTL locales. Consequently, quite a few files which calls Label::SetHorizontalAlignment() are changed. The main changes are in 5 areas. Other files are changed due to the signature change of Label::SetHorizontalAlignment(). 1. jsmessage_box_handler.cc: pass in extra flag kFlagWebPage when creating MessageBoxView to indicate the message box is one from a web page, not from Chrome UI. 2. l10n_util.h/.cc added function GetFirstStrongDirection() 3. label.h/.cc a new argument is introduced in Label::SetHorizontalAlignment() to control whether the alignment need to be flipped or not for RTL locales. 4. message_box_view.cc when init message box view, if the flag is kFlagWebPage, get the text directionality from the text itself (not Chrome UI's) and calls Label::SetHorizontalAlignment() to not resetting the flag for RTL locales. 5. chrome_canvas_win.cc 5.1 ComputeFormatFlags() only set flag DT_RTLREADING for RTL locales if the text contains strong RTL characters and the alignment is RIGHT aligned. All labels of Chrome's UI and other Chrome UI components in RTL locales have been set as (or flipped to) RIGHT aligned. 5.2 DoDrawText() Only adjust string for locale is the reading direction is DT_RTLREADING. Review URL: http://codereview.chromium.org/18863 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10178 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix the tree.evan@chromium.org2009-02-232-3/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10177 0039d316-1c4b-4281-b951-d872f2087c98
* Bump VERSION to 2.0.167.0laforge@chromium.org2009-02-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10176 0039d316-1c4b-4281-b951-d872f2087c98