| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=125568
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/10274022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
realized the old implementation was over-complicated and could fail if two objects had interleaved, rather than nested, scope.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/10269008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10268021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=102482
TEST=
Review URL: http://codereview.chromium.org/10266010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/10271025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
page action.
BUG=124605
Review URL: http://codereview.chromium.org/10264004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This bug was introduced by r10170037 which waited until mouse was
released to truly end a grab.
BUG=crash when clicking on titlebar to restore a minimized panel
TEST=minimize a panel. click on titlebar to restore. verify no crash.
Review URL: https://chromiumcodereview.appspot.com/10266021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=aa@chromium.org
BUG=124477
Review URL: http://codereview.chromium.org/10177006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the original way (installed then loaded).
I originally switched the order so I could dispatch the onInstalled event, but
doing so in a PostTask is a better solution to that.
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/10274013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
TEST=tree
Review URL: https://chromiumcodereview.appspot.com/10260027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
HostPortAllocator is a PortAllocator specific to Chromoting host.
BUG=103991
Review URL: https://chromiumcodereview.appspot.com/10160013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
TEST=tree
Review URL: https://chromiumcodereview.appspot.com/10264018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
confirmation page.
BUG=125471
TEST=none
Review URL: http://codereview.chromium.org/10268019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Right-click #include "qms.h" in VS2010 works.
Review URL: http://codereview.chromium.org/10271005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://www.corp.google.com/~kenmoore/mocks/chromeos/Misc_2012/Menus/markup1/menu4.html
Menu text enabled color, button enabled text color, label enabled text color are set to #222.
Menu text disabled color, button disabled text color, label disabled text color are set to #999.
Menu keyboard shortcut text color is set to #999.
Menu item hover background color is set to #f1f1f1.
BUG=122858
TEST=Menu spec for all the color is implemented, see code review description for details.
Review URL: http://codereview.chromium.org/10270021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
r134550
BUG=119511
TEST=none
TBR=reed
Review URL: https://chromiumcodereview.appspot.com/10262024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Installed the root certificate on each of the chrome-qa bots and
ran the disabled SSL tests to verify. Only managed to install the
root certificate on the windows bots on the chromium waterfall.
TEST=Verified in each chrome-qa bot.
BUG=119110,119173
Review URL: https://chromiumcodereview.appspot.com/10271021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
TBR=thestig@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10170045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
clients that have UMA enabled. Causing startup crash on Linux chromeos bot.
This requires a change to the ChromeNetworkDelegate where we feed the incognito state (a bool) into the object at creation time, so we can check that field when doing our header setting.
BUG=123609
TEST=With UMA enabled (not Chromium), visit www.google.com and ensure that the request header includes X-Chrome-UMA-Enabled with value "1". Ensure that disabling UMA also disables the transmission of this header entirely. Also, ensure that unit_tests GoogleUtilTests all pass.
TBR=ivankr@chromium.org
Review URL: http://codereview.chromium.org/10108026
TBR=stevet@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10264023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=crash reporting still works (need to build Chrome, not Chromium) and dbeam%40%20doesn't%20go%20crazy%20trying%20to%20read%20it
Review URL: https://chromiumcodereview.appspot.com/10007040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This archive is referred to by our canary link to the webapp.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10271019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes Chrome listen for messages from the power manager
asking it to dim or undim the screen. We'll use this on
desktop devices with external displays to dim the screen
just before blanking it when the user is idle.
BUG=125176
TEST=added, also did manual testing with powerd changes
Review URL: http://codereview.chromium.org/10263011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LibjingleTransport transport instances will be sharing a single
PortAllocator, so config needs to be passed to TransportFactory.
BUG=103991
Review URL: https://chromiumcodereview.appspot.com/10160012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10266019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this patch, I moved more panel-specific logic out of the base classes:
* Title decoration to draw the title with pango markup
* SendEnterNotifyToCloseButtonIfUnderMouse
I overrode UsingCustomPopupFrame in PanelBrowserWindowGtk to always return false. That way, panels are always painted with custom frame. Now no matter which theme the user picks and which state (drawing attention or not) the panel is at, we paint the frame in the same code path.
I also fixed the extra line shown in title-only panel by adding IsMinimized check to BrowserWindowGtk::ShouldDrawContentDropShadow.
BUG=117205
TEST=Manual test by verifying panels being painted with correct theme
Review URL: https://chromiumcodereview.appspot.com/10180011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The typos are caught by jscompile.
Review URL: https://chromiumcodereview.appspot.com/10262013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ben recently added support in cros-disks for an optional mount label.
(https://gerrit.chromium.org/gerrit/#change,21171)
Make use of this option to display a user-friendly file name for the
mounted archive, instead of the actual file name of the cache blob
"<resource_id>.<md5>.mounted".
BUG=chromium-os:28678
TEST=Tested mounting archives (both local and on gdata).
Review URL: http://codereview.chromium.org/10231010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/10261017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Below are a few tests that are crashing (the list is not complete):
compositing/plugins/composited-plugin.html
compositing/plugins/1x1-composited-plugin.html
compositing/plugins/small-to-large-composited-plugin.html
compositing/plugins/large-to-small-composited-plugin.html
This allows us to show a nicer placeholder when loading a plug-in fails then the one coming from WebKit.
BUG=123580
TEST=manual
Review URL: http://codereview.chromium.org/10093011
TBR=bauerb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10274020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Addresses follow-up comments from 10197005.
Review URL: http://codereview.chromium.org/10221027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To be re-enabled tomorrow.
R=dennisjeffrey@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10265019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This broke as a result of r134028, where we iterate all RVHs associated with an extension instead of just ExtensionHosts.
BUG=125306
TEST=Test hosted app menus, extension popup menus and platform app popups work correctly.
Review URL: http://codereview.chromium.org/10253021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=125635
Review URL: https://chromiumcodereview.appspot.com/10260024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UMA enabled.
This requires a change to the ChromeNetworkDelegate where we feed the incognito state (a bool) into the object at creation time, so we can check that field when doing our header setting.
BUG=123609
TEST=With UMA enabled (not Chromium), visit www.google.com and ensure that the request header includes X-Chrome-UMA-Enabled with value "1". Ensure that disabling UMA also disables the transmission of this header entirely. Also, ensure that unit_tests GoogleUtilTests all pass.
TBR=ivankr@chromium.org
Review URL: http://codereview.chromium.org/10108026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This copy was fetched from:
hg.mozilla.org/projects/kraken/
Modifications made:
The python script make-hosted.py was run to update the hosted/ directory, and the unused tests, sunspider, and sunspider-compare-results files were deleted.
BUG=
TEST=
Review URL: http://codereview.chromium.org/10070009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead use GetFileInfoByPathAsync(). This is in preparation for
making FindEntryByPathAsync() private.
Along the way, get back |file_name| field in GDataFileProto, which
was once removed in crrev.com/134405, as this info was needed.
BUG=chromium-os:30251
TEST=can open both regular files hosted documents on gdata as before
Review URL: https://chromiumcodereview.appspot.com/10270025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also changed the name of the function from _GetMemoryStats to
GetCrosMemoryStats.
This change allows autotests (that import pyauto) to invoke the memory
collection function using something like this:
mem_info_dict = self.pyauto.GetCrosMemoryStats(20)
(except replace '20' with a suitable duration for the given test).
BUG=None
TEST=Verified that autotest graphics_WebGLPerformance can successfully
invoke GetCrosMemoryStats(), given the change to pyauto.py in this CL.
Review URL: https://chromiumcodereview.appspot.com/10271023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=119287
TEST=Follow steps in bug
Review URL: http://codereview.chromium.org/10095024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to show a nicer placeholder when loading a plug-in fails then the one coming from WebKit.
BUG=123580
TEST=manual
Review URL: http://codereview.chromium.org/10093011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I moved sel_ldr_launcher_chrome.cc into the Chromium repo in r134552
but I forgot to update build.scons. This update is necessary for
removing sel_ldr_launcher_chrome.cc from the NaCl repo because it
ensures that the 'launch_nacl_process' variable (which module_ppapi.cc
assigns to) will be defined. (The alternative would be to
conditionalise the assignment of 'launch_nacl_process' in
module_ppapi.cc.)
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2750
TEST=NaCl's Scons build
Review URL: http://codereview.chromium.org/10261016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Win fix for CL: http://codereview.chromium.org/10235010/
TBR=sadrul
BUG=124269
TEST=win aura compiles
Review URL: https://chromiumcodereview.appspot.com/10269015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
TEST=tree
Review URL: https://chromiumcodereview.appspot.com/10261018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following cleanup was done in preparation for notifications which may require multiple SystemTrayBubble instances:
* Separate out SystemTrayBubbleView from SystemTrayBubble
* Move SystemTray.popup_ -> SystemTrayBubble.bubble_widget_
* Remove scoped_ptr for views (views are owned by the view hierarchy)
* Changed behavior to not close when focus is lost so that the default view can be reused.
BUG=124269
TEST=All tests should pass; system tray behavior should be unchanged.
Review URL: https://chromiumcodereview.appspot.com/10235010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=102482
TEST=
Review URL: http://codereview.chromium.org/10260016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=124843
TEST=as in bug
Review URL: http://codereview.chromium.org/10269003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The function is no longer used.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/10263012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Host will have host-specific port allocator, so PortAllocator creation
has to be moved out of protocol code. Since PortAllocator needs to be
configured with network settings (nat traversal and port range), I
refactored how these settings are passed between layers.
BUG=103991
Review URL: https://chromiumcodereview.appspot.com/10233021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134608 0039d316-1c4b-4281-b951-d872f2087c98
|