| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
going to enable them and watch closely.
BUG=16934
TEST=none
Review URL: http://codereview.chromium.org/149763
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fixing what r20898 broke.
Review URL: http://codereview.chromium.org/155676
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The only change is adding a missing handle scope to make sure that we
do not leak handles.
TBR=kasperl@chromium.org
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non focused buttons.
BUG=16973
TEST=Tab to the buttons at the top of the NNTP. They should have a
*outlined* look (same as hover).
Review URL: http://codereview.chromium.org/159013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16579
TEST=run ui tests all day, verify no reported leaks :-)
Review URL: http://codereview.chromium.org/159008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
types. Also expands on the documentation of GetViewForPoint.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149723
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/16559
Review URL: http://codereview.chromium.org/159012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155697
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hat tip to spotrh
BUG=16948
TEST=none
Review URL: http://codereview.chromium.org/149786
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r15113 (http://src.chromium.org/viewvc/chrome?view=rev&revision=15113) .
Besides, set referrer_charset_ (used in guessing the C-D charset in GetFileNameFromCD) to pref::kDefaultCharset without any q values appended.
TEST=1. Set the default charset in Options | Advanced | Fonts & Languages to ISO-8859-1.
2. Type http://i18nl10n.com/moztest/random21.yyy in the omnibox and the filename in the download bar should start with "횉횗짹횤21"
3. Change the default charset to Korean
4. Try #2 again and the filename in the download bar should start with '?쒓?21'.
BUG=1148 (http://crbug.com/1148 )
Review URL: http://codereview.chromium.org/149705
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Update list of most visited URLs on an exponential timer, resetting when the history is cleared.
Review URL: http://codereview.chromium.org/155619
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This logic comes from carefully reading what Mozilla does.
We're still behind the flag --enable-plugins so this won't
turn on plugins for users anymore.
BUG=15504
Review URL: http://codereview.chromium.org/155594
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- For input handling so far
BUG=16673
TEST=unit test included
Review URL: http://codereview.chromium.org/155613
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Still not done yet.
BUG=none
TEST=none
TBR=aa
Review URL: http://codereview.chromium.org/155696
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/15334
TEST=type in a popup containing more than one item; as the number of items decreases, the list should properly shrink and draw itself.
Review URL: http://codereview.chromium.org/155694
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15475
TEST=none
Review URL: http://codereview.chromium.org/155690
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=stuart
Review URL: http://codereview.chromium.org/159007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16006
TEST=none.
Review URL: http://codereview.chromium.org/149794
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes the valgrind suppression for this leak.
Valgrind: 1, rohitrao: 0
BUG=17002
TEST=No more leaky.
Review URL: http://codereview.chromium.org/159005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Bug 15762 happens on Linux, too, so move suppression to generic file.
Also trim unneeded end of stack.
BUG=15762
TEST=watch valgrind test_shell_tests go greener on linux (and not redder on mac)
Review URL: http://codereview.chromium.org/155658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155659
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
menu from View. Add stub menu item for Task Manager (disable).
BUG=16135
TEST=js console opens
Review URL: http://codereview.chromium.org/149677
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
click menu. Also includes a couple of methods which will be needed
once support for the spelling panel is finished. Patch from Paul Wicks
(pwicks86@gmail.com)
BUG=NONE
TEST=Context menu on the mac should show and allow switching between languages
for the spellchecker
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mpcomplete
Review URL: http://codereview.chromium.org/149783
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17002
TBR=rohitrao
Review URL: http://codereview.chromium.org/159004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12149
TEST=checkdeps should still pass
Review URL: http://codereview.chromium.org/155673
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
optimization to make access to internal fields on JavaScript
objects through the V8 API faster.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because of a hard-disk problem, I lost the original change. So, I would like to send another change for this fix.
This is the second part of the fix for Issue 13711.
On non-ASCII keyboards (e.g. Russian and Hebrew), |event->keyval| represents a non-ASCII value that BrowserWindowGtk::HandleAccelerator() cannot handle.
To fix this issue, this change uses |event->hardware_keycode| to retrieve its ASCII value before calling BrowserWindowGtk::HandleAccelerator().
BUG=13711 "Alt-D does not work when in editbox"
TEST=Type alt+d keys on a Russian keyboard and verify the input focus is moved to an onmibox.
Review URL: http://codereview.chromium.org/155555
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
issues on Mac OS caused by inlining functions containing static
variables.
BUG=http://code.google.com/p/v8/issues/detail?id=404
TEST=none
Review URL: http://codereview.chromium.org/155683
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
patch by <joel.stan@gmail.com>
original review url: http://codereview.chromium.org/155677
Review URL: http://codereview.chromium.org/149797
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/155662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a NULL NPObject to NPN_HasMethod. I checked out Firefox's implementation and they check for NULL NPObjects in all functions except NPN_Evaluate and NPN_SetException.
Fix is to emulate Firefox behavior.
Fixes http://code.google.com/p/chromium/issues/detail?id=16900
Bug=16900
Review URL: http://codereview.chromium.org/155628
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on WebKitClient. This allows glue/localized_strings.cc to move
into the WebKit API implementation.
BUG=16933
TEST=none
R=dglazkov
Review URL: http://codereview.chromium.org/149760
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension developers who want to package extensions as part of a build script
and aren't there to click the message box.
R=aa,jackson
BUG=14732
TEST=Pack an extension with the --no-message-box flag and notice that there is no message box.
Review URL: http://codereview.chromium.org/149795
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
/etc/lsb-release does not exist on all distros, and sometimes it does
not provide any useful info. Whereas all LSB complaint distros return
useful data with the lsb_release command.
Review URL: http://codereview.chromium.org/155653
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
don't restore anything.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155667
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Flaky tests appearing some in morning, and some afternoon.
BUG=16779, 16742, 13907
TEST=None
Review URL: http://codereview.chromium.org/149793
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149789
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This code should enable the creation of a basic context menu for the Video and Audio tags. The actions for fullscreen, save screenshot, loop, and set playback rate are not yet implemented.
BUG=15686
TEST=None
Review URL: http://codereview.chromium.org/149604
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pretty. Animations and aesthetic appeal will come in a
future CL.
BUG=http://crbug.com/14462
BUG=http://crbug.com/14937
BUG=http://crbug.com/15839
BUG=http://crbug.com/16487
TEST=Infobars should show up when expected.
Review URL: http://codereview.chromium.org/155494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=evan
Review URL: http://codereview.chromium.org/149787
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16951
TEST=launch bookmark manager on gnome/metacity, observe that window has icon
Review URL: http://codereview.chromium.org/155672
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=tabs opened via "Open link in new tab..." should open in foreground, not background.
Review URL: http://codereview.chromium.org/155671
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only show linux splash page for new windows.
May this be the end of this sad saga.
TEST=if chrome is already running, `./out/Debug/chrome test.html` doesn't open splash page
BUG=http://crbug.com/16893
Review URL: http://codereview.chromium.org/149780
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149779
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green build
Review URL: http://codereview.chromium.org/155666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
named bookmark.
Also, change the naming scheme of the DnD targets.
BUG=16791
TEST=select a link in the web page and drag it to the bookmark bar.
Review URL: http://codereview.chromium.org/155661
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, on windows, replace new lines with window style new lines. This call is just there to match Pasteboard::writeSelection(), since AFAICT WebFrameImpl::GetSelection() is never used on any platform besides linux.
BUG=16926
TEST=see bug
Review URL: http://codereview.chromium.org/155650
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20920 0039d316-1c4b-4281-b951-d872f2087c98
|