| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TranslateInfoBarBase. Along the way, remove the ClearMaxTextSize() calls; it seems to me that leaving the button size alone when changing from a longer language name to a shorter one is better (and apparently whoever made that the default behavior for Menu and TextButtons agrees).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6480017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and windows.
Now the behavior matches the comment in rwhv.h
Since the new behavior matches the old (mac-only) GetWindowRect() function, delete it.
Introduces a new function that returns the bounds in the cocoa sense, and update one the one calling side that needs it to use this.
BUG=71368
TEST=Open chrome at ui scale of 2, make sure extension popups look broken in the same way as before this patch. Make sure the web still looks like it did before (pixel-scaled).
Review URL: http://codereview.chromium.org/6463012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With all this file moving, many nib files had outdated paths in them.
I did:
1. A build of the "chrome" target
2. |open chrome/app/nibs/*.xib|
3. Wait for the communication between XCode and IB to cease
4. Hit Cmd-S Cmd-W for every nib window
This was with xcode 3.2.5 on OS X 10.6
57 files changed, 21802 insertions(+), 1258 deletions(-)
No intended behavior change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6476021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72148
TEST=none
Review URL: http://codereview.chromium.org/6480024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
signature.
BUG=72154
TEST=none
Review URL: http://codereview.chromium.org/6480026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71786
TEST=browser & unit tests
Review URL: http://codereview.chromium.org/6246105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. ChromeURLDataManager is no longer a singleton and is always used on
the UI thread. ChromeURLDataManager is now profile specific (you get
from the profile).
. ChromeURLDataManagerBackend handles the URLRequests and the
DataSources. ChromeURLDataManagerBackend is created by
ChromeURLRequestContext.
All DataSources are now profile specific. There were two that wanted
to be global, but have been converted.
This differs from the last version in that DataSource::SendResponse
does nothing if the DataSource is schedule for deletion. This is
necessary otherwise SendResponse will up the ref count and by the time
the request is processed on the IO thread chances are the DataSource
will have been deleted. And if it wasn't deleted, it'll get scheduled
for deletion again. <insert comment here about the perils of using
delayed deletion> This has always been possible, it just appears to be
more likely with my patch.
BUG=52022 71868
TEST=none
Review URL: http://codereview.chromium.org/6479007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72424
TEST=no DCHECK, see bug
Review URL: http://codereview.chromium.org/6460039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This metric will give us idea whether we need to take further measures to
close the short gap between the time the RLZ token is first cached and
later used to perform searches.
BUG=71548
TEST=Manual.
Review URL: http://codereview.chromium.org/6465020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FileSystem API.
For now it has no meaningful implementation yet; mostly just for
defining a few interfaces.
BUG=
TEST=FileSystemUsageTrackerTest.DummyTest
Review URL: http://codereview.chromium.org/6426001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72437
TEST=see bug for manual test
Review URL: http://codereview.chromium.org/6476006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=51716,58145
TBR=glider
Review URL: http://codereview.chromium.org/6469025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41073
TEST=launch chrome, hover the location icon, a tooltip with "View site information" should appears.
Review URL: http://codereview.chromium.org/6463024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixes possible problem with white rectangle blinking when spinner
window is shown.
BUG=chromium-os:7919
TEST=manual
Review URL: http://codereview.chromium.org/6452005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix the logging for more debugging tomorrow.
BUG=none
TEST=none
TBR= dhollowa@chromium.org
Review URL: http://codereview.chromium.org/6476026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72169,74295
TBR=glider
TEST=TSan/UI bots are greener
Review URL: http://codereview.chromium.org/6480029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ResourceDispatcherTest.RespectNoSniffDirective
BUG=57717,72538,72541,72542,72544
TBR=glider
TEST=Memory waterfall goes greener
Review URL: http://codereview.chromium.org/6476024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR= dhollowa@chromium.org
Review URL: http://codereview.chromium.org/6480028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For instance, if initial_locale in startup_manifest.json is set to "fr",
we'll set up the hardware keyboard to French, and use it in the OOBE
screen.
BUG=chromium-os:10964
TEST=manually on the netbook. Confirm that French keyboard layout is enabled by default by putting startup_manifest.json with initial_locale set to "fr".
Review URL: http://codereview.chromium.org/6463018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=canary
TBR=zmo
Review URL: http://codereview.chromium.org/6478022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6456026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
needed, in order to make input method switching light-weight.
BUG=chromium-os:9206
TEST=manually
Review URL: http://codereview.chromium.org/6459018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builder.
This is the only functional difference that I can see between the previous version of the test and the current one.
BUG=72401
TEST=
Review URL: http://codereview.chromium.org/6478012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We plan to save the hardware kayboard layout information as ID
like "xkb:us::eng", hence the function to get the information
should just return the ID, rather than a descriptor struct.
BUG=chromium-os:10964
TEST=input methods work as before on the netbook
Review URL: http://codereview.chromium.org/6465022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11480
TEST=chrome buidls and runs fine
Review URL: http://codereview.chromium.org/6476022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing, moving the bits Mac uses to ui/base/events.h
BUG=72040
TEST=none
TBR=sky
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74377
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=9075
TEST=Login as Guest, go to chrome://settings, Personal Stuff, Passwords, ensure all settings concerning saving passwords are disabled and never save passwords is selected.
Review URL: http://codereview.chromium.org/6250199
Patch from Vsevolod Vlasov <vsevik@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Undesired font is rendered for Japanese if only Helvetica and Arial
are specified.
BUG=chromium-os:11863
TEST=manually see new tab page font (text for 'web store', specifically)
Review URL: http://codereview.chromium.org/6349104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6479002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=hamaji
Review URL: http://codereview.chromium.org/6480020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
about:gpu page.
BUG=71879
TEST=
Review URL: http://codereview.chromium.org/6460016
Patch from John Bates <jbates@chromiu.org>.
TBR=nduca@chromium.org
Review URL: http://codereview.chromium.org/6476019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11861
TEST=Test network menu
Review URL: http://codereview.chromium.org/6465028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6478014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
race the removal of the observer with the check. Use a private flag instead
until this hack can be removed.
BUG=67174
TEST=none
Review URL: http://codereview.chromium.org/6469017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
client side arrays.
TEST=none
BUG=71717
Review URL: http://codereview.chromium.org/6459013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6355012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
9.0.597.84. The crash
occurs when the external tab container instance is being torn down which takes down the rootview
which attempts to destroy child views leading to a crash while accessing a deleted focusmanager
instance.
Proposed fix is to destroy the root child views in the TAB_CONTENTS_DESTROYED notification
which is sent out in the destructor of the TabContents object.
BUG=72356
TEST=none
Review URL: http://codereview.chromium.org/6463032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AudioMixerPulse was sometimes being destroyed while the Init call was still in it's worker thread's queue. If we see that Init hasn't been called yet, RunAllPending() is called to clear out the queue first. This is goes along with the previous fix, where we are trying to close the AudioHandler sooner in the shutdown process http://codereview.chromium.org/646500
BUG=chromium-os:11745
TEST=browser_tests should not fail with "check failed: incoming_queue_.empty()"
Review URL: http://codereview.chromium.org/6476004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a typedef for WebUI to allow us renaming the class now, and then renaming the other entries in small chunks.
Also rename the file from dom_ui.[cc,h] to web_ui.[cc,h].
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6458016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=disables crashing test
BUG=49497
Review URL: http://codereview.chromium.org/6480012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. ChromeURLDataManager is no longer a singleton and is always used on
the UI thread. ChromeURLDataManager is now profile specific (you get
from the profile).
. ChromeURLDataManagerBackend handles the URLRequests and the
DataSources. ChromeURLDataManagerBackend is created by
ChromeURLRequestContext.
All DataSources are now profile specific. There were two that wanted
to be global, but have been converted.
This differs from the version I landed in that there is now a NULL
check in ChromeURLDataManager::DeleteDataSources.
BUG=52022 71868
TEST=none
TBR=willchan, evan, ahendrickson
Review URL: http://codereview.chromium.org/6462036
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/6478010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
we can insert the pasted bookmarks after the selection.
BUG=49362
TEST=Make sure that pasting Bookmarks in the BookmarkManager view makes sense.
Review URL: http://codereview.chromium.org/6460011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18727
TEST=Make sure that we are properly recording all (and only) valid pages in our history.
Review URL: http://codereview.chromium.org/6475001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=mbelshe
Review URL: http://codereview.chromium.org/6469016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6480001
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/6469014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6480001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The other constants will be moved in future patches.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6458014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=hamaji
Review URL: http://codereview.chromium.org/6471007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74368 0039d316-1c4b-4281-b951-d872f2087c98
|