| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The example demonstrates how to use the Slider class.
BUG=none
TEST=manually
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34142
Review URL: http://codereview.chromium.org/466055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to the OOM killer.
BUG=29752
TEST=During out of memory conditions, Linux kernel picks a plugin/renderer over the browser process.
Review URL: http://codereview.chromium.org/467058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
considerably *more* flaky on windows. Go back to the default number
of workers (0).
Sigh. It was worth a try.
Review URL: http://codereview.chromium.org/489001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21732
TEST=none
Review URL: http://codereview.chromium.org/489002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to function in circumstances where there is no Browser instance present. This is a symptom of a tab-contents view hosted in an ExternalTabContainer.The major change here is the removal of the explicit dependency on a Browser instance across all of the delegates involved when showing a pop-up API. I modified the following delegates:- ExtensionPopupHost::Delegate- TabContentsDelegate- ExtensionFunctionDispatcher::DelegateBecause the pop-up requires a Profile, and a gfx::NativeWindow, I added methods to the above interfaces to provide them.BUG=noneTEST=ExtensionApiTest.FLAKY_Popup
Review URL: http://codereview.chromium.org/434046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The signature of this leak has been changed since r34036. This CL updates
the leak signature and moves it to suppressions_mac.txt.
BUG=28072
TEST=none
Review URL: http://codereview.chromium.org/460158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
build reliably.
BUG=None
TEST=None
TBR=tommi
Review URL: http://codereview.chromium.org/484004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/481008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
except linux debug.
The test was made less flaky upstream in http://trac.webkit.org/changeset/51666.
In the last 6 days, it has only failed for linux debug - http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=LayoutTests%2Ftransitions%2Fshorthand-transitions.html.
BUG=18584
TEST=none
Review URL: http://codereview.chromium.org/481010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suspect this is the cause of a cluster of plugin layout test failures
which appear Mac-specific. E.g.
http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Mac10.5/builds/7582/steps/webkit_tests/logs/stdio
LayoutTests/plugins/bindings-test.html = CRASH
LayoutTests/plugins/destroy-during-npp-new.html = CRASH
LayoutTests/plugins/destroy-stream-twice.html = CRASH
LayoutTests/plugins/document-open.html = CRASH
LayoutTests/plugins/embed-attributes-style.html = CRASH
LayoutTests/plugins/get-empty-url.html = CRASH
LayoutTests/plugins/getintidentifier-special-values.html = CRASH
LayoutTests/plugins/geturl-replace-query.html = CRASH
LayoutTests/plugins/invoke.html = CRASH
LayoutTests/plugins/netscape-construct.html = CRASH
LayoutTests/plugins/netscape-destroy-plugin-script-objects.html = CRASH
LayoutTests/plugins/netscape-enumerate.html = CRASH
LayoutTests/plugins/netscape-identifier-conversion.html = CRASH
LayoutTests/plugins/netscape-invoke-default.html = CRASH
LayoutTests/plugins/netscape-plugin-map-data-to-src.html = CRASH
LayoutTests/plugins/netscape-plugin-setwindow-size.html = CRASH
LayoutTests/plugins/npruntime.html = CRASH
LayoutTests/plugins/open-and-close-window-with-plugin.html = CRASH
LayoutTests/plugins/plugin-remove-subframe.html = CRASH
LayoutTests/plugins/reloadplugins-and-pages.html = CRASH
LayoutTests/plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html = CRASH
LayoutTests/plugins/setProperty.html = CRASH
This simplifies things a bit over the old way, and should be a step closer to supporting more QDbased plugins.
Also makes the HandleInputEvent logic a bit clearer.
BUG=none
TEST=Quicktime movies should still play on the Mac.
Review URL: http://codereview.chromium.org/483004
TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/483006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the relevant gyp files.
BUG=29738
Review URL: http://codereview.chromium.org/479005
TBR=mmoss@google.com
Example choke:
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Perf/builds/4382/steps/compile/logs/stdio
Compiling /b/slave/chromium-rel-linux-hardy/build/src/sconsbuild/Release/obj/chrome/unit_tests/common/bzip2_unittest.o
/b/slave/chromium-rel-linux-hardy/build/src/chrome/common/bzip2_unittest.cc:6:19: error: bzlib.h: No such file or directory
Review URL: http://codereview.chromium.org/484003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=eroman
Review URL: http://codereview.chromium.org/482004
TBR=michaeln@google.com
Review URL: http://codereview.chromium.org/481013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This simplifies things a bit over the old way, and should be a step closer to supporting more QD-based plugins.
Also makes the HandleInputEvent logic a bit clearer.
BUG=none
TEST=Quicktime movies should still play on the Mac.
Review URL: http://codereview.chromium.org/483004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
decoders.
This changes the DecoderBase API to be fully asynchronous when invoking its subclass's actions.
Review URL: http://codereview.chromium.org/465044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
UpdatePageActions() can get called after the gtk widgets have been destroyed.
BUG=29757
TEST=see bug
Review URL: http://codereview.chromium.org/476007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
callers of l10n_util::GetApplicationLocale to use this instead.
In the browser process, it's wrong to call
l10n_util::GetApplicationLocale with an empty string because then
it won't consider the user pref value when resolving the locale.
On Linux, it's also wrong to call l10n_util::GetApplicationLocale
after startup because the call touches disk and on Linux, we assume
that all of the program files can be deleted after startup (so
updates in place can work).
Review URL: http://codereview.chromium.org/476002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=29589
TEST=none
Review URL: http://codereview.chromium.org/479015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29850
Review URL: http://codereview.chromium.org/477011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a dropdown from the page action icon when you click on the icon.
If the page has only one feed, the dropdown does not appear and the
extension works as before.
BUG=None
TEST=Test this on a page with multiple feeds and make sure a dropdown
appears when you click on the RSS icon and that clicking each feed
name takes you to the extension 'subscribe?' page.
Review URL: http://codereview.chromium.org/475007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
interface provide heuristics for determining the type of a form field. An initial implementation, EmailField, is provided.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/469013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/483005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
layout-test-results directory instead of a regressions.txt. This file contains
more information in an easier-to-mechanically-consume format.
Also, refactor the print routines to use the unexpected-results struct, which cleans
up a bunch of stuff.
R=ojan@chromium.org, pam@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/465090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=eroman
Review URL: http://codereview.chromium.org/482004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- get extension_browsertests_misc compiling
- mark a bunch of tests with bugs and dependencies before they can come online
- bring a bunch of tests online (also on linux)
- Also removed some variables only used in one spot in the gyp file now.
- Update all the browser_tests to use the MAYBE_ pattern to make sure we never get a conflict on the define
BUG=none
TEST=waterfall stays green
Review URL: http://codereview.chromium.org/475008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
gyp files.
BUG=29738
Review URL: http://codereview.chromium.org/479005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, update some comments to use the new bug number.
BUG=8205,25404
Review URL: http://codereview.chromium.org/483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29917
TEST=Open about box on dev and beta. See channel in about box after version.
Review URL: http://codereview.chromium.org/463063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
warnings turned on (such as for Native Client).
Review URL: http://codereview.chromium.org/482005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on some testing on a single core machine, reducing this
number below 10 doesn't seem to help. On some of the page
cycler tests (intl2 in particular), I observed some excessive
paint rect counts (>50). Those outliers seem to explain the
perf regression observed for single core machines.
R=brettw
BUG=29589
TEST=none
Review URL: http://codereview.chromium.org/481002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/476005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=asargent
Review URL: http://codereview.chromium.org/482002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/29681 (likely Apple bug)
TBR=asargent
Review URL: http://codereview.chromium.org/476004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
2. Move the numcores code into platform_utils.
Review URL: http://codereview.chromium.org/481004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pick the color of the slider's thumbpart and rail from the GTK theme.
We cannot match the exact visual appearance of the GTK theme, as
rendering engines can make arbitrary changes to the actual visual
appearance. But by sampling a representative set of pixels, we ensure
that we will at least match the general color scheme.
BUG=10949
patch by <markus [at] chromium>
original review: http://codereview.chromium.org/400027/show
Review URL: http://codereview.chromium.org/466080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failing on image
BUG=none
TEST=none
TBR=markus
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is also linked
in by toolbar.
This CL gets rid of this dependency and also ensures that full crash dumps are gathered during
chrome frame reliability test runs.
Review URL: http://codereview.chromium.org/481003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
use it. Implement a mac menu controller that takes this model and generates an NSMenu. Remove the Page Menu NSMenu from Toolbar.xib since it's now created in code.
BUG=22646
TEST=page menu should work as before
Review URL: http://codereview.chromium.org/465130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
if the listing wasn't empty (otherwise we'd record a useless
and misleading "unknown server" entry).
TEST=none
BUG=25520
Review URL: http://codereview.chromium.org/474003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
function that matches WebKit instead, since the callers really care about content area scrollbars.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/463061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* ExternalMetrics class requires scoped_refptr.
original CL : http://codereview.chromium.org/470006
BUG=None
TEST=Run unit_test with valgrind.
patch from issue 470006
Review URL: http://codereview.chromium.org/465140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OSCertHandle so that we can also use it on Windows.
Remove the unused SSLClientSocketMac::intermediate_certs_ member.
R=hawk
BUG=28744
TEST=Can visit good HTTPS sites with no certificate errors. Clicking
the "Certificate information" button in the page security information
window should show a complete certificate chain (as opposed to just
the server certificate).
Review URL: http://codereview.chromium.org/452042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This patch was originally prepared by Alexander Potapenko (cc'ed)
and reviewed as http://codereview.chromium.org/464032
TBR=dank
Review URL: http://codereview.chromium.org/478003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings the heap leak checker back again.
The patch was originally prepared by Alexander Potapenko (cc'ed)
and reviewed as http://codereview.chromium.org/464034
TBR=willchan,antonm
Review URL: http://codereview.chromium.org/478002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
passing the HttpResponseInfo (containing the response headers) to
FlipStream.
R=mbelshe
BUG=none
TEST=The DCHECK in GetCertID() in resource_dispatcher_host.cc should not
fail when you visit an HTTPS site using SPDY.
Review URL: http://codereview.chromium.org/471007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Landing for eisinger.
BUG= 21459
TEST= On history page, font for delete day msg is correct, and you can tab to it.
Review URL: http://codereview.chromium.org/473004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
which caused subtle changes in pixel values even for the non-themed case.
BUG=29748
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34164 0039d316-1c4b-4281-b951-d872f2087c98
|