| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed points at http://crosbug.com/7707
1) Welcome Screen: combo boxes flickering
2) Don't show register step when register screen is not defined
5) Proper font & layout for update screen
6) Updated default screen size to match mocks (EULA/register/create account), update, welcome - OK.
Sign in screen has the same size when presented alone or with other pods.
9) Added « character to EULA Back button.
BUG=chromium-os:7707
TEST=Manual.
Review URL: http://codereview.chromium.org/3863003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ExtensionTest.GenerateId
Review URL: http://codereview.chromium.org/3851004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3764013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green
TBR=jamesr
Review URL: http://codereview.chromium.org/3761013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the disabled drop down in the Preferences dialog box.
It's a redo of CL 3865001 without the typo.
BUG=49306
TEST=SearchEngineListModelTest.Default
Review URL: http://codereview.chromium.org/3812011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An example of a flake:
ChromeMainTest.AppLaunch:
c:\b\slave\win\build\src\chrome\app\chrome_main_uitest.cc(28):
error: Value of: UITest::GetBrowserProcessCount()
Actual: 3
Expected: 2
BUG=none
TEST=ui_tests
Review URL: http://codereview.chromium.org/3796009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
show a selection in the disabled drop down in the Preferences dialog box.
BUG=49306
TEST=SearchEngineListModelTest.Default
Review URL: http://codereview.chromium.org/3865001
TBR=jeanluc@google.com
Review URL: http://codereview.chromium.org/3837008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use const ref instead of copying.
No inlining of ctor/dtor.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3785002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the disabled drop down in the Preferences dialog box.
BUG=49306
TEST=SearchEngineListModelTest.Default
Review URL: http://codereview.chromium.org/3865001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Improve how error bubble is closed.
BUG=chromium-os:7690
TEST=Manual
Review URL: http://codereview.chromium.org/3797008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before the fix, the update status message in the about page of Chrome OS
became incorrect, if the about page was reloaded after the update was complete.
TEST=manually on the netbook
BUG=chromium-os:6526
Review URL: http://codereview.chromium.org/3850004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to show extension initialization in user log
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/3787009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Questions:
1) Is WebGraphicsContext3D only used for WebGL? Currently
this patch makes that assumption.
2) I started by adding const char* allowed_extensions to
a bunch of functions. Then, at the IPC level added
GPUInitParams. Should I use GPUInitParams everywhere?
3) Is the path for gpu_init_params.h ok?
TEST=unit tests, manually tested WebGL
BUG=none
Review URL: http://codereview.chromium.org/3775014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to share more code,
and also makes FLAKY_ and FAILS_ prefixes
work in test_shell_tests.
BUG=none
TEST=test_shell_tests
Review URL: http://codereview.chromium.org/3843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First Run. Make sure the minimum bubble is not showed if there is no default search.
This is a re-issue of CL 3565013 without the extraneous change to search_engine_list_model.mm, to be done in a forthcoming CL>
BUG=49306
TEST=Set a managed default search provider. Clear your Chromium user data directory (~/Library/Chromium, ~/.config/chromium, %localappdata%\Chromium) and the "First Run" file found next to the executable. Start Chrome. It should not ask you to choose a default search provider. Disable the default search provider via policy. Make sure the minimal bubble is not shown. Redo these tests for the GOOGLE_CHROME_BUILD to make sure that we still ask about usage stats.
Review URL: http://codereview.chromium.org/3847006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
when closing an incognito window that had a download.
BUG=59365
TEST=see bug
Review URL: http://codereview.chromium.org/3826014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=yutak
BUG=59560
TEST=none
Review URL: http://codereview.chromium.org/3803010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
safebrowsing browsertest run end to end test with the test server.
BUG=47318
TEST=this is the test
Review URL: http://codereview.chromium.org/3277008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3803011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of the dialog redesign for this feature. We need a way to go from the url to the search engine icon and friendly name (for search engines that we know about).
BUG=38475
TEST=unit_tests --gtest_filter=TemplateURLPrep*
Review URL: http://codereview.chromium.org/3847004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=59727
TEST=interactive_ui_tests --gtest_filter=TestEnableResourcesTab
TBR=tyoshino@chromium.org
Review URL: http://codereview.chromium.org/3781019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59645
TEST=editing/spelling/design-mode-spellcheck-off.html
Review URL: http://codereview.chromium.org/3814018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
choose it at First Run. Make sure the minimum bubble is not showed if there is no default search.
BUG=49306
TEST=Set a managed default search provider. Clear your Chromium user data directory (~/Library/Chromium, ~/.config/chromium, %localappdata%\Chromium) and the "First Run" file found next to the executable. Start Chrome. It should not ask you to choose a default search provider. Disable the default search provider via policy. Make sure the minimal bubble is not shown. Redo these tests for the GOOGLE_CHROME_BUILD to make sure that we still ask about usage stats.
Review URL: http://codereview.chromium.org/3565013
TBR=jeanluc@google.com
Review URL: http://codereview.chromium.org/3747009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that when they fail they print the values in question.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3828013
TBR=pkasting@chromium.org, jamesr@chromium.org
Review URL: http://codereview.chromium.org/3854004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
fail they print the values in question.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3828013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=59320
TEST=layout
TBR=senorblanco
Review URL: http://codereview.chromium.org/3838007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab_switching_test, and without the changes to tools_sanity_unittest.cc, which have already been relanded separately.
TBR=timsteele
Original changelog message:
Convert LOG(INFO) to VLOG(1) - base/.
Also removes an "else" after "return" and aligns "<<" per style guide.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3850007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=build and ran it.
Review URL: http://codereview.chromium.org/3845004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=webfilewriter_base_unittest.cc
Review URL: http://codereview.chromium.org/3806009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
services' to be grey.
BUG=59283
TEST=visual
Review URL: http://codereview.chromium.org/3835003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
First Run. Make sure the minimum bubble is not showed if there is no default search.
BUG=49306
TEST=Set a managed default search provider. Clear your Chromium user data directory (~/Library/Chromium, ~/.config/chromium, %localappdata%\Chromium) and the "First Run" file found next to the executable. Start Chrome. It should not ask you to choose a default search provider. Disable the default search provider via policy. Make sure the minimal bubble is not shown. Redo these tests for the GOOGLE_CHROME_BUILD to make sure that we still ask about usage stats.
Review URL: http://codereview.chromium.org/3565013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For example, if the test server fails to start, it would crash before these
changes.
BUG=None
TEST=unit_tests -- gtest_filter=TemplateURL* (will run the affected tests).
Review URL: http://codereview.chromium.org/3816008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7492
TEST=run pepper flash (with LSO support) on http://www.bestflashanimationsite.com/tutorials/4/ , check that it properly stores the objects.
Review URL: http://codereview.chromium.org/3800010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=hayato
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3822006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3771009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59644
TEST=Open a page contianing an accelerated plugin bigger than the window; it should clip instead of scaling down.
Review URL: http://codereview.chromium.org/3858004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Data dialog
BUG=49128
TEST=none
Review URL: http://codereview.chromium.org/3807009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=arv@chromium.org
BUG=59235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59642
TEST=win32 tsan bot goes green.
Review URL: http://codereview.chromium.org/3808011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
uninitialized variable. (It's actually guaranteed to be initialized, but the code made that hard for the compiler to infer.)
TEST=built on Linux with GCC 4.3.4
BUG=none
Review URL: http://codereview.chromium.org/3750019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/3817006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
unconditionally.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3838006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we turn on the autocomplete refactoring in WebKit).
The inputElementClicked case is now handled by the PageClickTracker.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3825009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabling preloadinge domui menu page. This is a tentative workaround for test failures that expects certain number of page load in test until we make decision about domui.
TBR=zelidrag@chromium.org
BUG=59421
TEST=MetricsServiceTest.CloseRenderersNormally should cycle green
Review URL: http://codereview.chromium.org/3788007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See bug for more info.
TBR=johnnyg@chromium.org
BUG=59670
TEST=valgrind bot will not report this leak.
Review URL: http://codereview.chromium.org/3822010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I now reset the find observer only when I am in the non-json case.
Since I am not in the JSON case when calling my tests, I am hoping
that the find observer is not initialized and hence does not cause
issues on destructor.
(Committing on behalf of amolk. Originally reviewed and LGTM-ed here: http://codereview.chromium.org/3754007/show)
BUG=58516
TEST=
Review URL: http://codereview.chromium.org/3808010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59659
TEST=Valgrind gets greener
TBR=johnnyg
Review URL: http://codereview.chromium.org/3855005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62986 0039d316-1c4b-4281-b951-d872f2087c98
|