| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Split the arbitrator into a class that handles the threading and a class that handles location provider arbitration. Changed unit tests and MockLocationProvider to work with this new model.
BUG=None
TEST= --gtest_filter=*Geolo*
Review URL: http://codereview.chromium.org/3548008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(This doesn't actually enable any functional changes yet.)
BUG=none
TEST=none (yet)
http://codereview.chromium.org/3454021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3582005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AccessibilityEventRouterGtk::RemoveRootWidget via reference counting,
which stops ExtensionApiTest, FLAKY_Tabs from crashing on chromeos.
BUG=56479
TEST=ExtensionApiTest.FLAKY_Tabs no longer crashes, and added new AccessibilityEventRouterGtkTest.
Review URL: http://codereview.chromium.org/3382025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
squished.
The progress animation was showing up squished vertically to about 10 pixels on linux, and to
fix that we now create bitmaps with the proper colour depth ourselves and draw the animation
frames onto it instead of using the built-in method.
BUG=53598
TEST=manual, test that the speech recognition progress animation shows up as expected and not squished.
Review URL: http://codereview.chromium.org/3576006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/7010 http://crosbug.com/3062
TEST=Manual
Review URL: http://codereview.chromium.org/3610001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These two commits were suppressions for a small leak in DnsRRResolver
which was fixed in 61136.
BUG=57456
TEST=memory waterfall
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3330016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7100
TEST=Boot device. On "Select network" screen click on the network
selection combo box. The networks menu that will appear has the same
width as combo box itself.
Review URL: http://codereview.chromium.org/3586005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
tests on Windows.
TBR=glider
Review URL: http://codereview.chromium.org/3616001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=michaeln
BUG=46601
TEST=ExtensionApiTest.FLAKY_Popup no longer runs
Review URL: http://codereview.chromium.org/3603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3432033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3610002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The operator<< for url_parse::Component needs to be declared
in the same namespace as its parameter type, in this case url_parse.
Otherwise Clang fails to compile this because it is more strict on the Standard.
See http://clang.llvm.org/compatibility.html#dep_lookup for more info.
BUG=none
TEST=unit_tests
Review URL: http://codereview.chromium.org/3575002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: this is a TODO in string_util.h)
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3594002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in chromium os ui_tests) to match the new report stacks.
Added another suppression for bug 49279 (New leak in
ChromeCookieMonsterDelegate)
Suppressed bug 57539 (Memory leak in ExtensionImpl::SetFunctionNames)
BUG=32085,49279,57539
TBR=timurrrr
Review URL: http://codereview.chromium.org/3544005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The operator<< for webkit_glue::FormData needs to be declared
in the same namespace as its parameter type, in this case webkit_glue.
Otherwise Clang fails to compile this because it is more strict on the Standard.
See http://clang.llvm.org/compatibility.html#dep_lookup for more info.
BUG=none
TEST=unit_tests
Review URL: http://codereview.chromium.org/3583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also add Chromium vs Google Chrome clarification at the beginning of the generated policy documentation and remove ADM outputs with pseudo-translations.
BUG=None
TEST=manual
Review URL: http://codereview.chromium.org/3605003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The operator<< for AutocompleteResult::const_iterator needs to be declared
in the same namespace as its parameter type, in this case the global namespace.
Otherwise Clang fails to compile this because it is more strict on the Standard.
See http://clang.llvm.org/compatibility.html#dep_lookup for more info.
BUG=none
TEST=unit_tests
Review URL: http://codereview.chromium.org/3591001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In webkit patch https://bugs.webkit.org/show_bug.cgi?id=46873 I'm renaming the
input element's @webkitspeech attribute to @x-webkit-speech. This chromium CL updates
the relevant test files with both the old and new attribute names so that they
won't break while the webkit change is being submitted.
I'm also adding an extra event handler for 'onwebkitspeechchange'. This event will be added to webkit shortly and I'm including it now to allow webkit rolls to go without issues. The old attribute and event handler will be removed after the webkit changes are rolled into DEPS.
BUG=53598
TEST=browser_tests --gtest_filter=SpeechInputBrowserTest.*
Review URL: http://codereview.chromium.org/3539006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=hclam
Review URL: http://codereview.chromium.org/3552004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3598002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's risky to modify this code, and it needs a serious cleanup.
Meanwhile, we should avoid landing changes that would make this code
even more complicated or difficult to clean up.
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3601003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3524006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change widen the suppression rule for Bug 39965 more to catch up with probably r61120 <http://crrev.com/61120>.
TBR=thesig,timurrrr
BUG=39963
TEST=make the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3539009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57064
TEST=manual
Review URL: http://codereview.chromium.org/3452028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
rest of Chrome. Allows plugins to have different zoom ranges, and also to update zoom on its own.
Review URL: http://codereview.chromium.org/3419023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the indicator up to the OS updater on Chrome OS.
BUG=chromium-os:6526
TEST=Connect to a dev server with a newer version, and check that the display appears.
Review URL: http://codereview.chromium.org/3607001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change updates a suppression rule for Bug 39963 to catch up with probably r61120 <http://crrev.com/61120>.
TBR=thesig,timurrrr
BUG=39963
TEST=make the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3527006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Tested compile with official mode flags
TBR=hbono
Review URL: http://codereview.chromium.org/3528007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It seems AutomationProxyTest.AppModalDialogTest crashes because Singleton<AppModalDialogQueue>()->active_dialog() call in this function returns NULL since r60785. This change just adds a NULL check to avoid this crash.
BUG=25039,57385
TEST=make the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3522007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=6789
TEST=none
Review URL: http://codereview.chromium.org/3521005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to use DeterministicSocketData which should avoid the flaky test
problem that 3432009 introduced.
--
Add a new class SpdyProxyClientSocket which implements ClientSocket
by sending a CONNECT request via a SPDY SYN_STREAM frame to a SPDY proxy,
and then reading/writing data to/from SPDY Data frames.
BUG=29625
TEST=none
Review URL: http://codereview.chromium.org/3578002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also added logging unittests.
BUG=57383
TEST=logging_unittest.cc
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61127
Review URL: http://codereview.chromium.org/3575008
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/3527004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also added logging unittests.
BUG=57383
TEST=logging_unittest.cc
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61127
Review URL: http://codereview.chromium.org/3575008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to a constant 2 seconds.
This used to be settable with a default of 2 seconds, but the flag got rerouted to the action timeout flag in 60764.
Review URL: http://codereview.chromium.org/3516009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
go green.
Disk Cache: Add a quick return path for truncating an empty stream
and make sure that Flush() doesn't fail when it has nothing to do.
BUG=56872, 57395
TEST=none
Review URL: http://codereview.chromium.org/3551005
TBR=rvargas@google.com
Review URL: http://codereview.chromium.org/3543007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
miniview correctly. Refactored to use shared routine that
is used for the other sections.
BUG=54901
TEST=Open a bunch of NTP, then a bunch of tabs to different
sites. Close all the site tabs. NTP should never show clipped
words.
TBR=arv@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Cache hits resulted in a memory leak. RRResolverHandles didn't delete
themselves so, in the event of a cache hit, when a runnable method calling
Post() was used, they would never be deleted.
2) It was possible to delete a lock which was still locked, causing a possible
memory leak, depending on the implementation of pthread mutexes.
BUG=57456
TEST=net_unittests
http://codereview.chromium.org/3531006/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
renable the check against loading the plugins on the UI/IO thread.
Review URL: http://codereview.chromium.org/3569008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=fbarchrd
BUG=57266
TEST=Tree is green. ARM ffmpeg can be loaded.
Review URL: http://codereview.chromium.org/3555004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=morrita
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3611004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The default behaviour of GtkTextView on ctrl+backspace is a little counter
intuitive. If there is selected text and the cursor is on the left edge of
the selection, then instead of removing the selected text, it removes the
word prior to the selection. So in cases where ctrl+backspace is pressed
and text is selected, treat it as a normal backspace.
BUG=18224
TEST=Type in 'goo' in the omnibox. That should autocomplete to 'google.com'.
Pressing ctrl+backspace should remove the suggested 'gle.com'.
Review URL: http://codereview.chromium.org/3446021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=ExtensionTest.IsPrivilegeIncrease
Review URL: http://codereview.chromium.org/3582004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this and I don't feel comfortable leaving it on trunk while
they are ironed out.
The terminology in the code is a bit schizophrenic at the
moment, so for clarity:
open = big icons showing
closed = small icons showing
hidden = no icons showing (button in bottom of tab)
1. If the apps section is hidden and an app is installed, the
apps section comes back weirdly. The content is visible, but
the header is not and the menu along the bottom of the tab
is still there.
2. Sections' open state not persisted. If you click on a
header to make a section open, then refresh, that section is
closed again.
3. If you open the most visited section, then refresh, the
most visited section will look closed. But if you hover in
the empty area in the bottom of the tab, you will get
cursor changes and status bubbles. This is probably related
to 2, above.
These aren't that hard to fix probably, but there are a few
other high priority minor fixes I need to get in for m7,
and I'm afraid of this change conflicting with them for
merges. So I'm pulling this out until one of us has time to
get back to it.
TBR=thakis@chromium.org
BUG=55148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also added logging unittests.
BUG=57383
TEST=logging_unittest.cc
Review URL: http://codereview.chromium.org/3575008
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/3606003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See image here: http://imgur.com/XdxX6
BUG=55148
TEST=Close one or more sections in NTP. Font on collapsed menus
should be the same as section headers.
Review URL: http://codereview.chromium.org/3526009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added logging unittests.
BUG=57383
TEST=logging_unittest.cc
Review URL: http://codereview.chromium.org/3575008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61127 0039d316-1c4b-4281-b951-d872f2087c98
|