| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also did a little cleanup in getPlugins. I found that there was a
WebPluginInfo struct declared within the WebCore namespace that was causing us
to need '::' in front of WebPluginInfo. I killed the erroneous declaration so
that the rest could be cleaned up. I also renamed getPlugins to plugins since
I think that is more consistent with how Apple names these kinds of methods.
There was some old, unused USE(JSC) code in ScriptController.cpp that I deleted.
R=erikkay
Review URL: http://codereview.chromium.org/12601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fixes bug http://code.google.com/p/chromium/issues/detail?id=4582, which is a crash in the renderer process, which occurs when the renderer receives a sync message requesting accessibility information from the browser, while it waits
for the PluginDestroyed sync call to unwind.
The ViewMsg_GetAccessibilityInfo has a timeout associated with it, which indicates that it is ok for the call to fail. We now turn off the unblock flag on the sync message which will ensure that it does not reenter Webkit in this scenario.
R=jcampan
Bug=4582
Review URL: http://codereview.chromium.org/12402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
converter name alias (iso-8859-9 => windows-1254)
TBR=tony
BUG=3863
Review URL: http://codereview.chromium.org/11381
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
revealed slipped by getting added to the SCons build:
net\base\x509_certificate_unittest.cc
chrome\browser\greasemonky_master_unittest.cc
chrome\browser\greasemonky_slave_unittest.cc
chrome\browser\template_url_prepopulate_data_unittest.cc
chrome\renderer\render_widget_unittest.cc
* Sort file lists.
* Move net\*_unittest.cc files that don't have "win" in the
base name to the to_be_ported_files lists for Linux and Mac.
Review URL: http://codereview.chromium.org/11587
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The document wrapper wasn't kept alive in the life time of the frame. This results issue 4532.
I don't how to create a test case yet, but verified that dromaeo test runs fine with this fix.
Review URL: http://codereview.chromium.org/11376
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By reducing the number of include paths that are specified
as $WEBKIT_DIR/port, we reduce the number of paths that get
expanded by the addRepository functions. Instead, we only specify directories from $WEBKIT_DIR/port if we have header files in those directories. The down side is that if we add a header to port, we need to update the include paths.
Also, don't specify WebCore includes with OBJ_ROOT as the fallback repository so we save on -I expansion.
Remove $WEBKIT_PORT_DIR because it's the same as $PORT_DIR.
The change to glue/SConscript is to pick up webkit_version.h since glue is the only place that needs it.
Review URL: http://codereview.chromium.org/11598
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11399
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Properly initialize ResourceLoaderBridge::ResponseInfo content_length. After a long journey, this value is used in WebCore::ProgressTracker::incrementProgress.
Review URL: http://codereview.chromium.org/11394
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are very very close to matching Windows metrics for buttons.
- Sort RenderThemeGtk.h declarations in the same
order as RenderThemeWin.h
- Sort RenderThemeGtk.cpp implementations in the
same order as declared in the header.
- Put all internal static helpers together.
- Merge in some comments and code from RenderThemeWin.
- Drop incorrect button style methods, when really we want
the default behavior instead.
- Use 11px Times New Roman for the layout test mode
system font.
- Switch to Mist as the default layout test theme.
This matches Windows much better, with square
buttons, etc.
- Sort the font list in test_shell_gtk.
Review URL: http://codereview.chromium.org/11390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Remove setButtonPadding, it was a private method that had no callers.
Review URL: http://codereview.chromium.org/11391
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and Linux try to match it.
- Remove trailing whitespace and extra newlines.
- Reorder some declarations in the header to
better group similar methods.
- Drop unimplemented declaration of addIntrinsicMargins.
- Implement the empty RenderThemeWin constructor and
destructor in the header file.
- Reorder all implementations to match declaration order.
- Move the enums into the anonymous namespace.
- Don't indent in an anonymous namespace.
- Move all internal static helpers together.
Review URL: http://codereview.chromium.org/11596
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
just a baby step in getting RenderThemeGtk to be more like RenderThemeWin.
- Remove some cosmetic differences from prototypes.
- Remove the unused systemFont(X, X) from GTK.
- Make supportsFocus have internal linkage, there is no
RenderTheme::supportsFocus. This matches GTK.
Review URL: http://codereview.chromium.org/11591
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
After a recent merge, port/dom no longer exists. The Windows build was updated, but scons was left in a non-building state.
Review URL: http://codereview.chromium.org/11387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11382
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
forwarded to the skia ones.
Review URL: http://codereview.chromium.org/11588
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11380
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=openvcdiff,huanr
Review URL: http://codereview.chromium.org/11810
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on the cairo surface in the canvas's GdkSkiaObjet that matches the canvas's matrix translation. Change rendering of some other widgets (buttons, entry fields, etc) that were being translated manually.
Review URL: http://codereview.chromium.org/11562
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
list (for things to be ported) to the add-to-input file list.
These ended up on the wrong list because we had really confusing
logic down at the bottom of SConscript.port, with multiple lists
and redundant conditional checks. So refactor the bottom to
collect all platform-specific logic behind single checks for
the platform, rearrange and rename lists to (hopefully) make it
easier to identify what goes where, and add comments.
Review URL: http://codereview.chromium.org/11361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11379
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add third_party/purify/pure_api.c to the base\base_lib.scons sources.
* Support specification of CHROME_BUILD_TYPE (and CHROMIUM_BUILD
while we're here) either on the command line or as an
external environment variable.
* Fix syntax error in release_impl_purify.scons (previously unused).
* Add a central $CHROMIUM_CC_OPT_FLAGS variable (included in $CCFLAGS)
that can be used to set explicitly the optimization level without
having to worry about optimization flags being pulled in from other
settings files.
Review URL: http://codereview.chromium.org/11368
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
doing an install and not for uninstall.
BUG=4651
Review URL: http://codereview.chromium.org/11365
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- save password
Review URL: http://codereview.chromium.org/11559
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
crash in ResourceDispatcherHost::OnReadCompleted.
R=eroman
BUG=b/1498134
Review URL: http://codereview.chromium.org/11584
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1497924
Review URL: http://codereview.chromium.org/11369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
deleted.
Review URL: http://codereview.chromium.org/11370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The idea is just crash a little earlier and hopefully
see if we can detect memory corruption as the cause of
the actual bug.
Review URL: http://codereview.chromium.org/11583
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11585
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11375
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In response to an invalidation, we call into WebKit to do layout.
On Windows, WM_PAINT is a virtual message so any extra Invalidates that come
up while it's doing layout are implicitly swallowed as soon as we actually do
drawing via BeginPaint.
Though GTK does know how to collapse multiple paint requests, it won't erase
paint requests from the future when we start drawing. So the solution is to
track whether we're currently handling a redraw, and during that if we get told
by WebKit that a region has become invalid, we still add that region to the
local dirty rect but *don't* enqueue yet another "do a paint" message.
Review URL: http://codereview.chromium.org/11371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
there. This leaves forwarding headers in base/gfx, which I'll clean up in a future pass.
Review URL: http://codereview.chromium.org/11808
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's currently a GCC bug which stops this working for return values which have a destructor. Hopefully this will help someone in the future, with future versions of GCC.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38172
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31742
Review URL: http://codereview.chromium.org/11494
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Code from phajdan.jr@gmail.com.
Review URL: http://codereview.chromium.org/11367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Although you cannot see the blood, sweat and tears on this changelist,
know that they are there.
We still aren't quite perfect, but it's better.
Review URL: http://codereview.chromium.org/11344
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=dglazkov
Review URL: http://codereview.chromium.org/11529
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
header file, we were missing a const.
Review URL: http://codereview.chromium.org/11809
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=4491
Review URL: http://codereview.chromium.org/11202
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
include guards of the moved files, but nothing else.
Review URL: http://codereview.chromium.org/11568
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the memory model here was wrong. This moves to the Cairo way of doing things. (An alternative would be to change NativeImagePtr from a raw pointer to a ref-counting pointer, like the Mac does. This would ape the Mac API, which is perhaps more future-proof, at the cost of needless refcounting complexity [since SkBitmap internally refs its pixel data already].)
BUG=4298
Review URL: http://codereview.chromium.org/11580
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11581
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/11578
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This implements AlertInfoBar and InfoBarContainer. It also makes the crashed plugin/js oom infobars use this new system.
Design Doc: http://dev.chromium.org/developers/design-documents/info-barshttp://crbug.com/4620
Review URL: http://codereview.chromium.org/11318
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5856 0039d316-1c4b-4281-b951-d872f2087c98
|