summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix deadlock when plugin puts an alert and right afterwards the browser ↵jam@chromium.org2009-09-2845-382/+125
| | | | | | | | | | process makes a win32 call that ends up waiting on the plugin. Since the plugin thread is blocked, the Windows message doesn't get dispatched and the browser ui thread deadlocks. The message from the renderer would make the plugin run a nested message loop but it doesn't get run on the browser ui thread since it's blocked. The fix is to set the event that runs nested message loop in the renderer process. BUG=23147 TEST=ui tests already cover nested message loops and plugins. This particular scenario is hard to write a test case for because it's a race condition involving the browser. Review URL: http://codereview.chromium.org/243018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27421 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium side implementations of some FileSystem methods. This is needed to ↵jianli@chromium.org2009-09-285-1/+41
| | | | | | | | | | | complete the WebKit bug fix https://bugs.webkit.org/show_bug.cgi?id=29109. BUG=none TEST=none Review URL: http://codereview.chromium.org/209072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27420 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27407.senorblanco@chromium.org2009-09-281-5/+0
| | | | | | Review URL: http://codereview.chromium.org/249027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27419 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize all member variables in the default constructor.jhawkins@chromium.org2009-09-281-4/+16
| | | | | | | | | CID=1423 BUG=none TEST=none Review URL: http://codereview.chromium.org/249024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27418 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dashboard history management to properly start from a blankojan@chromium.org2009-09-281-17/+14
| | | | | | | slate when converting the hash parameters to the currentState object. Review URL: http://codereview.chromium.org/242038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27417 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27412 it breaks the toolkit views Linux build.jcampan@chromium.org2009-09-2859-250/+188
| | | | | | | TBR=sky Review URL: http://codereview.chromium.org/254005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27416 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit revision 48796:48820levin@chromium.org2009-09-282-1/+7
| | | | | | | | | | | | Add some layout tests for me to investigate (likely just a rebaseline). BUG=None TEST=None TBR=senorblanco@chromium.org Review URL: http://codereview.chromium.org/251018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27415 0039d316-1c4b-4281-b951-d872f2087c98
* Add section about the Ruby script to the packaging page.kathyw@google.com2009-09-282-6/+43
| | | | | | | | TBR=aa Review URL: http://codereview.chromium.org/244025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27414 0039d316-1c4b-4281-b951-d872f2087c98
* Change the way the NonClientView handles forcing the native frame for ↵ben@chromium.org2009-09-2811-64/+82
| | | | | | | | | | | | | popups/app windows. Rather than carrying state in a force_native_frame_ member it uses a virtual method AlwaysUseNativeFrame analogous to AlwaysUseCustomFrame. This makes me a little happier. BUG=none TEST=On a vista capable system, test that when a theme is installed, popups and app frames are rendered with the native frame. Test that constrained windows (e.g. HTTP basic auth) are rendered with the custom frame. Without a theme installed, test that all windows have a native frame except constrained windows. With Vista Basic system setting, verify that all windows have a custom frame, including constrained windows. Review URL: http://codereview.chromium.org/200146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27413 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to ↵jcampan@chromium.org2009-09-2859-188/+250
| | | | | | | | | | | | several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/248010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27412 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize ids_found_ in the constructor.jhawkins@chromium.org2009-09-281-1/+1
| | | | | | | | | CID=4622 BUG=none TEST=none Review URL: http://codereview.chromium.org/242040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27411 0039d316-1c4b-4281-b951-d872f2087c98
* Add some recent reliability crashes to known_crashes.txt.senorblanco@chromium.org2009-09-281-7/+16
| | | | | | | | | BUG=23278,23280,23281 TEST=Reliability bot a shade greener TBR=thestig Review URL: http://codereview.chromium.org/244026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27410 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove two unused member variables.jhawkins@chromium.org2009-09-281-3/+0
| | | | | | | | | CID=6087 BUG=none TEST=none Review URL: http://codereview.chromium.org/242039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27409 0039d316-1c4b-4281-b951-d872f2087c98
* We need to return S_FALSE in our IHttpSecurity::OnSecurityProblem ↵ananta@chromium.org2009-09-281-12/+20
| | | | | | | | | | | | | | | | | implementation for certificate errors to be displayed in IE6. This is because on IE6 the default IBindStatusCallback implementation in MSHTML implements the IWindowForBindingUI interface only thus resulting in the error dialog being displayed. We emulate this by returning S_FALSE in OnSecurityProblem for IE6. This should fix the IE6 issue reported in bug http://b/issue?id=2059540 Bug=2059540 Review URL: http://codereview.chromium.org/220041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27408 0039d316-1c4b-4281-b951-d872f2087c98
* If IE was navigated away to a different page when the ChromeFrame inspector ↵ananta@chromium.org2009-09-281-0/+5
| | | | | | | | | | | | | | | | | window was open it would crash the browser. The fix is to ensure that the inspector window is closed when the ExternalTabContainer window is uninitialized. This fixes bug http://code.google.com/p/chromium/issues/detail?id=22993 Bug=22993 Review URL: http://codereview.chromium.org/249005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27407 0039d316-1c4b-4281-b951-d872f2087c98
* Moving ContextualAction class to common/extensions and in the process ↵finnur@chromium.org2009-09-2819-134/+134
| | | | | | | | | | | | | renaming it ExtensionAction. No code change. BUG=None TEST=Page actions and browser actions should work as before (no change) Review URL: http://codereview.chromium.org/242035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27406 0039d316-1c4b-4281-b951-d872f2087c98
* Implement about:ipc dialog for Mac.jrg@chromium.org2009-09-2827-146/+3218
| | | | | | | | | Convert IPC logging trigger from x-process waitable event to a messages sent to all processes. Review URL: http://codereview.chromium.org/192070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27405 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporated initial WebGL implementation for Chrome, currentlykbr@google.com2009-09-289-0/+29137
| | | | | | | | | | | | | | | | | disabled in the build. Change ENABLE_3D_CANVAS to 1 in src/third_party/WebKit/WebKit/chromium/features.gypi and regenerate project files to compile. Current code is Windows-specific and requires the sandbox to be disabled. Follow-on work will add ports to other platforms and eventually work with the sandbox enabled. This CL follows https://bugs.webkit.org/show_bug.cgi?id=29664 . BUG=http://code.google.com/p/chromium/issues/detail?id=21852 TEST=none (runs preexisting WebGL layout tests; more coming) Review URL: http://codereview.chromium.org/219001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27404 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability for script to resize the menu.sky@chromium.org2009-09-285-120/+132
| | | | | | | | | BUG=23261 TEST=none Review URL: http://codereview.chromium.org/249020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27403 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize all of the member variables in the default constructor.jhawkins@chromium.org2009-09-281-11/+20
| | | | | | | | | CID=1424 BUG=none TEST=none Review URL: http://codereview.chromium.org/245029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27402 0039d316-1c4b-4281-b951-d872f2087c98
* Moving tryserver.bradnelson@google.com2009-09-281-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27401 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27397 - First step towards NaClChrome integration:1. NaCl plugin ↵gregoryd@google.com2009-09-2829-516/+42
| | | | | | | | | | | | | becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Review URL: http://codereview.chromium.org/153002 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/235042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27400 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 219.4 to 219.5laforge@chromium.org2009-09-281-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27399 0039d316-1c4b-4281-b951-d872f2087c98
* Pulls ActiveWindowWatcher into app so that we can use it insky@chromium.org2009-09-2812-137/+164
| | | | | | | | | | | | | views. Converts from using notification server to observer as notification service is chrome only. Also changes the pointer type used by window_gtk to be a left arrow. BUG=none TEST=none Review URL: http://codereview.chromium.org/245016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27398 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-2829-42/+516
| | | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27397 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize profile_ and process_images_ in the constructor.jhawkins@chromium.org2009-09-282-3/+4
| | | | | | | | | CID=3971 BUG=none TEST=none Review URL: http://codereview.chromium.org/219014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27396 0039d316-1c4b-4281-b951-d872f2087c98
* Move cairo font handling from printing to skia to avoid circular dependency.mmoss@chromium.org2009-09-284-146/+150
| | | | | | | | | http://crbug.com/22792 Review URL: http://codereview.chromium.org/245027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27395 0039d316-1c4b-4281-b951-d872f2087c98
* Add columns to gtk task manager.thakis@chromium.org2009-09-281-1/+51
| | | | | | | | | BUG=16221 TEST=Open task man, right-click dialog, enable new columns (image size, script size, css size), surf around. Review URL: http://codereview.chromium.org/245018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27394 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing chrome.i18n.getMessage call, that loads message from the ↵cira@chromium.org2009-09-2824-32/+515
| | | | | | | | | | | | | | | | | | | extension catalog, and if necessary replaces placeholders (up to 9). I have 3 forms of getMessage call: getMessage("name") for simple messages without placeholders. getMessage("name", "one param") for messages with only one placeholder. getMessage("name", ["one", "two"]) for messages with only one or more placeholders. getMessage returns string. BUG=12131 TEST=Load samples/i18n extension (switch Chrome to sr locale) and observe ext. name, description and toolstrip texts should be in Serbian. Review URL: http://codereview.chromium.org/225009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27393 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize message_loop_ in the constructor.jhawkins@chromium.org2009-09-281-1/+2
| | | | | | | | | CID=1505 BUG=none TEST=none Review URL: http://codereview.chromium.org/219036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27392 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in drop arrow. Specifically window properties weresky@chromium.org2009-09-281-3/+3
| | | | | | | | | | | being set after Init, which does no good. BUG=23180 TEST=see bug Review URL: http://codereview.chromium.org/251019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27391 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize message_response_timeout_ in the constructor.jhawkins@chromium.org2009-09-281-0/+1
| | | | | | | | | CID=1504 BUG=none TEST=none Review URL: http://codereview.chromium.org/223028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27390 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27379, in hopes of fixing browser_tests.senorblanco@chromium.org2009-09-2827-106/+122
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27389 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add note to about:memoy re missing renderers.agl@chromium.org2009-09-281-1/+1
| | | | | | | | | | | | | | | | | | On Linux, we cannot gets at the 'maps' nor 'smaps' files for our renderers when they are sandboxed (because they are non-dumpable). One could imaging plumbing IPC calls to the renderers for this information, but it would be a lot of code for little gain. In the mean time we should at least explain why all the renderers might be missing. (This is an issue with the SUID sandbox. The seccomp sandbox would be ok.) BUG=23258 http://codereview.chromium.org/235008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27388 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix take 2.agl@chromium.org2009-09-281-0/+2
| | | | | | | (We don't have try servers for ChromeOS yet.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27385 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "gtk implemenation of Scrollbar."agl@chromium.org2009-09-286-472/+49
| | | | | | | This reverts commit 27381 (build break). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27384 0039d316-1c4b-4281-b951-d872f2087c98
* Make the invisible items in the system menu of a few Indian language ↵jshin@chromium.org2009-09-281-1/+2
| | | | | | | | | | | | | | | | versions of Chrome. |owner_drawn| is currently set if the UI font family or the UI font size is overriden. However, this leads menu items to be invisible in the system menu. This was not the case in Chrome 2.0, but somehow the way 'owner_drawn' menu is drawn has changed and we have this regression. As a work around for the branch (3.0 train left, but we can merge this to 3.0.1), this CL sets |owner_drawn| to false for the system menu even if the UI font or the UI font size is overriden. BUG=18042 (http://crbug.com/18042 ) TEST=Run Chrome with '--lang=hi' command line flag on Windows. Make sure that the translated menu items in the system menu are visible (e.g. 'New Tab', 'Task Manager') although a bit too small to read while the font size in the page/wrench menu is reasonably large. Review URL: http://codereview.chromium.org/200123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27382 0039d316-1c4b-4281-b951-d872f2087c98
* gtk implemenation of Scrollbar.oshima@chromium.org2009-09-286-49/+472
| | | | | | | | | | | enabled ScrollView on linux. BUG=none TEST=none Review URL: http://codereview.chromium.org/222030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27381 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: ChromeOS is using a more recent compiler.agl@chromium.org2009-09-281-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27380 0039d316-1c4b-4281-b951-d872f2087c98
* Assert that thread-safe reference counting is used withdarin@chromium.org2009-09-2827-122/+106
| | | | | | | | | | | | | | | | | | | | | | | | cross-thread NewRunnableMethod. This assertion caught such an error in VisitedLinkMaster! My approach, modify RunnableMethodTraits<T> to assert that when ReleaseCallee happens on a different thread from RetainCallee that the type supports thread-safe reference counting. I do this by adding a static method to both RefCounted<T> and RefCountedThreadSafe<T>. This results in a little ugliness in cases where people implement AddRef and Release by hand (to make the no-ops). There may be a nicer way to deal with those few cases. R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/251012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Sheets should be positioned between the content and everything above it.erg@chromium.org2009-09-281-2/+5
| | | | | | | | BUG=17615 Review URL: http://codereview.chromium.org/219032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27378 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: create the directory for the desktop file in the wrapper script if it ↵mdm@chromium.org2009-09-281-0/+1
| | | | | | | | | | | does not exist. BUG=none TEST=none Review URL: http://codereview.chromium.org/244018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27377 0039d316-1c4b-4281-b951-d872f2087c98
* Remove failing expectations for tests, fixed in ↵dglazkov@chromium.org2009-09-281-4/+0
| | | | | | | | | | | | http://trac.webkit.org/changeset/48759. TBR=abarth TEST=none BUG=17523 Review URL: http://codereview.chromium.org/249019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27376 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove --google-internal-crash-reporting.agl@chromium.org2009-09-287-269/+3
| | | | | | | | | It's time to kill this. It's been marginally useful, but only marginally. http://codereview.chromium.org/222021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27375 0039d316-1c4b-4281-b951-d872f2087c98
* Comment out the condition (b == vmax), since it will always be true at this ↵jhawkins@chromium.org2009-09-281-1/+3
| | | | | | | | | | point in the code. BUG=none TEST=none Review URL: http://codereview.chromium.org/243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27374 0039d316-1c4b-4281-b951-d872f2087c98
* A couple fixes to layout test scripts:jianli@chromium.org2009-09-283-4/+8
| | | | | | | | | | | | | | | | 1) Fix division by zero if running only 1 WONTFIX test. 2) Do not add to the missing list if a test missing the result is marked as WONTFIX. Also update the test_expectation list: 1) Remove SKIP for one test so that we can rebaseline it later. 2) Remove a qt test that was skipped previously because its missing result. BUG=none TEST=non Review URL: http://codereview.chromium.org/246013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27373 0039d316-1c4b-4281-b951-d872f2087c98
* Be defensive against 0-sized custom cursors. This may fix a moderately commoncevans@chromium.org2009-09-282-4/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | browser crash that triggers ~100 times a day: `anonymous namespace'::PureCall() _invalid_parameter_noinfo std::vector<unsigned char,std::allocator<unsigned char> >::operator[](unsigned int) WebCursor::GetCursor(HINSTANCE__ *) RenderWidgetHostViewWin::UpdateCursorIfOverSelf() RenderWidgetHostViewWin::UpdateCursor(WebCursor const &) I was unable to reproduce myself, so I don't know if the bad cursor came from the web or from the Windows "external cursor" concept. Accordingly: - Do not accept 0-sized cursors from the renderer. - Do not access array[0] on an empty array as per other call sites in the cursor code. Thanks to The Mighty Hoppy for triggering this via means unknown! BUG=NONE TEST=NONE (unable to reproduce) Review URL: http://codereview.chromium.org/251008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27372 0039d316-1c4b-4281-b951-d872f2087c98
* Added an accelerator to the HtmlDialogView class so that hitting the ESC key ↵tim@chromium.org2009-09-283-0/+14
| | | | | | | | | | | | | closes the dialog. BUG=19786 TEST=Open Sync Bookmaeks Login dialog. Enter credentials, TAB between fields, etc. to ensure nothing is broken. Hit the ESC key to dismiss the dialog. Patch by Randy Posynick (http://codereview.chromium.org/199069) Review URL: http://codereview.chromium.org/246020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27371 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: Listen for BROWSER_THEME_CHANGED and send updated CSS.erg@google.com2009-09-282-12/+34
| | | | | | | | | | GTK: Listen for BROWSER_THEME_CHANGED and upload proper colors. BUG=23031 Review URL: http://codereview.chromium.org/248006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27368 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up after the initial Chrome Frame commit.robertshield@chromium.org2009-09-288-28/+153
| | | | | | Review URL: http://codereview.chromium.org/242025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27367 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 05:58:23 +0000