summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Remove base/scoped_handle_win.h stub and fix up all callers to use ↵thakis@chromium.org2011-01-0757-269/+245
| | | | | | | | | | the new location and namespace." This reverts r 70795, it broke the build. TBR=vandebo git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70802 0039d316-1c4b-4281-b951-d872f2087c98
* Make glVertexAttribPointer return INVALID_OPERATION for offsetsgman@chromium.org2011-01-072-6/+147
| | | | | | | | | | | and strides that do not match type. TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/5991012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70800 0039d316-1c4b-4281-b951-d872f2087c98
* Start reordering the methods in headers in net/.erg@google.com2011-01-0730-965/+972
| | | | | | | | | | | | This patch also starts reordering some of the cc files to match their headers. More of both cleanups will be done in future patches. BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6085013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70799 0039d316-1c4b-4281-b951-d872f2087c98
* Added Two tests to Passwords.pynirnimesh@chromium.org2011-01-071-0/+27
| | | | | | | | | | | Added back testDisplayAndSavePasswordInfobar. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/4669008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70798 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for builder.avi@chromium.org2011-01-071-4/+4
| | | | | | | | | BUG=9911 TEST=compiles, works Review URL: http://codereview.chromium.org/6133004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70797 0039d316-1c4b-4281-b951-d872f2087c98
* Flags: Enable Tabbed Options by default.jhawkins@chromium.org2011-01-0711-46/+31
| | | | | | | | | BUG=59972 TEST=none Review URL: http://codereview.chromium.org/6177002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70796 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/scoped_handle_win.h stub and fix up all callers to use the new ↵tfarina@chromium.org2011-01-0757-245/+269
| | | | | | | | | | | location and namespace. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6126002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70795 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing omnibox continues search (pyauto) problem on non-mac machinerohitbm@google.com2011-01-071-5/+6
| | | | | | Review URL: http://codereview.chromium.org/6135005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70794 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a plugin crasher which occurs in the context of NPP_Destroy. The ↵ananta@chromium.org2011-01-071-14/+7
| | | | | | | | | | | | | | | | | | | | | plugin invokes NPN_MemFree in this context and we crash while invoking the destructor of the PluginHost as the reference count of the PluginHost object is 0. It is not clear as to why this happens as the PluginHost object is implemented as a singleton with a static scoped_refptr object around to ensure that the ref count is at least 1 until the CRT is around. From the dump it appears that CRT is still valid. In any case we don't need to validate the host pointers in NPN_MemAlloc and NPN_MemFree. Will look further in the code to see if there is any misuse of the PluginHost pointer. BUG=68767 TESt=none Review URL: http://codereview.chromium.org/6134001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70791 0039d316-1c4b-4281-b951-d872f2087c98
* Marking test LoginPromptBrowserTest.IncorrectConfirmation as flaky. See ↵twiz@google.com2011-01-071-1/+2
| | | | | | | | | | | here for evidence: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=LoginPromptBrowserTest.IncorrectConfirmation TEST=None BUG=68860 Review URL: http://codereview.chromium.org/6149002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70788 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Hashes for user actions originating outside Chrome.derat@chromium.org2011-01-072-0/+16
| | | | | | | | | BUG=chromium-os:8,chromium-os:10403 TEST=none Review URL: http://codereview.chromium.org/6050017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70787 0039d316-1c4b-4281-b951-d872f2087c98
* Disable sandboxed plugin for WinXPcpu@chromium.org2011-01-071-0/+1
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6131002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70785 0039d316-1c4b-4281-b951-d872f2087c98
* Re-disable TaskManagerBrowserTest.ReloadExtension for now. asargent@chromium.org2011-01-071-3/+2
| | | | | | | | | | | | | | I got the data I needed from re-enabling it, and have a way to repro and am working on a fix. BUG=42315 TEST=none TBR=twiz Review URL: http://codereview.chromium.org/6106008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70784 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70782 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-0719-103/+55
| | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6100007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-0719-55/+103
| | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70782 0039d316-1c4b-4281-b951-d872f2087c98
* Update stringslaforge@chromium.org2011-01-07205-10525/+27539
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70780 0039d316-1c4b-4281-b951-d872f2087c98
* Use PASS() everywhere in ppapi/tests.neb@chromium.org2011-01-0712-67/+67
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4182010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70779 0039d316-1c4b-4281-b951-d872f2087c98
* PPB_Class simple test.neb@chromium.org2011-01-073-0/+84
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6072003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70778 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the in memory db update rows that have search terms associatedsky@chromium.org2011-01-077-6/+77
| | | | | | | | | | | with them. BUG=none TEST=none Review URL: http://codereview.chromium.org/6135001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70777 0039d316-1c4b-4281-b951-d872f2087c98
* Make the popup blocker on by default. Flip the flag to be a disabling one.rsesek@chromium.org2011-01-074-9/+10
| | | | | | | | | BUG=60090 TEST=On Windows and Mac, when a popup is blocked, there's an animation in the Omnibox. Review URL: http://codereview.chromium.org/6028015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70775 0039d316-1c4b-4281-b951-d872f2087c98
* Start counting at 1 for extension API validation.jochen@chromium.org2011-01-071-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70774 0039d316-1c4b-4281-b951-d872f2087c98
* Make the order of methods in the cc files match the headers in base/.erg@google.com2011-01-078-412/+395
| | | | | | | | | BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6189001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70771 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from l10n_util. Part 8, the last part.avi@chromium.org2011-01-0738-350/+254
| | | | | | | | | BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6156001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70769 0039d316-1c4b-4281-b951-d872f2087c98
* Add a note to tabs.onCreated documentation that the url might not be defined.asargent@chromium.org2011-01-072-2/+2
| | | | | | | | | | | | | | Glen got bit by this during development of an extension, where he was expecting that the tab's url would always be defined right away. (Someone filed crbug.com/52195 about this a while back, but I had marked it as WontFix because there are legitimate reasons why the url isn't always set) BUG=none TEST=none Review URL: http://codereview.chromium.org/6193001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70767 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit 75243:75250jorlow@chromium.org2011-01-071-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/6186001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70766 0039d316-1c4b-4281-b951-d872f2087c98
* Replacing bing.com with search.msn.com (which redirects to bing.com) and ↵rohitbm@google.com2011-01-071-2/+2
| | | | | | | | word 'instant' to 'chrome instant' fix random failures. Review URL: http://codereview.chromium.org/6170002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70765 0039d316-1c4b-4281-b951-d872f2087c98
* Support OVERRIDE for clang.thakis@chromium.org2011-01-071-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6165001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70763 0039d316-1c4b-4281-b951-d872f2087c98
* Roll gtm from 410 to 425.thakis@chromium.org2011-01-071-1/+1
| | | | | | | | | | | Mostly to pick up a clang warning fix in r425. BUG=68713 TEST=clang bot goes green Review URL: http://codereview.chromium.org/6142005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70759 0039d316-1c4b-4281-b951-d872f2087c98
* After I watch running test carefully, I found that history page option ↵rohitbm@google.com2011-01-071-6/+9
| | | | | | | | starts coming into the omnibox, but test count comparison wasn't catching that. So now checking history page option in each waituntil iteration. Review URL: http://codereview.chromium.org/6008012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70758 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor grit -D flags into a gyp variable so we don'ttony@chromium.org2011-01-078-105/+75
| | | | | | | | | | | | have to repeat the logic for it in a bunch of different places. I had to add another level of variables{} so I could use use_titlecase_in_grd_files in a condition. I also removed some quotes around default values since that seems to be the more common way to express boolean values. BUG=68028 Review URL: http://codereview.chromium.org/6070011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70757 0039d316-1c4b-4281-b951-d872f2087c98
* Add a checkbox to the malware interstitial page, for user to opt-in to send ↵panayiotis@google.com2011-01-076-13/+119
| | | | | | | | | | | | | malware report. The user's choice will be stored as preference in user's profile. Landing original change by kewang: http://codereview.chromium.org/5102001/. BUG=60831 TEST=Relevant unit_tests,browser_tests Review URL: http://codereview.chromium.org/6066011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70755 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a crash with some HP printer drivers (when invoking ↵sanjeevr@chromium.org2011-01-074-6/+54
| | | | | | | | | | | | | | | | | | | | | | | | | PTGetPrintCapabilities on them). Detailed story: Calls to XPS APIs typically require the XPS provider to be opened with PTOpenProvider. PTOpenProvider calls CoInitializeEx with COINIT_MULTITHREADED. We have seen certain buggy HP printer driver DLLs that call CoInitializeEx with COINIT_APARTMENTTHREADED in the context of PTGetPrintCapabilities. This call fails but the printer driver calls CoUninitialize anyway. This results in the apartment being torn down too early and the msxml DLL being unloaded which in turn causes code in unidrvui.dll to have a dangling pointer to an XML document which causes a crash. To protect ourselves from such drivers we make sure we always have an extra CoInitialize (calls to CoInitialize/CoUninitialize are refcounted). BUG=None TEST=Test Cloud Print Proxy on Windows with HP Photosmart 7960 series printers. Review URL: http://codereview.chromium.org/6037019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70754 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust dialog size so the control is not truncatedgeorgey@chromium.org2011-01-071-1/+1
| | | | | | | | BUG=66111 TEST=in the bug, no code changes Review URL: http://codereview.chromium.org/6161001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70753 0039d316-1c4b-4281-b951-d872f2087c98
* Make Page Action popup bubble anchor its arrow on the left for RTL languages.finnur@chromium.org2011-01-071-2/+5
| | | | | | | | | | BUG=68030 TEST=See bug Review URL: http://codereview.chromium.org/6119002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70752 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we don't trigger the incompatibility badge if the flag is turned ↵finnur@chromium.org2011-01-072-11/+33
| | | | | | | | | | | | | off when the user navigates to about:conflicts and finds a conflict. Also, record an event when we show the incompatibilities badge to the user so we can find out how often this occurs in the field. BUG=None TEST=None Review URL: http://codereview.chromium.org/6061011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70751 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug 68588" crash occurs if the first run when mode is incognitogeorgey@chromium.org2011-01-071-0/+3
| | | | | | | | BUG=68588 TEST=Should not crash in described circumstances Review URL: http://codereview.chromium.org/6134002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70750 0039d316-1c4b-4281-b951-d872f2087c98
* Start sorting methods in class declarations.erg@google.com2011-01-0746-389/+434
| | | | | | | | | | | | | | | | | | | | | | | | A lot of our headers are a mess and aren't organized. Impose the following order on files in the base/ directory: class Blah { each public/protected/private section: typedefs; enums; static constants; ctors; dtors; methods; overridden virtual methods; data members; }; BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70749 0039d316-1c4b-4281-b951-d872f2087c98
* Fix link errors.ben@chromium.org2011-01-072-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70748 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land of http://codereview.chromium.org/6094009 with Mac build fix.kbr@google.com2011-01-076-104/+164
| | | | | | | | | | | | | | | | | | | | | Perform GPU-related initialization in GPU process in response to an IPC from the browser. Because Chromium's child process host detects that the child has crashed by watching for IPC channel errors, it is imperative that the GPU process's IPC channel be set up before it does any work that might cause it to crash. If initialization fails, the GPU process quits its message loop and cooperatively exits. Fixed a bug in the GpuProcessHost where it would not unblock renderers waiting for GPU process initialization if the GPU process exited. BUG=65369 TEST=ran test case from bug on machine with no GPU hardware and verified that it no longer hangs the renderer, and that the GPU process exits Review URL: http://codereview.chromium.org/6124002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70747 0039d316-1c4b-4281-b951-d872f2087c98
* I'm working on autocomplete edit view which does not use native controls for ↵oshima@chromium.org2011-01-078-100/+212
| | | | | | | | | | | | | | | | | | | Chromeos and Touch UI. The goal of this refactoring is to make it easy to swap AutocompleteEditView implementation between Gtk based impl and Views based one. This is 1st phrase and there will be more refacotring needed to implement AutocompleteEditViewViews. - Added factory method AutocompleteEditViewGtk::Create, which hides initialization details for gtk based impl. - Moved gtk specific accessibilty code to AutocompleteEditViewGtk. - Added TOOLKIT_VIWES only methods to AutocompleteEditView to hide platform specific implementation. (AddToView, CommitInstatntSuggestion/SetInstantSuggestion) BUG=none TEST=none no functional change. all tests should pass. Review URL: http://codereview.chromium.org/6036004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70746 0039d316-1c4b-4281-b951-d872f2087c98
* Fix checkdeps to account for new "ui" toplevel dir.ben@chromium.org2011-01-073-0/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70745 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build with using ui::TestAnimationDelegateben@chromium.org2011-01-071-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70744 0039d316-1c4b-4281-b951-d872f2087c98
* Move animation code to new ui/base/animation directory.ben@chromium.org2011-01-07124-616/+1651
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6154001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70743 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for WebKit 75242:75243. Also remove some now-redundant expectationssenorblanco@chromium.org2011-01-072-4/+1
| | | | | | | | | | | | from downstream test_expectations. BUG=none TEST=layout tests TBR=jorlow Review URL: http://codereview.chromium.org/6163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70742 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where we would allow dragging tabs in incognito windows toosky@chromium.org2011-01-071-2/+2
| | | | | | | | | | | far to the right. BUG=66713 TEST=see bug Review URL: http://codereview.chromium.org/6023014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70741 0039d316-1c4b-4281-b951-d872f2087c98
* Remove auth token generation timing histograms.cbentzel@chromium.org2011-01-072-29/+0
| | | | | | | | | | | These didn't turn out to be terribly useful, and add some complexity to HttpAuthHandler. BUG=NONE TEST=targets build Review URL: http://codereview.chromium.org/6103003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70740 0039d316-1c4b-4281-b951-d872f2087c98
* Makes instant not supress infobars. As part of this I'm removingsky@chromium.org2011-01-071-53/+0
| | | | | | | | | | | unnecessary overrides in instant's TabContentsDelegate implementation. BUG=68540 TEST=see bug Review URL: http://codereview.chromium.org/6152001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70739 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Valgrind: Suppress leak in net::SSLHostInfo::StartDnsLookup."agl@chromium.org2011-01-071-17/+0
| | | | | | | | | | This reverts commit r70714 which was a suppression for a bug fixed in r70737. BUG=68820 TEST=valgrind git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70738 0039d316-1c4b-4281-b951-d872f2087c98
* net: fix leak in SSLHostInfo's DNS request.agl@chromium.org2011-01-071-0/+1
| | | | | | | | | | I'm too used to callbacks which delete themselves and forgot to delete it myself in r70631. BUG=68820 TEST=valgrind git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70737 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit 75216:75242jorlow@chromium.org2011-01-071-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/6110002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70736 0039d316-1c4b-4281-b951-d872f2087c98