summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Support Closure in ALL the loops!ajwong@chromium.org2011-07-2615-126/+444
| | | | | | | | | | | | Add an overload for PostTask into MessageLoopProxy, and WorkerPool. BUG=35223 TEST=unittests. Review URL: http://codereview.chromium.org/7316015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94129 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Refactor sync datatype error handling.zea@chromium.org2011-07-2659-273/+777
| | | | | | | | | | | | | | | | | This introduces SyncError's, which are a convenient way of passing around an error location, type, and message. All datatypes have been refactored to use this, including in the AssociateModels code. A future change will use this to add support for continuing sync even when a datatype fails to start. In addition, eventually a future change will convert the UnrecoverableError handler to use SyncError's as well as have the datatype controller's and datatype manager surface SyncError's to the PSS. BUG=87645 TEST= Review URL: http://codereview.chromium.org/7453014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94128 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to create extension/app for a bookmark-app drop.gbillock@chromium.org2011-07-2614-6/+207
| | | | | | | | | | | R=estade@chromium.org BUG=none TEST=WebAppInfo.Bookmark,ExtensionTest.ExtraFlags,ExtensionPrefsFlags Review URL: http://codereview.chromium.org/7410004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94127 0039d316-1c4b-4281-b951-d872f2087c98
* CrOS - Mark FileManagerDialogTest.SelectFileAndCancel not flaky.jamescook@chromium.org2011-07-261-2/+1
| | | | | | | | | | | Underlying memory issue fixed last week. BUG=none TEST=browser_tests FileManagerDialogTest.* Review URL: http://codereview.chromium.org/7461065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94126 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled flaky nacl_integration test.ncbray@google.com2011-07-261-1/+5
| | | | | | | | | BUG= none TEST= none Review URL: http://codereview.chromium.org/7461083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94123 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Respect natural/inverted scroll direction on Lion when gesturing.rsesek@chromium.org2011-07-266-35/+94
| | | | | | | | | BUG=90342 TEST=With inverted scrolling, swiping left goes forward and swiping right goes backwards. Review URL: http://codereview.chromium.org/7461080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94122 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome://net-internals as broken by typo in 93953.tsepez@chromium.org2011-07-261-1/+1
| | | | | | | | | BUG=90527 TEST=chrome://net-internals shows information. TBR=eroman Review URL: http://codereview.chromium.org/7515001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94121 0039d316-1c4b-4281-b951-d872f2087c98
* Change the UpdateTitle message to use a string16 for the page title.evan@chromium.org2011-07-2611-21/+19
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/7510001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94120 0039d316-1c4b-4281-b951-d872f2087c98
* Expose nat_traversal flag to host and client plugins.sergeyu@chromium.org2011-07-2616-93/+91
| | | | | | | | | BUG=90213 TEST=None Review URL: http://codereview.chromium.org/7471054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94119 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused code. Pointed out in code review by prasadt.tony@chromium.org2011-07-261-4/+1
| | | | | | Review URL: http://codereview.chromium.org/7514011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94118 0039d316-1c4b-4281-b951-d872f2087c98
* Remove explicit keyword from multi-argument (w/o default values) constructorsdilmah@chromium.org2011-07-2692-211/+183
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7477008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94115 0039d316-1c4b-4281-b951-d872f2087c98
* Removing unused NativeButton codesaintlou@chromium.org2011-07-2624-1792/+38
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7493004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94114 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a test to make sure Chrome doesn't crash on startup whensky@chromium.org2011-07-267-23/+47
| | | | | | | | | | | | | configure to open maximized. Also, I'm making OnWidgetMove a little less error prone. BUG=89843 TEST=none R=pkasting@chromium.org Review URL: http://codereview.chromium.org/7489015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94113 0039d316-1c4b-4281-b951-d872f2087c98
* NativeWidgetViews: Add support for window properties.sadrul@chromium.org2011-07-262-8/+22
| | | | | | | | | | | | | | | Also, check view_ for NULL in a few places because these functions can be called when the NWViews is in the process of closing and view_ may have already been unset. This fixes a crash when closing chrome in --views-desktop world. BUG=none TEST=start chrome with --views-dekstop and close, chrome shouldn't crash. Review URL: http://codereview.chromium.org/7480017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94112 0039d316-1c4b-4281-b951-d872f2087c98
* Add a stub content_unittests target so we can point buildbot to it.phajdan.jr@chromium.org2011-07-263-0/+31
| | | | | | | | BUG=90443 Review URL: http://codereview.chromium.org/7467036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94111 0039d316-1c4b-4281-b951-d872f2087c98
* Add OS-Win to list of OSes allowed to see the multi-profiles switch.mirandac@chromium.org2011-07-261-1/+1
| | | | | | | | | BUG=none TEST=multi-profiles switch available on Win again. Review URL: http://codereview.chromium.org/7480012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94110 0039d316-1c4b-4281-b951-d872f2087c98
* Added bmp support to File Manager.serya@chromium.org2011-07-261-1/+2
| | | | | | | | | | BUG=chromium-os:17614 TEST=None Review URL: http://codereview.chromium.org/7514008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94109 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress leaks in gfx::CanvasSkia::SizeStringInt (issue 70327)glider@chromium.org2011-07-261-0/+65
| | | | | | | | | | | | Add another suppression for issue 48130 (leaks in chromeos::input_method) Suppress a leak in ChromeURLDataManagerBackend::AddDataSource (issue 90521) Extend the suppression for issue 82717 (leak in ChromeContentBrowserClient::BrowserRenderProcessHostCreated) BUG=70327,48130,90521,82717 TBR=timurrrr Review URL: http://codereview.chromium.org/7470021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94106 0039d316-1c4b-4281-b951-d872f2087c98
* net: allow SSL secrets to be exported sooner.agl@chromium.org2011-07-266-52/+58
| | | | | | | | | | | | This also addresses some follows up from previous CLs. BUG=none TEST=none Review URL: http://codereview.chromium.org/7493056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94105 0039d316-1c4b-4281-b951-d872f2087c98
* Rewire the metrics pref to the signed settings store on chromeos.pastarmovj@chromium.org2011-07-2611-166/+89
| | | | | | | | | | | | | | It used to check the consent file "Consent To Send Stats" which is insecure and does not respect cloud policies. The file is still used but only to store the install GUID. BUG=chromium-os:15188 TEST=Manually - set the policy on the server and verify that the UI reacts correctly. Also the owner should be able to change it. Review URL: http://codereview.chromium.org/7355019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94104 0039d316-1c4b-4281-b951-d872f2087c98
* Disable chromedriver test testShouldAllowUsersToDismissAnAlertManually on mac.kkania@chromium.org2011-07-261-1/+2
| | | | | | | | | | | It hangs. BUG=90519 TEST=none TBR=hnguyen Review URL: http://codereview.chromium.org/7480015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94101 0039d316-1c4b-4281-b951-d872f2087c98
* 2. Implement scale-to-fit and clipping in DecoderVp8hclam@chromium.org2011-07-2619-432/+635
| | | | | | | | | | | Perform color space conversion and scaling in DecoderVp8 using fast SIMD routines. Also move clipping to DecoderVp8 to save more CPU cycles. BUG=None TEST=None Review URL: http://codereview.chromium.org/7396005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94099 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromedriver to generate control and/or alt key strokes when given a ↵kkania@chromium.org2011-07-2610-34/+226
| | | | | | | | | | | | | character that requires it. Also, print out the version info and accept integers or floats when getting the first client rect. BUG=85239,88565 TEST=none Review URL: http://codereview.chromium.org/7412003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94097 0039d316-1c4b-4281-b951-d872f2087c98
* Support GL_OES_EGL_image_externalbulach@chromium.org2011-07-2623-42/+538
| | | | | | | | | | | | | Add support for GL_OES_EGL_image_external to the cmdbuffer code. Original patch from http://codereview.chromium.org/7458008/ Landing on behalf of Daniel Sievers <sievers@chromium.org> BUG= TEST=new unit_tests Review URL: http://codereview.chromium.org/7480014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94096 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Rename PageInfoModelObserver to Observer.tfarina@chromium.org2011-07-268-27/+30
| | | | | | | | | | | | | | | | | | | | | | | | | It's already a nested class of PageInfoModel class. This avoids a redundancy when inheriting from it: Instead of: class Foo : public PageInfoModel::PageInfoModelObserver { ... }; Now: class Foo : public PageInfoModel::Observer { ... }; This also renames ModelChanged from something less generic as OnPageInfoModelChanged and add virtual and OVERRIDE annotations where necessary. BUG=None TEST=None R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7493048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94095 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup of unit tests for spdy_session_ool.rtenneti@chromium.org2011-07-263-36/+39
| | | | | | | | | | | | Fixed the comments from Wan-Teh in CL http://codereview.chromium.org/7349023/ BUG=89094 R=wtc TEST=net unit tests. Review URL: http://codereview.chromium.org/7471056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94094 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Fixed the size of take photo dialogavayvod@chromium.org2011-07-262-13/+3
| | | | | | | | | | R=nkostylev@chromium.org BUG=chromium-os:18204 TEST=Go through OOBE until image screen, click on photo button, verify that the dialog shown is of the correct size. Review URL: http://codereview.chromium.org/7514007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94093 0039d316-1c4b-4281-b951-d872f2087c98
* views: Have the non-const version of child_at call the constant one.tfarina@chromium.org2011-07-261-3/+6
| | | | | | | | | | | BUG=72040 TEST=views_unittests, views_examples, views_desktop R=sky@chromium.org Review URL: http://codereview.chromium.org/7471048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94092 0039d316-1c4b-4281-b951-d872f2087c98
* net: add crypto.is and simon.butcher.name to HSTS preloaded list.agl@chromium.org2011-07-262-0/+16
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94091 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ExtensionCrashRecoveryTest.TwoExtensionsIgnoreFirst as flaky on Mac.willchan@chromium.org2011-07-261-3/+3
| | | | | | | | | BUG=89078 TEST=none Review URL: http://codereview.chromium.org/7470017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94090 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chrome.test.checkDeepEq to cope with null objectsjochen@chromium.org2011-07-265-0/+47
| | | | | | | | | | BUG=none TEST=I've put an api test in your api tests, so you can test your api while testing your api Review URL: http://codereview.chromium.org/7514004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94089 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Make Authenticator instance scoped_refptr again, fix crash.nkostylev@chromium.org2011-07-261-7/+13
| | | | | | | | | | | Other users of the Authenticator instance store it in scoped_refptr (LoginPerformer, ScreenLocker). BUG=chromium-os:18200 TEST=Signed in, observed no crash. Review URL: http://codereview.chromium.org/7461076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94088 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2011-07-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94087 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Roll 91698:91747.hans@chromium.org2011-07-261-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=enne Review URL: http://codereview.chromium.org/7461074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94086 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the suppression for leaks in NPAPIClient (issue 84223) to match the ↵glider@chromium.org2011-07-261-1/+41
| | | | | | | | | | | | CrOS reports Suppress the leaks in ResourceDispatcherHost callbacks (issue 90496) TBR=timurrrr BUG=84223,90496 Review URL: http://codereview.chromium.org/7461078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94085 0039d316-1c4b-4281-b951-d872f2087c98
* Add webNavigation.getFrame to retrieve information about frame IDsjochen@chromium.org2011-07-2612-30/+648
| | | | | | | | | | BUG=none TEST=browser and unit tests Review URL: http://codereview.chromium.org/7495027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94084 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2011-07-261-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94083 0039d316-1c4b-4281-b951-d872f2087c98
* Roll skia to 1951bsalomon@google.com2011-07-263-1/+23
| | | | | | Review URL: http://codereview.chromium.org/7504002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94082 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed slider thumb in the mediaplayer progress.serya@chromium.org2011-07-261-1/+1
| | | | | | | | | | | | Now "-webkit-appearance: sliderthumb-*" is used for a shadow element in input-range. The input-range element itself implicitly has "-webkit-appearance: slider-*" style that causes it to be rendered as a slider bar. Changing its style makes it transparent (we have separate DIV to show it in a special way. BUG=chromium-os:17030 TEST=Check that media player progress looks and behaves properly. Thumb is graggable, click the bar puts the thumb there. Review URL: http://codereview.chromium.org/7488055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94081 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 94049 (breaks tests) - WebUI TaskManager: make it default on Chrome OSwillchan@chromium.org2011-07-263-14/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | ===== Broke TaskManagerBrowserTest.ShutdownWhileOpen for Linux Views, see: http://build.chromium.org/p/chromium/builders/Linux%20Tests%20(Views%20dbg)(2)/builds/3396 http://build.chromium.org/p/chromium/builders/Linux%20Tests%20(Views%20dbg)(2)/builds/3400 http://build.chromium.org/p/chromium/builders/Linux%20Tests%20(Views%20dbg)(2)/builds/3406 ===== Got the approval from Linus to ship this on Chrome OS in M14 (cf. Comment 20 on http://crbug.com/69222) And makes some tests disabled since they are currently failing on WebUI TaskManager. BUG=chromium-os:13885 TEST=manual on chromeos-chrome in linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93908 Review URL: http://codereview.chromium.org/7465026 TBR=yoshiki@chromium.org Review URL: http://codereview.chromium.org/7461077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94080 0039d316-1c4b-4281-b951-d872f2087c98
* Unify the version string to be displayed on "About Chromium" dialog. (2.5/6)haraken@google.com2011-07-261-15/+15
| | | | | | | | | | | | | | | | | | | | | - This patch just changes the width of "About Chromium" dialog to 530px. FYI: We decided to split the changes of issue 7104106 (http://codereview.chromium.org/7104106/) into the following steps. This is the extra fix for the second step of them: (1) Add CreateVersionString() to chrome_version_info.*, update the GTK+ code to use it. (reviewer: erg, tony) (2) Update the mac code to use CreateVersionString(). Update About.xib. (reviewer: mark) (3) Update the views code to use CreateVersionString(). This can happen at the same time as (2). (reviewer: davemoore, tony) (4) Update version.bat to use lastchange.py. (reviewer: evan) (5) Update tweak_info_plist to use lastchange.py. This can happen at the same time as (4). (reviewer: mark) (6) Make changes to lastchange.py and webkit_version.py. (reviewer: evan, mark) BUG=37186 TEST=Observe that the "About Chromium" dialog on Mac has a reasonable width for showing the version string in one line. Review URL: http://codereview.chromium.org/7461067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94079 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 94059 (test still breaks) - Enable ↵willchan@chromium.org2011-07-261-1/+2
| | | | | | | | | | | | | | | | WorkerDevToolsSanityTest.InspectSharedWorker Now that http://trac.webkit.org/changeset/91661 is rolled, the test should pass. BUG=89845 TEST=WorkerDevToolsSanityTest.InspectSharedWorker Review URL: http://codereview.chromium.org/7480006 TBR=yurys@chromium.org Review URL: http://codereview.chromium.org/7514006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94078 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 94073 (broke a ton of tests) - Introduce a field trial for Instant.willchan@chromium.org2011-07-2616-199/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a field trial for Instant, opting in 10% of undecided users into the experiment. "Undecided" means that users who have played with the Instant checkbox (in Preferences -> Basics) will be excluded from the field trial. When Instant is turned on in this manner, it's restricted to search (i.e., other non-search URLs are not previewed). If the user is selected into the experiment, the checkbox state in preferences will accurately reflect that Instant is on, even if the user didn't enable it explicitly. Although the experiment enables the "Restrict Instant to Search" functionality, it's not reflected in about:flags. I consider this deficiency to be minor, since (i) most users won't check about:flags anyway, and (ii) about:flags is already inconsistent in other ways (for example, it also doesn't show if you added --restrict-instant-to-search manually). Similarly for --preload-instant-search, which preloads the default search engine's homepage when the omnibox gets keyboard focus. We respect group policy. If prefs::kInstantEnabled is a managed pref, the field trial will not affect the user. We store the actual random number generated for the user in a pref so that the same user gets the same experience across browser restarts (i.e., one-time randomization). This also allows us to change (through a Chrome update) the percentages allocated to different groups and thus allocate users to groups differently. If we only stored the final determination of the user's group in the pref, changing the group percentages would have no effect. The code doesn't use base::FieldTrial, because this experiment needs one-time randomization, and base::FieldTrial only supports it if the user has opted-in to UMA (see http://codereview.chromium.org/7360001/ for some context). There is no explicit expiry date for this experiment. The experiment can be disabled by updating the field trial percentages in instant_field_trial.cc and shipping an update to Chrome (not much different from how base::FieldTrial also requires new builds to expire experiments). BUG=none TEST=Delete profile and restart Chrome enough times to see that Instant is ON by default about 10% of the time; fiddling with the preferences checkbox gives expected results. Review URL: http://codereview.chromium.org/7337007 TBR=sreeram@chromium.org Review URL: http://codereview.chromium.org/7461075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94077 0039d316-1c4b-4281-b951-d872f2087c98
* Add additional check for required passphrase in SetupSyncrsimha@chromium.org2011-07-262-1/+8
| | | | | | | | | | | | | | | | | | | | | | The sync integration tests use a method called SetupSync to initialize a sync client. The step that performs an initial sync can sometimes remain incomplete due to a required passphrase. r93873 relocated the check for SET_PASSPHRASE_FAILED in SetupSync. It turns out that this check needs to be made before and after initial sync, since SET_PASSPHRASE_FAILED can be triggered in a couple of places. This patch adds a check at the original place, and should fix the flaky test SetPassphraseAndThenSetupSync. TBR=zea@chromium.org BUG=90371, 90397 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/7477006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94076 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2011-07-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94075 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 3.5.0ricow@chromium.org2011-07-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7488052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94074 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce a field trial for Instant.sreeram@chromium.org2011-07-2616-14/+199
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a field trial for Instant, opting in 10% of undecided users into the experiment. "Undecided" means that users who have played with the Instant checkbox (in Preferences -> Basics) will be excluded from the field trial. When Instant is turned on in this manner, it's restricted to search (i.e., other non-search URLs are not previewed). If the user is selected into the experiment, the checkbox state in preferences will accurately reflect that Instant is on, even if the user didn't enable it explicitly. Although the experiment enables the "Restrict Instant to Search" functionality, it's not reflected in about:flags. I consider this deficiency to be minor, since (i) most users won't check about:flags anyway, and (ii) about:flags is already inconsistent in other ways (for example, it also doesn't show if you added --restrict-instant-to-search manually). Similarly for --preload-instant-search, which preloads the default search engine's homepage when the omnibox gets keyboard focus. We respect group policy. If prefs::kInstantEnabled is a managed pref, the field trial will not affect the user. We store the actual random number generated for the user in a pref so that the same user gets the same experience across browser restarts (i.e., one-time randomization). This also allows us to change (through a Chrome update) the percentages allocated to different groups and thus allocate users to groups differently. If we only stored the final determination of the user's group in the pref, changing the group percentages would have no effect. The code doesn't use base::FieldTrial, because this experiment needs one-time randomization, and base::FieldTrial only supports it if the user has opted-in to UMA (see http://codereview.chromium.org/7360001/ for some context). There is no explicit expiry date for this experiment. The experiment can be disabled by updating the field trial percentages in instant_field_trial.cc and shipping an update to Chrome (not much different from how base::FieldTrial also requires new builds to expire experiments). BUG=none TEST=Delete profile and restart Chrome enough times to see that Instant is ON by default about 10% of the time; fiddling with the preferences checkbox gives expected results. Review URL: http://codereview.chromium.org/7337007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94073 0039d316-1c4b-4281-b951-d872f2087c98
* Remove frameId, tabId and type from webRequest.onBeforeRedirectbattre@chromium.org2011-07-265-244/+6
| | | | | | | | | | | | Discussions with Yuzhu Shen showed that frameId, tabId and type are not needed in webRequest.onBeforeRedirect to track the URL of all frames. This CL removes them and updates the documentation accordingly. BUG=60101 TEST=no Review URL: http://codereview.chromium.org/7484066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94070 0039d316-1c4b-4281-b951-d872f2087c98
* Updating extension to support change to `webNavigation`'s `onBeforeRetarget`.mkwst@chromium.org2011-07-263-13/+22
| | | | | | | | | | | See http://codereview.chromium.org/7343014 for the change in question. BUG=90383 TEST= Review URL: http://codereview.chromium.org/7465034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94069 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress a leak in URLFetcher::Core::StartURLRequestWhenAppropriate (issue ↵glider@chromium.org2011-07-261-1/+34
| | | | | | | | | | | | | 80663) Suppress a use-after-free in NativeWidgetView::set_delete_native_widget (issue 90484) Suppress a leak in QuotaManager::RegisterClient (issue 90487) BUG=80663,90484,90487 TBR=timurrrr Review URL: http://codereview.chromium.org/7480008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94068 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 18:29:51 +0000