summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix another race condition on worker process shutdown that results in ↵jam@chromium.org2009-10-1010-35/+34
| | | | | | | | | | use-after-free. Like 23018, this is happening because valgrind is slowing the worker thread shutdown enough that the backup terminate process code executes. BUG=24346 TEST=covered by valgrind Review URL: http://codereview.chromium.org/266036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28646 0039d316-1c4b-4281-b951-d872f2087c98
* Render sync code inactive without any way to enable.tim@chromium.org2009-10-103-20/+0
| | | | | | | | | | | | **** I WILL REVERT THIS PATCH IMMEDIATELY. It is a kill switch that may need to be merged in later. *** Patching this CL is a quick shut-off mechanism in the event sync needs to de disabled prior to a release build. TEST=No sync UI visible. about:sync shows 'SYNC_DISABLED', no 'Sync Data' folder created when run. Review URL: http://codereview.chromium.org/270049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28645 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline some layout tests after roll to r49405hclam@chromium.org2009-10-1019-6/+322
| | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/261054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28644 0039d316-1c4b-4281-b951-d872f2087c98
* Fix double page generation bug. Now that we use onhashchange,ojan@chromium.org2009-10-102-4/+2
| | | | | | | there's no need to call handleLocationChange manually. Review URL: http://codereview.chromium.org/267044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28643 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pthreads from build and installer files.tim@chromium.org2009-10-1013-1235/+1
| | | | | | | | | | | We can yank it from deps/ following this. BUG=19895 TEST=sync_unit_tests Review URL: http://codereview.chromium.org/261042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28642 0039d316-1c4b-4281-b951-d872f2087c98
* Mark all the tests that take >3 seconds to run as SLOW.ojan@chromium.org2009-10-101-47/+130
| | | | | | | | | After this, I think we can reduce the layout test timeout to something like 5 seconds. This should greatly improve cycle time. Review URL: http://codereview.chromium.org/270022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28639 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to pull in new version of OpenVCDIFFjar@chromium.org2009-10-101-1/+1
| | | | | | | r=openvcdiff@gmail.com Review URL: http://codereview.chromium.org/269036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28638 0039d316-1c4b-4281-b951-d872f2087c98
* Fix one more size_t/uint32 casting issue for the mac.mbelshe@chromium.org2009-10-102-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/269040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28637 0039d316-1c4b-4281-b951-d872f2087c98
* posix: avoid using printf when we're not sure of the types involvedevan@chromium.org2009-10-091-8/+12
| | | | | | | | | It was totally bogus to pass char* to StringPrintf("%ls", ...). I hate this code so much. Review URL: http://codereview.chromium.org/271040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28634 0039d316-1c4b-4281-b951-d872f2087c98
* Expeecting several layout tests to fail after webkit rollhclam@chromium.org2009-10-091-1/+7
| | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/261052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28633 0039d316-1c4b-4281-b951-d872f2087c98
* Add logging macros that automatically append the last system error in string ↵tschmelcher@chromium.org2009-10-095-8/+407
| | | | | | | | | | | | | form. Also add thread-safe, portable variants for strerror() and strerror_r() on POSIX so that existing error logging code that calls strerror() for something other than LOG, LOG_IF, or CHECK can be changed to use safe versions too. After this CL I will eliminate all unsafe uses of strerror() in our code. TEST=Linux: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build with both the default strerror_r implementation (GNU) and the other one (POSIX) via some throw-away macro evilness, and also tested the default strerror_r again on an opt build to verify DPLOG is a no-op; Windows: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build; also tested LOG_GETLASTERROR_MODULE with winhttp and ERROR_WINHTTP_CANNOT_CONNECT and verified that it prints the correct system message and that it doesn't with PLOG; also tested LOG_GETLASTERROR_MODULE with a bogus module name and verified that it prints an error that it can't find the module, and the original error; Mac: none (implicitly tested via the Linux POSIX tests); trybots for Win, Mac, and Linux 32-bit; built locally for Linux 32-bit and 64-bit and tested base_unittests and also running Chromium itself; wrote the upcoming CL that switches strerror() calls to use PLOG and verified that it builds and works for both Linux 32-bit and Linux 64-bit; lint BUG=none Review URL: http://codereview.chromium.org/265052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28632 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a naming collision in thread.h on a crit section that can cause a deadlockzork@google.com2009-10-092-5/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/264026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28631 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS to r49405hclam@chromium.org2009-10-091-1/+1
| | | | | | | | TBR=dglazkov Review URL: http://codereview.chromium.org/266046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28630 0039d316-1c4b-4281-b951-d872f2087c98
* The textfield's text was not updated when text is updated by input.oshima@chromium.org2009-10-092-4/+29
| | | | | | | | | BUG=None TEST=view_examples now has button to show & update textfield's text. Review URL: http://codereview.chromium.org/267040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28629 0039d316-1c4b-4281-b951-d872f2087c98
* Browser actions: limit minimum size of omnibox. When decreasing the width of ↵sidchat@chromium.org2009-10-093-1/+51
| | | | | | | | | | the omnibox, the Browser actions start falling off one by one till there are two left. After that, the omnibox itself starts shrinking, as it normally does. Note that if there is only one browser action, then it remains sticky to the toolbar. BUG=23962 TEST=none Review URL: http://codereview.chromium.org/262008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28628 0039d316-1c4b-4281-b951-d872f2087c98
* Add EV certificate text to the Mac location barhawk@chromium.org2009-10-095-17/+132
| | | | | | | | BUG=10910 TEST=EV sites (e.g., http://www.paypal.com and most bank sites) get a green text description next to the lock icon in the location bar, non-EV (and non-SSL) sites do not Review URL: http://codereview.chromium.org/216031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28627 0039d316-1c4b-4281-b951-d872f2087c98
* Force linux_symbols target to run when building all (even though nothingmmoss@chromium.org2009-10-091-1/+2
| | | | | | | | | depends on it). Review URL: http://codereview.chromium.org/270053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28626 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory_test's temporary user data directory path, the base namesgk@chromium.org2009-10-091-5/+8
| | | | | | | | | of which is copied into the containing temporary directory. BUG=none TEST=Useful mem test stats in the perf graph. Review URL: http://codereview.chromium.org/266047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28625 0039d316-1c4b-4281-b951-d872f2087c98
* test conversion from toolstrips to actionserikkay@chromium.org2009-10-097-10/+271
| | | | | | Review URL: http://codereview.chromium.org/264019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28624 0039d316-1c4b-4281-b951-d872f2087c98
* Make our Mock Sockets capable of running full duplex.mbelshe@google.com2009-10-092-18/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/273013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28622 0039d316-1c4b-4281-b951-d872f2087c98
* Change text for extension download UI.sidchat@chromium.org2009-10-094-12/+25
| | | | | | | | BUG=23105 TEST=none Review URL: http://codereview.chromium.org/261026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28621 0039d316-1c4b-4281-b951-d872f2087c98
* Fix use-after-free in the worker process. The object was shutting down the ↵jam@chromium.org2009-10-093-23/+14
| | | | | | | | | | process so it was a race condition that the process was still running when the task executed. BUG=23018 TEST=covered by valgrind on mac Review URL: http://codereview.chromium.org/267035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28620 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix early font free during printing.estade@chromium.org2009-10-094-50/+61
| | | | | | | | | | The ownership model for this stuff (fonts, cairo canvas, etc.) is a bit brittle. Don't know how to improve it though. BUG=23372 Review URL: http://codereview.chromium.org/270048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28619 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: use NtpBackgroundUtil to draw detached bookmark bar.estade@chromium.org2009-10-093-172/+21
| | | | | | | | BUG=23836 Review URL: http://codereview.chromium.org/268027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28618 0039d316-1c4b-4281-b951-d872f2087c98
* A couple fixes for network cros librarychocobo@google.com2009-10-092-57/+42
| | | | | | | | | | - no need to send updates after connecting to wifi. the cros api will handle this. - clear state before parsing ServiceStatus in case the network no longer exists. BUG=23923 TEST=none Review URL: http://codereview.chromium.org/271038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28617 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebKit::WebVector instead of std::vector in WebKit::WebMediaPlayerhclam@chromium.org2009-10-093-8/+9
| | | | | | | | Get rid of the use of std::vector. Review URL: http://codereview.chromium.org/259053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28616 0039d316-1c4b-4281-b951-d872f2087c98
* media_bench use djb2 hash from media/basefbarchard@chromium.org2009-10-091-13/+1
| | | | | | Review URL: http://codereview.chromium.org/271034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28615 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies the layout test formatter to not have any dependencies on ↵gwilson@google.com2009-10-092-8/+69
| | | | | | | | | | | | | | chromium_utils. This should allow it to run on Mac successfully. Also adds some methods to path_utils that only existed in src-buildbot/chromium_utils. These did not exist anywhere else under webkit/tools/. R=ojan BUG=none TEST=run "test_output_formatter.sh -v -i" on Mac, it should not fail. Review URL: http://codereview.chromium.org/271035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28614 0039d316-1c4b-4281-b951-d872f2087c98
* Several theming fixes for the Mac. Sorry for the extensive change, but theythakis@chromium.org2009-10-0927-346/+839
| | | | | | | | | | | | | | | | | | were all sort of intertwined. Fixes up patterns in general so that they are all in phase. Moves the window widget buttons down by two pixels. Draws overlays correctly. Fixes up some accessibility issues with the default window widgets. Gets rid of some out of date files (tab_cell). BUG=18438, 18547, 19851, 20295, 22213, 23651, 24338 TEST=Launch Chrome. Switch to "dots" theme from the Google themes. Create a couple of tabs. Check to make sure that the background pattern line up with the tabs. Move the tabs around. Check that the hightlight colors and text colors look correct for all of the tabs. Make sure the patterns stay lined up. Resize the window, make sure none of the patterns move around. Create new windows by dragging the tabs out of the windows and make sure a new window is created with the correct pattern. Show the "find" bar. Make sure its pattern lines up correctly with the tabbar. Switch to default theme. Make sure it looks correct and draws properly. Switch to Zen theme and make sure that the overlay at the top draws correctly. Create a new window. make sure that the rollovers in the window widgets work correctly in both the active and inactive window. Mouse down on the zoom button in the inactive window and notice that the window context changes. Move off of the zoom button and mouse up. Mouse down on the miniaturize button on the inactive window and notice that the window context does not change. Move off of the miniaturize button and mouse up. Do the same thing you did for the miniaturize button for the close button. Start up Accessibility Inspector from the developer tools. Make sure that the window widgets report their accessibility information correctly. Review URL: http://codereview.chromium.org/260009 Patch from dmaclach@chromium.org. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28613 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline image for LayoutTests\editing\execCommand\paste-1.html for Windows.jparent@chromium.org2009-10-093-6/+2
| | | | | | | | | | | | It started failing with Skia deps roll (r28109), looks like it was just missed in rebaselining. Also updated expectations for this test to match reality (win and mac debug are flaky, linux is fine). TEST=none BUG=none Review URL: http://codereview.chromium.org/272003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28612 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes (again) the rendering problem we have with zero-heightgspencer@google.com2009-10-091-0/+5
| | | | | | | | | | | | | window resizes from Firefox. It puts back the explicit window resize, but doesn't do it if the window is zero width or height. This seems to fix the problem without causing resize problems in the beach demo. TESTED=ran beach demo, 2d, and render-mode examples, in separate tabs and checked to make sure that background tabs didn't draw over foreground tabs (all in Firefox). Review URL: http://codereview.chromium.org/267041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28610 0039d316-1c4b-4281-b951-d872f2087c98
* This rolls back V8 to the version we had previously.gspencer@google.com2009-10-091-1/+1
| | | | | | | | | | | I had originally rolled this forward to match what Chrome was using (r3030 of v8), but using that version of v8 stops us from rendering for some reason. I'm rolling this back so we can render again, but we'll have to figure out what broke our rendering before we can roll v8 forward. Review URL: http://codereview.chromium.org/271039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28608 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 28599.darin@chromium.org2009-10-095-98/+113
| | | | | | Review URL: http://codereview.chromium.org/272017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28607 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling a interactive testjcampan@chromium.org2009-10-091-1/+2
| | | | | | | | | | | | | Disabling the last browser focus interactive UI tests. It mysteriously crashing, as with the rest of them that were disabled yesterday (this one was left out, probably unintentionaly). BUG=http://crbug.com/24400 TBR=estade Review URL: http://codereview.chromium.org/272016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28606 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome frame to watchlistamit@chromium.org2009-10-091-0/+4
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/273005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28605 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in IEExec of SBCMDID_MIXEDZONE for setting URL zoneamit@chromium.org2009-10-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | IEExec(&CGID_Explorer, SBCMDID_MIXEDZONE, 0, NULL, NULL) in ChromeActiveDocument::ActiveXDocActivate caused IEFrame to send an invalid SB_SETTIPTEXTW to comctrl32 resulting in a crash. Long story short, this happens due to IEFrame calling back exec on us (for cmdid 41) and us returning S_FALSE. IEFrame treats that as a success (can't really blame it here :) and gets its internal logic mixed up. The fix is to always return OLECMDERR_E_NOTSUPPORTED from our Exec handler if we don't support that command. BUG=24115 TEST=none Review URL: http://codereview.chromium.org/265055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28604 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix some omnibox breakage for small windows.shess@chromium.org2009-10-093-10/+149
| | | | | | | | | | | | Change the code to decorate the contents string normally, then elide the marked-up string if it doesn't fit. http://crbug.com/23279 TEST=See bug. Review URL: http://codereview.chromium.org/264012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28603 0039d316-1c4b-4281-b951-d872f2087c98
* Update DEPS file to NaCl @842.bsy@google.com2009-10-091-1/+1
| | | | | | | | | | | | | | | trybots succeeded at Builds 2353, 2390, and 2524. x64 chrome build tested manually. BUG=none TEST=none Review URL: http://codereview.chromium.org/270050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28602 0039d316-1c4b-4281-b951-d872f2087c98
* Improve error messages when a manifest is not readable or not valid JSON.aa@chromium.org2009-10-097-5/+67
| | | | | | Review URL: http://codereview.chromium.org/251003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28601 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the problem that files cannot be dropped on the input widget on the Mac.jianli@chromium.org2009-10-091-1/+16
| | | | | | | | | BUG=19529 TEST=none Review URL: http://codereview.chromium.org/270026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28600 0039d316-1c4b-4281-b951-d872f2087c98
* Convert types in WebFrameLoaderClientImpl in preparation for movingdarin@chromium.org2009-10-095-113/+98
| | | | | | | | | | | | | | this class into the WebKit API implementation. This is a redo of r28545, which was reverted in r28552. TBR=dglazkov BUG=10034 TEST=none Review URL: http://codereview.chromium.org/261047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28599 0039d316-1c4b-4281-b951-d872f2087c98
* Fix layout test after WebKit roll to r49372hclam@chromium.org2009-10-091-0/+3
| | | | | | | | | | | | BUG=24454 TBR=dglazkov Fixing: LayoutTests/http/tests/globalhistory/history-delegate-basic-visited-links.html Review URL: http://codereview.chromium.org/270051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28598 0039d316-1c4b-4281-b951-d872f2087c98
* Fix spacing that was supposed to go in a previous checkin and somehow pkasting@chromium.org2009-10-091-1/+1
| | | | | | | missed it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28597 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove deprecated AbsolutePath function."evan@chromium.org2009-10-093-8/+14
| | | | | | This reverts commit r28593. Random guess at build breakage. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28596 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Rename ThemePreviewInfobarDelegate toaa@chromium.org2009-10-098-66/+66
| | | | | | | | | | ThemeInstalledInfoBarDelegate Contributed by Thiago Farina <tfarina@gmail.com> TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28595 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent threads from running in libjingle after their object has been deleted.zork@google.com2009-10-092-0/+14
| | | | | | | | BUG=23251 TEST=none Review URL: http://codereview.chromium.org/261043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28594 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated AbsolutePath function.evan@chromium.org2009-10-093-14/+8
| | | | | | Review URL: http://codereview.chromium.org/271037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28593 0039d316-1c4b-4281-b951-d872f2087c98
* linux/mac: use "First Run", not "First Run Dev"evan@chromium.org2009-10-091-8/+7
| | | | | | | | | | | | This should've been done back when we finished the First Run dialogs, but better late than never. BUG=24397 TEST=Run Chrome on an old profile; you should not get a first run dialog if you've already clicked through and your user data dir should now contain a "First Run" file and no "First Run Dev" file. Run Chrome on a new profile; First Run should still work as before. Review URL: http://codereview.chromium.org/273009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28592 0039d316-1c4b-4281-b951-d872f2087c98
* Add a FilePath version of the CommandLine constructor. Mark the wstring ↵thestig@chromium.org2009-10-092-2/+20
| | | | | | | | | | version as deprecated. BUG=none TEST=none Review URL: http://codereview.chromium.org/271031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28590 0039d316-1c4b-4281-b951-d872f2087c98
* Build 64-bit RPMs.thestig@chromium.org2009-10-091-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/266024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28589 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 08:48:38 +0000