summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Rename AutofillManager to FormFieldHistoryManager to better reflect the ↵jhawkins@chromium.org2009-10-217-13/+212
| | | | | | | | | | purpose of the class. BUG=none TEST=none Review URL: http://codereview.chromium.org/292050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29717 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings by reference.jhawkins@chromium.org2009-10-212-4/+4
| | | | | | | | | CID=2635 BUG=none TEST=none Review URL: http://codereview.chromium.org/293058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29716 0039d316-1c4b-4281-b951-d872f2087c98
* Copyedit of pageAction.html. Also some bracket fixes to manifest.html.kathyw@google.com2009-10-214-110/+154
| | | | | | | | | | TEST=none BUG=none TBR=aa Review URL: http://codereview.chromium.org/300042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29715 0039d316-1c4b-4281-b951-d872f2087c98
* The Management UI now fetches the icon for each extensionfinnur@chromium.org2009-10-217-7/+30
| | | | | | | | | | | | | | and shows it on the page. BUG=12119 TEST=Open chrome://extensions and all extensions that have an icon associated with them, should show the icon and those that don't have the generic plugin icon. Review URL: http://codereview.chromium.org/292048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29714 0039d316-1c4b-4281-b951-d872f2087c98
* Start running video-canvas-source.html before we mark it as fully passing.scherkus@chromium.org2009-10-211-2/+2
| | | | | | | | | | | BUG=13907 TEST=tree stays green TBR=hclam Review URL: http://codereview.chromium.org/306035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29713 0039d316-1c4b-4281-b951-d872f2087c98
* Make gtk menu block on call to RunMenuAt.chocobo@google.com2009-10-214-6/+35
| | | | | | | | TEST=none BUG=25429 Review URL: http://codereview.chromium.org/293057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29711 0039d316-1c4b-4281-b951-d872f2087c98
* Gets status bubbles on views/gtk to correctly track when the parentsky@chromium.org2009-10-215-3/+51
| | | | | | | | | | | | | window is hidden/minimized/moved. This is made tricky by the fact that gtk doesn't have the notion of owned windows that automatically hidden along with the parent as windows does. BUG=none TEST=none directly, although covered by ui tests. Review URL: http://codereview.chromium.org/304008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29710 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Properly flip coordinate systems in BrowserWindowCocoa.rohitrao@chromium.org2009-10-211-3/+4
| | | | | | | | BUG=http://crbug.com/18707 TEST=New windows on secondary monitors should cascade correctly. Review URL: http://codereview.chromium.org/314006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29709 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Properly save the workarea when saving window positions.rohitrao@chromium.org2009-10-211-0/+8
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/315002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29708 0039d316-1c4b-4281-b951-d872f2087c98
* Remove incorrect image baseline.evan@chromium.org2009-10-215-2/+3
| | | | | | Review URL: http://codereview.chromium.org/293061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29707 0039d316-1c4b-4281-b951-d872f2087c98
* Messaging of the download item for extension is now:mark@chromium.org2009-10-216-79/+87
| | | | | | | | | | | | | | | | Extensions can harm your computer. Are you sure you want to continue? [Continue] [Discard] This involved taking out the GTMUILocalizerAndLayoutTweaker from the xib and placing it within the controller itself, since the content of the UI is determined at runtime and cannot rely simply on the xib contents. For Win and Linux, only the confirm button needed to change. Patch by Andy Bonventre <andybons@gmail.com> BUG=23105,25257 TEST=When clicking on a link to an extension, the messaging should be specific to extensions and the button to confirm the installation should be 'Continue' instead of 'Save'. Review URL: http://codereview.chromium.org/293014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29706 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented WebMediaPlayerImpl::hasSingleSecurityOrigin().scherkus@chromium.org2009-10-211-2/+4
| | | | | | | | | | BUG=13907 TEST=video-canvas-source.html passes. Review URL: http://codereview.chromium.org/293059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29705 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit test compiling on Linuxzork@chromium.org2009-10-214-13/+1
| | | | | | Review URL: http://codereview.chromium.org/295034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29704 0039d316-1c4b-4281-b951-d872f2087c98
* Shorten searchable_form_data.cc more. Use early return/continue to flatten ↵pkasting@chromium.org2009-10-211-132/+105
| | | | | | | | | | indenting for readability. Avoid an unneeded cast. Use const_iterators where possible, and point to const objects. Change a few variables' names in hopes of increasing clarity. BUG=none TEST=none Review URL: http://codereview.chromium.org/293056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29703 0039d316-1c4b-4281-b951-d872f2087c98
* Split net into net and net_base to reduce v8 dependency injection.maruel@chromium.org2009-10-212-17/+74
| | | | | | | | | | Also remove redundant ui_test_utils.* from sync_integration_tests. TEST=still build BUG=22926 Review URL: http://codereview.chromium.org/307023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29702 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Properly call setIsActive() when becoming and resigning key window.rohitrao@chromium.org2009-10-215-12/+52
| | | | | | | | BUG=http://crbug.com/21738 TEST=TestShell windows should properly become inactive when not key windows. Scrollbars and highlighted text should be grey, not blue. Review URL: http://codereview.chromium.org/255094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29701 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] DCHECK when raising NSException.shess@chromium.org2009-10-215-0/+224
| | | | | | | | | | | | | | NSException == badness. This causes a DCHECK when someone is setting out to raise an NSException. http://crbug.com/24463 TEST=none Provoke some exceptions. Review URL: http://codereview.chromium.org/292004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29700 0039d316-1c4b-4281-b951-d872f2087c98
* Disable WorkerFastLayoutTests on all platforms insteadnsylvain@chromium.org2009-10-211-6/+1
| | | | | | | | | | | of just Linux, because it keeps failing on Windows too. BUG=22780 Review URL: http://codereview.chromium.org/300040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29698 0039d316-1c4b-4281-b951-d872f2087c98
* Hack around the floating tab when using space/enter to end a drag.tony@chromium.org2009-10-212-2/+38
| | | | | | | | | | | | | We don't get a drag-end or a drag-failed event if the user presses space/enter, so we hack around this with a timer. I filed a bug with GTK+ upstream about not getting the event: https://bugzilla.gnome.org/show_bug.cgi?id=599130 BUG=21627 Review URL: http://codereview.chromium.org/300028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29697 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old ap-value munging code in Chrome Frame.robertshield@chromium.org2009-10-214-170/+0
| | | | | | Review URL: http://codereview.chromium.org/303023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29696 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for issue 24888xiyuan@chromium.org2009-10-211-0/+24
| | | | | | | | | | | Richedit seems to have a default paragraph format which will be used when the last paragraph in the document is deleted. (e.g. when SetWindowText is called, or when user manually deletes everything). When this happens, richedit also automatically set keyboard layout to match the default paragraph format. Unfortunately, fix for issue 11683 does not help for this scenario. The default paragraph format seems could only be set when user switches keyboard layout with an empty richedit. The fix in this CL works around the problem by setting richedit's text to empty before it forward the reading order change hotkey (ctrl+shift/shift+ctrl). BUG=24888 TEST=Verify this CL fixes issue 24888 that LTR/RTL reading order is preserved when user selects suggestions/changes tabs after changing keyboard layout with non-empty text in Omnibox. Review URL: http://codereview.chromium.org/294013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29695 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline audio-constructor-autobuffer.html and mark video-loop.html as ↵scherkus@chromium.org2009-10-214-38/+111
| | | | | | | | | | | | | failing. BUG=13907 TEST=tree goes green TBR=hclam Review URL: http://codereview.chromium.org/307022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29694 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to use libcros to make changes to touchpad settings.chocobo@google.com2009-10-216-126/+106
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/300011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29693 0039d316-1c4b-4281-b951-d872f2087c98
* Implement dragging icon for dragging bookmarks in views/gtk.skrul@google.com2009-10-217-9/+86
| | | | | | Review URL: http://codereview.chromium.org/270068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29692 0039d316-1c4b-4281-b951-d872f2087c98
* Um, polish...something...mark@chromium.org2009-10-212-1/+6
| | | | | | | | | | | | | Use a Mac-like tab key image for "Press [tab] to search" on the Mac. New image from Cole. Hello, VAG Rounded. BUG=21444 TEST=Start typing "go" in the omnibar, the "tab" image should look Mac-ish. On other platforms, the "Tab" image should be unchanged. Review URL: http://codereview.chromium.org/307024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29691 0039d316-1c4b-4281-b951-d872f2087c98
* New tab close button images from Cole.mark@chromium.org2009-10-212-1407/+2679
| | | | | | | | BUG=21444 TEST=Lollipops have not fallen in dirt? Review URL: http://codereview.chromium.org/314005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29689 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Be more aggressive in repositioning windows that are offscreen.rohitrao@chromium.org2009-10-212-133/+387
| | | | | | | | BUG=http://crbug.com/18713 TEST=Windows that can fit entirely onscreen should appear entirely onscreen. Review URL: http://codereview.chromium.org/293052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29688 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Select the first row in cookies table when the Cookies window ismattm@chromium.org2009-10-213-1/+76
| | | | | | | | | | | | | | opened. Windows already does this. BUG=None TEST=compiled and tested on linux and covered by unit_tests. Review URL: http://codereview.chromium.org/270063 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29687 0039d316-1c4b-4281-b951-d872f2087c98
* Add a mechanism to disable IPv6.eroman@chromium.org2009-10-2119-129/+302
| | | | | | | | | | | | | | | | | | | (1) Adds the ability to specify the address family on a per-request basis. (2) Exposes a --disable-ipv6 flag to chrome that changes the default address family from AF_UNSPEC to AF_INET (same sort of thing Firefox does). (3) Changes the backing datastructure for HostCache:EntryMap and HostResolverImpl::JobMap from a "hash_map" to a "std::map". This was for consistency with other code (when I went to add a custom hash trait, I couldn't find any existing code which was using hashmap for custom keys). (4) Updates about:net-internals to display an address family for the hostcache dump (since it is now a part of the key). This change is in anticipation of turning off IPv6 host resolving in the PAC utility functions (see bug 24641). But it is also a feature addition. BUG=24641 TEST=HostCacheTest.AddressFamilyIsPartOfKey Review URL: http://codereview.chromium.org/302010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29686 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29678 - Cleaning up media layout tests expectations.nsylvain@chromium.org2009-10-211-57/+38
| | | | | | | | | | | | | BUG=13907 TEST=n/a Review URL: http://codereview.chromium.org/295040 TBR=scherkus@chromium.org Review URL: http://codereview.chromium.org/315003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29685 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing better fallback algorithm.cira@chromium.org2009-10-219-136/+227
| | | | | | | | | | | | | | | | | | | | | | | Before: current_locale->default_locale Now: current_locale->chain_of_parent_locales->default_locale If default_locale is de, and current locale en_US, we follow: en_US -> en -> de en is not a Chrome locale (only en_US, en_GB are), but we fake it to allow this kind of fallback. Developers can implement common locale root with most of the messages (like en) and put locale specifics in en_GB (color->colour) or en_US. You can even symlink en and en_US and save on work. I am planning on fixing loading local resources too, to use this child->parent fallback. BUG=12131 Review URL: http://codereview.chromium.org/293037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29684 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29635 - DevTools: fix and enable TestContentScriptIsPresentnsylvain@chromium.org2009-10-212-13/+1
| | | | | | | | | | | The test was still failing Review URL: http://codereview.chromium.org/314001 TBR=yurys@google.com Review URL: http://codereview.chromium.org/292051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29683 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify GetLinuxDistro() for Chrome OS.thestig@chromium.org2009-10-211-5/+13
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/303018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29682 0039d316-1c4b-4281-b951-d872f2087c98
* Trim unused members from SearchableFormData. Remove copies of WebCore ↵pkasting@chromium.org2009-10-219-193/+85
| | | | | | | | | | functions that are now public. Fix a few style errors. Make some functions shorter. Remove "using" directives since most of the file ignored them anyways. Remove unneeded #includes. BUG=none TEST=none Review URL: http://codereview.chromium.org/292041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29681 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ThreadSanitizer suppression for bug 15147.eroman@chromium.org2009-10-211-7/+0
| | | | | | | | | | This hasn't reproduced in the past bunch of runs of net_unittests; I believe it was fixed by r26611. BUG=15147 Review URL: http://codereview.chromium.org/294034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29680 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up media layout tests expectations.scherkus@chromium.org2009-10-211-38/+57
| | | | | | | | | | BUG=13907 TEST=n/a Review URL: http://codereview.chromium.org/295040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29678 0039d316-1c4b-4281-b951-d872f2087c98
* Added a static function pointer to cache the SetActiveURL pointer.cpu@chromium.org2009-10-211-10/+12
| | | | | | | | | | | | | | | - Windows only change. This is basically landing jschuh change http://codereview.chromium.org/293040 TEST=none BUG=25366 Review URL: http://codereview.chromium.org/313009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29677 0039d316-1c4b-4281-b951-d872f2087c98
* Some more, release link error fixmichaeln@google.com2009-10-211-5/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29676 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a compile error.michaeln@google.com2009-10-211-5/+3
| | | | | | Review URL: http://codereview.chromium.org/307021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29675 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29668 - Add a commandline option for specifying a particular build to ↵kkania@google.com2009-10-216-263/+256
| | | | | | | | | | | | | test and for permitting the tests to be run regardless of underlying platform. Also some minor fixes and cleanup. BUG=none TEST=none REVIEW=http://codereview.chromium.org/269016/ TBR=kkania@chromium.org Review URL: http://codereview.chromium.org/293054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29674 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Display explanatory message on sad tab page.estade@chromium.org2009-10-212-5/+4
| | | | | | | | | | | Also fix canvas text drawing bugs for certain vertical alignments. BUG=25267 TEST=about:crash Review URL: http://codereview.chromium.org/307015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29673 0039d316-1c4b-4281-b951-d872f2087c98
* Style and comment fixes for sync_setup_wizard_gtk.cc and sync_setup_wizard.hzork@chromium.org2009-10-213-8/+20
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/292038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29672 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Switch from "Cancel" to "Do Nothing" for the external protocol dialog, ↵avi@chromium.org2009-10-212-6/+7
| | | | | | | | | | | and allow remembering the "Do Nothing" choice. BUG=none TEST=Verify that "Do Nothing" is the left button, and that clicking the "Remember" checkbox remembers the "Do Nothing" state. Review URL: http://codereview.chromium.org/314003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29671 0039d316-1c4b-4281-b951-d872f2087c98
* AppCacheResponse storage implementationmichaeln@google.com2009-10-2113-115/+1378
| | | | | | | | | | | | | | * classes AppCacheResponseReader and AppCacheResponseWriter * also implements AppCacheStorage.LoadResponseInfo() * using a memory-backed disk_cache for now, so not really on disk yet TEST=appcache_response_unittest.cc BUG=none Review URL: http://codereview.chromium.org/269062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29670 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RenderViewHostDelegate::Autofill to ↵jhawkins@chromium.org2009-10-219-52/+56
| | | | | | | | | | RenderViewHostDelegate::FormFieldHistory to better reflect the purpose of the interface. BUG=none TEST=none Review URL: http://codereview.chromium.org/294030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29669 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command-line option for specifying a particular build to test and for ↵kkania@chromium.org2009-10-216-256/+263
| | | | | | | | | | permitting the tests to be run regardless of underlying platform. Also some minor fixes and cleanup. BUG=none TEST=none REVIEW=http://codereview.chromium.org/269016/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29668 0039d316-1c4b-4281-b951-d872f2087c98
* More work on browser actions doc.kathyw@google.com2009-10-213-145/+281
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/295039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29667 0039d316-1c4b-4281-b951-d872f2087c98
* Use the original profile when opening the keyword editor window, sincepam@chromium.org2009-10-213-4/+10
| | | | | | | | | | | | | | | otherwise the profile pointer may go stale if it was opened from an Incognito window. Simplify the check that already does this on Mac. GetOriginalProfile() returns the profile it's called on, if it isn't incognito. BUG=23359 TEST=open Incognito window, right-click in omnibox, Edit Search Engines, close Incog window, edit an engine Review URL: http://codereview.chromium.org/307010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29666 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the extension shelf on Linux.phajdan.jr@chromium.org2009-10-217-363/+10
| | | | | | | | | | | | | The extension team's plan is to get rid of extension shelf entirely. This is also going to fix a crash. TEST=none BUG=25106 Review URL: http://codereview.chromium.org/313006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29665 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compatibility problems with FileZilla FTP Server.phajdan.jr@chromium.org2009-10-212-8/+31
| | | | | | | | | TEST=Covered by net_unittests. BUG=25316 Review URL: http://codereview.chromium.org/293049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29662 0039d316-1c4b-4281-b951-d872f2087c98