| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=32819
TEST=see bug
Review URL: http://codereview.chromium.org/545150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This picks up the following fix:
skia: Always use aliased text when antialiasing is disabled.
Otherwise, people who have antialiasing disabled end up with
subpixel rendering if the subpixel setting happens to be set
to something other than "none". This change's interpretation
of these overlapping settings seems to be consistent with
GTK's and Firefox's.
BUG=28382
TEST=tested that aliased text is now drawn in the above case
Review URL: http://codereview.chromium.org/555035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29862
TEST=None
Review URL: http://codereview.chromium.org/551015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/548105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
authentication is succesful in Chrome OS.
BUG=1220
TEST=The menu option in the wrench menu should indicate that bookmarks are
synced on startup, and it should be possible to disable sync through the
options dialog.
Review URL: http://codereview.chromium.org/551053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
creating nested menus. This means that the menu Run is invoked on
isn't necessarily the selected menu. I need to push up state to the
menu run is invoked on, otherwise nothing happens when a menu is selected.
BUG=32662
TEST=see bug
Review URL: http://codereview.chromium.org/545142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bots three times and they seemed to like the patch.
BUG=16447
TEST=The change is to a test.
Review URL: http://codereview.chromium.org/553042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
popup window.
BUG=29355
TEST=none
Review URL: http://codereview.chromium.org/552084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
AutoFillDialogObserver interface that is used to send the profile information back to clients.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary to make some plugins work. Satoru has a patch to
do backtraces in a different manner.
BUG=32762
TEST=about:plugins doesn't call random other plugins the native client plugin
Review URL: http://codereview.chromium.org/553047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32765
Review URL: http://codereview.chromium.org/551097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes two notable changes:
- Plugins that are scrolled completely out of view will get an empty clip rect now.
- Carbon Plugins that are scrolled completely out of view will get idle events at a lower rate.
Also removes code to compute title bar offset, which is now cruft since the dummy window is chromeless.
BUG=30838
TEST=Plugins should continue to draw smoothly when visible, and audio should not be interrupted when they are scrolled out of view.
Review URL: http://codereview.chromium.org/543156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'd like to build this code for Chrome OS, but the gtest
include path is different there. I'm removing the include
and adding the FRIEND_TEST() macro directly to json_reader.h.
BUG=none
TEST=compiled
Review URL: http://codereview.chromium.org/546100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/string_split.
BUG=None
TEST=base_unittests
Original patch by Thiago Farina
Original Review: http://codereview.chromium.org/464075
Review URL: http://codereview.chromium.org/502074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32594
TEST=none (see steps to reproduce)
Review URL: http://codereview.chromium.org/554034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and the server replies that it is giving us x bytes but
we receive less than that, forward the failure to the
caller instead of asking for another range.
BUG=31000
TEST=unittests
Review URL: http://codereview.chromium.org/545101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/546091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If you click and hold on a close button that is being animated closed, it will crash if you release it after the tab is completely closed. The button is being freed when the |super mouseDown| call is in it's tracking loop, so we need to hold on to it with a scoped_nsobject until we're done with it. The checkImageState call is called unnecessarily, but it shouldn't hurt anything.
BUG=28220
TEST=Click and hold on the close button of a tab that is animating closed. Release it a couple of seconds after the tab is fully hidden. To help test, you can change the kAnimationDuration in tab_strip_controller.mm to a higher value.
Review URL: http://codereview.chromium.org/555018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=wtc
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=32803
TEST=use it
TBR=thestig
Review URL: http://codereview.chromium.org/553046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32338
TEST=Preferences-->Under the Hood-->Show cookies... should now be localized.
Review URL: http://codereview.chromium.org/543128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32705
Review URL: http://codereview.chromium.org/548097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test was disabled except on linux until I enabled it in r36676. It passes on normal linux, but not chromeos. Further investigation is warranted, but it is not actually a regression.
BUG=32799
TEST=none
TBR=pkasting
Review URL: http://codereview.chromium.org/552083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32474
TEST=see bug for details
Review URL: http://codereview.chromium.org/545144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They are of the form @@somename, i.e. @@ui_locale.
Trying to reland. It's the same as http://codereview.chromium.org/546040.
It makes easier for developers to detect current UI locale (also available though window.navigator.language), or text
direction. I'll use them for static message replacement later on too.
Before this change developers would have to manualy add locale and text_dir messages and translate for all supported locales.
Added 5 reserved messages:
@@ui_locale
@@bidi_dir
@@bidi_reversed_dir
@@bidi_start_edge
@@bidi_end_edge
See http://code.google.com/apis/gadgets/docs/i18n.html#BIDI on why are they usefull.
Extended allowed charset for variable names with @. Added unittest for variable names.
TBR=jshin@chromium.org
Review URL: http://codereview.chromium.org/555021
TBR=cira@chromium.org
Review URL: http://codereview.chromium.org/546108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This additional check has existed since the code was first written, but wtc
queried it in [1] and noted that it doesn't match the Windows version.
[1] http://codereview.chromium.org/541022/diff/1/3#newcode309
Removing this additional test doesn't break any unittests so it looks
like we can match the Windows code here.
http://codereview.chromium.org/545156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Run all instances of a given plugin off of the same idle event source, rather than having each instance generating a constant event stream.
The performance win is probably negligeable now, but will be more important as other improvements are made, and it simplifies the shutdown logic.
BUG=none
TEST=Carbon-based plugins (Flash 10.0, QuickTime, etc.) should continue to play video smoothly.
Review URL: http://codereview.chromium.org/543143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
form @@somename, i.e. @@ui_locale.
Trying to re-land. It's the same as http://codereview.chromium.org/546040.
It makes easier for developers to detect current UI locale (also available though window.navigator.language), or text
direction. I'll use them for static message replacement later on too.
Before this change developers would have to manualy add locale and text_dir messages and translate for all supported locales.
Added 5 reserved messages:
@@ui_locale
@@bidi_dir
@@bidi_reversed_dir
@@bidi_start_edge
@@bidi_end_edge
See http://code.google.com/apis/gadgets/docs/i18n.html#BIDI on why are they usefull.
Extended allowed charset for variable names with @. Added unittest for variable names.
TBR=jshin@chromium.org
Review URL: http://codereview.chromium.org/555021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32790
TEST=Search for something that doesn't exist. Hear beep.
Review URL: http://codereview.chromium.org/545154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
DCHECK to try to catch instances where it is called away from the main thread.
BUG=32786
TEST=cmd-w/cmd-shift-w should always be correct.
Review URL: http://codereview.chromium.org/546106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Until we have real window activation status, just send a window focus event so that Cocoa plugins always think their window is active (as is currently the case with Carbon plugins).
Also wire up the Carbon interposing on window activation checks to talk to the delegate, so once the delegate has correct information Carbon will Just Work.
BUG=31847
TEST=Flash 10.1 should track the mouse when the plugin is loaded, without having to click in it first.
Review URL: http://codereview.chromium.org/552067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixing issue 553 in V8 requires changes in profiler log format.
This change accepts both versions of V8.
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/551095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
figure out why it's failing on the builder.
TEST=n/a
BUG=none
TBR=ananta
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome Frame.
BUG=22802
TEST=None
Review URL: http://codereview.chromium.org/555010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32564
TEST=Trybots
Review URL: http://codereview.chromium.org/554030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
domain cookie was being set twice although only set once by the server.
The test itself needed fixing as well as an extra check for domain cookies set by a different url than the current url.
There's one other problem remaining however which was initially reported in bug 30786 and I'll get on that next (bug reopened).
TEST=Run the FullTabModeIE_ChromeFrameDeleteCookieTest test.
BUG=32546, 30786
Review URL: http://codereview.chromium.org/546104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=thomasvl
Review URL: http://codereview.chromium.org/545152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added unittests for TemplateURLRef::ParseParameter and TemplateURLRef::ParseURL methods.
BUG=2238
TEST=Try adding urls with different combinations of {}, they all should work.
Review URL: http://codereview.chromium.org/555012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
A different point from Mac expectation is the height of <br>.
BUG=32672
TEST=none
Review URL: http://codereview.chromium.org/543151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in preparation
for upstreaming them to WebKit/WebKitTools/Scripts/webkitpy . This also
involves changing run_webkit_tests.py to run_chromium_webkit_tests.py to
minimize confusion with the existing runwebkittests perl script upstream.
There should be no uservisible impact as the existing shell and batch scripts
have been updated for the new paths.
BUG=none
TEST=none
R=eseidel@chromium.org
Review URL: http://codereview.chromium.org/545145
TBR=dpranke@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for upstreaming them to WebKit/WebKitTools/Scripts/webkitpy . This also
involves changing run_webkit_tests.py to run_chromium_webkit_tests.py to
minimize confusion with the existing run-webkit-tests perl script upstream.
There should be no user-visible impact as the existing shell and batch scripts
have been updated for the new paths.
BUG=none
TEST=none
R=eseidel@chromium.org
Review URL: http://codereview.chromium.org/545145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The diference from the upstream expectation is the first line.
Exception messages of V8 and JavaScriptCore are different.
BUG=32669
TEST=none
Review URL: http://codereview.chromium.org/551092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows and Linux.
They are new tests, and I confirmed the difference between these
expectations and WebKit/mac expectation is just font appearance.
BUG=32678
TEST=none
Review URL: http://codereview.chromium.org/548103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
which can happen if the sqlite history db is corrupt / offline.
BUG=25492
TEST=none
Review URL: http://codereview.chromium.org/492017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32740
TEST=Click Recents in bookmark manager, verify it still has a star icon.
Review URL: http://codereview.chromium.org/554029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32349
TEST=Valgrind linux doesn't yell.
Review URL: http://codereview.chromium.org/545076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
direction for
the clear browsing data dialog.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/542126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Merge <datalist> bugs into one bug
- Mark <datalist> failures DEFER.
BUG=20226
TEST=none
Review URL: http://codereview.chromium.org/551091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36732 0039d316-1c4b-4281-b951-d872f2087c98
|