| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
need to think about quoted values while also avoiding a string copy if the value is unquoted.
The iterator now holds a (normally empty) string member that it uses only if the currently accessed value is quoted. In this case, the value_begin and value_end iterators point into this string (holding the unquoted value) as opposed to the original buffer (holding the quoted value). The value is only unquoted if it is accessed.
As a result, the interface is simplified to not expose whether the current value is quoted. This simplifies the work of all clients. Furthermore, this implementation is optimized to only construct a string if it is required, whereas most clients previously (for simplicity) constructed a new string whether or not it was required. They will therefore benefit from a slight increase in efficiency.
BUG=52601
TEST=net_unittests / HttpUtilTest.NameValuePairs*, HttpAuthTest.*
Review URL: http://codereview.chromium.org/3777012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This policy and preference will hold the list of extensions that should be silently installed.
BUG=59782
TEST=none (real logic comes in later CLs)
TBR=jochen
Review URL: http://codereview.chromium.org/3781022
TBR=gfeher@chromium.org
Review URL: http://codereview.chromium.org/4035003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This policy and preference will hold the list of extensions that should be silently installed.
BUG=59782
TEST=none (real logic comes in later CLs)
Review URL: http://codereview.chromium.org/3781022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
privileged instances of Chrome Frame.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4031003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rename GeolocationDispatcherHost to GeolocationDispatcherHostOld and GeolocationDispatcher to GeolocationDispatcherOld in preparation for the new client-based implementation.
BUG=59908
TEST=None
Review URL: http://codereview.chromium.org/3799010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- that is, defining use_openssl=1 will now remove all dependency on NSS.
This does not impact any of the standard, non-openssl builds.
Adds stub implementations of several files that need to be fully implemented in follow up patchs.
Firefox import code will need some more substatial refactoring, as it makes little sense to be
attempting a firefox import without NSS libraries to hand, however the UI etc has numerous assumption
about the presence of this importer.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3855004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux_chromeos.
It crashes browser_tests in 20% of the times.
TBR=jcivelli@chromium.org
BUG=43437
TEST=none
Review URL: http://codereview.chromium.org/3985003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fixed now
TBR=thestig
TEST=Heapchecker bot should remain green
BUG=58242
Review URL: http://codereview.chromium.org/3975006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change, the icon and text were not proerly aligned.
TEST=manually check the layout. See crosbug.com/7938 for the screenshot
BUG=chromium-os:7938
Review URL: http://codereview.chromium.org/3996006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Pages with "chrome" scheme have very narrow permissions (e.g. no access to localStorage). We want inspector page to have the same permissions as usual page.
Review URL: http://codereview.chromium.org/3838005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a stub we used to use for the old Page Info Window, which has been replaced by a bubble.
BUG=59030
TEST=None
Review URL: http://codereview.chromium.org/4017003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/4071003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- MouseLeaveTest.TestOnMouseOut (issue 45892)
- BrowserFocusTest.FocusTraversal (issue 49738)
- BrowserFocusTest.FocusTraversalOnInterstitial (issue 49738)
- ExtensionApiTest.TabOnRemoved (issue 59198)
- ExtensionBrowserTest.PluginLoadUnload (issue 47598)
- ExtensionApiTest.WindowOpen (issue 60156)
TBR=nkostylev
BUG=45892, 49738, 59198, 60156
TEST=none
Review URL: http://codereview.chromium.org/4029005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, replace "About Chrome" with "About Chrome OS" in the wrench menu.
TEST=Connect to a dev server with a newer version, and check that the menu item appears, and the dialog works.
BUG=chromium-os:6526
BUG=chromium-os:7847
Review URL: http://codereview.chromium.org/3858002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is upstreaming a Gentoo Linux patch.
BUG=none
TEST=noe
Review URL: http://codereview.chromium.org/3769008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59330
TEST=browser_tests
Review URL: http://codereview.chromium.org/4000002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
both chrome:settings/internet and chrome:mobilesetup pages.
Fixed some minor internet settings formatting issues while I was already there.
BUG=chromium-os:6987, chromium-os:7619, chromium-os:7546
TEST=make sure cellular connection can be activated from chrome:settings
Review URL: http://codereview.chromium.org/3744013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=dglazkov
Review URL: http://codereview.chromium.org/4061003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
some test
bots.
BUG=44991
TEST=none
Review URL: http://codereview.chromium.org/3992005
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/4028002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bots.
BUG=44991
TEST=none
Review URL: http://codereview.chromium.org/3992005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
since we now prefer input_method_ to language_.
BUG=none
TEST=manually done.
Review URL: http://codereview.chromium.org/4043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pull in the ICU-side change.
See http://codereview.chromium.org/3770017 for the ICU-side
change.
BUG=NONE
TEST=Run tools/licenses.py to generate the html for 'about:credits'
and make sure that ICU is listed only once and the license
for 'Chinese/Japanese' word list is present.
Review URL: http://codereview.chromium.org/3815010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes unit test failures
TBR: cmasone@chromium.org
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4073001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also remove some "using"s, remove some extra {}s, and fix function argument wrapping to comply with the style guide.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3975003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/4011004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whether you're running cygwin python or win32 python and regardless of
where you're invoking the script from.
BUG=59958
TEST=run from the directory above src
R=jam@chromium.org
Review URL: http://codereview.chromium.org/3995005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to flake anymore on windows or linux. For some reason it
doesn't show up in the flakiness dashboard at all for mac,
but a spot check of recent builds show similar
rock-solidness.
TBR=phajdan.jr@chromium.org
BUG=46301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60229
TEST=none
Review URL: http://codereview.chromium.org/3984004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60184
TEST=unit_tests --gtest_filter=WebDatabaseTest.RemoveAutoFillProfilesAndCreditCardsModifiedBetween
Review URL: http://codereview.chromium.org/4064001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59630
TEST=none
Review URL: http://codereview.chromium.org/3826016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also removes LOG_RESOURCE_REQUESTS and all associated code.
Also remove some "using"s, fix non-const ref (style violation), remove some "else" after "return", and remove some extra {}s.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3941001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
not use WorkerThread::current""
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit b7ce919957536ceb0cfac1709bc779fd086b6ce8.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
WorkerThread::current"
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3869003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WorkerThread::current
Currently FileEntry.file() or FileEntrySync.file() calls File::create() on the (WebKit's) worker thread but on chromium we use WorkerThread::current() (which assumes WebKit's main thread in the worker process) to process the mime request initiated by File::create().
File::create() needs to be called on the main thread (this is related to webkit.org/b/47700) or WorkerWebKitClientImpl::mimeTypeForExtension should not use WorkerThread::current() to process the request.
BUG=60081
TEST=no crash in fast/filesystem/workers/file-from-file-entry.html
Review URL: http://codereview.chromium.org/4012002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
57405).
Update bug numbers in two places, so that each has a distinct bug with owners
that are involved in the area and each of those bug depends on the underlying
bug.
TEST=SearchProviderTest.TestIsSearchProviderInstalled
BUG=57405,60043,60035
Review URL: http://codereview.chromium.org/3985002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=built and ran O3D on Linux (64-bit)
Review URL: http://codereview.chromium.org/3978003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Remove the ViewAccessibilityWrapper class. The view can directly manage it's ViewAccessibility.
2. Always use GetAccessibleForView to retrieve a view's associated accessibility object. This ensures that the correct accessibility object is returned for native view host objects.
3. Update get_accFocus to use FocusManager.
4. Move oleacc guid definitions to view_win.cc.
BUG=none
TEST=interactive_ui_tests:BrowserViewsAccessibilityTest.TestBrowserRootViewAccObj
TEST=Manual: I can select the accessibility object of a native view host within AccExplorer32.exe.
Review URL: http://codereview.chromium.org/4047001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=crl --enable-tabbed-options. The AutoFill options should works as before.
Review URL: http://codereview.chromium.org/4015003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes bug with logging in twice not clearing the
start time, and a merge problem with cookie fetching in
login_utils.cc
BUG=chromium-os:7971
TEST=check /tmp/login-times-sent. Should see login complete before cookies fetched
(CookiesFetched won't appear).
Review URL: http://codereview.chromium.org/4034005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extension events are no longer broadcast to an entire process. They are
filtered by extension. This allows me to move the cross-incognito check into
the browser, and remove a bunch of cruft associated with that.
BUG=58214
TEST=no functional change
Review URL: http://codereview.chromium.org/3775015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Enable sync, notice passwords is an option / enabled. unit_tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63223
Review URL: http://codereview.chromium.org/3913005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7864
TEST=run chromium-os tests, make sure they run
Review URL: http://codereview.chromium.org/4043003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=built on Linux; Win & Mac trybots
Review URL: http://codereview.chromium.org/4014004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clear focus of textfield so that re-enabling textfield sets the focus to the textfield.
BUG=chromium-os:5763
TEST=manual. in locked state, type wrong password. the focus should
be back to text field.
Review URL: http://codereview.chromium.org/3996005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently putting DEPS in functional dir messes up the checkout on the
official pyauto bots (causing re-definition). Moving to a separate location.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3997004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63441 0039d316-1c4b-4281-b951-d872f2087c98
|