| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
behind a switch, --enable-new-autofill. So far, we only pop up an infobar asking the user if he'd like to save the form information. I've added a rudimentary icon for the infobar, pulled from the mocks, so we'll probably want a blessed version of this icon at some point.
BUG=18201
TEST=none
Review URL: http://codereview.chromium.org/339030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
located in any directory, as long as the directory structure is correct.
Original review at: http://codereview.chromium.org/344013.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/339040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/347006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
coding. I can't think of a good reason why we were hard coding it
before.
BUG=17592
TEST=none
Review URL: http://codereview.chromium.org/340009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
svn properties.
TBR=maruel
BUG=25952
Review URL: http://codereview.chromium.org/345015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/342021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add in some flaky tests and remove a bunch of plugin tests that are now passing on MAC.
BUG=25880
BUG=20748
BUG=20438
BUG=11613
BUG=10438
BUG=10374
BUG=10354
BUG=10667
BUG=10351
BUG=10673
BUG=6735
TEST=layout test bots still green
Review URL: http://codereview.chromium.org/345010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=rolandsteiner
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/341021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/340021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
automation proxies, which I maintain is a bad thing.
BUG=Start IE with debug CF installed, navigate to a chrome frame page, exit IE, see the DCHECK.
Review URL: http://codereview.chromium.org/342018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and specific commands.
Common are things like Noop, SetToken, Jump, Gosub, return.
Specific are O3D etc...
Review URL: http://codereview.chromium.org/329046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/338066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
start==0 and end==9223372036854775807, i.e. the full positive range of a
64-bit signed int.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/346003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tests,etc. to be located in any directory, as long as the directory structure is maintained.
Review URL: http://codereview.chromium.org/344013
TBR=kkania@google.com
Review URL: http://codereview.chromium.org/345013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=ojan
BUG=25858
TEST=rebaseline tool
Review URL: http://codereview.chromium.org/345008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=Covered by net_unittests.
BUG=25520
TBR=eroman
Review URL: http://codereview.chromium.org/344015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
located in any directory, as long as the directory structure is maintained.
Review URL: http://codereview.chromium.org/344013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
just windows.
see http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(dbg)(2)/builds/3796/steps/ui_tests/logs/CloseTab
BUG:14774
Review URL: http://codereview.chromium.org/346005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/339048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
specifically so as to not lose test coverage on other platforms.
TBR=aa
BUG=26035
TEST=None
Review URL: http://codereview.chromium.org/343019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
them.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/343018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added parser for "ls" listing style, and tests. This is not yet used by the browser (will do that in a following CL).
TEST=Covered by net_unittests.
BUG=25520
Review URL: http://codereview.chromium.org/244008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/342009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/337058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Will investigate tomorrow.
TBR=sgjesse@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/343020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, fix some glitches in sizing the popups.
BUG=25214
TEST=ExtensionApiTest.BrowserActionPopup
Review URL: http://codereview.chromium.org/295051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This version contains a number of bug fixes and better heap profiling
support.
Review URL: http://codereview.chromium.org/339044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as the FLIP client reads. Then, enable the use of the
CONTROL_FLAG_FIN on a request which has no data.
Added a new test for a POST. The test passes today, but I
will make it stronger with my next pass at fully implementing
POST.
POST uploads are still not complete
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/338055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21729
TEST= Manually tested that onUpdated sends all tab info. Updated unit tests.
Review URL: http://codereview.chromium.org/289006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
bug:26035
Review URL: http://codereview.chromium.org/338064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
covers the issue.
Review URL: http://codereview.chromium.org/343017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
renderers.
TEST=flag on browser causes logging from renderers.
BUG=none
Review URL: http://codereview.chromium.org/342017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
often both on Linux and Windows.
BUG:14774
Review URL: http://codereview.chromium.org/347003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CFRunLoopTimers are implemented in terms of kernel ticks, a time base which is
suspended while the system is sleeping. In order to properly perform delayed
work at the proper initially-scheduled time (or at system wake if the
scheduled time passed while the system was asleep), the associated timer needs
to be reset to the most recently scheduled next-fire time on wake from sleep.
BUG=22508
TEST= - Make Chrome the active application.
- Close all Chrome windows.
- Close the laptop lid.
- Wait for it to begin sleeping, indicated by the pulsing light. NOTE:
wait until the light actually begins pulsing, not just until it turns
on. The disk and fans should all be stopped.
- Reopen the laptop. If needed, authenticate to the screen saver.
- Click the Chrome icon in the dock. A new window should open on the
New Tab page.
- Quickly type "google.com/" into the omnibox.
- The page should load, its favicon should be visible, and the tab title
should read "Google". This should happen as instantly as a normal
page load. The tab title should not "stick" on "New Tab" and the icon
load should not be delayed for any amount of time.
Review URL: http://codereview.chromium.org/342011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To resolve the problem of '..' parent references as well as symbolic links on POSIX platforms, we can simply use the file_util::AbsolutePath() function.
This has the drawback of having a different behavior on Windows and POSIX platforms, in the way that it can return a canonical path that doesn't exists when ran on Windows, but it will return an empty path (or false) when run on a POSIX platform.
So we need to add an extra PathExists() call to unify the behavior.
BUG=25681,25131
Review URL: http://codereview.chromium.org/343003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a DCHECK fire in
the Chrome frame network tests for whether the current thread is the UI thread. We need to invoke
the correct constructor.
The other fix is in our com_util::IDispatchImpl class where we end up crashing if we fail to find
the type information for the passed in interface. Strangely this is failing for the IChromeFrame
interface which is an IDispatch derivative and seems to be correctly registered. It also fails
with the ATL IDispatchImpl classes though. However we should not crash here :) I also removed
the NOTREACHED as it keeps firing on debug test runs. Will take a look at this closely later.
TBR=tommi
Review URL: http://codereview.chromium.org/343013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/344009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24622,24597
Review URL: http://codereview.chromium.org/330029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/333045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a max of 19px square.
BUG=25626
Review URL: http://codereview.chromium.org/342012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old name is also aliased for backwards compat.
This lands:
http://codereview.chromium.org/224012
BUG=21433
Review URL: http://codereview.chromium.org/339041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
seen it crash on the try servers as well).
TBR=lzheng
BUG=26035
TEST=None
Review URL: http://codereview.chromium.org/338060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25947
TEST=Not easily testable until we have the strings localized.
Review URL: http://codereview.chromium.org/329039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bug originates from extensions being treated case sensitive on Windows and Mac OSX, where they shouldn't be.
Therefore I added generic static methods to FilePath to compare strings in the same way the file system does, and changed the relevant parts of the code to make use of them.
I tested the methods under Windows and Mac OS X. I also wrote a basic version for Linux/Posix that behaves the same way as the original code, so there should at least be no regression.
Also, while fixing this I found some confusion in the code about whether extensions are used with or without leading dot. For this reason I changed some functions that were taking an extension as parameter to instead take the whole file path. This makes calling these functions easier and the caller doesn't need to know whether the extension is supposed to be with or without dot.
In the same vein, I split DownloadManager::IsExecutable into IsExecutableFile, where one again passes in the whole file and doesn't have to worry about getting the extension right, and IsExecutableExtension, which corresponds to the original functionality. Ideally only the former method should be public, but that again would have required further code scrubbing that was (even more) outside of the original bug fix.
Finally, fixed a wrong comment in the file path tests.
BUG=10876
TEST=FilePathTest.MatchesExtension, .CompareIgnoreCase
Review URL: http://codereview.chromium.org/149796
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html,
these tests didn't crash after webkit rolls.
BUG=25399
TEST=these layout tests doesn't crash
Review URL: http://codereview.chromium.org/342013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix warning: comparison between signed and unsigned integer expressions
in base/pickle.cc
TBR=thesig
BUG=none
TEST=build sucess
Review URL: http://codereview.chromium.org/342014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/297011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If X509Certificate is created in URLRequestAutomationJob or
URLRequestInterceptJob, cert_handle_ is NULL.
So if such certificate is being to be verified (not sure it happens), it would cause crash or some
problem.
BUG=15614
TEST=none
Review URL: http://codereview.chromium.org/329036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30319 0039d316-1c4b-4281-b951-d872f2087c98
|