summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Asynchronously open the temp file used for Pepper StreamToFile, and delete thedarin@chromium.org2010-07-3010-17/+539
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | temp file once we are done with it. We observe ResourceHandle::OnRequestClosed as a signal of when we should delete the temp file. This corresponds to the WebURLLoader being closed (or canceled). This patch also includes some helpers: base/scoped_callback_factory.h This class makes it easy to allocate Callbacks that hold a weak reference back to the owning class. It works just like ScopedRunnableMethodFactory but for Callbacks instead of RunnableMethods. base/platform_file.h Added a PassPlatformFile class that is useful for cases where a callback may decide not to take ownership of a PlatformFile (as can happen when using ScopedCallbackFactory). chrome/file_system_proxy.{h,cc} This class provides static methods for executing file system commands on the FILE thread. It routes callbacks back to the originating thread to deliver results (file handles, etc.). Note: this file declares a few functions that are not yet used. I anticipate that we'll make use of these and add more functions here to support the Pepper and OWP FileSystem APIs. chrome/chrome_thread_relay.{h,cc} This class is a helper class for proxying calls over to a background ChromeThread and then returning results to the originating ChromeThread. R=brettw BUG=49789 TEST=(more to be added in third_party/ppapi/tests) Review URL: http://codereview.chromium.org/2878062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54402 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine API.evan@chromium.org2010-07-306-28/+7
| | | | | | | | | Cleaned up the final few callers, punting the remaining harder ones to TODOs. Review URL: http://codereview.chromium.org/3043033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54400 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54381 - Revert 54378 - Add content-length to spdy post request header.lzheng@chromium.org2010-07-304-24/+115
| | | | | | | | | | | | | | | | | | I was rolled back due to this failure: http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac10.6%20(dbg)/builds/9160 I think that failure is not related to this CL (there might be a hidden problem with the WriteError test). I will disable that test and fix it if needed. TEST=spdy_network_transaction_unittest.cc BUG=50545 Review URL: http://codereview.chromium.org/3023029 TBR=mbelshe@google.com Review URL: http://codereview.chromium.org/3041035 TBR=lzheng@chromium.org Review URL: http://codereview.chromium.org/3082009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54398 0039d316-1c4b-4281-b951-d872f2087c98
* o3d-webgl: Skin, SkinEval and VertexSource classes.pathorn@chromium.org2010-07-3011-20/+1067
| | | | | | | | | | This allows the basic sproingie skinning demo to work. BUG=none TEST=o3d-webgl-samples/skinning.html works Review URL: http://codereview.chromium.org/3005015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54397 0039d316-1c4b-4281-b951-d872f2087c98
* Cr.js: Allow cr.define to export getters and setters.arv@chromium.org2010-07-302-2/+35
| | | | | | | | | | | There was a bug in the export code for exporting properties since it was just doing a simple [[Get]] which breaks cr.doc as well as the option to have singletons created lazily by the getter. BUG=None TEST=Options and Bookmarks should still work. Review URL: http://codereview.chromium.org/3031035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54393 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some wstrings used in ui_test.cc.evan@chromium.org2010-07-3015-60/+53
| | | | | | | | | This removes all switch-related wstring APIs from ui_test.cc, and fixes all the callers. Review URL: http://codereview.chromium.org/3066026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54392 0039d316-1c4b-4281-b951-d872f2087c98
* Refine the tool so that, it binary searches for the extensions that crashes ↵alyssad@chromium.org2010-07-301-22/+59
| | | | | | | | the browser (if there is one). Review URL: http://codereview.chromium.org/3060021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54391 0039d316-1c4b-4281-b951-d872f2087c98
* Add --enable-speech-input switch and set ENABLE_INPUT_SPEECH=1satish@chromium.org2010-07-3011-0/+75
| | | | | | | | | | | | | | | | | | Flip the compile-time enable switch for speech input to on and add a command-line switch to put the functionality behind. The command-line flag will be used both on the Chromium side and in WebKit via WebRuntimeFeatures. This CL depends on the webkit patch https://bugs.webkit.org/show_bug.cgi?id=43146 BUG=none TEST=browser_tests --gtest_filter=SpeechInputEnableSwitchTest.* Originally Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54235, but reverted due to tests failure. Review URL: http://codereview.chromium.org/3064017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54389 0039d316-1c4b-4281-b951-d872f2087c98
* More FRIEND_TEST_ALL_PREFIXES.phajdan.jr@chromium.org2010-07-3023-65/+67
| | | | | | | | | TEST=none BUG=44549 Review URL: http://codereview.chromium.org/3053024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54388 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Let task manager columns span entire window immediately.thakis@chromium.org2010-07-301-0/+1
| | | | | | | | | BUG=32148 TEST=Open task manager. It should immediately look like it did if you opened it and then resized it by 1px previously. Review URL: http://codereview.chromium.org/3056036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54387 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Give page actions a default image when preview enabled.shess@chromium.org2010-07-301-1/+10
| | | | | | | | | | | | During install it is possible to display (or layout) the action before the images have come in. Provide a default image for this case. BUG=50771 TEST=See bug. Review URL: http://codereview.chromium.org/3047031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54386 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper2 audio (trusted side) implementation. Still missing a synchronization ↵neb@chromium.org2010-07-309-2/+489
| | | | | | | | | | | for the callback setting, will be done soon. BUG=none TEST=test plugin plays music Review URL: http://codereview.chromium.org/2962003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54383 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54378 - Add content-length to spdy post request header.lzheng@chromium.org2010-07-304-115/+24
| | | | | | | | | | | | | http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac10.6%20(dbg)/builds/9160 TEST=spdy_network_transaction_unittest.cc BUG=50545 Review URL: http://codereview.chromium.org/3023029 TBR=lzheng@google.com Review URL: http://codereview.chromium.org/3041035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54381 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Incorporate 'quick' history provider index as an autocomplete ..."phajdan.jr@chromium.org2010-07-3017-350/+207
| | | | | | | | | | Broke AutocompleteEditViewTest.DesiredTLD and AutocompleteEditView.EscapeToDefaultMatch on Linux. TBR=mrossetti Review URL: http://codereview.chromium.org/3052031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54380 0039d316-1c4b-4281-b951-d872f2087c98
* Add content-length to spdy post request header.lzheng@google.com2010-07-304-24/+115
| | | | | | | | TEST=spdy_network_transaction_unittest.cc BUG=50545 Review URL: http://codereview.chromium.org/3023029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54378 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize salt_ to zero in VisitedLinkCommon.bryner@chromium.org2010-07-301-0/+3
| | | | | | | | | | | | | | Previously, this memory would remain uninitialized until the renderer received a VisitedLink_NewTable message. This was causing valgrind errors in PhishingDOMFeatureExtractorTest when WebKit computed URL fingerprints, since the test never sends a VisitedLink_NewTable message. BUG=none TEST=no valgrind errors in PhishingDOMFeatureExtractorTest Review URL: http://codereview.chromium.org/2873081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54376 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 3ziadh@chromium.org2010-07-3036-17/+77
| | | | | | | | | | | | | | | | Preventative maintenance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. These files were discovered using the -Wnon-virtual-dtor flag in g++. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3072010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54373 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54363 since it adds a runtime dependency on MSVCR80.dll.darin@chromium.org2010-07-303-23/+1
| | | | | | | | TBR=mal Review URL: http://codereview.chromium.org/3057026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54367 0039d316-1c4b-4281-b951-d872f2087c98
* Handle a case if BindContextInfo::FromBindContext fails and not leak a ↵tommi@chromium.org2010-07-301-0/+4
| | | | | | | | | | | ProtData instance. BUG=none TEST=fixes a potential memory leak. Review URL: http://codereview.chromium.org/2832097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54366 0039d316-1c4b-4281-b951-d872f2087c98
* Remove heapcheck suppression for 50583.rdsmith@google.com2010-07-301-6/+0
| | | | | | | | | BUG=50583 TEST=none Review URL: http://codereview.chromium.org/3046032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54364 0039d316-1c4b-4281-b951-d872f2087c98
* Add d3dx9_42.dll, libEGL.dll, and libGLESv2.dll to the distributed builds.darin@chromium.org2010-07-303-1/+23
| | | | | | | | R=mal Review URL: http://codereview.chromium.org/3032040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54363 0039d316-1c4b-4281-b951-d872f2087c98
* ffmpeg deps roll to fix chrome builds on 32 bit linuxfbarchard@chromium.org2010-07-301-1/+1
| | | | | | | | | BUG=50784 TEST=build chrome branded 32 bit ffmpeg Review URL: http://codereview.chromium.org/3061038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54361 0039d316-1c4b-4281-b951-d872f2087c98
* Convert DictionaryValue's keys to std::string (from wstring).viettrungluu@chromium.org2010-07-3026-201/+398
| | | | | | | | | | | | Everything now needs to be changed to avoid the deprecated wstring methods; this includes the unit tests. BUG=23581 TEST=all our tests still pass Review URL: http://codereview.chromium.org/3075010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54359 0039d316-1c4b-4281-b951-d872f2087c98
* Add a newline to the end of the unit test file.brettw@chromium.org2010-07-301-1/+1
| | | | | | TEST=it compiles git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54358 0039d316-1c4b-4281-b951-d872f2087c98
* Selection model refactoring.arv@chromium.org2010-07-306-269/+299
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3025014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54357 0039d316-1c4b-4281-b951-d872f2087c98
* Widen CoreAudio suppression.cbentzel@chromium.org2010-07-301-3/+1
| | | | | | | | | | | | | This started failing with a new caller (fun:AudioObjectAddPropertyListener) in Mac Valgrind (2) bot http://build.chromium.org/buildbot/memory/builders/Chromium%20Mac%20UI%20(valgrind)(2)/builds/3734 BUG=9351 TEST=None Review URL: http://codereview.chromium.org/3071010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54356 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-30144-838/+1464
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporate 'quick' history provider index as an autocomplete provider in ↵mrossetti@chromium.org2010-07-3017-207/+350
| | | | | | | | | | | preparation for the replacement of the current history_url_provider. This step refactors the history provider code a bit, introduces the replacement class (history-quick_provider), and adds a unittest template. Note that the 'quick' provider will only support the fast, synchronous autocomplete pass. Once the quick provider has been completed the current history_url_provider will be replaced. In the meantime, the latter will remain in operation in order to provide the slower history results. BUG=None TEST=None Review URL: http://codereview.chromium.org/3017008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54354 0039d316-1c4b-4281-b951-d872f2087c98
* Add new flimflam error codes.chocobo@chromium.org2010-07-301-1/+5
| | | | | | | | BUG=chromium-os:1078 TEST=none Review URL: http://codereview.chromium.org/3018029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54351 0039d316-1c4b-4281-b951-d872f2087c98
* Moved option-related JS classes behind options namespacezelidrag@chromium.org2010-07-3023-1557/+1808
| | | | | | | | | BUG=none TEST=make sure options still work Review URL: http://codereview.chromium.org/3027003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54350 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Add tabpose windowthakis@chromium.org2010-07-3014-1/+254
| | | | | | | | | | | | | | | | | | | | The window doesn't have any contents yet, which makes its appearance look a bit janky for now. BUG=50307 TEST= * All the following happens only if --enable-expose-for-tabs is passed in, else all of it should be disabled. * In a browser window, hit cmd-f10 or three-finger-swipe down. A grey overlay with a gradient at the top should appear. * The overlay should cover tab contents, eventual info bars, the bookmarks bar if it's detached (but not the bookmarks bar if it's not detached), and eventual attached inspector windows. It should not cover the download shelf if it's open. * The window should block clicks on the tab strip and the download shelf for now. * The overlay should close on three-finger-swipe up, click, esc, enter, and space. * Every open browser window should have its own overlay, and they should be independent of each other. * If a browser window with an overlay window is active, most menu items should be greyed out, and all browser-related keyboard shortcuts should be disabled. * In particular, hitting cmd-f10 twice should open only one overlay per browser window * The overlay should have the correct size with a UI scale factor > 1 Review URL: http://codereview.chromium.org/2819070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54349 0039d316-1c4b-4281-b951-d872f2087c98
* Revert timeout value for sync integration tests.rsimha@chromium.org2010-07-302-3/+3
| | | | | | | | | | | | | | | | The XP bots still need a longer timeout for the sync integration tests, so I'm reverting my earlier change to the timeout value. Also fixing an issue where InProcessBrowserTest::TimedOut() incorrectly reports the current value of timeout. TBR=timsteele BUG=50589,50590 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3077009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54348 0039d316-1c4b-4281-b951-d872f2087c98
* Suppression for http://crbug.com/50766cbentzel@chromium.org2010-07-301-0/+26
| | | | | | | | | BUG=50766 TEST=None Review URL: http://codereview.chromium.org/2832098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54345 0039d316-1c4b-4281-b951-d872f2087c98
* Disable tests failing on official buildersnirnimesh@chromium.org2010-07-301-0/+5
| | | | | | | | | | | | | downloads.DownloadsTest.testZip -- fails on official win builder when run thru buildbot only. runs fine when run manually codesign -- codesign tests should be run *after* the build has been signed BUG=50481 TEST=pyauto_functional_tests go green on official mac, win builders Review URL: http://codereview.chromium.org/2825078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54344 0039d316-1c4b-4281-b951-d872f2087c98
* Mark BrowserFocusTest.TabInitialFocus as FLAKY.phajdan.jr@chromium.org2010-07-301-1/+2
| | | | | | | | | | | | | | | | | We've seen some flaky flips July 19th, but it still might be caused by more recent changes like my download cleanup or other changes that have landed recently. More data in the bug. TBR=jcivelli,suzhe,oshima TEST=BrowserFocusTest.TabInitialFocus BUG=50763 Review URL: http://codereview.chromium.org/3017046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54342 0039d316-1c4b-4281-b951-d872f2087c98
* Mark KeyboardAccessTest.ReserveKeyboardAccelerator as FAILSphajdan.jr@chromium.org2010-07-301-1/+2
| | | | | | | | | | | | | It has been re-added in http://codereview.chromium.org/3029038/show TBR=pkasting (to re-route to the test author) TEST=KeyboardAccessTest.ReserveKeyboardAccelerator BUG=50760 Review URL: http://codereview.chromium.org/2819082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54341 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude AutoFillManagerTest.GetBillingSuggestionsAddress1 from running in ↵rohitrao@chromium.org2010-07-301-1/+1
| | | | | | | | | | branded builds. BUG=50537 TEST=unit_tests should pass in branded builds. Review URL: http://codereview.chromium.org/3068013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54340 0039d316-1c4b-4281-b951-d872f2087c98
* Use a plain ASCII string for the UI locale in the plugin service.evan@chromium.org2010-07-305-9/+9
| | | | | | | | Removes a few needless conversions. Review URL: http://codereview.chromium.org/3075012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54339 0039d316-1c4b-4281-b951-d872f2087c98
* Use a few more FilePaths in bookmark import.evan@chromium.org2010-07-303-11/+12
| | | | | | | | | | Removes some wstrings. BUG=24672 Review URL: http://codereview.chromium.org/2819080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54338 0039d316-1c4b-4281-b951-d872f2087c98
* Deflake ListenSocketTest.ServerSend and remove unused telnet code.agl@chromium.org2010-07-306-563/+47
| | | | | | | | | http://codereview.chromium.org/2847089/show BUG=48562 TEST=net_unittests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54336 0039d316-1c4b-4281-b951-d872f2087c98
* Add back experimental* pages for APIs that have graduatedkathyw@chromium.org2010-07-308-0/+1964
| | | | | | | | | | | | from experimental to supported. Otherwise, it's hard to know what happened to that API you were experimenting with... TEST=none BUG=none TBR=erikkay Review URL: http://codereview.chromium.org/2868084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54335 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r54074.dtseng@chromium.org2010-07-3011-11/+233
| | | | | | Review URL: http://codereview.chromium.org/3010040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54334 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize SpdyStreamMember to kInitialWindowSize.finnur@chromium.org2010-07-301-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3081004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54333 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug with detecting window sizes that match the monitor size.tony@chromium.org2010-07-301-11/+17
| | | | | | | | | | | | | | | | | | The previous code was comparing the window size to the screen size, but that doesn't work properly for twinview or other cases where there are multiple monitors that make up a single screen. Instead, compare the window size against all monitors (since we don't know which monitor the window is going to be placed on) and resize if it matches any monitor size. Also fix a bug in BoundsMatchMonitorSize where we should just be comparing sizes, not rectangle positions. BUG=32347 Review URL: http://codereview.chromium.org/3060032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54332 0039d316-1c4b-4281-b951-d872f2087c98
* When running as a remote, call gdk_notify_startup_completedavidben@chromium.org2010-07-301-0/+4
| | | | | | | | | | | | | | | | | | | | | Linux programs are expected to notify their launcher when they finish loading. GTK+ does this automatically when the first GtkWindow is opened. When acting as a remote, no window is opened, so we should manually send the notification. This could perhaps be more thorough and pass DESKTOP_LAUNCH_ID to the remote to call with gdk_notify_startup_complete_with_id, but a quick survey on codesearch suggests that no one bothers anyway. (This is reproducible in KDE. The bug report suggests some configurations of GNOME need this as well, but not yet reproducible.) R=estade BUG=45392 TEST=throbber disappears on second Chrome launch in KDE Review URL: http://codereview.chromium.org/3051023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54331 0039d316-1c4b-4281-b951-d872f2087c98
* Uninitialized member in SpdyStream.finnur@chromium.org2010-07-301-1/+2
| | | | | | | | | | | BUG=None TEST=None CID=11904 Review URL: http://codereview.chromium.org/3083006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54330 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit from 64352 to 64357.jorlow@chromium.org2010-07-301-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/3041032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54329 0039d316-1c4b-4281-b951-d872f2087c98
* Add the new notification balloon wrench icon. Part of last change but ↵johnnyg@chromium.org2010-07-302-0/+1
| | | | | | | | | | | | separated for try bot purposes. BUG=49190 TEST=none TBR=thakis Review URL: http://codereview.chromium.org/2806094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54328 0039d316-1c4b-4281-b951-d872f2087c98
* Give a better error when extension unpacking can't be done.skerner@chromium.org2010-07-302-19/+33
| | | | | | | | | | | The sandbox can not allow file access to paths that contain reparse points. Chrome tries to find a reparse point free path to the directory which will be sandboxed for extension unpacking. However, there are cases where there is no such path. See the bug for an example. In this case, give a decent error message. BUG=49530 TEST=Manually created a partition mounted in C:/mnt, mounted as drive letter, and mounted only under /Devices/HardDisk3/, tried unpacking extensions in each. Review URL: http://codereview.chromium.org/3060026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54327 0039d316-1c4b-4281-b951-d872f2087c98
* Change mac notifications UI to match the new mocks. Introduce a new utility ↵johnnyg@chromium.org2010-07-3014-196/+401
| | | | | | | | | | | | | | | | | view which provides an image based button that changes on hover and press. Refer to the bug for screenshots of the current and desired UI. Screenshot of what results from this patch is visible at http://www.corp.google.com/~johnnyg/49490patch.png XIB change: change height of title bar, change bindings of buttons. BUG=49190 TEST=notifications on the mac Review URL: http://codereview.chromium.org/3014004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54326 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 12:11:27 +0000