summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* This fixes http://code.google.com/p/chromium/issues/detail?id=2472, whichananta@chromium.org2008-10-086-4/+55
| | | | | | | | | | | | | | | | | | is an issue with popups displayed by the flash plugin in response to a user click, getting blocked. The plugin invokes NPN_Evaluate to execute the javascript. It also invokes the NPN_PushPopupEnabledState/NPN_PopupEnabledState API's to set the popup enabled stack for the duration of the call. The fix is to add the plumbing in NPN_Evaluate to pass in a flag indicating whether popups are allowed for the duration of the call. Bug=2472 Review URL: http://codereview.chromium.org/6562 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3074 0039d316-1c4b-4281-b951-d872f2087c98
* Allow lang to be blank in the renderer and plugin if running intc@google.com2008-10-081-2/+5
| | | | | | | single process mode. Review URL: http://codereview.chromium.org/5602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3073 0039d316-1c4b-4281-b951-d872f2087c98
* Constrained window title text colors are inverted.ben@chromium.org2008-10-081-1/+1
| | | | | | | http://crbug.com/3249 Review URL: http://codereview.chromium.org/6367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3072 0039d316-1c4b-4281-b951-d872f2087c98
* Always position and size the toolbar view, since it's used to position other ↵ben@chromium.org2008-10-081-17/+18
| | | | | | | | | | elements. Regression from changelist earlier today. Review URL: http://codereview.chromium.org/6365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3071 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Gears build:mpcomplete@google.com2008-10-082-1/+5
| | | | | | | | | - remove accidental print statement. - add a check that the p4 tree is checked out where we expect it, and if not, exit. Review URL: http://codereview.chromium.org/6598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3070 0039d316-1c4b-4281-b951-d872f2087c98
* Add a flaky layout test to exceptions.ericroman@google.com2008-10-081-1/+2
| | | | | | Review URL: http://codereview.chromium.org/6599 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3069 0039d316-1c4b-4281-b951-d872f2087c98
* - Add auth integration tests to http_network_transaction_unitttest.ccericroman@google.com2008-10-083-14/+276
| | | | | | | | - Add unique error code for when origin server returns 407. Review URL: http://codereview.chromium.org/4334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3067 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the window icon is set to at least the app icon as the window is ↵ben@chromium.org2008-10-081-8/+5
| | | | | | | | | created, so it shows up in places like Alt+Tab, etc. http://crbug.com/3100 Review URL: http://codereview.chromium.org/6358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3066 0039d316-1c4b-4281-b951-d872f2087c98
* remove unneeded webkit_glue:: and wrap windows functions in ifdefserg@google.com2008-10-083-12/+16
| | | | | | | | Review URL: http://codereview.chromium.org/6413 Patch from icefox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3065 0039d316-1c4b-4281-b951-d872f2087c98
* Unrollback 3024 (partially rolled back in 3027).ericroman@google.com2008-10-087-88/+10
| | | | | | | | It is fixed in mac build now -- problem was bad format string to StringPrintf, where passed string instead of char*. Review URL: http://codereview.chromium.org/6359 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3064 0039d316-1c4b-4281-b951-d872f2087c98
* Update the SCons build for the WebKit merge:sgk@google.com2008-10-088-282/+559
| | | | | | | | | | | | | | | | | * Update relevant file lists. * Modify CPPPATH directory lists to mirror the VS build. * Add new command-line defines. * Remove an incorrect /css/ subdirectory from the generated CSS*.in paths so the DAG properly hooks them up with the right source files. * Change the idiom when we exclude files that just haven't been ported yet: keep all the to-be-ported files on the global list, and explicitly remove them on the necessary platforms. (This should make it a little easier to verify that we have all the right files, and the config change when porting a file will be to just delete the relevant line.) * Comment the use of addRepository(). Review URL: http://codereview.chromium.org/6323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3063 0039d316-1c4b-4281-b951-d872f2087c98
* Change the font search order to try Lucida Sans Unicode before Arial Unicode ↵jungshik@google.com2008-10-0826-253/+254
| | | | | | | | | | | | | | | | | | MS because the former is available on Windows XP or later while the latter is only available with MS Office installed. This is partly to make font-dependent layout test results 'invariant' with or without Arial Unicode MS installed. Eventually, we may want to make those tests more robust against the font availability by removing some Unicode characters not commonly available. BUG=2304 TEST=pass the layout tests affected Review URL: http://codereview.chromium.org/6495 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3062 0039d316-1c4b-4281-b951-d872f2087c98
* This file was supposed to get committed during my last refactoring chunk but ↵pkasting@chromium.org2008-10-081-3/+4
| | | | | | | | got left out by mistake. Review URL: http://codereview.chromium.org/5659 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3061 0039d316-1c4b-4281-b951-d872f2087c98
* Pass NotificationSource by const ref rather than value, as it's a class (and ↵pkasting@chromium.org2008-10-082-4/+4
| | | | | | | | this matches NotificationObserver). Review URL: http://codereview.chromium.org/6468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3060 0039d316-1c4b-4281-b951-d872f2087c98
* Update a comment based on our findings today.pkasting@chromium.org2008-10-081-4/+4
| | | | | | Review URL: http://codereview.chromium.org/6463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3059 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pixel tests broken by my wdiff change.evanm@google.com2008-10-081-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3058 0039d316-1c4b-4281-b951-d872f2087c98
* Klocwork bug. The dtor of Win2kThreadpool needs to be virtual sincecpu@google.com2008-10-083-23/+14
| | | | | | | | | | | the object is destroyed thru the base. - Removed UnRegisterWait loop in dtor. BUG=3108 Review URL: http://codereview.chromium.org/6247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3057 0039d316-1c4b-4281-b951-d872f2087c98
* Reuse a method that will be required for criteria checker as well.kuchhal@chromium.org2008-10-084-35/+23
| | | | | | Review URL: http://codereview.chromium.org/6587 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3056 0039d316-1c4b-4281-b951-d872f2087c98
* Build some code and unit tests inside chrome. This depended on sqlite, somark@chromium.org2008-10-084-5/+3460
| | | | | | | adding that too. Review URL: http://codereview.chromium.org/6361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3055 0039d316-1c4b-4281-b951-d872f2087c98
* Add win32 installer to Gears SConscripts.mpcomplete@google.com2008-10-083-74/+184
| | | | | | Review URL: http://codereview.chromium.org/6591 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3054 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tree breakage by referencing correct open-vcdiff directory.erg@google.com2008-10-081-1/+1
| | | | | | | | | TBR=jar Review URL: http://codereview.chromium.org/6364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3053 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes leak in new test.sky@google.com2008-10-081-2/+3
| | | | | | | | | BUG=none TBR=pkasting Review URL: http://codereview.chromium.org/6362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3052 0039d316-1c4b-4281-b951-d872f2087c98
* Make Mac clipboard code tolerant of nil clipboard without crashing. Add amark@chromium.org2008-10-081-30/+36
| | | | | | | DCHECK to catch this case, and clean up some of the clipboard code. Review URL: http://codereview.chromium.org/6580 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3051 0039d316-1c4b-4281-b951-d872f2087c98
* Provide converters to and from NSString* in sys_string_conversionsmark@chromium.org2008-10-085-8/+77
| | | | | | Review URL: http://codereview.chromium.org/6355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3050 0039d316-1c4b-4281-b951-d872f2087c98
* Remove include to file that does not exist and sign comparison compiler warning.erg@google.com2008-10-082-3/+2
| | | | | | | | Review URL: http://codereview.chromium.org/6218 Patch from icefox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3049 0039d316-1c4b-4281-b951-d872f2087c98
* Use wdiff to produce expected output.evanm@google.com2008-10-085-8/+44
| | | | | | | | | | | It's enabled by a --wdiff flag to run_webkit_tests. (DEPS update is to pull in new cygwin with wdiff.exe.) Example output: http://neugierig.org/drop/inline-crash-wdiff-win.html Review URL: http://codereview.chromium.org/6330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3048 0039d316-1c4b-4281-b951-d872f2087c98
* Removing old vcdiff hierarchy (replaced by sdch/open-vcdiff pulled separately)jar@google.com2008-10-08120-82593/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3047 0039d316-1c4b-4281-b951-d872f2087c98
* Comparison between signed and unsignederg@google.com2008-10-082-2/+2
| | | | | | | | Review URL: http://codereview.chromium.org/6411 Patch from icefox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3046 0039d316-1c4b-4281-b951-d872f2087c98
* Mac build breakage. Revert 3035 & 3040.maruel@google.com2008-10-0810-19/+3533
| | | | | | Review URL: http://codereview.chromium.org/6357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3045 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused static functionerg@google.com2008-10-082-13/+2
| | | | | | | | Review URL: http://codereview.chromium.org/6216 Patch from icefox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3044 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs leading to a layout test failure:sky@google.com2008-10-085-5/+17
| | | | | | | | | | | | | | . Our Document.idl was not up to date. This resulted in an error when the JavaScript tried to execute a function on Document. . Our code to write a SkBitmap to a BMP was writing colors premultiplied. It shouldn't do that. BUG=2973 TEST=layout test fix Review URL: http://codereview.chromium.org/6348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3043 0039d316-1c4b-4281-b951-d872f2087c98
* base/logging.h defines LOG when webkit is about to so undef iterg@google.com2008-10-082-2/+3
| | | | | | | | Review URL: http://codereview.chromium.org/6204 Patch from icefox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3042 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo I noticed when looking at object tracking. The wrong argument wasbrettw@google.com2008-10-081-1/+1
| | | | | | | given to the printf. Review URL: http://codereview.chromium.org/6356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3041 0039d316-1c4b-4281-b951-d872f2087c98
* Update Xcode project to match http://codereview.chromium.org/6353/amanda@chromium.org2008-10-081-11/+9
| | | | | | Review URL: http://codereview.chromium.org/6595 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3040 0039d316-1c4b-4281-b951-d872f2087c98
* Use Skia on Linux alsoerg@google.com2008-10-082-4/+4
| | | | | | | | Review URL: http://codereview.chromium.org/6410 Patch from icefox. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3039 0039d316-1c4b-4281-b951-d872f2087c98
* Make it so that you can resize glass windows from the bottom.ben@chromium.org2008-10-081-1/+2
| | | | | | | | http://crbug.com/2483 Review URL: http://codereview.chromium.org/6593 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3038 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled the drag and drop of images and links in the blocking pages to ↵jcampan@chromium.org2008-10-085-33/+11
| | | | | | | | | | | | prevent bad navigations. Removed an unused file as well. BUG=3235 TEST=Trigger a blocking page (ex: https://ebay.com). Try dragging the warning image and link around. This should not do anything. Review URL: http://codereview.chromium.org/6590 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3037 0039d316-1c4b-4281-b951-d872f2087c98
* External contribution from developer0420@gmail.com. Pressing enter insky@google.com2008-10-081-3/+5
| | | | | | | | | | | | the bookmark bubble when focus is on the edit button should start editing. BUG=2863 TEST=Bring up the bookmark bubble, move focus to the edit button and press enter. Make sure the editor comes up. Review URL: http://codereview.chromium.org/6594 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3036 0039d316-1c4b-4281-b951-d872f2087c98
* DeleteButtonController was left over from previous unforkage.dglazkov@google.com2008-10-089-3522/+10
| | | | | | Review URL: http://codereview.chromium.org/6353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3035 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix more standard non-client painting by extending the client ↵ben@chromium.org2008-10-082-10/+14
| | | | | | | | | | area of the frame to the top of the window. http://crbug.com/3246 Review URL: http://codereview.chromium.org/6349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3034 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem with popups frames when magic_browzr.erg@google.com2008-10-081-9/+18
| | | | | | | | | Some code got committed which made assumptions which were only true when magic_browzr was on. Review URL: http://codereview.chromium.org/5649 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3033 0039d316-1c4b-4281-b951-d872f2087c98
* Hackish changes to make gears work in the renderer with the sandbox.mpcomplete@google.com2008-10-084-0/+52
| | | | | | Review URL: http://codereview.chromium.org/6434 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3032 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes to the experimental bloom filter storage code.paulg@google.com2008-10-083-46/+69
| | | | | | | | | | | Update the unittest to handle the bloom filter storage implementation and fix a test scenario. This change does not affect the current working implementation. Review URL: http://codereview.chromium.org/6513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3031 0039d316-1c4b-4281-b951-d872f2087c98
* Klocwork bug. Checking the wrong variable.cpu@google.com2008-10-081-7/+12
| | | | | | | | BUG = 3103 Review URL: http://codereview.chromium.org/6453 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3030 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 3024, broke mac build.maruel@google.com2008-10-087-10/+88
| | | | | | Review URL: http://codereview.chromium.org/6351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3027 0039d316-1c4b-4281-b951-d872f2087c98
* changes to get mac layout tests moving forward. Turn off objc GC and remove ↵pinkerton@google.com2008-10-082-4/+3
| | | | | | | | asserts in the plugin stub code that throw off the layout tests. Review URL: http://codereview.chromium.org/6588 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3026 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ownerNode-lifetime-expected-2.html.ericroman@google.com2008-10-082-2/+1
| | | | | | | | The problem is, with the new version of WebKit <link> nodes will only have a sheet created for them if they have href attribute (so the src attribute to non-existant css doesn't work). Review URL: http://codereview.chromium.org/6325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3025 0039d316-1c4b-4281-b951-d872f2087c98
* Pull in new googleurl@94 which includes GURL::EffectiveIntPort().ericroman@google.com2008-10-088-89/+11
| | | | | | | | Update callers to use this method. Review URL: http://codereview.chromium.org/5641 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3024 0039d316-1c4b-4281-b951-d872f2087c98
* Re-baseline svg-as-background since we actually get this righttc@google.com2008-10-086-80/+6
| | | | | | | | | | (the checked in image is wrong). Mark 3 tests as failing for a reason. The images checked in for maskRegions is wrong, so I just deleted it. Review URL: http://codereview.chromium.org/6585 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3023 0039d316-1c4b-4281-b951-d872f2087c98
* Use the new HTTP stack by default in the net module'swtc@google.com2008-10-084-1/+9
| | | | | | | | | | | | | | | | tests, but continue to use WinHTTP by default in the test shell and chrome. The mapping of CRYPT_E_NO_REVOCATION_CHECK to ERR_CERT_NO_REVOCATION_MECHANISM (a certificate error code) is necessary to make the HTTPSTestServer's start and shutdown GET commands work. (The TestDelegate ignores all certificate errors.) R=darin Review URL: http://codereview.chromium.org/6472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3022 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 02:06:14 +0000