summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert part of "Remove deprecated CommandLine::GetLooseValues(), rename to ↵evan@chromium.org2010-07-224-16/+16
| | | | | | | | | | | args()." We will need to reapply this once o3d updates to current base/. This reverts part of commit r53193. Review URL: http://codereview.chromium.org/2854058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53280 0039d316-1c4b-4281-b951-d872f2087c98
* Always refresh the desktop size before showing notifications. This should ↵johnnyg@chromium.org2010-07-211-0/+1
| | | | | | | | | | | prevent all the corner cases of misplacement being reported. BUG=various TEST=change desktop size, show notifications Review URL: http://codereview.chromium.org/2824061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53277 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill Empty profiles should not be saved from AutoFillDialog Add and Edit ↵dhollowa@chromium.org2010-07-217-31/+121
| | | | | | | | | | | | | | | sheets on Mac. Changes the AutoFillDialog on Mac to not store intermediate results of "Add" and "Edit" actions when those actions result in empty address or credit card information. Empty addresses and credit card information is culled at this level now, not just after "Save" from the main dialog. BUG=47742 TEST=AutoFillDialogControllerTest.AddNewProfile, AutoFillDialogControllerTest.AddNewEmptyProfile, AutoFillDialogControllerTest.AddNewCreditCard, AutoFillDialogControllerTest.AddNewEmptyCreditCard Review URL: http://codereview.chromium.org/3061001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53276 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in chrome/test/functional/codesign.pyalyssad@chromium.org2010-07-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3033015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53274 0039d316-1c4b-4281-b951-d872f2087c98
* Quick fix for window sizing under resolution independence on Mac. Scrolling ↵avi@chromium.org2010-07-211-6/+10
| | | | | | | | | | | and the "more" arrows are still broken, but this at least makes things usable. BUG=http://crbug.com/19476 TEST=run app under high-res, click bookmark bar button, see that the popup is sized to hold the buttons. Review URL: http://codereview.chromium.org/3029020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53272 0039d316-1c4b-4281-b951-d872f2087c98
* Add python script that can add "#pragma once" to all our files.thakis@chromium.org2010-07-211-0/+49
| | | | | | Review URL: http://codereview.chromium.org/2842064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53271 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit from 63842:63859tony@chromium.org2010-07-211-1/+1
| | | | | | | | TBR=senorblanco Review URL: http://codereview.chromium.org/3060003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53270 0039d316-1c4b-4281-b951-d872f2087c98
* Change EXPECT_TRUE(false) to the more readable ADD_FAILURE()cmasone@google.com2010-07-211-1/+1
| | | | | | | | | BUG=None TEST=run unit tests Review URL: http://codereview.chromium.org/3061002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53269 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: when closing a browser window, cancel the active drag session.estade@chromium.org2010-07-213-0/+15
| | | | | | | | | | | This speculatively works around an issue where users' windows would get stuck open in rare (non-reproducible, but widely reported) cases. BUG=23733 TEST=none :( Review URL: http://codereview.chromium.org/2888027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53268 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53264 - wiptony@chromium.org2010-07-211-1/+1
| | | | | | | | | | | | The commit message is incomplete. I'll reland with the correct commit message. Review URL: http://codereview.chromium.org/2832067 TBR=tony@chromium.org Review URL: http://codereview.chromium.org/2834063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53267 0039d316-1c4b-4281-b951-d872f2087c98
* comment for what linearscale isfbarchard@chromium.org2010-07-211-1/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2883032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53266 0039d316-1c4b-4281-b951-d872f2087c98
* Fix valgrind error in OwnerManagerTest.ExportImportPublicKeycmasone@google.com2010-07-211-0/+2
| | | | | | | | | | | | | I was taking ownership of an object from NSS and then forgetting to free it :-/ BUG=49847 TEST=Ran unit test in question under valgrind Now you don't even need to land http://codereview.chromium.org/2873057/show :-) Review URL: http://codereview.chromium.org/2819060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53265 0039d316-1c4b-4281-b951-d872f2087c98
* wiptony@chromium.org2010-07-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/2832067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53264 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored the customize dialog UI. tim@chromium.org2010-07-211-159/+207
| | | | | | | | | | Original patch by dudley@chromium.org (http://codereview.chromium.org/2861069) BUG=49704 Review URL: http://codereview.chromium.org/3019014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53263 0039d316-1c4b-4281-b951-d872f2087c98
* Adding some sample code showing usage of contextMenu API.asargent@chromium.org2010-07-213-0/+77
| | | | | | | | | | BUG=49687 TEST=none TBR=rafaelw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53258 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Mark CheckFalseTest.CheckFails as FAILS.thestig@chromium.org2010-07-211-0/+3
| | | | | | | | BUG=49838 TEST=none Review URL: http://codereview.chromium.org/2870063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53257 0039d316-1c4b-4281-b951-d872f2087c98
* sync: fixes crash that happens when you disable a datatype while there are ↵tim@chromium.org2010-07-214-8/+108
| | | | | | | | | | | | | | | | unsynced / unapplied items pertaining to that type. Added CHECKs to SafeToPurgeFromMemory to see if we catch any stack traces there and confirm that this is indeed happening. BUG=49278 TEST=SyncerTest.TestPurgeWhileUnsynced + TestPurgeWhileUnapplied Review URL: http://codereview.chromium.org/2806064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53256 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind Mac: Widen a suppression.thestig@chromium.org2010-07-211-4/+4
| | | | | | | | | BUG=30264 TEST=none TBR=stuartmorgan Review URL: http://codereview.chromium.org/3032013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53255 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53247 - Links opening up in the host browser in ChromeFrame would not ↵sanjeevr@chromium.org2010-07-212-20/+0
| | | | | | | | | | | | | | | | | | | | show up as visited. This was because top level link navigations are directly sent via the OpenURL mechanism to the host browser and as a result the visited link history is not updated. Fix is to update the navigation history in the ExternalTabContainer::OpenURLFromTab function. We currently use the UpdateHistoryForNavigation function in TabContents which is also used by regular navigations initiated within the renderer. Fixes bug http://code.google.com/p/chromium/issues/detail?id=37262 Bug=37262 Review URL: http://codereview.chromium.org/3020019 TBR=ananta@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53253 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling ppapi to v169.dumi@chromium.org2010-07-211-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/3022016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53248 0039d316-1c4b-4281-b951-d872f2087c98
* Links opening up in the host browser in ChromeFrame would not show up as ↵ananta@chromium.org2010-07-212-0/+20
| | | | | | | | | | | | | | | | | | visited. This was because top level link navigations are directly sent via the OpenURL mechanism to the host browser and as a result the visited link history is not updated. Fix is to update the navigation history in the ExternalTabContainer::OpenURLFromTab function. We currently use the UpdateHistoryForNavigation function in TabContents which is also used by regular navigations initiated within the renderer. Fixes bug http://code.google.com/p/chromium/issues/detail?id=37262 Bug=37262 Review URL: http://codereview.chromium.org/3020019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53247 0039d316-1c4b-4281-b951-d872f2087c98
* Start trimming headers included in the slowest to compile files.erg@google.com2010-07-2123-61/+106
| | | | | | | | | | | Big chunk in the automation code. BUG=none TEST=none Review URL: http://codereview.chromium.org/3056007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53246 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Let interactive_ui_tests load nibs.thakis@chromium.org2010-07-211-0/+2
| | | | | | | | | | | The problem was that all objc symbols get stripped, and the nib resolving mechanism relied on them. BUG=22515,21276 TEST=Patch in http://codereview.chromium.org/2986004 , run `xcodebuild/Debug/interactive_ui_tests --gtest_filter=BrowserKeyEventsTest.NormalKeyEvents`. Shouldn't crash. Review URL: http://codereview.chromium.org/2847065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53245 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad from r627 to r628 to pick up:mark@chromium.org2010-07-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Separate the "hello" message from the parameter messages in Inspector::ReadMessages as was done before r627. The "hello" message contains the parameter count and is referenced while the message reader loops through parameter messages. Prior to r627, both messages were named |message|, which was confusing, probably caused a compiler warning, and apparently provided the motivation to share them. This caused the crash inspector to fail to properly collect the parameters. The common failure mode (although others are possible) was for the inspector to attempt tor read more parameter messages than were available, resulting in an IPC timeout and inspector death. No crash report would be written, and the application expecting its crash to be inspected would time out waiting for a response from the inspector and then _exit. Thisis effectively a failure to properly handle crashes. The inner message is reintroduced, and named parameter_message for disambiguation. BUG=49821 TEST= - Crashes catchable by the Mac Breakpad framework. - about:crash and its browser equivalent works and produces crash dumps in ~/Library/Breakpad/Chrome_Mac Review URL: http://codereview.chromium.org/2842063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53244 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind/Heapchecker: Suppress leaks for LoadTimingObserverTest.thestig@chromium.org2010-07-212-0/+13
| | | | | | | | BUG=49828 TEST=none Review URL: http://codereview.chromium.org/3058005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53243 0039d316-1c4b-4281-b951-d872f2087c98
* fix build breakage caused by merge error.oshima@chromium.org2010-07-211-3/+3
| | | | | | | | | | TBR=krasimira@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/2809065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53242 0039d316-1c4b-4281-b951-d872f2087c98
* Send UnlockCompleted signal even if screen lock is already present.oshima@chromium.org2010-07-212-7/+39
| | | | | | | | | BUG=chromium-os:4827 TEST=new test TestShowTwice Review URL: http://codereview.chromium.org/2854055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53241 0039d316-1c4b-4281-b951-d872f2087c98
* If we're setting a frame's content settings based on its opener,japhet@chromium.org2010-07-211-3/+6
| | | | | | | | | | | | null check the opener's WebView before using it. BUG=42974 TEST=Flaky, no known repro steps Review URL: http://codereview.chromium.org/2850037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53240 0039d316-1c4b-4281-b951-d872f2087c98
* Used the service utility process host to render PDFs in a sandbox for the ↵sanjeevr@chromium.org2010-07-215-170/+369
| | | | | | | | | | | Windows cloud print proxy. Also made the print spooling asynchronous. BUG=None TEST=Test cloud print proxy on all supported platforms. Review URL: http://codereview.chromium.org/3051006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53238 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the regex used to test for the Mac platform.kurrik@chromium.org2010-07-211-1/+1
| | | | | | | | | BUG=49809 TEST=None Review URL: http://codereview.chromium.org/2805097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53237 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt at trying to land buggy bho avoidance: ↵tommi@chromium.org2010-07-218-69/+308
| | | | | | | | | | | | | | | | | | http://codereview.chromium.org/3031009 A different approach to avoid crashes in buggy 3rd party BHOs.This time we're more preceise and only target the buggy components.Behaviour for components that handle browser events correctly, is unchanged even in the presence of buggy DLLs.The core class here is the BuggyBhoTls class and here's the comment for that class: // Construct an instance of this class on the stack when firing web browser // events that can be sent to buggy BHOs. This class will intercept those // BHOs (see list in cc file) and ignore notifications to those components // for as long as the BuggyBhoTls instance on the stack lives. TEST=A better fix for bug 44463 but also fixes bug 49373 and a number of crashes that haven't been associated with bug reports yet. BUG=44463, 49373 Review URL: http://codereview.chromium.org/3053008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53236 0039d316-1c4b-4281-b951-d872f2087c98
* Use check item for side tab menu.oshima@chromium.org2010-07-214-7/+14
| | | | | | | | | BUG=chromium-os:4948 TEST=manual: toggle side tab from wrench menu and side tab menu will be checked. Review URL: http://codereview.chromium.org/3034021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53235 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for: State in small letters should be auto-filled from the profile.jhawkins@chromium.org2010-07-216-1/+88
| | | | | | | | | | | BUG=38222 TEST=in the bug Patch by George Yakovleg <georgey@chromium.org> Review URL: http://codereview.chromium.org/2832064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53234 0039d316-1c4b-4281-b951-d872f2087c98
* Address Finnur's review comments (variable names and comments) that werejshin@chromium.org2010-07-214-6/+12
| | | | | | | | | | | | | | dropped inadvertently when landing from a machine other than one where the original CL was written. In addition, adjust Tamil and Malayalam UI dimensions for XP. BUG=48202 TEST=In Tamil and Malyalam Chrome on XP, content-settings dialog do not have anytruncation. TBR=finnur Review URL: http://codereview.chromium.org/3015011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53233 0039d316-1c4b-4281-b951-d872f2087c98
* Fix transforms to be preconcat like skia so multiple transforms are ↵ben@chromium.org2010-07-212-4/+35
| | | | | | | | | | | accumulated with each call to TranslateInt/ScaleInt. BUG=none TEST=see unittest Review URL: http://codereview.chromium.org/3025010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53232 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor SSLClientAuthHandler and certificate selectiondavidben@chromium.org2010-07-2115-110/+392
| | | | | | | | | | | | | | | | | | | | | | | | | This cleans up much of the code involved in displaying a certificate selection dialog to the user. - Adds a new inner class to RenderViewHostDelegate (later to be populated with more SSL things). - Adds a helper class for TabContents' implementation. - Moves the certificate dialogs themselves to have a common entry point. - Makes SSLClientAuthHandler call the RVHDelegate to query the user, with the TabContents implementation displaying the dialogs. - Picks the correct parent window for the dialog on all platforms, instead of relying on BrowserList::GetLastActive - Makes the OS X implementation use an asynchronous sheet, now that we know the parent. - Fixes an index-mismatch problem in the OS X implementation, should we fail to create an identity. R=agl,brettw,mark BUG=148 TEST=selecting client certificates still works Review URL: http://codereview.chromium.org/2823038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53231 0039d316-1c4b-4281-b951-d872f2087c98
* Make conditional requests when updating the appcache.michaeln@chromium.org2010-07-213-88/+172
| | | | | | | | | TEST=altered existing tests to also cover this case BUG=49548 Review URL: http://codereview.chromium.org/3033003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53230 0039d316-1c4b-4281-b951-d872f2087c98
* Increase network state change notification delay to 2seconds.oshima@chromium.org2010-07-211-2/+2
| | | | | | | | | BUG=chromium-os:4825 TEST=none Review URL: http://codereview.chromium.org/3031016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53229 0039d316-1c4b-4281-b951-d872f2087c98
* Print a better error message when someone passes the wrong parameters tompcomplete@chromium.org2010-07-211-1/+5
| | | | | | | | | | | sendRequest. BUG=46094 TEST=no Review URL: http://codereview.chromium.org/3005022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53228 0039d316-1c4b-4281-b951-d872f2087c98
* Land for njw:chocobo@chromium.org2010-07-215-6/+15
| | | | | | | | | | | | | | Make NetworkLibrary::UpdateSystemInfo() externally usable, and invoke it before retrieving/displaying network information, so that we successfully display data that the user has just changed via another mechanism. BUG=chromium-os:3972 TEST=Configure certificates via entd and log out. Log back in and select the network menu, then (immediately) the relevant SSID. Check for the proper certificate information, rather than unset fields. Review URL: http://codereview.chromium.org/3019015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53227 0039d316-1c4b-4281-b951-d872f2087c98
* Exit Fullscreen when screen is lockedoshima@chromium.org2010-07-214-11/+113
| | | | | | | | | BUG=chromium-os:4212 TEST=TestFullscreenExit added Review URL: http://codereview.chromium.org/2832063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53226 0039d316-1c4b-4281-b951-d872f2087c98
* Enable stack dumps in DRT.tony@chromium.org2010-07-212-1/+8
| | | | | | | | This matches what's happening in test_shell. Review URL: http://codereview.chromium.org/3049003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53225 0039d316-1c4b-4281-b951-d872f2087c98
* Conditionally draw a bezel below text fields, used for the omnibox.pinkerton@chromium.org2010-07-213-5/+39
| | | | | | | | BUG=49793 TEST=visual inspection. unit tests shouldn't leak or crash on drawing. Review URL: http://codereview.chromium.org/3042014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53224 0039d316-1c4b-4281-b951-d872f2087c98
* Fix deadlock by introducing a new transaction event.chron@chromium.org2010-07-214-15/+52
| | | | | | | | This is still going through the trybots now. Review URL: http://codereview.chromium.org/2805095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53223 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit r63817:63842.senorblanco@google.com2010-07-211-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=tc Review URL: http://codereview.chromium.org/3017019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53222 0039d316-1c4b-4281-b951-d872f2087c98
* UpdateZoomControls honors the global enabled state of the zoom commands.sanjeevr@chromium.org2010-07-211-2/+9
| | | | | | | | | BUG=None TEST=Test zooming. Review URL: http://codereview.chromium.org/3055006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53221 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the browser fetch the translate script regularly.jcivelli@chromium.org2010-07-2110-76/+141
| | | | | | | | | | | | | | New versions of that script may get pushed from time to time. Fetching the script again ensures people that don't restart their browser for long periods of time still get the new versions. Also renamed the enum from constant style to macro-style, as it is the Chromium way to go from the Chromium style guide (which is in that regard different than the Google style guide). BUG=None TEST=Run the unit-tests. Review URL: http://codereview.chromium.org/3034013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53220 0039d316-1c4b-4281-b951-d872f2087c98
* Update the sync node title for classic autofill to bealbertb@chromium.org2010-07-212-3/+2
| | | | | | | | | | | "autofill_entry|$name|$value". BUG=40876 TEST=none Review URL: http://codereview.chromium.org/3005013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53219 0039d316-1c4b-4281-b951-d872f2087c98
* Implement initial ClipRect.ben@chromium.org2010-07-217-73/+112
| | | | | | | | | | | Move IntersectsClipRectInt and GetClipRect functions to CanvasSkia private, since they are only used internally. BUG=none TEST=see unittest. Review URL: http://codereview.chromium.org/2959014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53218 0039d316-1c4b-4281-b951-d872f2087c98
* Download code cleanup:phajdan.jr@chromium.org2010-07-213-48/+71
| | | | | | | | | | | | | | | | | | | | Changed the code to be more object-oriented. Instead of exposing 150 accessors we should do as much as possible inside the object, exposing a nice API. DownloadFile just got a small step closer to that. Also, reduce amount of state duplication. For example, information about the download progress was both in DownloadFile and DownloadFileManager (maybe it's still somewhere else). The download path information is still duplicated, removing it is going to be harder. Finally, removed completely unused state variables from DownloadFile. TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/3026012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53217 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 03:11:25 +0000