| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
It depends on http://codereview.chromium.org/126046
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155912
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159692
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
still broke valgrind ui_tests.
Review URL: http://codereview.chromium.org/159694
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
valgrind test failure.
This CL implements the second TODO item of issue 12343:
2) We should send back an ACK to the second process. If the second process doesn't get an ACK in the given timeout, it should kill the first process and go ahead and start.
The approach of this CL is to append process id to the singleton's socket filename, such as "SingletonSocket-12345", and creates a symbol link "SingletonSocket" to the real socket file. In ProcessSingleton::NotifyOtherProcess() if it's successfully connected to "SingletonSocket" but no ACK received, then the original process can be killed by its process id retrieved from the symbol link.
BUG=http://crbug.com/12343 ProcessSingleton Linux cleanups
TEST=In one terminal, launch chrome and stop the process by pressing ctrl-z, then launch chrome again in another terminal. The second chrome shall be started in 5 seconds, and the first one shall be killed.
Review URL: http://codereview.chromium.org/160436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This would remove the download list (CTRL+J) as well.
BUG=60 (http://crbug.com/60)
TEST=Download a file from the net, download shelf appears, click the download item's arrow and "Remove from list". The item removes from the shelf and list.
Review URL: http://codereview.chromium.org/155749
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
foreground.
BUG=none
TEST=tabs opened via "Open link in new tab..." should open in foreground, not background.
Review URL: http://codereview.chromium.org/155671
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/160439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A "Remove from list" link would be added to the download items and once clicked, it will remove it from the shelf and list.
BUG=60 (http://crbug.com/60)
TEST=Download a file from the net, CTRL+J. Click on "Remove from list". The item removes from the list and download shelf.
Review URL: http://codereview.chromium.org/155750
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13907
Review URL: http://codereview.chromium.org/160435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=15267,17974
Review URL: http://codereview.chromium.org/159685
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159682
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=18046
TEST=media_unittests --gtest_filter=FFmpegDemuxerTest.ProtocolRead
FFmpeg may read over the size of a file. When it happens we
should return AVERROR_EOF.
Review URL: http://codereview.chromium.org/159679
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Perhaps this got in from git not running
gcl lint / gcl presubmit checks?
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159678
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Through extensive testing Antoine concluded that our behavior is correct,
so let's have our test verify we don't regress this.
BUG=15907
Review URL: http://codereview.chromium.org/160375
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gtk_util/gtk_tree_util.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160417
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
too slow.
TEST=none
http://crbug.com/18122
Review URL: http://codereview.chromium.org/160430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This crash is caused by a race condition when the media
pipeline is shutting down.
Here is a sequence that leads to crash:
1. PipelineImpl::Stop() is called.
2. BufferedDataSource::Stop() is called on pipeline thread.
BufferedDataSource::StopTask() is posted on render thread.
3. BufferedDataSource::StopTask() is executed.
4. BufferedDataSource::Read() is called on demuxer thread.
5. BufferedDataSource::ReadTask() is executed. *bang*
The cause of the crash is the involvement of three threads
and it happens that ReadTask() is executed after StopTask().
Since we cannot prevent BufferedDataSource::Read() being
called by FFmpegDemuxer since the stop signal hasn't arrived
at the demuxer yet. This change will suppress activity of
data source after the stop task executed.
I didn't reuse the |stopped_| variable to suppress activity
but instead introduce another |stop_task_executed_| signal
because |stopped_| is prevent the data source from making
callbacks to the demuxer after stopped has received. And by
doing this we don't need to introduce an additional critical
section which is not desirable.
Review URL: http://codereview.chromium.org/159675
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159649
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keyboard handling was significantly changed for IMEs to work, and
in the process test_shell was broken. This change is just enough
to get plain ASCII text working again, which is at least useful
for diagnosing e.g. gmail bugs.
BUG=18115
Review URL: http://codereview.chromium.org/159673
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16738
TEST=run the media LayoutTests
Review URL: http://codereview.chromium.org/159669
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=16161
Review URL: http://codereview.chromium.org/160429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It also fixes some small problems with the build (naming of plugin DLL and
activex host dll)
Review URL: http://codereview.chromium.org/160428
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/159662
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the call is async, we need to manually tell Browser that
we're no longer in full screen mode.
BUG=18104
Review URL: http://codereview.chromium.org/159670
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Mac.
I can't reproduce locally, but the code should give enough info after one crash.
TEST=none
http://crbug.com/18036
Review URL: http://codereview.chromium.org/160421
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=make your browser very narrow in debug mode, it doesn't crash
Review URL: http://codereview.chromium.org/159665
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It was contributing to test flakiness. I also updated a comment explaining why the code doesn't kill the plugin process.
TEST=none
http://crbug.com/18108
Review URL: http://codereview.chromium.org/159602
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally reviewed at: http://codereview.chromium.org/159642
Patch by Anton Muhin
R=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159666
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17632
Review URL: http://codereview.chromium.org/159664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18071
Review URL: http://codereview.chromium.org/160422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159657
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=16738
TEST=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/160425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160415
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also reverting 22065/22046/22041 which are changes to knowncrashes.txt.
TBR=huanr
Review URL: http://codereview.chromium.org/160418
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a few bugs of button sensitivity not updating when it should.
Add the unittest to the valgrind/unit_tests.gtest_linux.txt list since Gtk is
causing UninitCondition errors when run with no DISPLAY.
BUG=11507
BUG=15445
Review URL: http://codereview.chromium.org/160420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original review: http://codereview.chromium.org/159653
R=darin,pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the issues caused by static_cast<ChromeURLRequestContext*>.
There were assumptions in the code that a URLRequestContext*
will always be ChromeURLRequestContext* and resulting
'static_cast's. This assumption is no longer true. Instead,
URLlRequestContext now has a member GetChromeURLRequestContext
that returns a ChromeURLRequestContext* if it really that type.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/18085
Review URL: http://codereview.chromium.org/159658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18025
Review URL: http://codereview.chromium.org/160369
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ownership of its list of subviews. The subviews of the TabStripView are
now generated directly (in appropriate z-order) from a list of permanent
subviews (e.g., the new tab button) and the list of tabs. In general,
this patch seems to make tab manipulation much more stable. Patch from
Viet-Trung Luu (viettrungluu@gmail.com)
BUG=14913
TEST=open/move/close/duplicate/rip/etc. tabs and observe; also check context
menus
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test.
Note: the fix is trivial, but adding support for a test required teaching the
FileHandler of testserver to consume a post body.
BUG=16832
TEST=covered by unit test
R=abarth
Review URL: http://codereview.chromium.org/149710
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=sgk
BUG=none
TEST=building interactive_ui_tests should build chrome
Review URL: http://codereview.chromium.org/160409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=pkasting
BUG=18079
TEST=covered by TabDraggingTest.Tab2OutOfTabStrip
Review URL: http://codereview.chromium.org/160412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The corresponding valgrind error has been fixed.
TEST=test_shell_tests under Valgrind should pass
BUG=15762
Review URL: http://codereview.chromium.org/159646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 91bd4c1a4703db44ea45852bf2f62822e1ded743, which caused valgrind errors.
TBR=erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
targeting an existing window. Makes things much nicer.
BUG=14923, 14925, 15667
TEST=dragging tabs in and out of windows, and within windows. Make sure new tab button goes away when it should and always comes back.
Review URL: http://codereview.chromium.org/160345
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
scripts.
BUG=11797
TEST=no
Review URL: http://codereview.chromium.org/159542
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18047
TEST=see bug
Review URL: http://codereview.chromium.org/159654
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22090 0039d316-1c4b-4281-b951-d872f2087c98
|