| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
RenderProcessHost
BUG=50936,52834
Review URL: http://codereview.chromium.org/3116028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52831
TBR=glider
Review URL: http://codereview.chromium.org/3131028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ConfigDirPolicyProvider.
BUG=52418
TEST=unit tests
Review URL: http://codereview.chromium.org/3124025
TBR=mnissler@chromium.org
Review URL: http://codereview.chromium.org/3161035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
chrome/browser/host_content_settings_map_unittest.cc
BUG=50936,52828
Review URL: http://codereview.chromium.org/3152036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/3108032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
used for recovery screen.
BUG=chromium-os:5877
TEST=Run Chrome with --login-manager --login-screen=html file://filename
Review URL: http://codereview.chromium.org/3158023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52387,52826
TBR=glider
Review URL: http://codereview.chromium.org/3177027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/57178 broke some tests in browser_test and ui_test.
In the test RedirectTest.ClientCancelled, it needs a user-initiated event to trigger the redirect, now it uses "javaScript:click()". When landing r57178, the call of window.open which is inside the call of javaScript:click() was treated as non user-initiated, so the in-page location change was treated as client redirect and the redirect was recoreded, that is why this test was failed when landing r57178. (Please refer to the logic in FrameLoaderClientImpl::dispatchDidNavigateWithinPage.)
In the tests AppApiTest.AppProcess, ExtensionBrowserTest.WindowOpenExtension and ExtensionBrowserTest.WindowOpenInvalidExtension, they assume the new tabs opened by window.open in current window. But when landing r57178, since those calls of window.open were treated as non user-initiated, the disposition type of new tabs were changed to Popup, which caused a few new tabs were created instead of a few new tabs in current window (Please refer to RenderView::show), which cause those tests were failed when landing r57178.), that is why those tests were failed when landing r57178.
BUG=17655
TEST=RedirectTest.ClientCancelled, AppApiTest.AppProcess, ExtensionBrowserTest.WindowOpenExtension, ExtensionBrowserTest.WindowOpenInvalidExtension
Review URL: http://codereview.chromium.org/3136019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
HostContentSettingsMapTest.ResourceIdentifierPrefs)
TBR=bauerb
BUG=52808
Review URL: http://codereview.chromium.org/3113025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52418
TEST=unit tests
Review URL: http://codereview.chromium.org/3124025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change just creates a scoped_ptr<Value> variable and sets the return value of base::JSONReader::Read() to it.
BUG=52808
TEST=make the "Linux Test (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3163027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
~ChromeURLRequestContext
BUG=52825,20997
Review URL: http://codereview.chromium.org/3146028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3131027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/3167031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=CrOS builds
TBR=jhawkins
Review URL: http://codereview.chromium.org/3171021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR: johnnyg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
just added notification_observer.h.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3120021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=johnnyg
Review URL: http://codereview.chromium.org/3166021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- convert GetURLAndTitleToBookmark() and GetURLsForOpenTabs()
- convert BookmarkEditor::EditDetails
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3176024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=zelidrag
TEST=none
BUG=chromium-os:5522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
last error
code from the net::TestServer::WaitToFinish helper function.
TBR=amit
Review URL: http://codereview.chromium.org/3156039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
switch and display the new DOM UI when it's used.
BUG=chromium-os:5522
TEST=make sure the new DOM UI option tab opens from status bar drop down menues (language, internet and system settings)
Review URL: http://codereview.chromium.org/3142020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is enabled. This fixes the case where restoring a previously-hidden accelerated
tab would not actually show its contents without mouse-moving within the tab's
contents.
Patch by Nat Duca (nduca@chromium.org)
R=darin
BUG=51306
TEST=Load the two URLS specified in original bug report into seperate tabs.
Switching tabs should show the content of the correct tab.
Originally reviewed at: http://codereview.chromium.org/3161023/show
Review URL: http://codereview.chromium.org/3176025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change just catches up with the recent clean-up of base (r55400).
BUG=none
TEST=make the "Chromium Mac (valgrind)" bot greener.
Review URL: http://codereview.chromium.org/3119032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37375
TEST=updated StatusIcon unit tests
Review URL: http://codereview.chromium.org/3189003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It changes to fetch https://www.google.com/searchdomaincheck?format=domain&type=chrome
instead of checking http://www.google.com/ redirection.
Also show infobar if google domain has been changed to new domain and ask
user to switch new domain.
Fix Win IO Perf regressions:
- GoogleURLTracker::RequestServerCheck() is not called in headless mode
(CHROME_HEADLESS=1) nor in Chrome Frame (--chrome-frame).
Fix leaks in TestingProfile::CreateRequestContext(): 52562
- Add TestURLFetcher::set_request_context() do nothing, because TestURLFetcher
might miss to release core_->request_context_getter_.
Fix GoogleURLTracker observer removal DCHECK: 52608
- call RemoveAll(), instead of calling Remove()s
BUG=48688,15141,52477,52562,52608
TEST=unit_tests passes
Review URL: http://codereview.chromium.org/3171019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=rolandsteiner
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=rolandsteiner
Review URL: http://codereview.chromium.org/3167029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closing. Here's the sequence that triggers the closing:
. go to a page.
. go to a new page, preferably one that takes a while to resolve, such
as one on a site that doesn't exist.
. After this step is_waiting_for_unload_ack_ has been set to true on
the first RVH.
. click stop before the page has been commited.
. click reload.
. is_waiting_for_unload_ack_ is still true, and the if the hang monitor
fires the tab gets closed.
I've changed the code to always set is_waiting_for_unload_ack_ when we
initiate a load.
BUG=52003
TEST=see bug
Review URL: http://codereview.chromium.org/3115020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
language_preferences.h exports lots of constants hence polutes chromeos
namespace.
TEST=compiles. try bots.
BUG=chromium-os:5848
Review URL: http://codereview.chromium.org/3132023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It creates a variable and copy the value all around. Instead use pointer so the other places where the variable is used
just point to the orignal variable instead of copying the value.
BUG=None
TEST=out/Debug/base_unittests --gtest_filter=EnvironmentTest.*
Review URL: http://codereview.chromium.org/3186017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use ScopedPK11Slot.
Move common test functionality into functions.
Move common test conditions into SetUp/TearDown.
Move common test variables into attributes of the test class.
BUG=19991
TEST=tests still pass
Review URL: http://codereview.chromium.org/3189014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration test logs do not reveal when different sync events
occur on the ProfileSyncServiceTestHarness objects. This checkin adds
logging for sync events so that failures are easier to debug.
BUG=52761
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3169028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19991
TEST=builds
Review URL: http://codereview.chromium.org/3104022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests failing on vista
BUG=52682
TEST=included
Review URL: http://codereview.chromium.org/3142022
TBR=cpu@chromium.org
Review URL: http://codereview.chromium.org/3122031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=rolandsteiner
Review URL: http://codereview.chromium.org/3119029
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/3111021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=52682
TEST=included
Review URL: http://codereview.chromium.org/3142022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52723
Review URL: http://codereview.chromium.org/3126023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3169029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=rolandsteiner
Review URL: http://codereview.chromium.org/3119029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
New hooks allow the user to pause/resume/cancel/remove downloads and more.
Review URL: http://codereview.chromium.org/3176016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3116019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In browser_resources.grd, both IDR_SYNC_SETUP_FLOW_HTML and
IDR_REMOTING_SETUP_FLOW_HTML are point to setup_flow.html although they
are different files in different folders. ResourceBundle gets confused
and always return the later one when asked for IDR_SYNC_SETUP_FLOW_HTML.
This problem only happens on Windows but not Linux.
This patch tries to avoid this problem by renaming remoting files with
a remoting_ prefix.
BUG=52777, 52625
TEST=Setup sync now loads the correct setup_flow.html
Review URL: http://codereview.chromium.org/3191013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'd like to see how common it is to use a network file system for
your home directory. This would help evaluate how important it is
to support these users.
See also:
http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/b43d2905f079fa1c
Review URL: http://codereview.chromium.org/3187011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3157027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui_test.
This makes PathService clear its cache after overriding a path.
We have many paths depending on each other, so this is necessary
to avoid inconsistencies.
TEST=ui_tests in Release mode
BUG=49838
Review URL: http://codereview.chromium.org/2805100
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3169031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56778 0039d316-1c4b-4281-b951-d872f2087c98
|