summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Dropping unconnected obsolete vsprops files.bradnelson@google.com2010-02-0319-294/+0
| | | | | | | | | BUG=8042 TEST=None Review URL: http://codereview.chromium.org/567033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38016 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.browserAction.setPopup().skerner@chromium.org2010-02-0319-16/+427
| | | | | | | | | BUG=27526 TEST=Unit tests BrowserActionApiTest.BrowserAction*Popup . Review URL: http://codereview.chromium.org/552263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38015 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] use subprocess.Popen instead of os.popen2 to avoid warnings on 10.6 ↵thomasvl@chromium.org2010-02-031-1/+2
| | | | | | | | | | bots due to newer python version BUG=27879 TEST=none Review URL: http://codereview.chromium.org/570004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38013 0039d316-1c4b-4281-b951-d872f2087c98
* OTS DEPS roll to r26 to support "kern" OpenType table.yusukes@chromium.org2010-02-031-1/+1
| | | | | | | | BUG=27132 TEST=none Review URL: http://codereview.chromium.org/567019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38012 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show a translate infobar when the page is in a languagejcampan@chromium.org2010-02-033-1/+25
| | | | | | | | | | | | not supported by the translation server. BUG=34365 TEST=Visit http://www.breizh.net/brezhoneg/, no translation infobar should be shown. Review URL: http://codereview.chromium.org/568028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38010 0039d316-1c4b-4281-b951-d872f2087c98
* Themes: HasCustomImage() must only return true for images that were providederg@google.com2010-02-033-20/+81
| | | | | | | | | | | | | by the extension and not for images that were autogenerated. Since this adds data to the theme pack file, bump the version number. BUG=34078 TEST=BrowserThemePackTest.TestHasCustomImage Review URL: http://codereview.chromium.org/562025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38006 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port: another chunk of chrome/browser ifdef cleaningpvalchev@google.com2010-02-0310-29/+30
| | | | | | Review URL: http://codereview.chromium.org/553153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38004 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: middle click on a bookmark bar folder should open all in tabs.estade@chromium.org2010-02-032-1/+13
| | | | | | | | | BUG=34416 TEST=try it Review URL: http://codereview.chromium.org/569031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38003 0039d316-1c4b-4281-b951-d872f2087c98
* Back out trunk r37998.mark@chromium.org2010-02-0322-1077/+430
| | | | | | | | | | | | | | | | | | | | | | | | | | Modify CookiePolicy to work asynchronously This change will enable us to prompt the user before setting a cookie. While we only need to prompt before setting, we actually need to make both CanSetCookie and CanGetCookies asynchronous. This is necessary in order to preserve FIFO ordering since the value returned by GetCookies depends on the changes made to the cookie DB by SetCookie. This change also includes some simplification of CookieStore. Instead of N virtual functions, I distilled it down to only 4. The remaining functions are instead expressed in terms of those. While studying all the places where we currently use CookiePolicy, I found that some of them were not appropriate. After discussing with Amit, I decided to remove the policy checks in URLRequestAutomationJob. See the comments in the code regarding this. I changed the signature of CookieMonster::GetRawCookies to GetAllCookiesForURL to better match GetAllCookies. I also filed a bug about making it even closer in functionality. Related to this change webkit/glue/webcookie.h grows a constructor that takes a CanonicalCookie to help clean up some code. On the Chrome side, ChromeURLRequestContext now has a ChromeCookiePolicy object. That object is threadsafe ref counted because it is passed between the UI and IO threads. It is responsible for implementing the queuing logic described above. It will also in the future trigger the Chrome UI code to actually show the setcookie prompt. Please review the state machinery changes in URLRequestHttpJob carefully. R=eroman BUG=34331 TEST=no tests yet for prompting. Review URL: http://codereview.chromium.org/567015 TBR=darin@chromium.org Review URL: http://codereview.chromium.org/562037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38002 0039d316-1c4b-4281-b951-d872f2087c98
* Back out trunk r38000.mark@chromium.org2010-02-031-2/+33
| | | | | | | | | | | | | Fix ChromiumOS build. TBR=eroman Review URL: http://codereview.chromium.org/569030 TBR=darin@chromium.org Review URL: http://codereview.chromium.org/565036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38001 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromiumOS build.darin@chromium.org2010-02-031-33/+2
| | | | | | | | TBR=eroman Review URL: http://codereview.chromium.org/569030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38000 0039d316-1c4b-4281-b951-d872f2087c98
* Added status area to login wizard view.avayvod@chromium.org2010-02-032-5/+42
| | | | | | | | | | Separated objects construction and initialization. BUG=34374 TEST=Chrome based login now should have status area buttons in the right-top corner. Review URL: http://codereview.chromium.org/564027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37999 0039d316-1c4b-4281-b951-d872f2087c98
* Modify CookiePolicy to work asynchronouslydarin@chromium.org2010-02-0322-430/+1077
| | | | | | | | | | | | | | | | | | | | | This change will enable us to prompt the user before setting a cookie. While we only need to prompt before setting, we actually need to make both CanSetCookie and CanGetCookies asynchronous. This is necessary in order to preserve FIFO ordering since the value returned by GetCookies depends on the changes made to the cookie DB by SetCookie. This change also includes some simplification of CookieStore. Instead of N virtual functions, I distilled it down to only 4. The remaining functions are instead expressed in terms of those. While studying all the places where we currently use CookiePolicy, I found that some of them were not appropriate. After discussing with Amit, I decided to remove the policy checks in URLRequestAutomationJob. See the comments in the code regarding this. I changed the signature of CookieMonster::GetRawCookies to GetAllCookiesForURL to better match GetAllCookies. I also filed a bug about making it even closer in functionality. Related to this change webkit/glue/webcookie.h grows a constructor that takes a CanonicalCookie to help clean up some code. On the Chrome side, ChromeURLRequestContext now has a ChromeCookiePolicy object. That object is thread-safe ref counted because it is passed between the UI and IO threads. It is responsible for implementing the queuing logic described above. It will also in the future trigger the Chrome UI code to actually show the set-cookie prompt. Please review the state machinery changes in URLRequestHttpJob carefully. R=eroman BUG=34331 TEST=no tests yet for prompting. Review URL: http://codereview.chromium.org/567015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37998 0039d316-1c4b-4281-b951-d872f2087c98
* Add "File Bug" link to flakiness dashboard to ease filing new layout test ↵dglazkov@chromium.org2010-02-031-1/+18
| | | | | | | | | | | | regression bugs. R=arv TEST=none BUG=none Review URL: http://codereview.chromium.org/563020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37997 0039d316-1c4b-4281-b951-d872f2087c98
* Adding catches to states of the UI to only allow button pushes in certain ↵dhg@chromium.org2010-02-032-6/+31
| | | | | | | | | | | states. Basically adding error catching. BUG=none TEST=none Review URL: http://codereview.chromium.org/562005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37996 0039d316-1c4b-4281-b951-d872f2087c98
* Make Chrome CLD uses the most recent generated tables.jcampan@chromium.org2010-02-034-225/+74905
| | | | | | | | | TEST=None BUG=None Review URL: http://codereview.chromium.org/565020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37995 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix menu IDs (Save Page As... and Text Encoding menu items).viettrungluu@chromium.org2010-02-031-151/+924
| | | | | | | | | | | | Fix breakage caused by <http://src.chromium.org/viewvc/chrome?view=rev&revision=37819>. Changed tags for File->{Save Page As..., Email Page Location, Print...} and View->Text Encoding. BUG=34463 TEST=Check that File->Save Page As... (and Cmd-S), File->Email Page Location, and View->Text Encoding work properly. Review URL: http://codereview.chromium.org/566033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37994 0039d316-1c4b-4281-b951-d872f2087c98
* Enabled in-process NaCl plugin on Linux. Turns out it's remarkably similar ↵cbiffle@google.com2010-02-031-2/+2
| | | | | | | | | | to OS X support, so this CL simply tweaks the #ifdefs. BUG=32602 TEST=none Review URL: http://codereview.chromium.org/569018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37993 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 37989 - unit test failed on Mac builder despite passing on try serverjoth@chromium.org2010-02-0310-404/+13
| | | | | | | | | | | | | | | | Original change: Add tests for the geolocation network provider. Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe gtest_filter=NetworkLocationProvider* gtest_break_on_failure Review URL: http://codereview.chromium.org/556106 TBR=joth@chromium.org Review URL: http://codereview.chromium.org/570006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37992 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling NavigateOut test since that also depends on theamit@chromium.org2010-02-031-1/+3
| | | | | | | | | | gcf: protocol that's now disabled. TBR=ananta Review URL: http://codereview.chromium.org/560035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37990 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for the geolocation network provider.joth@chromium.org2010-02-0310-13/+404
| | | | | | | | | | | Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure Review URL: http://codereview.chromium.org/556106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37989 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing tests and change GMock'ism foramit@chromium.org2010-02-031-21/+25
| | | | | | | | | | | | testing::AnyNumber() to be followed by WillRepeatedly(...) instead of WillOnce TBR=ananta Review URL: http://codereview.chromium.org/563019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37988 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: follow up fix for raw cookies access. Restore auto-locking and do ↵pfeldman@chromium.org2010-02-031-0/+8
| | | | | | | | | | GC upon raw cookies request. TBR=yurys Review URL: http://codereview.chromium.org/564039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37985 0039d316-1c4b-4281-b951-d872f2087c98
* Socket late binding bugfix.willchan@chromium.org2010-02-032-0/+72
| | | | | | | | | I added code in r36144 so that we wouldn't create extra ConnectJobs if we were still releasing sockets. This code did not handle the case where we had multiple disconnected releasing sockets. I've added a test and code to cover this case now. BUG=34123 Review URL: http://codereview.chromium.org/557089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37984 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DCHECK'ing that all NetworkChangeNotifiers are removed.willchan@chromium.org2010-02-031-1/+4
| | | | | | | | BUG=34391 Review URL: http://codereview.chromium.org/560026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37982 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cf: protocolamit@chromium.org2010-02-0314-59/+249
| | | | | | | | | | | | | | | | | | | | Well, almost. cf: is now changed to gcf: protocol. gcf: protocol now is supported only for the following cases: 1. gcf:attach_external_tabXXX urls. These are URLs used internally by Chrome Frame to implement window.open 2. gcf:about:xxx 3. gcf:view-source:xxx 4 For any other URLs ONLY if it is enabled by setting a registry value 'EnableGCFProtocol' to 1 in HKCU\Software\Google\ChromeFrame BUG=22721,23006,23175,29350 TEST=changed existing cf: tests to new gcf: tests, added a new test for cf:view-source Review URL: http://codereview.chromium.org/562008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37981 0039d316-1c4b-4281-b951-d872f2087c98
* Move bookmark managerarv@chromium.org2010-02-0335-0/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/560023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37980 0039d316-1c4b-4281-b951-d872f2087c98
* a little code cleanup for translate infobarskuan@chromium.org2010-02-033-7/+17
| | | | | | | | | | | - use index of selected language menu item (which corresponds to index in array of languages) to check if selection has changed; was retrieving, converting and comparing text, which is more expensive and slower - only call backend to translate when source and target languages are different BUG=31297 TEST=verify that selection of languages in translate infobars still work as expected. Review URL: http://codereview.chromium.org/563018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37979 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: CookieMonster::GetRawCookies should return keys as well as cookies.pfeldman@chromium.org2010-02-035-46/+115
| | | | | | Review URL: http://codereview.chromium.org/565035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37978 0039d316-1c4b-4281-b951-d872f2087c98
* Changes necessary to compile gpu demos on linux. It is not functional yet ↵alokp@chromium.org2010-02-0314-437/+342
| | | | | | | | | just compiling. BUG=26099 Review URL: http://codereview.chromium.org/552240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37977 0039d316-1c4b-4281-b951-d872f2087c98
* Some minor change to the translate classes to address the remarksjcampan@chromium.org2010-02-034-36/+39
| | | | | | | | | | | | from Jungshik review: http://codereview.chromium.org/552216/show TEST=None BUG=None Review URL: http://codereview.chromium.org/566024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37976 0039d316-1c4b-4281-b951-d872f2087c98
* To implement Pepper in Native Client we need access to the implementation of thesehr@google.com2010-02-039-27/+69
| | | | | | | | | | | | | | Pepper APIs in Chrome. Specifically, we need to be able to get the base::SharedMemory or TransportDIB memory regions used to communicate with devices. To enable doing this, especially in 64-bit Chrome, I needed to change the GetStateContext and SetStateContext functions to manipulate 64-bit values. This CL does not include the Native Client hookup to the new APIs, but is needed to do so. BUG=none TEST=none Review URL: http://codereview.chromium.org/569004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37975 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for gratuitous fake emboldening of already-bold fonts on Linux.senorblanco@chromium.org2010-02-031-1/+1
| | | | | | | | | BUG=22360 TEST=none Review URL: http://codereview.chromium.org/564038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37974 0039d316-1c4b-4281-b951-d872f2087c98
* To comply better with the Apple hig I changed the menu from showing a ↵thakis@chromium.org2010-02-032-37/+736
| | | | | | | | | | | | | checkmark icon next to Pause to alternating the words "Pause" and "Resume". XIB change: unset the 'On Image' on the Pause button. BUG=23069 TEST=Download large file and verify that the menu item says "Pause." Click "Pause" and the menu item should now say "Resume". Review URL: http://codereview.chromium.org/563001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37973 0039d316-1c4b-4281-b951-d872f2087c98
* Committing for stoyan since we need this now...mad@chromium.org2010-02-031-3/+3
| | | | | | | | | http://codereview.chromium.org/569017 BUG=0 TEST=Run the test for both Debug and Release builds git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37972 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 37968 - Update V8 to version 2.1.0.ager@chromium.org2010-02-036-21/+6
| | | | | | | | | | | | | | This version contains a number of bugfixes including wrapping of values when calling userdefined functions and a stricter JSON parser. BUG=32191,34221 Review URL: http://codereview.chromium.org/564037 TBR=ager@chromium.org Review URL: http://codereview.chromium.org/562035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37971 0039d316-1c4b-4281-b951-d872f2087c98
* Support disabling items in submenus of a context menu.jeremy@chromium.org2010-02-032-0/+2
| | | | | | | | | | | | | Without this change, items in submenus of a context menu where always enabled. With this change, the value we use for [NSMenuItem setEnabled:] is respected. This change is required for an upcoming change that needs this to work. BUG=none TEST=Right-click on a text input field, Spell Checker Options->Show spelling panel shouldn't be disabled. Review URL: http://codereview.chromium.org/567031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37970 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 54255:54278hamaji@chromium.org2010-02-031-1/+1
| | | | | | | | | | TBR=senorblanco TEST=trybots BUG=none Review URL: http://codereview.chromium.org/561046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37969 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.1.0.ager@chromium.org2010-02-036-6/+21
| | | | | | | | | | | This version contains a number of bugfixes including wrapping of values when calling user-defined functions and a stricter JSON parser. BUG=32191,34221 Review URL: http://codereview.chromium.org/564037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37968 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 315.0 to 316.0chrome-release@google.com2010-02-031-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37965 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unexpected pass around userscripthamaji@chromium.org2010-02-031-4/+1
| | | | | | | | | | TBR=mpcomplete TEST=trybots BUG=none Review URL: http://codereview.chromium.org/560029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37964 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 54232:54255hamaji@chromium.org2010-02-031-1/+1
| | | | | | | | | | TBR=senorblanco TEST=trybots BUG=none Review URL: http://codereview.chromium.org/569025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37963 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 54232:54244hamaji@chromium.org2010-02-031-1/+1
| | | | | | | | | | TBR=senorblanco TEST=trybots BUG=none Review URL: http://codereview.chromium.org/561044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37962 0039d316-1c4b-4281-b951-d872f2087c98
* Added Credit card preview in the form ******[last four digits], Exp: [Date - ↵georgey@chromium.org2010-02-033-2/+38
| | | | | | | | | | month and year] BUG=33026 TEST=should appear like in mocks, when dialog is finished Review URL: http://codereview.chromium.org/566027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37961 0039d316-1c4b-4281-b951-d872f2087c98
* Copy percent-escaped URL when copying all the text from the address bar (Mac)kinuko@chromium.org2010-02-039-82/+69
| | | | | | | | | | | | | | | | | | | | BUG=31104 TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 and select entire text in Omnibox, then copy the text. Paste the copied text into other applications such as notepad and check if the pasted text contains %E4%B8%8A%E5%9C%B0, not 上地. Paste the copied text into Safari's URL bar and type return. Check if you are navigated to the same website. Paste the copied text into textareas in Chrome and check if the pasted text contains %E4%B8%8A%E5%9C%B0. Paste the copied text into Gmail's rich text editing mode and check if the pasted text contains 上地. Right click the link you pasted in Gmail and check if you see "Go to: http://www.google.com/...%E4%B8%8A%E5%9C%B0". Paste the copied text into TextEdit and check if the pasted text isn't garbled and correctly contains 上地. Check if the link in TextEdit is pointing to encoded URL (http://www.google.com/...%E4%B8%8A%E5%9C%B0). TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 again and select "q=上地" in Omnibox, then copy the text. Paste it into somewhere and check if you see "q=上地". TEST=Copy "上地" from somewhere and paste it into Omnibox. Copy from Omnibox and paste it into notepad. Then check if the pasted text is NOT encoded. Review URL: http://codereview.chromium.org/549172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37955 0039d316-1c4b-4281-b951-d872f2087c98
* Add a comment about the behavior of ViewMsg_Replace.tkent@chromium.org2010-02-031-0/+2
| | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/561043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37953 0039d316-1c4b-4281-b951-d872f2087c98
* Move ChromeBrowserView* -> BrowserView* and ChromeosBrowserView* -> ↵ben@chromium.org2010-02-0315-260/+230
| | | | | | | | | | | | | chromeos::BrowserView* Now has all build fixes integrated. BUG=none TEST=none TBR=oshima Review URL: http://codereview.chromium.org/568030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37952 0039d316-1c4b-4281-b951-d872f2087c98
* Let renderer notify browser if content gets blocked.thakis@chromium.org2010-02-039-25/+124
| | | | | | | | | BUG= TEST=Go to a page with blocked stuff. Icons should appear in omnibox. Review URL: http://codereview.chromium.org/565010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37951 0039d316-1c4b-4281-b951-d872f2087c98
* Change the behavior of ViewMsg_Replace. It replaces a word around thetkent@chromium.org2010-02-032-2/+6
| | | | | | | | | | | | | | | | caret if there is no selected text. See http://webkit.org/b/33364 BUG=8841 TEST=Open www.google.com on Windows or Linux (not Mac OS) type "qeury" Right-click on the text field Select "query" Confirm that qeury is replaced with "query" Review URL: http://codereview.chromium.org/562014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37939 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 37913. Clear local state on exit.jochen@chromium.org2010-02-0314-12/+151
| | | | | | | | | BUG=32719 TEST=none Review URL: http://codereview.chromium.org/560024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37936 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 02:21:05 +0000