| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=40505
TEST=existing test under valgrind.
Review URL: http://codereview.chromium.org/1589028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Turns out queuing up a million of these is a bad bad thing.
BUG=40970
TEST=See test in bug.
Review URL: http://codereview.chromium.org/1568027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't show search item until we do a search. Leave the item there unless the user explicitly clears the search.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1619010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds menu item "Edit->AutoFill Form" and keyboard shortcut cmd-shift-a to
fill form on page with default address and/or credit card information.
Nib change: add "AutoFill Form" menu item under Edit, with command id 40024.
BUG=39491
TEST=Open browser window with autofillable form, invoke menu item with mouse or
cmd-shift-a. Expect: form fills.
Review URL: http://codereview.chromium.org/1622020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/1606021
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=feldstein
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
requests.
BUG=None
TEST=Open bookmarks manager. The tree should show the expand icons all the time (given that there are nested folders).
Review URL: http://codereview.chromium.org/1639001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This depends on http://codereview.chromium.org/1610011/show
BUG=37802
TEST=Open the bookmark manager. It should now show favicons.
Review URL: http://codereview.chromium.org/1574021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An extension needs to add chrome://favicon/ to its permission to able to load
favicon images.
WebKit changes: https://bugs.webkit.org/show_bug.cgi?id=37228
BUG=37802
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.*
Review URL: http://codereview.chromium.org/1610011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=antonm
Review URL: http://codereview.chromium.org/1512033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't fix the TTS padding, unfortunately I have more pressing mstone5 bugs to attend to for now (and fixing that padding doesn't look trivial).
BUG=40843
TEST=visual --- text in omnibox and popup should align; images should align as well.
Review URL: http://codereview.chromium.org/1576031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40848
TEST=none
Review URL: http://codereview.chromium.org/1530027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29148
TEST=prints documents greater than one page (to real printers)
Review URL: http://codereview.chromium.org/1520014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes for issues with new moniker patch.
BUG=none
TEST=covered by existing tests
Review URL: http://codereview.chromium.org/1625010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1622019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Nib change: in each nib, added a checkbox with the correct title and bindings to the file owner of enabled<=>canAlterDefault and value<=>isDefault
BUG=http://crbug.com/38263
TEST=as in bug
Review URL: http://codereview.chromium.org/1527022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installed (but not loaded).
Refactored theme handling code in ExtensionInstallerUI.
BUG=40847
TEST=manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44134
Review URL: http://codereview.chromium.org/1625007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40950
Review URL: http://codereview.chromium.org/1634006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces the various resources used for omnibox icons with PDF images.
The use of copies is because the field is flipped while the popup is
unflipped (and the icons get flipped to match).
BUG=37865
TEST=Icons don't look suck, look awesome when scale factor is changed under Quartz Debug.
Review URL: http://codereview.chromium.org/1629010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=40995
Review URL: http://codereview.chromium.org/1527024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40952
Review URL: http://codereview.chromium.org/1618011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pressed (ctrl-shift-a).
BUG=39491
TEST=none
Review URL: http://codereview.chromium.org/1521020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
notifications don't shrink caused a regression when the notification is of minimal size (like the one from html5rocks.com), since this is the same as the pre-show size.
BUG=40817
TEST=see bug
Review URL: http://codereview.chromium.org/1558031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of r42674).
BUG=none
TEST=Run (branded, official) Google Chrome build with --enable-internal-flash; EULA "dialog" tab should no longer be shown, and our Flash should be enabled (check about:plugins). Without --enable-internal-flash, it should still not appear in about:plugins.
Review URL: http://codereview.chromium.org/1527023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the files.
BUG=none
TEST=On official Google Chrome builds, set your favourite language and check about:terms. Should see "Appendix A" in English at the end. Ugh.
Review URL: http://codereview.chromium.org/1631011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
autocomplete dropdown.
BUG=40855
TEST=none
Review URL: http://codereview.chromium.org/1631010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1625009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
make it render as HTML. This is not the fix for bug, but to prevent people from making the same mistake again.
BUG=38105
TEST=None
Review URL: http://codereview.chromium.org/1617013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui_tests, because they fail on the Linux perf canary bot.
TEST=none
BUG=40995
TBR=antonm
Review URL: http://codereview.chromium.org/1611018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=linux perf page_cycler_dhtml is green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1539029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=type in urls and make sure once loaded we don't show http. Make sure we do show https (and other schemes) though.
Review URL: http://codereview.chromium.org/1513023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installed (but not loaded).
Refactored theme handling code in ExtensionInstallerUI.
BUG=40847
TEST=manual
Review URL: http://codereview.chromium.org/1625007
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/1599024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
action toolbar even without overflow.
The show/hide is async following the size_request change, so gtk_chrome_shrinkable_hbox_get_visible_child_count was not appropriate. Instead, show/hide the chevron when buttons show/hide.
BUG=40763
TEST=see bug. Also, removing extensions still updates the chevron state.
Review URL: http://codereview.chromium.org/1558035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
header. This also makes the splitter use the same color as the blue header.
BUG=38004
TEST=Launch bookmark manager and see the blue header and blue splitter
Review URL: http://codereview.chromium.org/1513029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installed (but not loaded).
Refactored theme handling code in ExtensionInstallerUI.
BUG=40847
TEST=manual
Review URL: http://codereview.chromium.org/1625007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
56449
They should also now work better in extension popups than they ever did previously.
known issue: the <select> box keeps the focus ring while the dropdown is open (affects all platforms)
BUG=39937
TEST=
1) Using https://chrome.google.com/extensions/detail/jiannbmldmbdmkhkdknlaemanjcobdko , the select popup should work as expected.
2) Using <select> should work as expected; in particular, while using focus-follows-mouse, mousing over other toplevel windows while the dropdown is showing should not close the dropdown
Review URL: http://codereview.chromium.org/1558014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=40439
TBR=sky@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
right thing when rtl.
BUG=40920
TEST=make sure the tabstrip draws correctly when running rtl and
closing/moving/inserting tabs.
Review URL: http://codereview.chromium.org/1613009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19113
TEST=none
Review URL: http://codereview.chromium.org/1576030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specific GLContext classes.
- GLContext encapsulates management of GL contexts on each platform.
- ReadPixels uses actual current window size to validate source rectangle.
TEST=trybots, running Pepper 3D and WebGL demos on all platforms
BUG=none
Review URL: http://codereview.chromium.org/1605014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- text is now 70% alpha
- font is 1 size larger
- 6 pixels between status icons
- icon and text are lined up better
- when clock changes text, bounds are reset properly
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1589021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
version is rolled forward.
TEST=none
BUG=40976
Review URL: http://codereview.chromium.org/1610016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1525022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is invalid.
I can't actually repro this bug, but I think this should fix it.
BUG=40439
Review URL: http://codereview.chromium.org/1540024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is done in en and en-GB (without corrections to the English).
This still needs to be done in all other languages.
BUG=none
TEST=On a branded build, go to about:terms and check that
TBR=cpu@chromium.org, laforge@chromium.org
Review URL: http://codereview.chromium.org/1539027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Polish the db tests a little bit, now there are critical and non-critical and it handles better is chrome is already running
BUG=27885
TEST=none
Review URL: http://codereview.chromium.org/1540027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing on behalf of dbelenko@google.com.
This is a new version of the older patch. Main changes include: 1. Rebased to a never Git revision to make things easier to land. 2. Chrome will now preserve the command line switches except for those that are blacklisted. 3. Fixed a race condition that would cause the browser to think it didn't exit cleanly after it's been restarted. 4. Fixed minor nits and omissions (indentation, etc).
This patch adds a timer which fires every 6 hours and checks whether the
browser is in the "persistent" (background) mode, and whether there's an
update pending restart. If both conditions are true, the browser is
restarted with blacklisted command line keys and all loose values stripped. In order to
restart the browser in the background mode, the --long-lived-extensions
key is also added to the command line.
This change is Windows-only, and it won't become fully functional until
Drew (atwilson) checks in his work that enables Chrome to go into background.
Additionally, this addresses an issue where a restarted browser might load its profile data before the previous browser process exited - we now load the profile data *after* trying to contact the other browser. This exposed a race condition in SessionRestoreUITest.RestoreAfterClosingTabbedBrowserWithAppAndLaunching, so we disabled that test and logged http://crbug.com/40946.
BUG=40975,40946
Review URL: http://codereview.chromium.org/1618012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=40932
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/1591028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Skia that is currently used for video scaling.
BUG=19113
TEST=none
Review URL: http://codereview.chromium.org/1556021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44119 0039d316-1c4b-4281-b951-d872f2087c98
|