summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix a memory error writing to a deleted URLFetcher instance.eroman@chromium.org2010-04-103-9/+10
| | | | | | | | BUG=40505 TEST=existing test under valgrind. Review URL: http://codereview.chromium.org/1589028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44175 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Do not schedule more than one delayed call to setNeedsDisplayInRect. ↵rohitrao@chromium.org2010-04-102-6/+30
| | | | | | | | | | Turns out queuing up a million of these is a bad bad thing. BUG=40970 TEST=See test in bug. Review URL: http://codereview.chromium.org/1568027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44174 0039d316-1c4b-4281-b951-d872f2087c98
* Only show search item when there is a searchfeldstein@chromium.org2010-04-101-2/+8
| | | | | | | | | | | Don't show search item until we do a search. Leave the item there unless the user explicitly clears the search. BUG=none TEST=none Review URL: http://codereview.chromium.org/1619010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44173 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill cmd-shift-a keyboard shortcut on Mac.dhollowa@chromium.org2010-04-101-2/+54
| | | | | | | | | | | | | | | Adds menu item "Edit->AutoFill Form" and keyboard shortcut cmd-shift-a to fill form on page with default address and/or credit card information. Nib change: add "AutoFill Form" menu item under Edit, with command id 40024. BUG=39491 TEST=Open browser window with autofillable form, invoke menu item with mouse or cmd-shift-a. Expect: form fills. Review URL: http://codereview.chromium.org/1622020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44172 0039d316-1c4b-4281-b951-d872f2087c98
* Images only checkin for try server goodness.glen@chromium.org2010-04-104-0/+0
| | | | | | | | | | See http://codereview.chromium.org/1606021 BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44171 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build breakage after r44169arv@chromium.org2010-04-101-1/+0
| | | | | | | | | BUG=None TEST=None TBR=feldstein git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44170 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager - Change the tree expand icon behavior to match Brian's ↵arv@chromium.org2010-04-102-58/+15
| | | | | | | | | | | | requests. BUG=None TEST=Open bookmarks manager. The tree should show the expand icons all the time (given that there are nested folders). Review URL: http://codereview.chromium.org/1639001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44169 0039d316-1c4b-4281-b951-d872f2087c98
* Add favicons to the bookmark manager.arv@chromium.org2010-04-103-6/+4
| | | | | | | | | | | This depends on http://codereview.chromium.org/1610011/show BUG=37802 TEST=Open the bookmark manager. It should now show favicons. Review URL: http://codereview.chromium.org/1574021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44168 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extensions to access chrome://favicon/.arv@chromium.org2010-04-1014-11/+104
| | | | | | | | | | | | | | | An extension needs to add chrome://favicon/ to its permission to able to load favicon images. WebKit changes: https://bugs.webkit.org/show_bug.cgi?id=37228 BUG=37802 TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.* Review URL: http://codereview.chromium.org/1610011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44167 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 57286:57383.dumi@chromium.org2010-04-101-1/+1
| | | | | | | | | | TEST=none BUG=none TBR=antonm Review URL: http://codereview.chromium.org/1512033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44164 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: fix padding of autocomplete popup.estade@chromium.org2010-04-101-2/+2
| | | | | | | | | | | This doesn't fix the TTS padding, unfortunately I have more pressing mstone5 bugs to attend to for now (and fixing that padding doesn't look trivial). BUG=40843 TEST=visual --- text in omnibox and popup should align; images should align as well. Review URL: http://codereview.chromium.org/1576031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44163 0039d316-1c4b-4281-b951-d872f2087c98
* loosen origin requirements for apps for nowerikkay@chromium.org2010-04-101-5/+5
| | | | | | | | | BUG=40848 TEST=none Review URL: http://codereview.chromium.org/1530027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44162 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix printing somewhat.estade@chromium.org2010-04-104-230/+70
| | | | | | | | | BUG=29148 TEST=prints documents greater than one page (to real printers) Review URL: http://codereview.chromium.org/1520014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44161 0039d316-1c4b-4281-b951-d872f2087c98
* Fix IE6 switching issuesananta@chromium.org2010-04-096-20/+51
| | | | | | | | | | | Fixes for issues with new moniker patch. BUG=none TEST=covered by existing tests Review URL: http://codereview.chromium.org/1625010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44160 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Final (late) grd string changes.jhawkins@chromium.org2010-04-093-4/+7
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1622019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44159 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Use as default" checkboxes to the autofill dialogs on the Mac.avi@chromium.org2010-04-0910-41/+539
| | | | | | | | | | | Nib change: in each nib, added a checkbox with the correct title and bindings to the file owner of enabled<=>canAlterDefault and value<=>isDefault BUG=http://crbug.com/38263 TEST=as in bug Review URL: http://codereview.chromium.org/1527022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44158 0039d316-1c4b-4281-b951-d872f2087c98
* Show Infobar on new synced theme even if the theme was alreadyakalin@chromium.org2010-04-093-38/+69
| | | | | | | | | | | | | | | installed (but not loaded). Refactored theme handling code in ExtensionInstallerUI. BUG=40847 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44134 Review URL: http://codereview.chromium.org/1625007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44157 0039d316-1c4b-4281-b951-d872f2087c98
* At some UMA counters to log when various failures happen.skrul@chromium.org2010-04-096-14/+36
| | | | | | | | BUG=40950 Review URL: http://codereview.chromium.org/1634006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44156 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] PDF icons for omnibox.shess@chromium.org2010-04-0916-16/+6921
| | | | | | | | | | | | | Replaces the various resources used for omnibox icons with PDF images. The use of copies is because the field is flipped while the popup is unflipped (and the icons get flipped to match). BUG=37865 TEST=Icons don't look suck, look awesome when scale factor is changed under Quartz Debug. Review URL: http://codereview.chromium.org/1629010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44152 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling WorkerTest.WorkerWebSocketLayoutTests on Linux bots only.dumi@chromium.org2010-04-091-1/+5
| | | | | | | | | | TEST=none BUG=40995 Review URL: http://codereview.chromium.org/1527024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44151 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when we delete the group we're requesting a socket for.willchan@chromium.org2010-04-094-20/+55
| | | | | | | | BUG=40952 Review URL: http://codereview.chromium.org/1618011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44150 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Fill the default profile when the AutoFill accelerator combo is ↵jhawkins@chromium.org2010-04-0921-34/+277
| | | | | | | | | | | pressed (ctrl-shift-a). BUG=39491 TEST=none Review URL: http://codereview.chromium.org/1521020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44149 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure small notifications get shown. Previous change to make sure ↵johnnyg@chromium.org2010-04-091-3/+6
| | | | | | | | | | | notifications don't shrink caused a regression when the notification is of minimal size (like the one from html5rocks.com), since this is the same as the pre-show size. BUG=40817 TEST=see bug Review URL: http://codereview.chromium.org/1558031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44148 0039d316-1c4b-4281-b951-d872f2087c98
* No longer display EULA when internal Flash enabled (revert r42783 and most ↵viettrungluu@chromium.org2010-04-0912-339/+0
| | | | | | | | | | | of r42674). BUG=none TEST=Run (branded, official) Google Chrome build with --enable-internal-flash; EULA "dialog" tab should no longer be shown, and our Flash should be enabled (check about:plugins). Without --enable-internal-flash, it should still not appear in about:plugins. Review URL: http://codereview.chromium.org/1527023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44147 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily add "Appendix A" of the Terms of Service (in English) into all ↵viettrungluu@chromium.org2010-04-0947-15/+2021
| | | | | | | | | | | the files. BUG=none TEST=On official Google Chrome builds, set your favourite language and check about:terms. Should see "Appendix A" in English at the end. Ugh. Review URL: http://codereview.chromium.org/1631011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44146 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Theme the icons in the location bar and use GTK colors for the ↵erg@chromium.org2010-04-094-17/+152
| | | | | | | | | | | autocomplete dropdown. BUG=40855 TEST=none Review URL: http://codereview.chromium.org/1631010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44145 0039d316-1c4b-4281-b951-d872f2087c98
* Fix silly DCHECK introduced by me in r44019.tonyg@chromium.org2010-04-091-3/+4
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/1625009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44144 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent people from adding mime type to supported_non_image_types that will ↵inferno@chromium.org2010-04-091-0/+4
| | | | | | | | | | | make it render as HTML. This is not the fix for bug, but to prevent people from making the same mistake again. BUG=38105 TEST=None Review URL: http://codereview.chromium.org/1617013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44143 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling worker-simple.html and shared-worker-simple.html indumi@chromium.org2010-04-091-1/+1
| | | | | | | | | | | | | ui_tests, because they fail on the Linux perf canary bot. TEST=none BUG=40995 TBR=antonm Review URL: http://codereview.chromium.org/1611018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44142 0039d316-1c4b-4281-b951-d872f2087c98
* Update dhtml linux results after tcmalloc revert.chase@chromium.org2010-04-091-1/+1
| | | | | | | | | | BUG=none TEST=linux perf page_cycler_dhtml is green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/1539029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44141 0039d316-1c4b-4281-b951-d872f2087c98
* Strips http from the omniboxsky@chromium.org2010-04-0921-155/+270
| | | | | | | | BUG=none TEST=type in urls and make sure once loaded we don't show http. Make sure we do show https (and other schemes) though. Review URL: http://codereview.chromium.org/1513023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44140 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44134 - Show Infobar on new synced theme even if the theme was alreadyakalin@chromium.org2010-04-093-69/+38
| | | | | | | | | | | | | | | | installed (but not loaded). Refactored theme handling code in ExtensionInstallerUI. BUG=40847 TEST=manual Review URL: http://codereview.chromium.org/1625007 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/1599024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44139 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 373.0 to 374.0laforge@chromium.org2010-04-091-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44137 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: fix corner case where we'd show the overflow chevron for the browser ↵estade@chromium.org2010-04-092-14/+33
| | | | | | | | | | | | | action toolbar even without overflow. The show/hide is async following the size_request change, so gtk_chrome_shrinkable_hbox_get_visible_child_count was not appropriate. Instead, show/hide the chevron when buttons show/hide. BUG=40763 TEST=see bug. Also, removing extensions still updates the chevron state. Review URL: http://codereview.chromium.org/1558035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44136 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager - Add blue line and move menu button into the summary ↵arv@chromium.org2010-04-092-18/+39
| | | | | | | | | | | header. This also makes the splitter use the same color as the blue header. BUG=38004 TEST=Launch bookmark manager and see the blue header and blue splitter Review URL: http://codereview.chromium.org/1513029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44135 0039d316-1c4b-4281-b951-d872f2087c98
* Show Infobar on new synced theme even if the theme was alreadyakalin@chromium.org2010-04-093-38/+69
| | | | | | | | | | | | | installed (but not loaded). Refactored theme handling code in ExtensionInstallerUI. BUG=40847 TEST=manual Review URL: http://codereview.chromium.org/1625007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44134 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: fix <select> dropdown corner case behaviors caused by WebKit changeset ↵estade@chromium.org2010-04-092-40/+52
| | | | | | | | | | | | | | | | | 56449 They should also now work better in extension popups than they ever did previously. known issue: the <select> box keeps the focus ring while the dropdown is open (affects all platforms) BUG=39937 TEST= 1) Using https://chrome.google.com/extensions/detail/jiannbmldmbdmkhkdknlaemanjcobdko , the select popup should work as expected. 2) Using <select> should work as expected; in particular, while using focus-follows-mouse, mousing over other toplevel windows while the dropdown is showing should not close the dropdown Review URL: http://codereview.chromium.org/1558014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44133 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r44125aa@chromium.org2010-04-095-50/+31
| | | | | | | | BUG=40439 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44132 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bugs in new tab strip animations where they weren't doing thesky@chromium.org2010-04-093-1/+10
| | | | | | | | | | | | right thing when rtl. BUG=40920 TEST=make sure the tabstrip draws correctly when running rtl and closing/moving/inserting tabs. Review URL: http://codereview.chromium.org/1613009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44131 0039d316-1c4b-4281-b951-d872f2087c98
* add filtering to player_wtlfbarchard@chromium.org2010-04-095-27/+76
| | | | | | | | | BUG=19113 TEST=none Review URL: http://codereview.chromium.org/1576030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44130 0039d316-1c4b-4281-b951-d872f2087c98
* - Extracted platform specific code from GLES2 command decoder to platform ↵apatrick@chromium.org2010-04-0936-1171/+1432
| | | | | | | | | | | | | specific GLContext classes. - GLContext encapsulates management of GL contexts on each platform. - ReadPixels uses actual current window size to validate source rectangle. TEST=trybots, running Pepper 3D and WebGL demos on all platforms BUG=none Review URL: http://codereview.chromium.org/1605014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44129 0039d316-1c4b-4281-b951-d872f2087c98
* Status area improvements:chocobo@chromium.org2010-04-0914-43/+75
| | | | | | | | | | | | | | - text is now 70% alpha - font is 1 size larger - 6 pixels between status icons - icon and text are lined up better - when clock changes text, bounds are reset properly TEST=none BUG=none Review URL: http://codereview.chromium.org/1589021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44128 0039d316-1c4b-4281-b951-d872f2087c98
* Disable this test on Linux, because it will fail as soon as WebKit'sdumi@chromium.org2010-04-091-0/+6
| | | | | | | | | | | | version is rolled forward. TEST=none BUG=40976 Review URL: http://codereview.chromium.org/1610016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44127 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing test expectaions after 44119 BUG=19113 TEST=nonesergeyu@chromium.org2010-04-091-0/+6
| | | | | | Review URL: http://codereview.chromium.org/1525022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44126 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt fix for crash bug when alert closes while owning hostaa@chromium.org2010-04-095-31/+50
| | | | | | | | | | | | is invalid. I can't actually repro this bug, but I think this should fix it. BUG=40439 Review URL: http://codereview.chromium.org/1540024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44125 0039d316-1c4b-4281-b951-d872f2087c98
* Change Terms of Service to include Adobe Flash stuff.viettrungluu@chromium.org2010-04-092-8/+88
| | | | | | | | | | | | | This is done in en and en-GB (without corrections to the English). This still needs to be done in all other languages. BUG=none TEST=On a branded build, go to about:terms and check that TBR=cpu@chromium.org, laforge@chromium.org Review URL: http://codereview.chromium.org/1539027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44123 0039d316-1c4b-4281-b951-d872f2087c98
* Allow specifiying a different user-data-dir for diagnostic modecpu@chromium.org2010-04-096-27/+62
| | | | | | | | | | | - Polish the db tests a little bit, now there are critical and non-critical and it handles better is chrome is already running BUG=27885 TEST=none Review URL: http://codereview.chromium.org/1540027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44122 0039d316-1c4b-4281-b951-d872f2087c98
* Auto restart when update available while running in the background on windows.atwilson@chromium.org2010-04-0917-52/+213
| | | | | | | | | | | | | | | | | | | | | | | | Landing on behalf of dbelenko@google.com. This is a new version of the older patch. Main changes include: 1. Rebased to a never Git revision to make things easier to land. 2. Chrome will now preserve the command line switches except for those that are blacklisted. 3. Fixed a race condition that would cause the browser to think it didn't exit cleanly after it's been restarted. 4. Fixed minor nits and omissions (indentation, etc). This patch adds a timer which fires every 6 hours and checks whether the browser is in the "persistent" (background) mode, and whether there's an update pending restart. If both conditions are true, the browser is restarted with blacklisted command line keys and all loose values stripped. In order to restart the browser in the background mode, the --long-lived-extensions key is also added to the command line. This change is Windows-only, and it won't become fully functional until Drew (atwilson) checks in his work that enables Chrome to go into background. Additionally, this addresses an issue where a restarted browser might load its profile data before the previous browser process exited - we now load the profile data *after* trying to contact the other browser. This exposed a race condition in SessionRestoreUITest.RestoreAfterClosingTabbedBrowserWithAppAndLaunching, so we disabled that test and logged http://crbug.com/40946. BUG=40975,40946 Review URL: http://codereview.chromium.org/1618012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44121 0039d316-1c4b-4281-b951-d872f2087c98
* More flakynesssky@chromium.org2010-04-091-3/+6
| | | | | | | | | | BUG=40932 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/1591028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44120 0039d316-1c4b-4281-b951-d872f2087c98
* Optimized version of bilinear video scaler. It is about 2 times faster than ↵sergeyu@chromium.org2010-04-0910-488/+824
| | | | | | | | | | | Skia that is currently used for video scaling. BUG=19113 TEST=none Review URL: http://codereview.chromium.org/1556021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44119 0039d316-1c4b-4281-b951-d872f2087c98