| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
the PNG library, and it turns on some functionality that O3D needs for manipulating PNG files: It removes the definition of PNG_NO_WRITE_FILLER, PNG_NO_READ_FILLER, PNG_NO_SEQUENTIAL_READ_SUPPORTED, and PNG_NO_INFO_IMAGE from pngusr.h so that the functions used by O3D to read images progressively and for filler bytes for pixel expansion (RGB -> RGBX) are available.
BUG=none
TEST=successful trybot run for all platforms.
Review URL: http://codereview.chromium.org/140074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=13838
TEST=Open two browser windows. Drag one of the tabs into the other tabstrip. The first browser window should disappear and the browser should not crash.
Review URL: http://codereview.chromium.org/145019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14113
TEST=the navigation hotkeys now work in fullscreen mode. Make sure the follownig all work:
{ GDK_Left, IDC_BACK, GDK_MOD1_MASK },
{ GDK_BackSpace, IDC_BACK, GdkModifierType(0) },
{ XF86XK_Back, IDC_BACK, GdkModifierType(0) },
{ GDK_Right, IDC_FORWARD, GDK_MOD1_MASK },
{ GDK_BackSpace, IDC_FORWARD, GDK_SHIFT_MASK },
{ XF86XK_Forward, IDC_FORWARD, GdkModifierType(0) },
{ GDK_r, IDC_RELOAD, GDK_CONTROL_MASK },
{ GDK_F5, IDC_RELOAD, GdkModifierType(0) },
{ GDK_F5, IDC_RELOAD, GDK_CONTROL_MASK },
{ XF86XK_Reload, IDC_RELOAD, GdkModifierType(0) },
{ XF86XK_Refresh, IDC_RELOAD, GdkModifierType(0) },
key: { button, action, modifier }, where MOD1 = alt
Review URL: http://codereview.chromium.org/145020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=14946 (http://crbug.com/14946)
TEST=covered in test case
Review URL: http://codereview.chromium.org/145021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/14518
TEST=middle click on an infobar link, it should open in a new tab
Review URL: http://codereview.chromium.org/145013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The BrowserWindow creates the task manager UI directly, which uses the TaskManager to populate itself.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and added accessors.
Review URL: http://codereview.chromium.org/140080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/145001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=paul
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/144011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Test=none
BUG=none
Review URL: http://codereview.chromium.org/144007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NOTIMPLEMENTED() to the console.
http://crbug.com/14935
Review URL: http://codereview.chromium.org/145011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the current Autocomplete edit box and by using Gtk clipboard, it will paste and search it.
BUG=14800 (http://crbug.com/14800)
TEST=Selected text from view and right clicked copied. Went to the omnibox and right clicked > Paste and Go. It navigated to the page successfully.
Review URL: http://codereview.chromium.org/140050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
down to it so the window was never laid out when it was initially created.
http://crbug.com/14637
TEST=first run bubble should not be black
Review URL: http://codereview.chromium.org/145006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is off. Only paint the custom frame png if the custom frame is
on.
This fixes a bug where the blue gradient wans't applied on the window-decoration version.
Review URL: http://codereview.chromium.org/145005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions.enable pref was not being honored. Add tests.
This is intended to be submitted after:
http://codereview.chromium.org/132003
BUG=13467
TEST=Added unit tests
Review URL: http://codereview.chromium.org/132045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12258
TEST=unittests
Review URL: http://codereview.chromium.org/140015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/144005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is mainly intended to be pulled to the 3.0 branch. It won't be submitted until another corresponding change to
undo the damage is ready.
BUG=13467
TEST=Added unit tests
Review URL: http://codereview.chromium.org/132003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11441
TEST=Try the non-standard browser keys on a keyboard that has them. I.e. the back and forward button on a Thinkpad.
Review URL: http://codereview.chromium.org/140081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
Review URL: http://codereview.chromium.org/144004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The following tests needs to be rebaselined:
The following tests are marked as pass:
Review URL: http://codereview.chromium.org/141057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/14786
TEST=set bookmark bar to show by default. open a new browser window. There should be no weird vertical scrolling at the bottom of the page.
Review URL: http://codereview.chromium.org/145002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser window. This fixes a visual bug where the border looked
disconnected with the background. This matches what Windows does.
BUG=14884
Review URL: http://codereview.chromium.org/140078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be so that resize animations are not janktastic. TabOverviewContainer
only draws in the parts that are actually used so that it appears as
though the window is smaller than it is. This was needed as
moving/resizing bounds is way too expensive.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/132059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since the "remove" item always causes selection to change, we don't have to worry about trying to call remove twice with the same context menu.
TEST=see bug. Also, no new crashes on linux.
BUG=14443
Review URL: http://codereview.chromium.org/132048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[re-retry, seeing if reliability bots like it]
* use a new ChannelHandle type when passing IPC channels over IPC
The current POSIX code assumes that one end of a channel is always a new
child process (a renderer). For plugins we need to be able to construct
channels between each of the browser, plugin, and renderer.
This change augments the messages related to creating channels to allow
passing in a base::FileDescriptor containing the socket. The intent is
that the browser process, as the initial interchange between plugin and
renderer, creates the socketpair() on their behalf and hands each their
respective end of the connection.
* register channel endpoint names in the global pipe map
The plugin code assumes it can map from a string to a channel endpoint
at basically any time. So whenever we get a channel endpoint over IPC,
we install it in a global map of channel endpoints.
Review URL: http://codereview.chromium.org/113157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
_NET_CLIENT_LIST_STACKING.
BUG=14004
TEST=Drag tabs in and out of tabstrip in xmonad window manager.
Review URL: http://codereview.chromium.org/141061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
generated upstream.
BUG=13809
TEST=none
Review URL: http://codereview.chromium.org/139001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Ben nor I can get this one.
BUG=13500
TEST=none
Review URL: http://codereview.chromium.org/140009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=14889 (http://crbug.com/14889)
Review URL: http://codereview.chromium.org/140079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14753
Review URL: http://codereview.chromium.org/140039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
These cover a special case of encoding and decoding ASN.1
integers.
Review URL: http://codereview.chromium.org/140077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/14770
TEST=See bug.
Review URL: http://codereview.chromium.org/140011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=paul
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/141055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Vodaphone (UK) Mobile Broadband appears to be providing an extra level
of gzip compression, at the same time as it discards the content encoding
"sdch,gzip" and replaces it with "gzip."
The previous approach for handling a missing "sdch" content encoding
statement from a server that *probably* was trying to send encoded
content, was to replace the (probably) garbage content encoding with
tentative decodings for both gzip and sdch. That approach was not
sufficient for the resulting double-gzip encoding that Vodaphone
provided :-(.
This fix leaves the existing content encodings (such as Vodaphone's
solo "gzip"), and adds the tentative decodings (gzip plus sdch).
Hence we translate received content encodings (when we know we requested
an SDCH response by including an applicable dictionary) as follows:
"sdch,gzip" unchanged. This is perfect.
"" ==> "Tent_sdch, Tent_gzip"
"gzip" ==> "Tent_sdch, Test_gzip, gzip"
Note that the TENTATIVE_gzip is a sniffing gzip, that can turn into an
identity (no-op) filter if it can't find a gzip header.
By continuing to use a tentative SDCH, it is possible for the SDCH
filter to make error recovery decision, and to record stats
on this case.
In addition, I've changed the error recovery approach in the SDCH
filter to be ultra conservative. If there is ANY unrecoverable
error in a response to an SDCH request, then we will blacklist
the host of the URL. Recoverable errors are where the SDCH is fully
functional, and decodes its data using the dictionary.
The test cases added focus on the double gzip cases, as observed in
Vodaphone (UK) Mobile Broadband.
BUG=13606
r=huanr
Review URL: http://codereview.chromium.org/140037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
"wait" state for the correct period of time.
BUG=none
TEST=none, code not yet enabled
Review URL: http://codereview.chromium.org/141051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=wtc
Review URL: http://codereview.chromium.org/141054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11512
Review URL: http://codereview.chromium.org/140076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=b/1483703
Review URL: http://codereview.chromium.org/132046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
conversion to std::string correctly for all platforms.
BUG=14641
TEST=LoginDatabase unit tests should build and run on Windows
Review URL: http://codereview.chromium.org/139005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also switched from 3px borders to 4px borders because that's what they are
on windows. On linux, the borders look bigger because our webcontent area
doesn't drop a shadow.
For this to work for resizing on top, I had to remove the event box from
the browser titlebar and move the mouse event handling to the window.
BUG=14645
Review URL: http://codereview.chromium.org/140026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Consolidates the WasHidden/DidBecomeSelected logic into a single method.
This change is needed to make the hung renderer dialog disappear when
switching tabs.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/141048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18925 0039d316-1c4b-4281-b951-d872f2087c98
|