summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixes regression in info bubble that caused crash on clicking star onsky@google.com2008-12-102-18/+6
| | | | | | | | | | | | history page. BUG=4397 TEST=go to history page, click on a star and make sure star bubble pops up. Review URL: http://codereview.chromium.org/13349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6717 0039d316-1c4b-4281-b951-d872f2087c98
* Move DISALLOW_COPY_AND_ASSIGN(RefCountedThreadSafe<T>) to private section.tim@chromium.org2008-12-101-0/+1
| | | | | | | | | | | | I hope this is as innocent as it seems, but the presence of the "subtle" namespace freaks me out. Given that everything built, I doubt this was affecting anything because if it were somehow abused moving this to private should have generated compilation errors. In any event, smack me if I'm missing something "subtley" obvious or should try something else (besides running tests). Review URL: http://codereview.chromium.org/13219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6715 0039d316-1c4b-4281-b951-d872f2087c98
* Changes bookmark manager search to use contains vs starts with and tosky@google.com2008-12-106-25/+112
| | | | | | | | | | | | search urls. BUG=4065 TEST=create the URL foo.com and type 'foo.com' in the bookmark manager search box. Make sure the url you just typed shows up in the table. Review URL: http://codereview.chromium.org/13679 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6714 0039d316-1c4b-4281-b951-d872f2087c98
* Adds NULL checks for LoadLibrary and GetProcAddress calls insky@google.com2008-12-101-0/+6
| | | | | | | | | | | | IEImporter. As far as I could tell the crash was because LoadLibrary returned null. BUG=3897 TEST=none Review URL: http://codereview.chromium.org/13319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6713 0039d316-1c4b-4281-b951-d872f2087c98
* run ipc unit tests in release mode (was running other unit tests). port code ↵pinkerton@google.com2008-12-102-3/+3
| | | | | | | | wrapped in NDEBUG to get release mode compiling and running Review URL: http://codereview.chromium.org/13346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6712 0039d316-1c4b-4281-b951-d872f2087c98
* Update test lists to match the state of the bots.ojan@google.com2008-12-101-5/+3
| | | | | | | TBR to green bots. Review URL: http://codereview.chromium.org/13710 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6711 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6709,6708,6706.brettw@google.com2008-12-1015-160/+168
| | | | | | Review URL: http://codereview.chromium.org/13345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6710 0039d316-1c4b-4281-b951-d872f2087c98
* Use crappy apple define instead of OS_ defines since those don't exist for Skia.brettw@google.com2008-12-101-1/+1
| | | | | | Review URL: http://codereview.chromium.org/13709 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6709 0039d316-1c4b-4281-b951-d872f2087c98
* Add an additional include to get skASSERT.brettw@google.com2008-12-101-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6708 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak the linux build caused by r6698.deanm@chromium.org2008-12-101-2/+1
| | | | | | Review URL: http://codereview.chromium.org/13708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6707 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base dependency from image_operations and associated unittests. I ↵brettw@google.com2008-12-1015-167/+158
| | | | | | | | | also renamed the namespace from "gfx" to "skia". This also adds back the image_operations_unittest to a project (this had gotten lost in my move). Review URL: http://codereview.chromium.org/13143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6706 0039d316-1c4b-4281-b951-d872f2087c98
* The m_context member of the V8 proxy should be empty if any part ofager@google.com2008-12-102-27/+62
| | | | | | | | | | the initialization fails. In particular, if the DOM constructor cache could not be allocated, initialization of the context fails and we dispose and clear the m_context member to signal that the context cannot be used. Review URL: http://codereview.chromium.org/13338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6705 0039d316-1c4b-4281-b951-d872f2087c98
* Remove proxy_script_fetcher from the scons files too to try and green purify ↵ericroman@google.com2008-12-102-2/+0
| | | | | | | | | | builder. TBR=erikkay Review URL: http://codereview.chromium.org/13340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6704 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ProxyService usage in Java plugin proxy interfaceamit@chromium.org2008-12-101-4/+7
| | | | | | | | | | | ProxyServie now holds ownership of the ProxyResolver instance passed in. MozillaExtensionApi class passed in a stack instance of ProxyResolver causing problems in delete. Review URL: http://codereview.chromium.org/13702 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6703 0039d316-1c4b-4281-b951-d872f2087c98
* Remove proxy_script_fetcher_unittest.cc as it seems to be triggering a UMR.ericroman@google.com2008-12-102-12/+0
| | | | | | | | | | I cannot repro this locally, so doing a quick change to green the purify builder. TBR=erikkay Review URL: http://codereview.chromium.org/13704 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6702 0039d316-1c4b-4281-b951-d872f2087c98
* no-op style change.ericroman@google.com2008-12-101-4/+4
| | | | | | | | TBR=wtc@chromium.org Review URL: http://codereview.chromium.org/13703 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6701 0039d316-1c4b-4281-b951-d872f2087c98
* Support gprof and symbols options to the Linux build.deanm@chromium.org2008-12-101-0/+9
| | | | | | | | Both will work in either dbg or opt. SYMBOLS=1 is useful when building an opt build with debugging symbols. PROFILE=1 builds with gprof instrumentation. Review URL: http://codereview.chromium.org/13337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6700 0039d316-1c4b-4281-b951-d872f2087c98
* Add a ProxyScriptFetcher class for doing asynch downloads of PAC ↵ericroman@google.com2008-12-1024-3/+717
| | | | | | | | scripts.This object will be owned by ProxyService. It will be used to manage the fetching of PAC scripts (on the IO thread, using the primary URLRequestContext).BUG=74,2764 (partial) Review URL: http://codereview.chromium.org/13251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6699 0039d316-1c4b-4281-b951-d872f2087c98
* webkit merge 39000:39050, srcdimich@google.com2008-12-107-14/+54
| | | | | | | review: http://codereview.chromium.org/13697 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6698 0039d316-1c4b-4281-b951-d872f2087c98
* no-op style change.ericroman@google.com2008-12-101-4/+4
| | | | | | | | TBR=wtc@chromium.org Review URL: http://codereview.chromium.org/13335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6694 0039d316-1c4b-4281-b951-d872f2087c98
* Misc proxy service changes.ericroman@google.com2008-12-1021-219/+403
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (1) Changed the proxy service ownership model -- rather than being a detail of the HTTP stack, it is now a dependency owned by UrlRequestContext. - ProxyService is owned by UrlRequestContext (before was HttpNetworkSession) - ProxyResolver is owned by ProxyService (before was HttpNetworkSession) Being able to share the proxy service is needed in several places, including incognito mode http context (http://crbug.com/3564), and for proxy resolving in the new FTP stack. (2) Added an IPC for getting of the ProxyResolverWinHttp dependency in the plugin process. Not hooked up yet, but intent is to route the proxy resolve requests through the browser process. (3) Changed some unit tests which were depending on the system proxy settings (this was a sideffect of their calling HttpNetworkLayer::CreateFactory(NULL)). (4) Moved the first-time ProxyService::UpdateConfig out of the constructor and into the initial request. Done to avoid startup perf regressions, since the ProxyService construction is now done earlier (on the startup critical path). BUG=3564 Review URL: http://codereview.chromium.org/12938 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6693 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style fro last CL. I had extra space to prevent >> at the end of the ↵brettw@google.com2008-12-101-1/+1
| | | | | | | | template, but didn't remove them when I removed the innter template argument. Review URL: http://codereview.chromium.org/13700 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6692 0039d316-1c4b-4281-b951-d872f2087c98
* Fox more gcc template errors.brettw@google.com2008-12-101-3/+3
| | | | | | Review URL: http://codereview.chromium.org/13699 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6691 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc compilation issue. The inner class doesn't need a template decl.brettw@google.com2008-12-101-1/+0
| | | | | | Review URL: http://codereview.chromium.org/13698 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6690 0039d316-1c4b-4281-b951-d872f2087c98
* Add property bag to the build.brettw@google.com2008-12-104-0/+18
| | | | | | Review URL: http://codereview.chromium.org/13320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6689 0039d316-1c4b-4281-b951-d872f2087c98
* Linux rebaseline: LayoutTests/css2.1/t1508-c527-font-00-bagl@chromium.org2008-12-104-3/+26
| | | | | | | | | We don't match italic, small caps Helvetica. The advance sizes are incorrect for a few of the glyphs. At some point we just have to decide that exactly matching Windows isn't worth the effort and this is that point. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6688 0039d316-1c4b-4281-b951-d872f2087c98
* Annotate some tests more carefully with their status on Windows/Linux.evanm@google.com2008-12-101-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6687 0039d316-1c4b-4281-b951-d872f2087c98
* More tests_fixable annotations.evanm@google.com2008-12-109-6/+15
| | | | | | | Remove some incorrectly-baselined Windows tests. Add some Linux baselines. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6686 0039d316-1c4b-4281-b951-d872f2087c98
* Be stricter when clipping gtk widgets.estade@chromium.org2008-12-103-0/+4
| | | | | | | | This fixes a layout test on linux but we still hve to rebaseline the image. Review URL: http://codereview.chromium.org/13801 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6685 0039d316-1c4b-4281-b951-d872f2087c98
* Take two at a linter for the test list files. Apparentlyojan@google.com2008-12-102-63/+91
| | | | | | | | options.results_directory needs to be set before creating the TestRunner. Review URL: http://codereview.chromium.org/13328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6684 0039d316-1c4b-4281-b951-d872f2087c98
* Add teh two spaces back in since buildbot relies on it for parsing the output.ojan@google.com2008-12-101-1/+1
| | | | | | Review URL: http://codereview.chromium.org/13692 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6683 0039d316-1c4b-4281-b951-d872f2087c98
* Added --run-chunk argument which allows the caller to run a specific slice ↵erikkay@google.com2008-12-101-1/+39
| | | | | | | | of the non-skipped layout tests. This will allow us to shard the layout tests in purify. Review URL: http://codereview.chromium.org/13318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6682 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in the copy selection code. If there's notc@google.com2008-12-102-0/+7
| | | | | | | | | | | selection, we get a null range, so check for it. Also fallback if there's no frame with focus to the main frame. The webkit gtk code does this as well. Review URL: http://codereview.chromium.org/13297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6681 0039d316-1c4b-4281-b951-d872f2087c98
* Marked the wrong test. :(evanm@google.com2008-12-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6679 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6671.ojan@google.com2008-12-102-90/+63
| | | | | | Review URL: http://codereview.chromium.org/13690 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6677 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage.darin@chromium.org2008-12-101-2/+2
| | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/13326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6676 0039d316-1c4b-4281-b951-d872f2087c98
* Add crashers to fixable list. TBR to open tree.ojan@google.com2008-12-101-0/+4
| | | | | | Review URL: http://codereview.chromium.org/13324 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6674 0039d316-1c4b-4281-b951-d872f2087c98
* Yet more tests that are working on build bot and locally (including pixel ↵evanm@google.com2008-12-101-3/+4
| | | | | | tests). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6673 0039d316-1c4b-4281-b951-d872f2087c98
* Add a lint pass to be used to ensure test files have the correct syntax.ojan@google.com2008-12-102-63/+90
| | | | | | Review URL: http://codereview.chromium.org/13268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6671 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing 4687: Enter in FirstRun UI starts import when Customize link is focued.finnur@google.com2008-12-103-11/+8
| | | | | | | We now properly handle Enter when links are focused. I also made it so that links navigate on KeyDown (when you press Enter or Space) instead of on KeyUp. This matches WebKit and native Windows behavior. Review URL: http://codereview.chromium.org/13321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6670 0039d316-1c4b-4281-b951-d872f2087c98
* Linux rebaseline: LayoutTests/tables/mozilla/core/bloombergagl@chromium.org2008-12-104-2/+392
| | | | | | | | The test uses the MS Sans Serif font for one of the lines of text which is non-free and we can't match it on Linux. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6669 0039d316-1c4b-4281-b951-d872f2087c98
* Mark some Linux tests that pass on the buildbot and locally as OK.evanm@google.com2008-12-101-9/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6668 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from platform/graphics to platform/graphics/chromium.darin@chromium.org2008-12-1024-237/+214
| | | | | | | | | | | | | Files that ended with Win.cpp now end with ChromiumWin.cpp. I also cleaned up FontUtils[Chromium]Win.cpp so that it no longer depends on base/ or STL. R=brettw,jungshik Review URL: http://codereview.chromium.org/13304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6667 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some unnecessary cruft from this vcproj.darin@chromium.org2008-12-101-22/+0
| | | | | | | | R=maruel Review URL: http://codereview.chromium.org/13314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6666 0039d316-1c4b-4281-b951-d872f2087c98
* Linux rebaseline: LayoutTests/tables/mozilla/bugs/bug4093agl@chromium.org2008-12-104-2/+38
| | | | | | | | The text here is slightly too wide because of known rounding errors with phantom points in FreeType. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6665 0039d316-1c4b-4281-b951-d872f2087c98
* Linux rebaseline: LayoutTests/tables/mozilla/bugs/bug16252agl@chromium.org2008-12-104-2/+541
| | | | | | | | The lowercase 'c' in this font is 1px wider with FreeType due to known phantom point rounding differences. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6664 0039d316-1c4b-4281-b951-d872f2087c98
* Linux rebaseline: LayoutTests/tables/mozilla/bugs/bug2886-2.htmlagl@chromium.org2008-12-094-2/+108
| | | | | | | | The CSS specifies many non-free fonts which we aren't going to be able to match on Linux. Thus we rebaseline. Image diffs have been manually reviewed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6663 0039d316-1c4b-4281-b951-d872f2087c98
* Linux rebaselining: missed adding LINUX tags to some lines.agl@chromium.org2008-12-091-7/+7
| | | | | | | | | When merging the manual diff comments, my script didn't actually check that LINUX was included in the platform list of the test. These tests are the ones which will start failing when we turn on pixel tests. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6661 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Avoid using a block file to full capacity if there isrvargas@google.com2008-12-091-3/+17
| | | | | | | | | | | | another file already chained to this one. The second timer of DiskCacheTest.BlockFilesPerformance (net_perftests) is reduced by ~60% (YMMV). Review URL: http://codereview.chromium.org/13677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6660 0039d316-1c4b-4281-b951-d872f2087c98
* Add a batch file for running the webkit tests. Similar to the .sh version, ↵brettw@google.com2008-12-091-0/+1
| | | | | | | | this makes it easier for people using cmd to run the webkit tests (and use the correct version of python). Review URL: http://codereview.chromium.org/13605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6659 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 05:21:47 +0000