| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Removed methods for querying and enabling media cache as the cache has been stable enough we shouldn't have to worry about checking anymore.
BUG=None.
TEST=No specific test as this flag hasn't been used.
Review URL: http://codereview.chromium.org/4266001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61424
TEST=valgrind tests should pass.
Review URL: http://codereview.chromium.org/4104016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60211
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64960
Review URL: http://codereview.chromium.org/4222005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that has a buffer with an offset beyond the start of the
read.
The read logic was incorrectly calculating the eof for an
entry as the current size minus the unreported size, so it
was assuming that a buffer with a large offset was always
extending the file... so it was returning zeros for the data.
Now we don't attempt to keep buffers that extend a file, and
the eof computation was fixed to be just the current lenght.
BUG=59275
TEST=net_unittests
Review URL: http://codereview.chromium.org/4289004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
jglasgow@chromium.org:
Change the libcros API for cellular data plans keep all memory
allocation and deletion within libcros.
BUG=chromium-os:8297
TEST=ad hoc
Review URL: http://codereview.chromium.org/4270004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4303002
Patch from Varun Jain <varunjain@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41113
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents super-long titles/URLs in the content from making the bubble enormous. Also, if the bubble has multi-line strings, set its minimum width to 250. (This replaces some code that set the multi-line string width to exactly 256 regardless of the rest of the content.)
Also, elide the popup titles/URLs in the middle instead of the ends, in hopes of preserving more unique portions of them.
BUG=41113
TEST=Visit a test page that opens a popup with a very long URL or title. The popup blocked bubble should not become enormous.
Review URL: http://codereview.chromium.org/4242003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add path validation for SaveAs dialog in FileBrowse DOMUI;
- Add a UserCrosSettingsProvider instance to ExistingUserController.
This triggers cached settings refresh on login screen and protect us from
setting spoofing.
BUG=chromium-os:7738
TEST=Verify user could not save file outside default download dir andoverify that spoofed settings will be reverted on login screen show up.
Review URL: http://codereview.chromium.org/4181008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61518
TEST=none
Review URL: http://codereview.chromium.org/4449002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
auth.
Known Limitations:
- Only SSL3/TLS1.0 handshakes are supported. It's unlikely
SSLv2 will/should ever be implemented. NSS does not yet
support TLS1.1/1.2.
- On Windows, only CryptoAPI keys are supported. Keys that
can only be accessed via CNG will fail.
Technical Notes:
Windows:
- Only the AT_KEYEXCHANGE key is used, per
http://msdn.microsoft.com/en-us/library/aa387461(VS.85).aspx
- CryptSetHashParam is used to directly set the hash value.
This *should* be supported by all CSPs that are compatible
with RSA/SChannel, AFAICT, but testing is needed.
NSS:
- The define NSS_PLATFORM_CLIENT_AUTH is used to guard all
of the new/patched code. The primary implementation
details are in sslplatf.c.
Patch author: Ryan Sleevi <rsleevi@chromium.org>
Original review URL: http://codereview.chromium.org/2828002
BUG=148,37560,45369
TEST=Attempt to authenticate with a site that requires SSL
client authentication (e.g., https://foaf.me/simpleLogin.php
with a FOAF+SSL client certificate).
Review URL: http://codereview.chromium.org/3455019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and add some more DCHECKs
Some commands should never have a negative count
since the count refers to how much memory to access.
So, made those commands check for negative count on the client
side and kill the GPU process if they are negative on the
service side.
Note: Someone (me?) checked in a version of build_gles2_cmd_buffer.py
that generates a Finish handler that actually calls glFinish but
didn't check in the generated code.
Should I put that back to glFlush?
TEST=ran unit tests and opengl es 2.0 conformance tests
BUG=none
Review URL: http://codereview.chromium.org/4461001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change extends the log severities into the negative for VLOG verbosities.
It also keeps track of file/line information and passes it to any registered log handler.
The log level is naturally controlled by translating ETW log levels to the severities.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4164011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add some tests.
BUG=none
TEST=interactive_ui_tests --gtest_filter=InstantTest.*
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61908
TBR=glider
Review URL: http://codereview.chromium.org/4484001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There seems to be cases where there is an event with no type and get_type return a success code (probably S_FALSE, but I couldn't confirm it) and doesn't set the type string pointer return argument.
BUG= 61900
TEST= Make sure we still get proper web progress notifications...
Review URL: http://codereview.chromium.org/4444002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4398002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
without doing anything in the test it was timing out.
BUG=30519
TEST=self
Review URL: http://codereview.chromium.org/4158009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61746
TEST=Install an outdated extension. Clear the cache. Upadte extensions, see that new extension was downloaded. Reload about:cache. No entry for manifest or CRX present.
Review URL: http://codereview.chromium.org/4275002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
case being renamed
BUG=57832
TBR=garykac
Review URL: http://codereview.chromium.org/4425003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(no functional changes, just tidying up gyp).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4396003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This flag does not take effect when passed to browser processes, remove the comment lines saying otherwise.
BUG=None
TEST=compiles
Review URL: http://codereview.chromium.org/4213001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This broke v8 builders.
TBR=evan
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Libraries that depend on other targets cause the propagation of the other targets closure of library targets to all their dependents. This was the case with chrome_frame_ie, which caused npchrome_frame to link gmock and gtest.
Best case, this will slow down the build.
Worst case we're open to regressions that ship test code, as useful as our unittests are, I don't think users have much appreciation for installing them :).
This may require another change in build\all.gyp, as building the crash tests is no longer implicit in building npchrome_frame.
Also removed the base_noicu target, as all its dependents have a dependency on base.lib, so this won't prevent ICU usage regressions.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/4406001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separate the parts of ExternalPrefExtensionProvider that store the list of external extensions and the parts that parse the preference file. This makes it possible for other providers to reuse the storage code.
Also make it possible to have external extensions from update URLs with locations other than Extension::EXTERNAL_PREF_DOWNLOAD, by making it a parameter of OnExternalExtensionUpdateUrlFound.
Add new provider (ExternalPolicyExtensionProvider) to provide external extensions from policies.
BUG=59782
TEST=ExtensionsServiceTest.ExternalPrefProvider,ExternalPolicyExtensionProvider.*
Review URL: http://codereview.chromium.org/3826008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61054
TEST=PListWriterUnittest.*,PListStringsWriterUnittest.*
Review URL: http://codereview.chromium.org/4318001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dumi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=browser_tests:*.WebNavigationEvents*,unit_tests:FrameNavigationStateTest.*
Review URL: http://codereview.chromium.org/4381001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dumi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dumi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dumi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
use the library.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add a URL chrome://keyboardoverlay/ for keyboard overlay.
BUG=chromium-os:6268
TEST=manually on the net book
Review URL: http://codereview.chromium.org/4226001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The timezone change has been already prohibited by r64579 in C++,
but we should also disable this in the system settings page.
Note that manually_disabled is introduced in pref_ui.js since setting
"disabled = true" in options pages is overridden in the event
listener in pref_ui.js.
BUG=chromium-os:8541
TEST=confirmed that the timezone selection was disabled in guest mode.
Review URL: http://codereview.chromium.org/4296001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
You know when you're running the unit tests and windows pop up and a
sheet slides in? This makes them not do that. Found this setting
while researching something else.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4410002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4468001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/4426004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/4469001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61849
TEST=none
TBR=dmazzoni@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8400
TEST=make sure cellular connection can be activated from chrome:mobilesetup
Review URL: http://codereview.chromium.org/4333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4425002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is because the primary application of this class of GLContext is for testing and we do not want every GL related ui browser test to become flaky if there is a race condition between GL context destruction and window destruction.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/4458001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[I actually did this two months ago, and though I had committed it, but
due to the "git cl push" vs "git cl dcommit" craziness, it was never
in the tree.]
It was previously reviewed and LGTM'd here:
http://codereview.chromium.org/3235007/show
BUG=none
TEST=Tested on device, both using large numbers of tabs, and
small tabs that used lots of memory.
Review URL: http://codereview.chromium.org/4446002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also move the unittest.
BUG=None
TEST=compiles
Review URL: http://codereview.chromium.org/4352002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for now. It looks like run_testserver is crashing.
BUG=none
TEST=none
TBR=darin
Review URL: http://codereview.chromium.org/4411002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=compiles
Review URL: http://codereview.chromium.org/4233005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=test_directory_reader.cc
Review URL: http://codereview.chromium.org/4107004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These files probably just predate us having a _win suffix on Windows-specific
code.
BUG=18504
TEST=compiles
Review URL: http://codereview.chromium.org/4451001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65001 0039d316-1c4b-4281-b951-d872f2087c98
|