| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
"myIpAddress" <-- [partial]}.
Also adds a utility function to net_util for turning a addrinfo into an IP address string.
BUG=2764
Review URL: http://codereview.chromium.org/31009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
one-pixel-wide black lines, one horizontal and one vertical, which occur on the top and left of the box respectively. This gives the box a 3-D appearance. After reviewing the SVG code, it seems we are doing the right thing; i.e., the code specifies to draw these lines with stroke-width="1" to give the 3-D appearance. I am thinking that in the original mac baseline, these lines are not prominent due to difference in Skia SVG line handling and shading.
Review URL: http://codereview.chromium.org/28321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
works by emptying the IPC message loop of its tasks, which frees the SyncContext object. After this is checked in, I'll keep an eye to see if the same thing needs to be done for the SyncChannel tests (they seem to not be generating errors, from looking at the last dozen runs).
Review URL: http://codereview.chromium.org/28307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27299
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=deanm
Review URL: http://codereview.chromium.org/27348
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
WTL and not from ATL...
TBR=deanm
Review URL: http://codereview.chromium.org/28326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=deanm
Review URL: http://codereview.chromium.org/27347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mark
Review URL: http://codereview.chromium.org/27346
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mark
Review URL: http://codereview.chromium.org/28322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=tony
Review URL: http://codereview.chromium.org/27343
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
all of our webkit projects. Glue was missing it, so it didn't
compile.
TBR=darin
Review URL: http://codereview.chromium.org/31019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mbelshe
Review URL: http://codereview.chromium.org/27341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28319
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=mbelshe
Review URL: http://codereview.chromium.org/28226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=mark
Review URL: http://codereview.chromium.org/27336
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separate the platform specific AutocompleteEditView from the cross-platform model and controller. This leaves the model/controller in autocomplete_edit.{h,cc}, and moves the view into autocomplete_edit_view.h and autocomplete_edit_view_win.{h,cc}.
There is now an abstract interface (AutocompleteEditView) which the model uses to talk to the view. Other views (for example, the LocationBarView) will still talk directly to the AutocompleteEditViewWin, which is the full Chrome view.
This change also pulled in the Windows specific edit_drop_target code into autocomplete_edit_view_win.cc.
Review URL: http://codereview.chromium.org/27327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Windows.
Review URL: http://codereview.chromium.org/28318
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
we should only be making opaque the part of the layer that we actually drew
to (since the layer opaquifier doesn't know about clip masks).
Review URL: http://codereview.chromium.org/28284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- we had a large pile passing, but expected to fail, fixed.
- updated for a few tests that aren't always passing on the bots.
w/ these we should be green on the debug bot, but the release bot still sees
some random patterns i can't prevent failures w/ yet.
Review URL: http://codereview.chromium.org/27338
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is hard to instantiate platform-specifc classes (like the AutocompletePopupView) from cross-platform classes (like the model).
This does what makes more sense, create platform specific instances from platform specific code. The AutocompleteEditView now creates the AutocompletePopupView. The AutocompletePopupView now creates the AutocompletePopupModel.
This also requires exposing AutocompletePopupViewWin, so that in the future the AutcompletePopupViewWin will be able to be created with an AutocompleteEditViewWin pointer. This sort of reverts some of my previous changes, as is pulls the interface out of autocomplete_popup_view_win.cc and into autocomplete_popup_view_win.h. This is sad but neccessary.
This removes the AutocompletePopupView::CreatePopupView factory, and replaces it by directly instantiating the platform-specific view instance.
Review URL: http://codereview.chromium.org/28313
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28317
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
break the build.
TBR=cpy
Review URL: http://codereview.chromium.org/27331
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Evaluating a script that throws an uncaught exception should not
interfere with evaluating other code from C++ when the call to
evaluate returns.
I put indentical code in the V8Bridge a while ago and it seems to have
been lost in the unforking process.
BUG=4336
BUG=7773
BUG=8007
R=kasperl@chromium.org
Review URL: http://codereview.chromium.org/27326
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28297
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Convert the Mac build to the new GYP-based Xcode build, and remove the old
Xcode projects.
Review URL: http://codereview.chromium.org/28305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8158
Review URL: http://codereview.chromium.org/27285
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/2378/steps/purify%20test:%20unit/logs/stdio), but DeleteURLAndFavicon started failing mysteriously after my checkin.
Review URL: http://codereview.chromium.org/28304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
unless its preceeded by the switch terminator. This is to
prevent chromehtml: urls to supply arguments to Chrome.
BUG=5825
Review URL: http://codereview.chromium.org/20469
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR= cpu
Review URL: http://codereview.chromium.org/27314
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
takes half the time.
TBR=erikkay
Review URL: http://codereview.chromium.org/28300
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
mode.
BUG=7933
Review URL: http://codereview.chromium.org/27311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These are more effects of the recent webkit merge. It looks like dimich has his work cut out for him :)
TBR=jhawkins
Review URL: http://codereview.chromium.org/27309
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/29009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't call SetPriorityClass if CBSText.dll is loaded in the browser process. The
CBSText.dll loads as a global GetMessage hook into the browser process and
intercepts/unintercepts the kernel32 API SetPriorityClass in a background
thread. If the browser calls this API just
when it is intercepted the dlls interceptor proc messes up the stack while
returning back, which causes random crashes in the browser.
The hacky fix for now is to check for this dll and not invoke the API. We will
beautify this fix if it works in the wild.
This fixes http://code.google.com/p/chromium/issues/detail?id=6418
Bug=6418
Review URL: http://codereview.chromium.org/27298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
template page
Review URL: http://codereview.chromium.org/28172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
corner of the screen.
BUG=8151
Review URL: http://codereview.chromium.org/28247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27304
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/27303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
'WIN MAC :'.
This is follow up on review in http://codereview.chromium.org/27301
Review URL: http://codereview.chromium.org/27302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
platform specify its own downloads directory.
On mac this is unimplemented. On windows it remains the user document directory + "\Downloads\", and on linux we attempt to follow their XDG setting, but fall back to ~/Downloads if they have an unsafe value in their XDG setting.
Review URL: http://codereview.chromium.org/28167
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Call it from the Browser. (no-op if not packaged for branding).
Add new build target "app_packaging" to package (if possible).
(app_packaging target intentionally left out of "All").
For convenience, here is the app_packaging script embedded in the xcodeproj:
PACKAGER="${PROJECT_DIR}/tools/mac/package_chrome.sh"
if [ -f "${PACKAGER}" ]; then
"${PACKAGER}"
fi
Mark, I know this is not in gyp... I am happy to have this klobbered
and redo it (in gyp) at the appropriate time.
Review URL: http://codereview.chromium.org/27293
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Mozilla's implementation.
R=darin,eroman
BUG=6567,6824
Review URL: http://codereview.chromium.org/28144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Not complete since we are waiting for translations
- For chromium the tooltip says "Browse the internet"
BUG=b/1522969
Review URL: http://codereview.chromium.org/28272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit API now provides:
- layoutTestMode
- support for registering extra local URL schemes
- access to the current WebKitClient
WebKitClient was extended to include:
- access to the default locale
- access to the current time
- methods to start/stop the shared timer
- method to get work scheduled on the main thread
- methods to access cookies
- method to prefetch hostnames
R=dglazkov
Review URL: http://codereview.chromium.org/27276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10665 0039d316-1c4b-4281-b951-d872f2087c98
|