| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove button from options menu and only show it on hover
- allow MenuButton to be created with or without border for normal state
- make font size and color of all labels, buttons and dropdowns black and medium font respectively
- extract creation of label into private function to reduce code
- use new special image for all menu drop arrows
- modify base class MenuButton's menu_marker_ image to a non-const and allow it to be set
BUG=38296
TEST=verify per bug report.
Review URL: http://codereview.chromium.org/1150002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=wtc
Review URL: http://codereview.chromium.org/1155001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Following bug instructions, the only crash I
could reproduce was this timer-related one.
TBR=erikkay@chromium.org
BUG=35815
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=38104
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38845
TEST=Pass a ftp server response having two double quotes with no character in between and verify no browser crash happens.
Review URL: http://codereview.chromium.org/1082008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dpranke
TEST=rarely
BUG=verily
Review URL: http://codereview.chromium.org/1142006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1118005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch over to use test_expectations upstream.
TBR=dpranke
TEST=never
BUG=often
Review URL: http://codereview.chromium.org/1093006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions, and if there are loaded extensions we probably loaded them
explicitly (and got a notification thereof) so don't list them either.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1081008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1073005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some firewalls apparently try to preclude a "syn flood to host" by limiting
the number of syn's (used to open a TCP/IP socket) that are outstanding
without having received a syn-ack. Presumably this is to prevent a user
from participating in a syn-flood attack (which traditional sends a lot
of syn packets, with false return addresses, resulting in no responses).
Apparently this firewall technology has in some cases been extended
to include UDP sessions for which there has been no response, and this
may include DNS resolutions. Since the prefetcher currently resolves
as many as 8 names simultaneously, this is remarkably close to the
reported threshold of 10 un-answered connections. This test attempts
to limit connections to 2, 4, or 6, so that we can see if this helps
users.
In TCP, the RTO remains (under windows) at a full 3 seconds until after the
first ack is received. As a result, if the first data packet sent (after
the SYN) is lost, then TCP won't resend until after 3 seconds without an ack.
As a test, we split up the first packet into two parts (the second part
containing only one byte). This is done as an A/B test, and we'll see
if we get a measurable improvement in page-load-time latency.
Finally, to get better page load stats, I adjusted the PLT histograms
so that we record a "final" time for abandoned pages when they are
closed (even if they didn't finish rendering, etc.). This should give
a much more fair PLT comparison for all network latency experiments.
BUG=3041
BUG=12754
r=mbelshe,darin
Review URL: http://codereview.chromium.org/1088002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=built on Linux
BUG=none
Review URL: http://codereview.chromium.org/1125005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36629
TEST=net_unittests
Review URL: http://codereview.chromium.org/1120007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
sidetabs mode.
Reliability bot and Linux CrOS browser_tests all had crashes in ~TabStrip.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1141005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
libraries that we don't actually use.
TEST=built on Linux and ran it
BUG=none
Review URL: http://codereview.chromium.org/1072008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
bots due to a gyp/incredibuild issue.
Review URL: http://codereview.chromium.org/1109008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=temporary
Review URL: http://codereview.chromium.org/1140002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We keep track of which plugins we've already considered loading,
and skip them if we encounter them again. This situation is common
on Linux where people have many different symlinks pointing to the
same plugin.
BUG=38764
TEST=See bug for bad output without this patch; output with this patch is now good.
Review URL: http://codereview.chromium.org/1149005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38575
TEST=Valgrind Linux goes green.
Review URL: http://codereview.chromium.org/1096007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Second try with the following changes:
- Remove FLAKY_ from Feed tests and makes sure they pass.
BUG=4890,38609
TEST=browser_test.exe
Run Chrome, Press Ctrl+Shift+B. The new bookmark manager should open in a tab.
Review URL: http://codereview.chromium.org/1127006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38611
TEST=Built the mini_installer and verified that the files are in chrome.7z.
Review URL: http://codereview.chromium.org/1082006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=srsly
Review URL: http://codereview.chromium.org/1095006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14184
TEST=see bug
Review URL: http://codereview.chromium.org/1105006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the panel)
so that a user can delete multiple notification by clicking mouse on the same position.
BUG=33306
TEST=none. I will add tests next week.
Review URL: http://codereview.chromium.org/1147003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of gdk gdk itself maintains the mask to apply and ends up blowing away
our request for property change events. Using gdk_set_events doesn't
seem to have this problem.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1076007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1001003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36587
TEST=Open an incognito window and open the Downloads page for it. Now download something in the OTR window. The item should show up in the downloads page but it should be lighter and have a OTR icon background.
Review URL: http://codereview.chromium.org/1126005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file.
If one tries to upload a file that one doesn't have read access to,
the browser livelocks. It tries to read from the file, gets nothing
but spins forever because it knows that it hasn't finished reading.
To address this, firstly we add a check at stat() time to make sure
that we can read the file. However, this doesn't take care of the case
where the access() call was incorrect, or the permissions have changed
under us. In this case, we replace the missing file with NULs.
BUG=30850
Review URL: http://codereview.chromium.org/541022
TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/1145004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=521
TEST=none
Review URL: http://codereview.chromium.org/1079007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If one tries to upload a file that one doesn't have read access to,
the browser livelocks. It tries to read from the file, gets nothing
but spins forever because it knows that it hasn't finished reading.
To address this, firstly we add a check at stat() time to make sure
that we can read the file. However, this doesn't take care of the case
where the access() call was incorrect, or the permissions have changed
under us. In this case, we replace the missing file with NULs.
BUG=30850
Review URL: http://codereview.chromium.org/541022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12673,20459,20504
TEST=Valgrind Mac UI tests go green.
Review URL: http://codereview.chromium.org/1107009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=perf steps are green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1084012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We now guarantee the server cert is verified before sending a client cert.
BUG=38550
TEST=none (manual testing with five different public sites that use client certs)
Review URL: http://codereview.chromium.org/1116003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
chromium-linux-fontconfig-renderstyle.html to work.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1075010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
so that they don't include the name 'app'.
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
BUG=38704,38706
TEST=none
Review URL: http://codereview.chromium.org/1079008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37100
TEST=added new ui test
Review URL: http://codereview.chromium.org/1047006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=35248
TEST=Switch the language used by the ChromiumOS using the top left corner menu of the Network selection wizard.
Or you may use the following command on desktop using Chromium (built with GYP_DEFINES="chromeos=1"):
out/Debug/chrome --login-manager --login-screen=network
Review URL: http://codereview.chromium.org/1148003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
trunk/tools/dashboards.
TBR=ojan
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
AutoFill dialog. If the user has opened the dialog, AutoFill is implicitly enabled.
BUG=38538
TEST=none
Review URL: http://codereview.chromium.org/1077003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1142001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This undoes r42117 as I figured out what was going on.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42137 0039d316-1c4b-4281-b951-d872f2087c98
|