summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* posix: restore IPC loggingevan@chromium.org2009-07-271-0/+10
| | | | | | | | | | In the recent refactoring of IPC, it appears logging on POSIX was lost. The file modified here later checks an #ifdef that is set by the now-included ipc_message.h to set up POSIX logging. Review URL: http://codereview.chromium.org/159418 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21679 0039d316-1c4b-4281-b951-d872f2087c98
* Fix port disconnect so that it's refcounted. This fixes a bug where a channelmpcomplete@chromium.org2009-07-275-6/+122
| | | | | | | | | | | would close if any one listener on the channel called "disconnect()". BUG=16644 TEST=no Review URL: http://codereview.chromium.org/155476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21678 0039d316-1c4b-4281-b951-d872f2087c98
* Widen suppression for bug 17385 again. Should suppress warningdkegel@google.com2009-07-271-4/+2
| | | | | | | | | | | seen this morning in http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/1364/steps/valgrind%20test:%20unit/logs/stdio BUG=17385 TEST=watch valgrind unit tests go green Review URL: http://codereview.chromium.org/160168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21677 0039d316-1c4b-4281-b951-d872f2087c98
* Deps roll for newer gtm to pick up more localization support.thomasvl@chromium.org2009-07-271-1/+1
| | | | | | Review URL: http://codereview.chromium.org/160183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21676 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid calls to gtk_widget_get_pointer during mouse move iftc@google.com2009-07-271-7/+15
| | | | | | | | | | | | | not necessary. This is to work around janky scrolling behavior that brad was seeing. I can't repro, so he'll have to tell me if this works for him BUG=16786 Review URL: http://codereview.chromium.org/160179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21675 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for occasional leak in SVGNames::init, seen on dank@chromium.org2009-07-271-0/+9
| | | | | | | | | | | http://build.chromium.org/buildbot/waterfall/builders/Linux%20UI%201%20of%203%20(valgrind)/builds/239/steps/valgrind%20test:%20ui/logs/stdio this morning (and fairly often before that). BUG=17795 TEST=watch valgrind UI bots for a day or two and verify no leak in SVGNames::init Review URL: http://codereview.chromium.org/159420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21674 0039d316-1c4b-4281-b951-d872f2087c98
* Make downloads not prevent tabs from closing.brettw@chromium.org2009-07-279-40/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If a download creates a cross-site transition (for example, if you click a link in Gmail that results in a download in a new tab), that tab will be stuck and you can't close it or the browser. This is the opposite problem with a similar cause as bug 16246. In both cases we were using some secondary signal to tell us if we're closing for a cross site transition or closing the tab, and that signal was wrong. In this case, we were running the onunload handler, but because there was a pending RenderViewHost, the RenderManager would think that the close was a cross-site one, and not forward the close message to actually close the tab. This patch adds a flag to the on unload handlers that indicates whether it's for a tab closure or a cross-site transition, so we can do the right thing unambiguously when the message returns. In this case I keep this information in the RenderView in case we send multiple close requests, we'll close the tab if any of them were for the entire tab, even if that particular one was dropped because we don't want to have more than one in flight at once. BUG=17560 TEST=none. Review URL: http://codereview.chromium.org/160122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21673 0039d316-1c4b-4281-b951-d872f2087c98
* Make AutomationProxyTest.NavigateToURLWithTimeout* tests not-flaky.phajdan.jr@chromium.org2009-07-277-18/+148
| | | | | | | | | | | I used a mock url request job which is guaranteed to finish after the timeout the test uses. TEST=none http://crbug.com/16462 Review URL: http://codereview.chromium.org/155941 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21668 0039d316-1c4b-4281-b951-d872f2087c98
* Implement delete key for the Remove action in the bookmark manager.estade@chromium.org2009-07-272-9/+36
| | | | | | | | | | | | Although we will also need to implement certain other hotkeys such as Ctrl+C and so forth, I see no point in adding an accelerator group as we do not want the accelerators to work when the tree views don't have focus. Also we don't want the menu to show the accelerators. Also, fix a bug where the organize menu could be stale. mdm pointed out that ctrl+clicking the selection could lead to an empty selection. BUG=17393 Review URL: http://codereview.chromium.org/160137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21664 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add GYP variable to use the system libpng.agl@chromium.org2009-07-273-49/+90
| | | | | | | | | | | | Since our packagers have been requesting that we support using more system libraries, I'm starting to commit these sorts of changes. However, please note that one MUST NOT use the system libpng on, at least, Ubuntu 64-bit. Because Chromium on Linux is still a 32-bit build we end up with the 32-bit compat versions of libraries and, on Ubuntu at least, this includes a very old libpng with security issues. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21663 0039d316-1c4b-4281-b951-d872f2087c98
* Add experimental TSAN support (off by default)dkegel@google.com2009-07-271-0/+13
| | | | | | Review URL: http://codereview.chromium.org/160042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21659 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: gtk_window_present when an already-showing browser window is showing ↵estade@chromium.org2009-07-271-1/+2
| | | | | | | | | | | | and we want to show it again. I think this will be very WM-specific on whether it works. It seems that a lot of WMs don't want to allow windows from groups that don't have focus to do this. For example: http://blogs.gnome.org/metacity/2007/12/24/stacking/ BUG=17767 Review URL: http://codereview.chromium.org/160149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21657 0039d316-1c4b-4281-b951-d872f2087c98
* rolling backpinkerton@chromium.org2009-07-272-3/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21652 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling to WebKit r46389 with one test failure. TBR=dglazkovpinkerton@chromium.org2009-07-272-1/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21650 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid runtime linker warning dkegel@google.com2009-07-271-2/+13
| | | | | | | | | | | | "Symbol `SSL_ImplementedCiphers' has different size in shared object, consider re-linking" if SSL_ImplementedCiphers is different size on target system than it was on build system. BUG=12826 TEST=run on Jaunty, look for "Symbol `SSL_ImplementedCiphers' has different size in shared object" in console output Review URL: http://codereview.chromium.org/118367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21649 0039d316-1c4b-4281-b951-d872f2087c98
* Give crashed tabs the crashed tab icon on the Mac.avi@chromium.org2009-07-279-124/+266
| | | | | | | | | BUG=none TEST=crash a page and see if the icon shows up (animated) Review URL: http://codereview.chromium.org/160113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21648 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at Mac history menu.rohitrao@chromium.org2009-07-2712-9/+842
| | | | | | | | | | | | | | | | * The menu has two sections: most visited and recently closed. * Creates a HistoryMenuBridge that observes different data sources and stores results for use in the menu. * Creates a HistoryMenuController to respond to Cocoa IBActions from the menu. BUG=14933 TEST=History menu in mac should populate with most visited and recently closed sites. RELEASE_NOTES=Add initial implementation of the Mac history menu. Patch by Robert Sesek. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21639 0039d316-1c4b-4281-b951-d872f2087c98
* reenable a disabled part of a unit testerikkay@chromium.org2009-07-272-6/+4
| | | | | | | | | BUG=15363 TEST=ExtensionsService.LoadAllExtensionsFromDirectorySuccess Review URL: http://codereview.chromium.org/159388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21638 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: split console evaluation into two steps: actual evaluation and resultyurys@google.com2009-07-2712-30/+184
| | | | | | | | | | | wrapping. When second step is executed debugger_agent_manager will autocontinue on break. We assume that second step doesn't call user scripts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21635 Review URL: http://codereview.chromium.org/159395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21637 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 21635.yurys@google.com2009-07-2711-183/+29
| | | | | | Review URL: http://codereview.chromium.org/159399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21636 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: split console evaluation into two steps: actual evaluation and resultyurys@google.com2009-07-2711-29/+183
| | | | | | | | | wrapping. When second step is executed debugger_agent_manager will autocontinue on break. We assume that second step doesn't call user scripts. Review URL: http://codereview.chromium.org/159395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21635 0039d316-1c4b-4281-b951-d872f2087c98
* Fix location bar display.thakis@chromium.org2009-07-271-1/+1
| | | | | | | | | BUG=17667 TEST=see bug Review URL: http://codereview.chromium.org/160142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21634 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Change the lower right section to say "What will we put here?"arv@google.com2009-07-272-5/+4
| | | | | | | | | | | | TBR=glen@chromium.org BUG=None Test=None Review URL: http://codereview.chromium.org/159393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21633 0039d316-1c4b-4281-b951-d872f2087c98
* add test to verify mole data being readerikkay@chromium.org2009-07-261-0/+3
| | | | | | | | TBR=mpcomplete Review URL: http://codereview.chromium.org/160148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21632 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the concept of threading from ProxyService, and move it into the ↵ericroman@google.com2009-07-2617-325/+1108
| | | | | | | | | | | | | | | | | | | | | | | | ProxyResolver dependency. ProxyResolver may now complete requests asynchronously, and is defined to handle multiple requests. The code from ProxyService that queued requests onto the single PAC thread has moved into SingleThreadedProxyResolver. This refactor lays the groundwork for: (1) http://crbug.com/11746 -- Run PAC proxy resolving out of process. (Can inject an IPC bridge implementation of ProxyResolver) (2) http://crbug.com/11079 -- Run PAC proxy resolving on multiple threads. (Can implement a MultithreadedProxyResolver type class; still complications around v8 threadsafety though). BUG=http://crbug.com/11746, http://crbug.com/11079 TEST=existing unit-tests. Review URL: http://codereview.chromium.org/149525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21631 0039d316-1c4b-4281-b951-d872f2087c98
* Update gitignoreevan@chromium.org2009-07-261-1/+1
| | | | | | | | | | Protobuf was removed in favour of protobuf2. (Patch by Joel Stanley) Review URL: http://codereview.chromium.org/159334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21630 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: move close devtools button to the right.pfeldman@chromium.org2009-07-261-1/+2
| | | | | | | | BUG=17434 TBR=yurys git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21629 0039d316-1c4b-4281-b951-d872f2087c98
* Fix exception in DownloadManager if the download has no extension.aa@chromium.org2009-07-261-1/+2
| | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/159392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21628 0039d316-1c4b-4281-b951-d872f2087c98
* Modify detection of Chrome extensions in download manager. Itaa@chromium.org2009-07-261-3/+17
| | | | | | | | | | | | | | turns out many servers send the no-sniff option, including the one we use for our sample extensions. So we can't rely on mime types to detect Chrome extensions, at least until we have some place to put our samples that doesn't have this problem. TBR=erikkay Review URL: http://codereview.chromium.org/159391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21627 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to commit r21622: Add infobar preview for themes,aa@chromium.org2009-07-269-40/+174
| | | | | | | | remove --enable-extension requirement. Review URL: http://codereview.chromium.org/159390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21626 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revisions 21622-21624.aa@chromium.org2009-07-269-186/+48
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21625 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken tree.aa@chromium.org2009-07-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21624 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken tree on mac/linux.aa@chromium.org2009-07-263-1/+1
| | | | | | Review URL: http://codereview.chromium.org/159389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21623 0039d316-1c4b-4281-b951-d872f2087c98
* Add infobar preview for themes, remove --enable-extensionaa@chromium.org2009-07-269-48/+186
| | | | | | | requirement. Review URL: http://codereview.chromium.org/160141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21622 0039d316-1c4b-4281-b951-d872f2087c98
* add mole info to toolstrip definition and enable moleserikkay@chromium.org2009-07-2617-98/+242
| | | | | | Review URL: http://codereview.chromium.org/159202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21621 0039d316-1c4b-4281-b951-d872f2087c98
* Make the download manager display a scary file warning if anaa@chromium.org2009-07-253-29/+51
| | | | | | | extensions is not from the gallery. Review URL: http://codereview.chromium.org/159379 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21620 0039d316-1c4b-4281-b951-d872f2087c98
* * notify theme loading with --load-extensionerikkay@chromium.org2009-07-251-11/+22
| | | | | | | | * fix crasher in theme parsing with no images Review URL: http://codereview.chromium.org/160124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21619 0039d316-1c4b-4281-b951-d872f2087c98
* Adds strings for possible future web clips on the new tab pagearv@google.com2009-07-251-0/+170
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/160135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21618 0039d316-1c4b-4281-b951-d872f2087c98
* npruntime_util.h in webkit/glue should use the absolute path to npruntime.hjorlow@chromium.org2009-07-252-3/+1
| | | | | | | | | | | | rather than the "bindings/npruntime.h" that we must use in the WebKit API code. Change this back and revert the DEPS file change that allowed it to happen. BUG=none TEST=none Review URL: http://codereview.chromium.org/160140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21617 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add hints for the DEPs roll of InspectorBackend.pfeldman@chromium.org2009-07-252-1/+23
| | | | | | Review URL: http://codereview.chromium.org/160101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21616 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the tips service by default.arv@google.com2009-07-259-17/+38
| | | | | | | | | | | | | Update the UI to not say tips or recommendations. BUG=None TEST=Starting chrome should not show any tips byt default Review URL: http://codereview.chromium.org/160138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21615 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r21548 and r21559 due to crash spike.huanr@chromium.org2009-07-2512-116/+40
| | | | | | Review URL: http://codereview.chromium.org/159383 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21614 0039d316-1c4b-4281-b951-d872f2087c98
* Surround Sound handling by folding 5 channels down to stereo.fbarchard@chromium.org2009-07-255-5/+207
| | | | | | | | | BUG=16026 TEST=play a movie trailer with 5.1 audio. It should sound roughly the same as quicktime. Review URL: http://codereview.chromium.org/155894 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21613 0039d316-1c4b-4281-b951-d872f2087c98
* Implement mimetype sniffing for extensions.aa@chromium.org2009-07-258-7/+154
| | | | | | | | | | | abarth: can you review the changes to mime_sniffer.cc? paul: everything else? BUG=13296 TEST=Added unit tests Review URL: http://codereview.chromium.org/159345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21612 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented proper pause-then-seek behaviour for the media pipeline.scherkus@chromium.org2009-07-2516-365/+675
| | | | | | | | | | | | | | | | | | | | | | MediaFilter now has asynchronous Play() and Pause() methods that are implemented by default. Since we are a completely pull-based system, it turns out only AudioRendererBase and VideoRendererBase need to override them to halt reading from decoders. When a seek is received by the pipeline, it goes through the following state transitions: 1) Playing -> Pausing -> Paused (notify filters to stop reading) 2) Paused -> Seeking (notify filters to flush buffers and preroll) 3) Seeking -> Playing (preroll completed, resume playback) The key to this system is that there must be no pending reads in *any* filter when we start transitioning into the seeking state. That means the audio/video renderers do not complete their pausing->paused transition until they have completed all pending reads. To reiterate, since we're pulled based if the renderers are not reading any data, then *nothing* is happening in the pipeline. We get a lot of nice benefits from this assertion, namely no callbacks are ever "lost", they are always replied to until we are fully paused. Furthermore, we can guarantee that the first buffer received after a Seek() will be guaranteed to be discontinuous. This change also properly handles end-of-stream, seeking from an end-of-stream state, and displaying frames while paused. In summary, I was able to call Seek() in a while(true) loop without crashing or going out of sync. BUG=16014,16021,17456 TEST=seeking should be way more robust Review URL: http://codereview.chromium.org/160005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21611 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix the ImageOperations::CreateMaskedBitmap UMR by bringing the ↵glen@chromium.org2009-07-252-10/+11
| | | | | | | | | | | | | | unittest code in line with the other tests in image_operations_unittest. My half-educated suspicion is that alpha wasn't getting initted correctly, as a new UMR appeared in the "SkColor alpha_pixel = " line. (Can't verify as all my machines are in boxes). (This is TBR because the build is red). TBR=tony BUG=15762 TEST=Run valgrind/purify as in bug Review URL: http://codereview.chromium.org/159381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21610 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress crash for Ananta.paul@chromium.org2009-07-251-0/+3
| | | | | | | | | | TEST=None. BUG=17710 (http://crbug.com/17710) Review URL: http://codereview.chromium.org/160136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21609 0039d316-1c4b-4281-b951-d872f2087c98
* , INNTP: Adds 2 hard coded thumbnails.arv@google.com2009-07-255-7/+99
| | | | | | | | | | | | | This code needs to be rewritten after beta to handle localized content. BUG=15079 TEST=Start chrome with a new profile. There should be 2 thumbnails on the new tab page. Review URL: http://codereview.chromium.org/160126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21608 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented rest of webkit api/glue code needed for HTML5 media canPlayType().scherkus@chromium.org2009-07-257-27/+98
| | | | | | | | | | BUG=16636 TEST=we should respect the codecs= parameter when provided as a media mime type Review URL: http://codereview.chromium.org/160073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21607 0039d316-1c4b-4281-b951-d872f2087c98
* Our masker didn't account for the source image also having alpha.glen@chromium.org2009-07-252-12/+15
| | | | | | | | | BUG=17568 TEST=none Review URL: http://codereview.chromium.org/160034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21606 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 06:34:56 +0000