| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plugin.
I removed all the NaCl dependencies. Synchronous messages are now sent by NPAPI.
Removed BufferSyncInterface and replaced it with CommandBuffer. CommandBufferHelper now uses NPAPI.
Changed some unsigned ints to int32s because NPAPI doesn't support unsigned int.
There are now two subclasses of RendererCB. RendererCBLocal is for use with an in-process CommandBuffer. RendererCBRemote is for use with an out-of-process CommandBuffer.
I'm going to rearrange the locations of the source files under gpu_plugin next. CommandBuffer and GPUProcessor probably belong in the command_buffer_service library now. np_utils and system_services should be standalone libraries.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/266068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the case where the user types something that on its own isn't navigable, but might be the prefix of something else navigable.
While there are no tests for this directly, another change of mine to treat more inputs with explicit schemes as queries (e.g. "http:/") relies on this, and does unittest for it.
In order to fit the new relevance scores into the table, I went through and simplified the relevance scoring so that generally providers used the same scores for more input types. The effects of this should be barely noticeable (it affects the ranking of past search queries that are old against results from the secondary search provider), and it simplifies the code noticeably.
This also fixes a "bug" that the NavSuggest results were incremented backwards, but since we only score one of these right now there's no visible effect.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/291005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change importer will give preference to the value specified in master
preference for import_search_engine instead of ignoring it like before.
BUG=23649
TEST=Specified in above bug.
Review URL: http://codereview.chromium.org/274081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This works around webkit sensitivity to allocators that return
zero in this case.
BUG=20200
TEST=none
Review URL: http://codereview.chromium.org/302005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/303001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23649
TEST=installer_util_unittests, setup_unittests
Review URL: http://codereview.chromium.org/269107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/302006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
New code added more fwrite calls where the return code isn't handled,
causing compile errors on Fedora and other platforms.
While we're at it, use the new PLOG interface.
BUG=24347
Review URL: http://codereview.chromium.org/300007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ViewHostMsg_OpenURL IPC, it
needs to pass the referrer as well. The Chrome fixes in this CL are mostly related to passing the
HTTP referer off to the browser and from there to the ExternalTabContainer to ChromeFrame and back.
The ChromeFrame changes are basically around the same lines with one exception. When we handle the
AutomationMsg_OpenURL IPC in the activex and the active document we pass the referer if applicable
to the WebBrowser2::Navigate2 interface, which is then read by the BHO in BeforeNavigate2. We then
save away an AddRef'ed BHO pointer in TLS which is then referenced by the Active document for reading
the referer and passing it off to Chrome in the NavigateInExternalTab message.
Added a unit test in ChromeFrame which tests this case.
This fixes http://code.google.com/p/chromium/issues/detail?id=22994
Bug=22994
Review URL: http://codereview.chromium.org/274071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
about:net-internals.
This is useful when debugging IPv6 issues since you can see what the fallbacks are.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/271061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
deleted RenderWidgetHost during OnFinalMessage().
BUG=24248
Review URL: http://codereview.chromium.org/284019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18700
Review URL: http://codereview.chromium.org/292006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installer have successfully picked up the presence of the Chrome Frame Dll at build time.
This is to avoid project dependency regressions along the lines of http://crbug.com/25074 which cause Chrome Frame to build fine, but not be registered at install time.
BUG=http://crbug.com/25074
TEST=Compile of setup.exe must fail if CHROME_FRAME_BUILD is defined and the chrome frame dll is not present in the build directory.
Review URL: http://codereview.chromium.org/292013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dglazkov@chromium.org
Review URL: http://codereview.chromium.org/295006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
used for forcing Chrome OS updates.
There were many things that needed to be fixed for this to work.
Make skia's canvas return height of font for size of strings, instead of the actual height of the characters to bring it in line with Windows.
Make average character widths use pango metrics and windows dialog units. Make this lazy, to avoid most calls.
Fix bug in About panel that failed to adjust the embedded links to allow for the padding that Link adds so they can be focused.
Support gtk about panel in regular build, views in chrome os only.
Fix WindowGtk to call WindowClosing()
Fix canvas_linux::SetupPangoLayout() to wrap correctly, if passed a width
Fix Label::ComputeMultiLineFlags() to turn off eliding. With eliding the pango routines always return 1 line.
Enable focus manager in dialogs.
Version loader crashed in debug.
Review URL: http://codereview.chromium.org/282002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
layout test functionality. I kept one "test get property" since I thought we
might need to add properties to test stuff in the future, but removed basically
everything else, and reordered the file.
Review URL: http://codereview.chromium.org/302003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first of multiple patches that clean up handling of memory
regarding images. Previously, the code did several memcpy()s or
equivalents. This change:
- Creates an abstract interface RefCountedMemory which provides access to the
front() of a memory range and the size() of it. It is a RefCountedThreadSafe.
- Adds a RefCountedStaticMemory class which isa RefCountedMemory.
- Pushes RefCountedBytes up into base/ from chrome/ and make it conform to
RefCountedMemory.
- Have ResourceBundle return RefCountedStaticMemory to the mmaped() or DLL
loaded resources instead of memcpy()ing them.
- General cleanups to minimize copies in constructing RefCountedBytes.
- Use the above consistent interface in the BrowserThemeProvider, along with
special casing the loading of the new tab page background.
This patch is mostly cleanups and there should only be a slight performance
gain if any. Most of the real speedups should come in subsequent patches.
BUG=http://crbug.com/24493
TEST=Slightly faster on Perf bot; does not introduce crashes.
Review URL: http://codereview.chromium.org/288005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes are mostly code moves to extract common functionality.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/295005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No real code change.
Was found while playing around with http://crbug.com/22926
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/285010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
folder or other bookmarks folders.
TEST=none
BUG=25067
Review URL: http://codereview.chromium.org/293006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
info.
Review URL: http://codereview.chromium.org/294003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/304002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_browser_window.mm as of r28613.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/304001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the distro. On Chrome OS, we don't need to do this.
Review URL: http://codereview.chromium.org/285013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24895
TEST=DevToolsSanityTest.TestDebugIntrinsicProperties
Review URL: http://codereview.chromium.org/292014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NO CODE CHANGE.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gmock helpers.
Leak fixed - when gmock call is not satisfied, the callback that was set was leaked.
Suggestion for better names here and there are very welcome (though MF seems nice to me).
TEST=mocked tests runs
Review URL: http://codereview.chromium.org/285007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/49685.
TBR=awalker
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/292015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"figure out why windows needs to invert the setDefaultHandled() logic", which has been a very long-standing question.
BUG=19194
TEST=typing into text fields in plugin areas should
work once they are focused by clicking on the plugin.
jam: primary reviewer
pkasting: FYI, since one of the changes is a TODO(pkasting)
hbono: FYI, since this may improve IME compatibility as well
Review URL: http://codereview.chromium.org/269084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NSAutoreleasePool with scoped_nsobject.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/292011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24878
TEST=cmd-w/cmd-shift-w are always correct for close-tab/close-window when window layering changes.
Review URL: http://codereview.chromium.org/283017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This way the key view loop can't steal our events. This effectively reverts part of http://codereview.chromium.org/242069 and instead takes a bit from http://codereview.chromium.org/271054 .
BUG=24921
TEST=Open 2 tabs. Focus web. Ctrl-tab should switch tabs. Cmd-1/2 should switch tabs. Hitting backspace should go back if no textbox is focusses in the web, else it should delete in the textbox. Hitting cmd-f in docs should still open docs custom search interface.
Review URL: http://codereview.chromium.org/300002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These tests were added on the previous WebKit roll 49684:49761.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/293005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ukai
Review URL: http://codereview.chromium.org/299002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/294006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NullAudioRender::buffer_ was declared as scoped_ptr<uint8>, But
NullAudioRender::OnInitialize() sets uint8[] to it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/301001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/293001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none; This makes no functional change.
Review URL: http://codereview.chromium.org/300001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Linux does this in GtkIMContextWrapper::ProcessFilteredKeyPressEvent() by setting hardware_keycode to 0. It's a pain to change an NSEvent, so I just added a bool "skip" to NativeWebKeybordEvent and set it to "true" for rawkeydowns while ime is active.
BUG=25000
TEST=Open webpage. Focus text field. Type something, hit backspace. Text should be deleted. Focus background, hit backspace. Browser should go back one page. Focus text field, start IME (either by going to syspref->international->input menu and enabling e.g. "Kotoeri" and then selecting this in the top right corner and typing a single "a", or by just activating dead key ime on an us layout by hitting opt-u, opt-i, or opt-e), hit backspace. Browser should not go back but end IME mode.
Review URL: http://codereview.chromium.org/295003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
after inline autocomplete
BUG=24818 Funky behavior in omnibar editing
TEST=Run chromium with a clean profile, then access go/go (or similar url) for several times to make sure inputting 'g' can trigger inline autocomplete. Then input "go/go" and then check if the last char is gray.
TEST=Input something into omnibox to trigger inline autocomplete, then press ctrl-right and hold ctrl key, to move the cursor and clear the text selection, then release ctrl key, the text added by inline autocomplete should not be removed.
Review URL: http://codereview.chromium.org/287005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Implement WebFrameLoaderClient::dispatchUnableToImplementPolicy()
* Implement WebFrameLoaderClient::canHandleRequest() so that an
unkown scheme makes ResourceError.
- Introduce WebFrameClient::canHandleRequest() to avoid chrome::
dependency from webkit/glue.
- Introduce WebFrameClient::cannotShowURLError() to keep
transparency of WebURLError.
* Introduce WebFrameClient::unableToImplementPolicyWithError()
An implmentation in test_shell prints the message same as WebKit.
BUG=24074
TEST=This change enables 1 test.
Review URL: http://codereview.chromium.org/271087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/288006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chrome frame - this results in chrome frame not getting registered when setup is run.
BUG=http://crbug.com/25074
TEST=When Chrome Frame is built, the resulting mini_installer registers Chrome Frame.
Review URL: http://codereview.chromium.org/298001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with .. in them safely.
BUG=25131
TEST=Build unit_tests on Mac with default build location that contains a .. in the path.
Review URL: http://codereview.chromium.org/295001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that will protect us against these in the future.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/283026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
code from chrome\common.
Also added canvas support and hooked up NPAPI interface functions.
No tests have been added yet, so this is probably not fully ready.
Review URL: http://codereview.chromium.org/291001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parsing the Http traffic. HttpBasicStream delegates parsing to HttpStreamParser in preparation for HttpPipelinedStream.
Original review: http://codereview.chromium.org/249031
BUG=13289
TEST=unittests
Review URL: http://codereview.chromium.org/283022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=asargent
Review URL: http://codereview.chromium.org/293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29378 0039d316-1c4b-4281-b951-d872f2087c98
|