| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This change just adds a virtual destructor so scoped_ptr<TabHandler> calls it. It seems we are leaking all the objects created in DefaultTabHandler::DefaultTabHandler() because the TabHandler class does not have the virtual destructor and scoped_ptr<TabHandler> cannot call DefaultTabHandler::~DefaultTabHandler().
BUG=57251
TEST=make the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3518003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6699
TEST=boot chromium os on a netbook, select a network and click on continue,
the 'Sign in' button should be disabled, type some text in the username
AND in the password, the button should become enabled again.
Review URL: http://codereview.chromium.org/3421034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
connects the call to the existing backend implementation.
Review URL: http://codereview.chromium.org/3473021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=senorblanco
Review URL: http://codereview.chromium.org/3570002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with cocoa and gtk.
In the refactor in http://codereview.chromium.org/3398015 it seems that was missed.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3384036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) was using the wrong path for its http expectations file, so
it was never successfully loading the file
2) was not properly aborting when it could load a file, so it'd
run the full http test despite not having an expectations file
3) even with that, the http test always fails. At least it fails
quickly now.
BUG=21321
TEST=DomCheckerTest should get faster by failing fast
Review URL: http://codereview.chromium.org/3549002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
They had wrong ifdefs OS_MAC instead of OS_MACOSX.
BUG=44589
TEST=not running NoInfobarForSecondTab
TBR=joth,nsylvain
Review URL: http://codereview.chromium.org/3574001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=kinuko
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3542004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement ProduceVideoFrame() in GpuVideoDecoder and unit tests for testing
the loginc in GpuVideoDecoder.
BUG=53714
TEST=unit_tests --gtest_filter=GpuVideoDecoder*
Review URL: http://codereview.chromium.org/3414003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=scherkus
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3557001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3358020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It occasionally hungs on XP Test bot.
BUG=55642
TEST=green bot
TBR=nsylvain,willchan
Review URL: http://codereview.chromium.org/3573001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new AudioBuffersState contains current state of the audio buffers. This
object is passed all the way from the device to the audio renderer. Audio
renderer uses this information to synchronize audio.
BUG=52196,49110
TEST=see repro steps for 51637 and 52196.
Review URL: http://codereview.chromium.org/3444017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change updates a suppression rule to catch up with r60569 <http://crrev.com/60569>, which changed the parameter of RenderProcessHost::Init().
BUG=39963
TEST=make the valgrind bots green.
Review URL: http://codereview.chromium.org/3511001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add Widget::IsAccessibleWidget() that will return true when Chrome can be customized screen reader users.
BUG=37357,55902
TEST=JAWS or NVDA users have "(Incognito)" in their window title. Tablet users are unaffected.
Review URL: http://codereview.chromium.org/3427026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update to use new CryptohomeAsyncMount function signature defined in http://codereview.chromium.org/3475019/show
Needs to land simultaneously with http://codereview.chromium.org/3566001/show
BUG=chromium-os:4929
TEST=build
Review URL: http://codereview.chromium.org/3563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: This is a TODO in string_util.h)
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3404027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
signal delivery.
BUG=56388
TEST=unit test for web_resource_service still works.
Review URL: http://codereview.chromium.org/3523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The current WebKit test_expectations has a dupe. It stops us from running WebKit linux tests.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3551002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green bot
TBR=willchan
Review URL: http://codereview.chromium.org/3556002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
StartDoc returns <= 0 on failure, including when the user cancels out
of the save dialog on Windows 7.
BUG=none
TEST=Print to the Windows XPS printer, when the proxy brings up the save dialog, cancel. Proxy should stay running.
Review URL: http://codereview.chromium.org/3546001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Cloud Print Proxy.
Review URL: http://codereview.chromium.org/3547001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3555001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
uninstallation.
The important part is that it comes after the EXTENSION_UNLOADED
notification is sent. This makes it easier on the listeners, as they
can assume that extension notifications other than EXTENSION_UNINSTALLED
are sent for currently-installed extensions.
BUG=54415
TEST=BackgroundModeManagerTest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60834
Review URL: http://codereview.chromium.org/3461025
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/3528003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=clicking the exceptions links for those two tabs works again
Review URL: http://codereview.chromium.org/3517002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) move "make default" above crash reporting checkbox
2) remove Xs from top right of the first run dialogs (this is mostly aesthetic, some WMs will ignore this flag; we don't do anything crazy if users do manage to close the window(s) without making a selection)
3) remove extra vertical space between crash reporting checkbox and learn more link
4) remove "quit" button on 2nd dialog
BUG=49705
TEST=manual
Review URL: http://codereview.chromium.org/3402036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the nacl_thread class.
Moved static LaunchNaClChildProcess inline since we need access to variables from the single caller.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=728
TEST=none
Test to be added to NaCl integration bots.
Review URL: http://codereview.chromium.org/3527001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One of the big things is starting to move/declare ctors/dtors that derive from RefCounted<> to/in the implementation file.
(Saves 4 megabytes from libglue.a alone. 1 meg off libbrowser.a. Hundred of kilobyte savings in a large number of .a files; only libmedia.a grew and it's only 100k.)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3452030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* tie the lifetime of the resulting temp file to the lifetime of the URLLoader
(the plan is to later extend the lifetime of the temp file to support xhr.responseBlob)
* make it work in test_shell
* make it work for sync requests
* added OnDataDownloaded messages to report progress
A related BlobURL loading change.
* grab a reference to the blob early on to ensure it's still there when the 'job' is finally started.
TEST=manual and deletable_file_reference_unittest.cc
BUG=52486,56752
Review URL: http://codereview.chromium.org/3396029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Currently it's just a pass-through so everything still works while I begin to move stuff out of Browser down into it.
BUG=none
TEST=existing unittests.
Review URL: http://codereview.chromium.org/3412041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23916
TEST=http://fbarchard0-w.ad.corp.google.com/mediatests/2ch_test_folded_16int.wav
Review URL: http://codereview.chromium.org/3554001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=all tests that used to pass should continue to pass
Review URL: http://codereview.chromium.org/3402030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Created 2 tabs, one for for clearing local browsing data, one for clearing server data
- Refactored the old local browsing code to use a grid layout rather than less-wieldy math
- Controls on all tabs block while, closing dialog is disabled, new throbber is going while clear is in progress
- Clear server tab will be behind a flag until I deploy the server endpoint
- Retained old clearing behavior: dialog closes on successful lear
- Clear server UI only visible if user is syncing
Outstanding issues:
- Clearing currently causes an account to become unusable. The cause of the issue is a known problem with auth; currently investigating a fix
- Unlike local clearing, clearing server data is more likely to error out. For now I just show a label next to the clear button that says Error, allowing the user to try again
BUG=54349
TEST=Clear from UI, or run sync backend tests checked in for issue 54280
Review URL: http://codereview.chromium.org/3412032
TBR=raz@chromium.org
Review URL: http://codereview.chromium.org/3552001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23916
TEST=http://beta.html5test.com/
Review URL: http://codereview.chromium.org/3474015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added EncoderVp8 with test for chromoting.
TEST=remoting_unittests
BUG=50235
Review URL: http://codereview.chromium.org/3005036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=WatchdogTest.DisarmTest doesn't go flaky
Review URL: http://codereview.chromium.org/3545001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Provide getters for accessing textures in a WebVideoFrame
BUG=53714
TEST=None
Review URL: http://codereview.chromium.org/3472020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
side. This just connects the call
to the existing backend implementation.
Review URL: http://codereview.chromium.org/3473021
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/3522002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
to the existing backend implementation.
Review URL: http://codereview.chromium.org/3473021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3433028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The important part is that it comes after the EXTENSION_UNLOADED
notification is sent. This makes it easier on the listeners, as they
can assume that extension notifications other than EXTENSION_UNINSTALLED
are sent for currently-installed extensions.
BUG=54415
TEST=BackgroundModeManagerTest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60834
Review URL: http://codereview.chromium.org/3461025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3382023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=57189
TEST=none
Review URL: http://codereview.chromium.org/3534001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Created 2 tabs, one for for clearing local browsing data, one for clearing server data
- Refactored the old local browsing code to use a grid layout rather than less-wieldy math
- Controls on all tabs block while, closing dialog is disabled, new throbber is going while clear is in progress
- Clear server tab will be behind a flag until I deploy the server endpoint
- Retained old clearing behavior: dialog closes on successful lear
- Clear server UI only visible if user is syncing
Outstanding issues:
- Clearing currently causes an account to become unusable. The cause of the issue is a known problem with auth; currently investigating a fix
- Unlike local clearing, clearing server data is more likely to error out. For now I just show a label next to the clear button that says Error, allowing the user to try again
BUG=54349
TEST=Clear from UI, or run sync backend tests checked in for issue 54280
Review URL: http://codereview.chromium.org/3412032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, match full phone number.
BUG=56844
TEST=python chrome/test/functional/autofill.py
Review URL: http://codereview.chromium.org/3437025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
New code supports multiple PseudoTCP and UDP channels. Client and host still use old JjngleChannel for connection.
BUG=53986
TEST=None
Review URL: http://codereview.chromium.org/3319021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
identifying the SChannel function that fails with
SEC_E_INVALID_HANDLE.
R=eroman
BUG=55678
TEST=none
Review URL: http://codereview.chromium.org/3418036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the Chrome Frame Tests (IE8) build agent.
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/3528001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the current URL is phishing according to the client-side phishing
detector we notify the browser. The browser will then send a request
to the SafeBrowsing servers to verify that the URL is indeed phishing.
If the URL comes back phishing we will eventually display a warning to the
user.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3391020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60839 0039d316-1c4b-4281-b951-d872f2087c98
|