summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Linux: show the correct cursor when the render view regains focus.estade@chromium.org2009-05-051-1/+2
| | | | | | | | BUG=11407 Review URL: http://codereview.chromium.org/105002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15256 0039d316-1c4b-4281-b951-d872f2087c98
* Highlight the next find result when the return key is pressed in the Linux ↵jhawkins@chromium.org2009-05-052-31/+34
| | | | | | | | find bar. Review URL: http://codereview.chromium.org/99376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15255 0039d316-1c4b-4281-b951-d872f2087c98
* Various trivial clean-up bits:pkasting@chromium.org2009-05-055-14/+12
| | | | | | | | | | * Fix an 80-column issue * Remove an unused param * Remove an unnecessary setter * Fix a variable capitalization style violation Review URL: http://codereview.chromium.org/100361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15254 0039d316-1c4b-4281-b951-d872f2087c98
* Removing some duplicate source files and filters from vcprojs.bradnelson@chromium.org2009-05-042-24/+8
| | | | | | Review URL: http://codereview.chromium.org/99369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15251 0039d316-1c4b-4281-b951-d872f2087c98
* Several minor visual fixes to toolstrips:aa@chromium.org2009-05-046-47/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Layout toolstrips on the left of the bookmark bar so that something always obviously happens when you install one. This is in response to some feedback I've gotten demoing toolstrips for various people. * Open the NTP on install if the bookmarkbar isn't visible. Again, I'm trying to make something happen when you install an extension. This won't be the permanent behavior but it seems like doing nothing if you have your bookmark bar detached is likely to confuse people. * Fix a bug where we kept trying to resize the toolstrip back to the width it had when it was first made visible. * Fix a bug where we didn't always repaint the bookmarkbar after the toolstrip preferred width changed. This also seems to fix the issue where the buildbot sample shows up overlayed on top of tab contents, though I didn't mean to fix that with this CL. Review URL: http://codereview.chromium.org/100310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15249 0039d316-1c4b-4281-b951-d872f2087c98
* Specify all the outputs of theme_resources.grd-- it outputstc@google.com2009-05-041-1/+36
| | | | | | | | | | | | | | an extra .h and .cc file. This means I have to split it into it's own action since the other grd files don't create this output. This fixes a dependency in the make build. Review URL: http://codereview.chromium.org/99362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15248 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 9812: Remove current RSS code in favor of new more generalizedfinnur@chromium.org2009-05-0425-401/+5
| | | | | | | | | | | | PageAction code that serves the same purpose (and more). BUG=9812 TEST=No test needed, this shouldn't result in any noticable difference since the RSS parsing was disabled. Review URL: http://codereview.chromium.org/100356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15247 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r15244. Failed tests :(darin@chromium.org2009-05-0420-87/+315
| | | | | | | | TBR=mpcomplete Review URL: http://codereview.chromium.org/99370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15246 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in search provider. It wasn't setting template_url andsky@chromium.org2009-05-042-0/+11
| | | | | | | | | | | correct fill_into_edit for keywords. BUG=11416 TEST=see bug Review URL: http://codereview.chromium.org/100350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15245 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate webkit/glue/webhistoryitem* in favor of adding adarin@chromium.org2009-05-0420-315/+87
| | | | | | | | | | | | | | NavigateBackForwardSoon method WebViewDelegate. This moves all of the hacky details of how we intercept "history.{back, forward,go}" into the webkit layer. My eventual plan is to teach WebCore how to make this not hacky. BUG=11423 R=mpcomplete Review URL: http://codereview.chromium.org/100353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15244 0039d316-1c4b-4281-b951-d872f2087c98
* mac valgrind: remove special case in python script.dkegel@google.com2009-05-041-49/+13
| | | | | | | | | Also have --generate_suppressions output to normal log file for now. Review URL: http://codereview.chromium.org/99356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15243 0039d316-1c4b-4281-b951-d872f2087c98
* mac valgrind: media_tests: add suppression for second trace in ↵dkegel@google.com2009-05-041-0/+8
| | | | | | | | http://crbug.com/11327 Review URL: http://codereview.chromium.org/99359 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15242 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/99349 for Ryan.sky@chromium.org2009-05-044-1/+17
| | | | | | | | | | | | | | Comments from Ryan: Some small changes to get chromium building on ARM. I tested these using the standard Linux tool chain and crosstools-ng. BUG=none TEST=none Review URL: http://codereview.chromium.org/99365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15241 0039d316-1c4b-4281-b951-d872f2087c98
* media player movie functions to bind WTL menu events to pipeline.fbarchard@chromium.org2009-05-043-6/+192
| | | | | | Review URL: http://codereview.chromium.org/102002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15240 0039d316-1c4b-4281-b951-d872f2087c98
* Added media player File->Last to play the most recent movie again.fbarchard@chromium.org2009-05-044-15/+17
| | | | | | Review URL: http://codereview.chromium.org/100149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15239 0039d316-1c4b-4281-b951-d872f2087c98
* Undo part of brettw's WebContents refactor that removed TabContentsDelegatempcomplete@google.com2009-05-043-7/+112
| | | | | | | | | code from HtmlDialogView. BUG=http://code.google.com/p/chromium/issues/detail?id=9884 Review URL: http://codereview.chromium.org/99305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15238 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of aesthetic nits about infobars that have been broken since I ↵ben@chromium.org2009-05-042-6/+30
| | | | | | | | | | | | redid them a few months back. - close button is properly centered horizontally - animation looks correct - layout no longer dependent on current frame height http://crbug.com/11389 Review URL: http://codereview.chromium.org/99332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15237 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r15232 with a warnings fix:tc@google.com2009-05-043-670/+1399
| | | | | | | | | | | | | | | | | | | Merge latest changes from http://www.netlib.org/fp/dtoa.c into dtoa.cc This should fix the gcc 4.4. strict aliasing issues. More info here: http://patrakov.blogspot.com/2009/03/dont-use-old-dtoac.html Also update gcc_warnings.patch to match. BUG=9104 Original change by Craig Schlenter via http://codereview.chromium.org/99315 Review URL: http://codereview.chromium.org/99367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15236 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a browser crash when reading the disk cache experiment datarvargas@google.com2009-05-041-5/+6
| | | | | | | | | | | after failing to map the index file. BUG=11414 TEST=none Review URL: http://codereview.chromium.org/100349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15235 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux ui tests broken by r15112.estade@chromium.org2009-05-042-16/+8
| | | | | | | | | | also re-enable tests that I disabled in an attempt to green the bot TBR=tony Review URL: http://codereview.chromium.org/100351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15234 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Merge latest changes from http://www.netlib.org/fp/dtoa.c into dtoa.cc"tc@google.com2009-05-043-1390/+670
| | | | | | | | | This reverts commit r15232. Review URL: http://codereview.chromium.org/99366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15233 0039d316-1c4b-4281-b951-d872f2087c98
* Merge latest changes from http://www.netlib.org/fp/dtoa.c into dtoa.cctc@google.com2009-05-043-670/+1390
| | | | | | | | | | | | | | | | | This should fix the gcc 4.4. strict aliasing issues. More info here: http://patrakov.blogspot.com/2009/03/dont-use-old-dtoac.html Also update gcc_warnings.patch to match. BUG=9104 Original change by Craig Schlenter <craig.schlenter@gmail.com> via http://codereview.chromium.org/99315 Review URL: http://codereview.chromium.org/99364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15232 0039d316-1c4b-4281-b951-d872f2087c98
* Make buildbot sample more compact.aa@chromium.org2009-05-041-18/+53
| | | | | | | | | Only shows the text "tree: (open|closed)" initially now. When you hover over it, it animates open to show the entire bar. Review URL: http://codereview.chromium.org/100315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15231 0039d316-1c4b-4281-b951-d872f2087c98
* revert r15223 to see if it fixes the security-context-with-base-tag.html crashdarin@chromium.org2009-05-042-9/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15230 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable failing ui tests on linux.estade@chromium.org2009-05-041-0/+12
| | | | | | | | TBR=cpu Review URL: http://codereview.chromium.org/100348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15229 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BackSpace not working in Find box.finnur@chromium.org2009-05-041-2/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | This regressed with: http://codereview.chromium.org/99161 I think more work is needed, such as: 1) Figure out if more combinations need to be added. 2) Figure out if we can consolidate the code into one function, so that we don't need to keep three ShouldLookupAccelerators in sync (one in TextField, one in LocationBarView and potentially one in AutocompleteEditViewWin as well (OnKeyDownOnlyWritable). I'm not sure what all those magic keyboard constants like 0xBB do, so I think I'll leave the rest of the work to the person who created the changelist noted above. BUG=11326 TEST=Open google.com, press About link, press Ctrl+F, press e, press BackSpace. Chrome should not navigate back. Review URL: http://codereview.chromium.org/100347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15228 0039d316-1c4b-4281-b951-d872f2087c98
* Revert bug fix because interactive_ui_tests are failing.mbelshe@google.com2009-05-044-71/+4
| | | | | | Review URL: http://codereview.chromium.org/99358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15227 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes focus issues when browsing on Mac.rohitrao@chromium.org2009-05-042-2/+8
| | | | | | | | | | http://crbug.com/10032 TEST=Open a new tab and browse to www.google.com. Type something and check that focus is correctly set to the text field. Review URL: http://codereview.chromium.org/99327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15226 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: tweak find bar.estade@chromium.org2009-05-048-27/+28
| | | | | | | | | - (attempt to) fix find bar z ordering in a simpler way - get "close without animation" right. Review URL: http://codereview.chromium.org/100286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15225 0039d316-1c4b-4281-b951-d872f2087c98
* Don't analyze incomplete valgrind log files (as the parser crashes),dkegel@google.com2009-05-041-11/+20
| | | | | | | | make timeout global instead of per-file, shorten it. Review URL: http://codereview.chromium.org/100340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15224 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a WillDestroyFrame(WebFrame*) notification method to WebViewDelegate thatdarin@chromium.org2009-05-042-0/+9
| | | | | | | | | | | | | | | | | | gets called from WebFrameLoaderClient::frameLoaderDestroyed(). The Chromium Embedded Framework needs this notification to properly clean up memory associated with specific WebFrame instances (for example, custom NPObject types bound to the WebFrame via BindToWindowObject()). This patch was contributed by Marshall Greenblatt. R=aa,darin Review: http://codereview.chromium.org/99283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15223 0039d316-1c4b-4281-b951-d872f2087c98
* Rebase valgrind suppressions, add one for http://crbug.com/11130dkegel@google.com2009-05-041-2/+15
| | | | | | Review URL: http://codereview.chromium.org/100341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15222 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate wstring version of PathService::Get() in unit tests.thestig@chromium.org2009-05-047-51/+47
| | | | | | Review URL: http://codereview.chromium.org/100292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15221 0039d316-1c4b-4281-b951-d872f2087c98
* Lands the fix for bug 8088 from m0 (http://codereview.chromium.org/100022).sky@chromium.org2009-05-042-16/+5
| | | | | | | | | | | | | | | | | | | | | | | | | Here's his description: Mouse hover out of context menu should un-select menu item. All Context Menu's which are implemented with ChromeMenu is not properly un-selecting the menu item when out of focus. The areas where this is affected are: * Tabs * Bookmark bar * Bookmark managerThe others uses winapi for context menus. Doesn't use ChromeMenu, uses HMENU, that explanes why the others work. For this fix, I had to make sure that the MenuPart is always NONE when the mouse is moved outside of the context menu regions, and that is always the case. Hence, we can assure to remove selection. The same way it has been done for SetSelection, I have used the same technique for this, but simpler. BUG=8088 TEST=For the above mentioned affected areas, I brought up the context menu by right clicking, and hovered over a menu item, then move the mouse horizontally outside the context menu region, it deselected the item. Review URL: http://codereview.chromium.org/102025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15220 0039d316-1c4b-4281-b951-d872f2087c98
* Change in enable-spellcheck checkbox in Languages Options Tab should not be ↵sidchat@google.com2009-05-042-4/+6
| | | | | | | | | considered unless OK is clicked. Issue=11013 Review URL: http://codereview.chromium.org/99095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15219 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add Metrics sidebar support.pfeldman@chromium.org2009-05-044-24/+125
| | | | | | Review URL: http://codereview.chromium.org/99354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15218 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Linux find bar look a bit better.deanm@chromium.org2009-05-045-12/+27
| | | | | | | | | | - Fake some anti-aliasing so the text entry matches the next/prev images. - Match padding pixel perfect with Windows. Review URL: http://codereview.chromium.org/99275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15217 0039d316-1c4b-4281-b951-d872f2087c98
* Defer window.close(), window.resizeTo(), and window.moveTo()mbelshe@google.com2009-05-044-4/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | actions by posting a task back to the message loop before notifying the RenderWidgetHost to perform these operations. Otherwise, the JS code races with the browser to use the modified window. BUG=http://crbug.com/6377 BUG=http://crbug.com/6192 Also, because window resizing is asynchronous between the renderer and browser, added a renderer-side cache of "pending window rect" to ChromeClientImpl. Before the change, calling setWindowRect() would schedule a call to the RenderViewHost to do the work, but a subsequent call to windowRect() would return the current size, as through the call to setWindowRect() had never happened. We cache a pending size and then schedule a task on the message loop to clear the cached size. This allows javascript which writes and reads the WindowRect sizes to work, and once we come out of JS and return to the message loop, we'll go back to asking the RenderViewHost for the true values. This pending_window_size is my only concern about this patch. It does pass all layout tests, and the ChromeClientImpl code is executed in the test_shell.exe code path. BUG=http://crbug.com/835 TEST=LayoutTests have tests which cover all of these actions. The problem is that we run layout tests using the test_shell, not Chrome. Review URL: http://codereview.chromium.org/101019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15214 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "output=chrome" as the Suggest team has deprecated it server-side.pkasting@chromium.org2009-05-041-3/+2
| | | | | | | BUG=1660988 Review URL: http://codereview.chromium.org/102024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15212 0039d316-1c4b-4281-b951-d872f2087c98
* Reset the omnibox contents when the user reloads the page. Patch by Yusuke ↵pkasting@chromium.org2009-05-049-0/+25
| | | | | | | | Sato (see http://codereview.chromium.org/100198 ), r=me. BUG=2985 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15211 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Wire existing shortcutto out of process devtools.pfeldman@chromium.org2009-05-041-16/+20
| | | | | | Review URL: http://codereview.chromium.org/99345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15210 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the static next_id_ counter, to make construction of ProxyConfig ↵ericroman@google.com2009-05-044-19/+38
| | | | | | | | | on different threads safe. BUG=11323 Review URL: http://codereview.chromium.org/102023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15209 0039d316-1c4b-4281-b951-d872f2087c98
* Delete unused stuff from basictypes.h.willchan@chromium.org2009-05-041-13/+0
| | | | | | Review URL: http://codereview.chromium.org/99348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15208 0039d316-1c4b-4281-b951-d872f2087c98
* Update known list based on WebContent->TabContenthuanr@chromium.org2009-05-041-3/+3
| | | | | | | | | | change. BUG=11408 Review URL: http://codereview.chromium.org/99347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15207 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Implement search in scripts.pfeldman@chromium.org2009-05-044-2/+57
| | | | | | Review URL: http://codereview.chromium.org/100332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15206 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two Linux canvas related bugs.sky@chromium.org2009-05-043-7/+33
| | | | | | | | | | | | | | | . The platform paint was allocating at a size bigger than necessary. . ChromeCanvas::DrawStringInt was not taking into account the matrix on the canvas, which means the text could be drawn at the wrong location. BUG=none TEST=none Review URL: http://codereview.chromium.org/99279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15205 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some recently small size / position regressions in Linux Omnibox.deanm@chromium.org2009-05-042-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/100343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15204 0039d316-1c4b-4281-b951-d872f2087c98
* Add a crash case of 10901 to known listhuanr@chromium.org2009-05-041-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15203 0039d316-1c4b-4281-b951-d872f2087c98
* Fix find in page. When fixing the conflict after updating, I accidentallybrettw@chromium.org2009-05-041-0/+5
| | | | | | | removed the code that updates the find in page commands. Review URL: http://codereview.chromium.org/100331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression that the sad tab favicon is not displayed when a tab crashes.brettw@chromium.org2009-05-042-2/+8
| | | | | | | | | | | | | | This regressed in my favicon/title updating change because the crashed state is not updated on the codepath, since it comes from the tab. The other approach would have been to make this call through the "update everything" codepath for tbe state changing, but that's executed on a timer, and it's nice to show the tab crash right away since the check is very inexpensive. BUG=http://crbug.com/10756 Review URL: http://codereview.chromium.org/99341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15201 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 17:55:06 +0000