| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
CID=9154
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2946006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
suppression that was mistakenly added in a commented-out state.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2925010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
our combobox IAccessible. Since we already call SetFocus on the native combo box, this event will go to the AT correctly, but this IAccessible won't be hooked up to the rest of the IAccessible tree. Also, any changes made in combobox.cc/h concerning accessibility won't show up when the combobox receives focus.
BUG=48703
TEST=none
Review URL: http://codereview.chromium.org/2937004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10572
TEST=ViewTest.RerouteMouseWheelTest
Review URL: http://codereview.chromium.org/2946010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48733
TEST=None
Review URL: http://codereview.chromium.org/2980002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=48865
TBR=arv@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2969003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously a right-click in omnibox or on a page action would have a
context menu _and_ the omnibox popup. Clicking a page action or star
would mess up the omnibox selection. This brings things in line with
other platforms.
Also fix to not change selection if an omnibox decoration handles the click.
BUG=40145
TEST=Clicking star with omnibox popup up should close popup.
TEST=Clicking star should not change omnibox selection.
TEST=Right-click in omnibox with popup up should close popup.
Review URL: http://codereview.chromium.org/2900006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
additions.
Renaming audio_output.h to audio_io.h as future patches will add audio recording code to this file.
Also renamed a couple of methods to make it clear that these are for audio playback/output and similar methods will be added for audio capture/recording soon.
BUG=none
TEST=no change in functionality.
Review URL: http://codereview.chromium.org/2962006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile
TBR=vandebo
Review URL: http://codereview.chromium.org/2975004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When a subfolder (i.e. a folder in a dropdown menu, not on the bookmark bar itself) is middle clicked, it should open all sub nodes in tabs.
BUG=34416
TEST=none
Review URL: http://codereview.chromium.org/2968004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.ExperimentalPermissionsFail
Review URL: http://codereview.chromium.org/2976002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Idle
BUG=None
Review URL: http://codereview.chromium.org/2930001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a tab DnD.
BUG=48199
TEST=Manual, see bug.
Review URL: http://codereview.chromium.org/2922004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=net_unittests pass
Review URL: http://codereview.chromium.org/2896004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=48734
TEST=none
Review URL: http://codereview.chromium.org/2931006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This uncomments commented out code that used to broken due to a WebKit regression. WebKit was fixed a while ago so this now works again.
BUG=29422
TEST=Go to the history page. Resize the window and make sure you see '...' at the end of the item text.
Review URL: http://codereview.chromium.org/2912003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
propagation if the event is cloned; need to cancel the original event object.
Review URL: http://codereview.chromium.org/2962009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=tim
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48844
TEST=Open options > Personal Stuff, see link to dashboard.
Review URL: http://codereview.chromium.org/2934010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a defensive change to catch attempts to delete them on a different thread than where they were created (when in Debug mode).
Although most classes in net are not thread safe and could be annotated, I chose to annotate these specific ones since they are frequently the top-level objects held by embedders.
Review URL: http://codereview.chromium.org/1812007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
from the compressed box2d file to fix 'RangeError: Maximum call stack size exceeded' error in WebKit.
Review URL: http://codereview.chromium.org/2845011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2892004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2946005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is so that the SSLSocketParam can hold one of any of the existing SocketParams.
BUG=30357
TEST=existing unit tests
Review URL: http://codereview.chromium.org/2848029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fixes.
TEST=net_unittests
BUG=46589
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51007
Review URL: http://codereview.chromium.org/2804008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
about:net-internals prettier.
BUG=46822
Review URL: http://codereview.chromium.org/2932008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL requires http://codereview.chromium.org/2799036
- Cleanup the HttpProxyClientSocket interface a touch.
- Make HttpAuthController reference counted.
- Enable ClientSocketPool to return recoverable connections.
BUG=42795
TEST=existing unit tests
Review URL: http://codereview.chromium.org/2817033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/2845034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46696
TEST=Put an url on BMB. Click to it. Right-click delete, star in omnibox should update.
Review URL: http://codereview.chromium.org/2915002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
induce a slight delay between the time the connect is called and when
the posted task can complete. We weren't waiting for the 2ms to
elapse before expecting that it had completed.
BUG=47836
TEST=self
Review URL: http://codereview.chromium.org/2893010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
class (refactor).
BUG=42795
TEST=existing unit tests
Review URL: http://codereview.chromium.org/2799036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chroot.
ChromiumOS is trying to remove dpkg-buildpackage.
If running inside ChromiumOS chroot, the "which" can throw exception when the target file is missing.
( dpkg-buildpackage will be missing in this case )
This doesn't happen with the "which" on Ubuntu.
Work around it by using "whereis" instead. It works on both ChromiumOS choot and Ubuntu.
Review URL: http://codereview.chromium.org/2945011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=48637
Review URL: http://codereview.chromium.org/2927008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
using the magic Google meta-tag.
BUG=48606
TEST=See bug.
Review URL: http://codereview.chromium.org/2960001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2933007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome would open up a popup window which
opened up in IE. This is because of an orphan external tab container created to handle the popup. This tab is destroyed
in the normal case when the active document window is destroyed, which is the parent of the external tab container.
However in this case the active document is destroyed without its window being created thus resulting in the external tab
container lying around which holds a reference to the automation provider.
Fix is to pass the ChromeFrameAutomationClient window as the parent window in the AutomationMsg_ConnectExternalTab
message.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=48732
Bug=48732
Covered by ChromeFrame test FullTabNavigationTest.JavascriptWindowOpenDifferentDomain
Review URL: http://codereview.chromium.org/2911006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2891008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
forms. This protects the user's data from javascript that can read placeholder
values.
BUG=48233
TEST=FormManagerTest.PreviewForm
Review URL: http://codereview.chromium.org/2845041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=layout tests
Review URL: http://codereview.chromium.org/1917004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2921004
Patch from Ahmad Sharif <asharif@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prefs, to manage preferences set by extensions.
Update various callers of the PrefValueStore constructor accordingly.
The initial user will be the proxy extension API.
BUG=266
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/2823037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/48837
TEST=crash a tab (via task manager), sloowwwly resize window. Sad Tab icon should always draw crisp and clear.
Review URL: http://codereview.chromium.org/2966004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes sure we show the "translating..." infobar as soon as the user presses the translate infobar button.
We were previously delaying until the translate element script was fetched from the Google translate server, making the infobar appear unresponsive.
BUG=48692
TEST=Start Chrome, navigate to a site in a language different from
the Chrome language, press translate. The infobar should change
immediately to the "Translating..." infobar.
Review URL: http://codereview.chromium.org/2941005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
StartPage and EndPage APIs do not work in a metafile DC. We write custom GDICOMMENT records to designate a StartPage and EndPage.
BUG=None
TEST=Unit-tests provided.
Review URL: http://codereview.chromium.org/2947006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes PersonalDataManager to filter out empty profiles and credit card information before saving to the database.
BUG=47742
TEST=PersonalDataManagerTest.SetEmptyProfile, PersonalDataManagerTest.SetEmptyCreditCard
This fixes issue in unit test... prior review was at:
http://codereview.chromium.org/2897005
Review URL: http://codereview.chromium.org/2900005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Focus a windowless plugin, then click on another element on the page; the plugin should no longer have focus.
Review URL: http://codereview.chromium.org/2924001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
No code changes.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52081 0039d316-1c4b-4281-b951-d872f2087c98
|