| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=still compiles
Review URL: http://codereview.chromium.org/267065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
debug mode. There's a lot of tests that are only slow in DEBUG mode.
While it would be good to address them, it's really just not
worth the maintenance headache.
Review URL: http://codereview.chromium.org/267057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/271057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Please chime in on how you would like this changed.
Issues
*) should I delete the old nacl setup code?
Basically I commented out the old NaCl initialization
code and then copied the initialization code from
big_test. My understanding is whatever the old way
was is no longer current.
If I don't delete the old code should I go through
the trouble of separating the common code "bubble_demo"
from the setup code?
I'd prefer to just leave it as is and let someone who
knows the nacl stuff better to fix it.
*) How do I make it build correctly and also for gyp?
Also I'm not sure how to build it correctly. The
build.scons works but I get warnings like:
scons: warning: Two different environments were specified for target cross\buffer_sync_proxy.obj,
but they appear to have the same action: $CXX $_MSVC_OUTPUT_FLAG /c $CHANGED_SOURCES $CXXFLAGS $CCFLAGS $_CCCOMCOM
File "C:\src\o3d_spud\o3d\site_scons\site_tools\component_builders.py", line 249, in ComponentLibrary
Review URL: http://codereview.chromium.org/251052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Roll WebKit to r49473
- Re-enable failing ui_tests due to last roll
- Remove some failing layout tests expectations
Review URL: http://codereview.chromium.org/267060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a little of the macro magic.
Also, fix the build. Renderer_cb was missing some
functions.
I seems like it would be really good if we could
add something like this to the non-debug version
because developers need an easy way to check
for errors. Maybe these errors can go to the
chrome error console or something, at least in chrome.
Review URL: http://codereview.chromium.org/267061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I'm attempting to clean up CommandLine.
This change rearranges how initialization is done. I am trying
to eliminate redundant functions; more will come in subsequent changes.
Review URL: http://codereview.chromium.org/273018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I found a case of renderers trying to die in a signal handler but a
corrupt heap (and some atexit() handlers installed by XmlSomething)
made us hang forever.
BUG=http://crbug.com/23590, http://crbug.com/23919, http://crbug.com/22287 (maybe)
It isn't clear this fixes any known renderer hangs (e.g. the bugs
above) but it's a step in the right direction.
TEST=no known way to reliably hit this state.
Review URL: http://codereview.chromium.org/261059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
out on the Mac.
This fixes the fades, which were actually written but unfortunately not
working due to a silly bug. It also adds the delays, cleaning up a TODO.
It fixes some questionable logic ("hide by calling Hide() and then FadeIn()").
Finally, it allows better reuse of the status bubble NSWindow, and fixes a bug
that prevented the status bubble window from properly attaching to its parent
window if the parent was offscreen at attachment time. Unit tests for the new
behavior are included, and as a bonus, I've added better testing for some
existing behavior.
See http://dev.chromium.org/user-experience/status-bubble for the design of
the status bubble. Also, consult chrome/browser/views/status_bubble_views.cc
for the implementation used on Windows.
BUG=24495
TEST=Mouse over some links
Review URL: http://codereview.chromium.org/269045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=5339
TEST=git cl config downloads and installs configured
hooks
Review URL: http://codereview.chromium.org/257070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to fixup some warnings.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/274009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
in the matrix, in order to fix RotateModel test on ie6.
Review URL: http://codereview.chromium.org/271062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
with the message pumping or IPC channel where the sent reply from the browser doesn't make it to the renderer main thread.
BUG=24337
Review URL: http://codereview.chromium.org/273023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No idea if this is the best structure or the correct
options but I have to start somewhere. If you have
better ideas speakup or start editing :-D
If there is a way to get gpy to list the targets
please tell me so I can call it.
Review URL: http://codereview.chromium.org/242068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also did a bit of code cleanup.
BUG=11106
TEST=use tsan on ViewSourceTest.DoesBrowserRenderInViewSource
Review URL: http://codereview.chromium.org/273020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24444
Review URL: http://codereview.chromium.org/270066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/269055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
can link against it in the interim.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/255098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
The following test crashes on linux:
LayoutTests/http/tests/xmlhttprequest/web-apps/012.html
Review URL: http://codereview.chromium.org/267058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
LayoutTests/fast/events/invalid-001.html crashes on windows, mark it so.
Review URL: http://codereview.chromium.org/271059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=24652
WorkerTest.MultipleWorkers and WorkerTest.LimitPerPage
are failing too.
Review URL: http://codereview.chromium.org/270071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
These tests are failing on xp and vista:
WorkerTest.SingleWorker
WorkerTest.WorkerFastLayoutTests
WorkerTest.WorkerXhrHttpLayoutTests
Review URL: http://codereview.chromium.org/269056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Breaks the Release compile somehow. Sigh.
TBR=michaeln,mmoss
Review URL: http://codereview.chromium.org/266053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=24652
WorkerTest.LimitTotal starts to fail consistently after WebKit merge
40414:49432, disable it.
Review URL: http://codereview.chromium.org/272031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
Some tests are failing in win and mac, mark them so.
Review URL: http://codereview.chromium.org/270070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-[NSApplication sendAction:to:from:] is a central dispatcher for
target-action messages sent by controls. Backtraces from here often
contain only Cocoa messages, making it hard to tell where things are
at when a freed target gets messaged. Add additional info like the
action being requested and the tag of the sender.
http://crbug.com/24460
TEST=Browser continues to work.
Review URL: http://codereview.chromium.org/269039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a severely pared down version of webplugin_delegate files
that are not currently used to create any instances.
Also adds calls for render APIs that remain to be
connected to the impelementation. The function pointers are
returned by NPN_GetValue calls with new enumerated values.
I have also added Nicholas' NPEvent definitions.
These changes are to permit further collaboration between
sehr, brettw, and cpu.
Review URL: http://codereview.chromium.org/270024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
by wanting to parent bookmarkeditor to browserwindow, which returns a
native_window.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
Also provide stub method for GraphicsContext3D::getActiveAttrib()
and GraphicsContext3D::getActiveUniform().
Review URL: http://codereview.chromium.org/274006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/270045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
No code changes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added append scenario to view_examples
BUG=None
TEST=run unit_tests and verify with view_examples.
Review URL: http://codereview.chromium.org/271055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=stoyan
Review URL: http://codereview.chromium.org/266052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first of series of patches to implement printing on the Mac.
This API is based heavily on the Linux version; although it doesn't end up abstracting very much on the Mac, having a NativeMetafile implementation makes it easy to pass data through the existing print architecture.
BUG=13158
TEST=Printing unit tests; no effect in the application yet.
Review URL: http://codereview.chromium.org/269041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/266040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
at some callsites.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/269052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
additional things here:
. Avoid doing anything in OnSizeAllocation if the size hasn't
changed. Because of how gtk works I was getting stuck in a loop if I
OnSizeAllocate did anything if the size hadn't changed.
. Applied similar shortcut to TabContentsViewGtk.
. Made SimpleMenuModel only ask delegate for checked state if the item
is a check.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/261051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
launcher from DCHECK'ing
in debug builds.
Review URL: http://codereview.chromium.org/267054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=evan
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24354
TEST=Load the test_browser_action extension and click on the button a few times. It should cycle between a printer and animating shapes without crashing.
Review URL: http://codereview.chromium.org/261049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This converts BackendImpl to using FilePath.
BUG=24444
Review URL: http://codereview.chromium.org/261045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/269051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on a patch by avi@.
See also http://codereview.chromium.org/271054 .
Known issues:
* Breaks if any menu item ever uses a keyboard accelerator that doesn't use cmd as part of the flags.
(* Suppressing keypress() doesn't prevent default action (suppressing keydown() works though. Both Firefox and Safari prevent the default action when either is suppressed). This seems to be broken on linux and windows too, though – it seems to match IE8, but not Firefox or Safari. I guess this is the question for the web council.)
BUG=15090
TEST=Cmd-f now sucks when used on google docs.
Review URL: http://codereview.chromium.org/242069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We had two functions that did the same thing.
Though Terminate came first, I think Reset better conveys the intent.
Review URL: http://codereview.chromium.org/267047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/274004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/274002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- reduce header dependencies
- remove things that shouldn't be #included in a header, like string_util.h and theme_resources.h!
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/245011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
theming CL (28613). This fixes up drawing so the themes
line up correctly.
BUG=24481, 24484
TEST=None
Review URL: http://codereview.chromium.org/271045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The list was too long and was catching signals corresponding to Mach
exceptions that Apple Crash Reporter never attempts to catch, and signals
that don't even map to Mach exceptions. The default signal handlers are fine
in these cases.
BUG=24568
TEST=Crash reporting still disabled when appropriate
(see chrome/app/chrome_dll_main.cc and the comment before
DisableOSCrashDumps in ChromeMain)
Specifically, with stats reporting disabled, about:crash should result in
a sad tab but no silent crash report generated in
~/Library/Logs/CrashReporter
Review URL: http://codereview.chromium.org/272025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28700 0039d316-1c4b-4281-b951-d872f2087c98
|