| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
routing id directly. This simplifies the renderer code and also allow this code to be used in worker processes, where we don't have a frame.
Review URL: http://codereview.chromium.org/46026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Our old baseline was wrong. We now on par with the mac
expected output (only differ in font metrics).
Review URL: http://codereview.chromium.org/48020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
created. Caller passes no parameters to the
constructor of a data buffer now. GetWritableData() method is responsible for allocating memory.
Review URL: http://codereview.chromium.org/46015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Give renderer a chance to handle accelerators before browser does.
- Handle browser accelerators that aren't attached to any particular UI element in BrowserWindowGtk rather than in BrowserToolbarGtk
- Use Browser::ExecuteCommand() to handle accelerator activation
- Switch a random void* to gfx::NativeWindow
- Enable three browser commands on linux : Focus Location, Focus Search, Open file
This fully enables ctrl-l, ctrl-k, and ctrl-o. This fixes copy-pasta in the omnibox. This fixes the problem Dean described with <http://www.quirksmode.org/js/keys.html>.
bug=8659
Review URL: http://codereview.chromium.org/42190
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42239
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8580
Review URL: http://codereview.chromium.org/48003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DevToolsAgent now implements WebDevToolsAgentDelegate, DevToolsClient covers WebDevToolsClientDelegate.
WebDevToolsAgent instance is being created by the WebView early in the init code and belongs to it. WebView exposes interface for accessing the agent; it also extends its delegate interface to pass WebDevToolsAgentDelegate into it.
Note that there is no call overhead unless particular sub-agents are enabled in the WebDevToolsAgent.
WebDevToolsClient instance is being created externally by the DevToolsClient.
Review URL: http://codereview.chromium.org/46032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(note: this change now requires a P4 to build. It's easy to back it
out for older processors, but they shouldn't be used to run
layout-tests.)
We are seeing issues where the opt build ends up with very slightly
different colours in layout tests than the debug build. This is
probably due to floating point rounding differences.
All floating-point computations on x87 happens in 80-bit precision.
Because the C and C++ language standards allow the compiler to keep
the floating-point values in higher precision than what's specified in
the source and doing so is more efficient than constantly rounding up
to 64-bit or 32-bit precision as specified in the source, the
compiler, especially in the optimized mode, tries very hard to keep
values in x87 floating-point stack (in 80-bit precision) as long as
possible. This has important side effects, that the real value used in
computation may change depending on how the compiler did the
optimization - that is, the value kept in 80-bit is different than the
value rounded down to 64-bit or 32-bit. There are possible compiler
options to make this behavior consistent (e.g. -ffloat-store would
keep all floating-values in the memory, thus force them to be rounded
to its original precision) but they have significant runtime
performance penalty.
-mfpmath=sse -msse2 makes the compiler use SSE instructions which keep
floating-point values in SSE registers in its native precision (32-bit
for single precision, and 64-bit for double precision values). This
means the floating-point value used during computation does not change
depending on how the compiler optimized the code, since the value is
always kept in its specified precision.
Internal performace tests of these options shows that it's not a clear
performance win or loss across the board.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(and often doing it incorrect / leaking) to use an OwnedWidgetGtk.
Review URL: http://codereview.chromium.org/48007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
'bookmarks.html' file.
BUG=6957
Review URL: http://codereview.chromium.org/46008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We will pull this out again once the dev channel release has been cut.
We need to get this in the dev channel release to have the new
infrastructure tested in the real world.
Review URL: http://codereview.chromium.org/42234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
by changing DCHECK to DCHECK_EQ.
We're getting a lot of trouble with this check, and I just received
a report on irc about problems with it even after my last visitedlink
change (r11734). More information in the error message may help.
Review URL: http://codereview.chromium.org/42235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It is helpful to see the actual value during a check failure.
Review URL: http://codereview.chromium.org/42225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ownership of a GtkWidget encapsulated (and exposed) from a C++ object.
Debugging checks help verify that the GtkWidget is not leaked, and that it was destroyed when expected.
Review URL: http://codereview.chromium.org/42226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the process of being upstreamed and don't crash. patternRegions.svg
was listed as crashing, but I believe this comment was wrong as it
hasn't crashed in the last 20 runs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/42228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to work around a few google issues (Picasa web, China's icafe)
bug=3301
Review URL: http://codereview.chromium.org/46069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
may fix the attached bug.
The problem was that the debug check was in wrong place (too early, before
every member was initialized), so it failed in the test.
BUG=8710
Review URL: http://codereview.chromium.org/48005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add suppression for a small filename leak in our logging system
which would be too hard to fix properly.
Review URL: http://codereview.chromium.org/48010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=darin
BUG=Issue 8325
Review URL: http://codereview.chromium.org/46074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Issue was that EscapeQueryParamValue is equivalent to encodeURIComponent(), not escape()
BUG=8346
Review URL: http://codereview.chromium.org/42215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
current day we would never show any results.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/42196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
HistoryContentsProviderTest, and KeywordProviderTest from
chrome/browser/autocomplete.
NOTIMPLEMENTED bits where HistoryURLProviderTest and AutocompleteTest
have UI dependencies, and ExternalProtocolHandler has OS dependencies.
Review URL: http://codereview.chromium.org/43034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is no need to check process count (which tends to induce flakiness).
In fact, we are already checking all important facts:
- after checking that process handle is a not-null handle we know
that the process started successfully
- after WaitForSingleProcess returns true we know that the process
finished successfully
BUG=8811
Review URL: http://codereview.chromium.org/42224
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
developer tools windows. It's supposed to route devtoools messages. Also it will notify DevToolsClient when inspected renderer crashes or when it's changes due to cross-site navigation. Currently when inspected tab is closed it will close devtools window as well.
Devtools state moved from RenderViewHost and WebContentsView to the manager.
Please look at devtools_manager.{h,cc} in the first place.
Review URL: http://codereview.chromium.org/42076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add suppression for libevent oneshot timers; libevent
doesn't provide a way to free unexpired oneshot timers
at exit.
Refer to /usr/lib*/ rather than /usr/lib32, so
suppressions also work on 32 bit systems.
Review URL: http://codereview.chromium.org/46093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Except transform-absolute-in-positioned-container.html which was fixed with r11135 on Windows (and Mac also).
TBR=ojan@chromium.org
Review URL: http://codereview.chromium.org/48002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also add back anchor-toString-expected.txt.
TBR=ojan@chromium.org
Review URL: http://codereview.chromium.org/42222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Update test_fixable with some linux failures.
TBR=ojan@chromium.org
Review URL: http://codereview.chromium.org/46102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Part 2. Same comments as before, but it was broken up
in order to do the code review upload.
Review URL: http://codereview.chromium.org/46100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Part 3. Same comments as before, but it was broken up
in order to do the code review upload.
Review URL: http://codereview.chromium.org/46101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit\tools\webcore_unit_tests\TransparencyWin_unittest.cpp
were necessary due to http://trac.webkit.org/changeset/41692
LayoutTests\editing\pasteboard\paste-blockquote-into-blockquote-4.html
LayoutTests\editing\pasteboard\paste-blockquote-into-blockquote.html
were rebaselined due to http://trac.webkit.org/changeset/41677
chrome\fast\dom\Window\window-lookup-precedence.html
was rebaselined due to http://trac.webkit.org/changeset/41671
Many layout tests were rebaselined due to the skia change in
http://trac.webkit.org/changeset/41683
Review URL: http://codereview.chromium.org/46099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
loses focus.
BUG=8726
Review URL: http://codereview.chromium.org/42210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
e.g. during base_unittest's HMACTest.HmacSafeBrowsingResponseTest
Use wildcard to make glibc suppression match on Ubuntu 8.10 as well as 8.04
Review URL: http://codereview.chromium.org/42185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42213
TBR=dimich@chromium.org
Review URL: http://codereview.chromium.org/42213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Layout tests changes (and baselines):
* LayoutTests/fast/css/font-face-default-font.html
Fixed by aa upstream. The change was in the test itself.
* LayoutTests/fast/replaced/width100percent-searchfield.html
Fixed by levin upstream -- the themeChromiumWin.css change.
* LayoutTests/fast/forms/input-appearance-height.html
* LayoutTests/fast/repaint/search-field-cancel.html
Rebase needed due to themeChromiumWin.css change
* LayoutTests/fast/layers/normal-flow-hit-test.html
A slightly different font seems to be used in chromium which
casued some pixel differences in this test.
* LayoutTests/fast/forms/placeholder-pseudo-style.html
* LayoutTests/fast/forms/search-placeholder-value-changed.html
New tests which needed chromium baselines due to differences
in the search input box display.
* LayoutTests/fast/forms/placeholder-set-value.html
Differences in fonts and search input boxes were the cause
for the chromium baseline.
Review URL: http://codereview.chromium.org/46071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Found via valgrind.
This was originally http://codereview.chromium.org/47001 but
was rolled back due to possibly unrelated build breakage.
Review URL: http://codereview.chromium.org/42205
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Pull basic Window interface out of WindowWin into new interface, Window.
Convert code to use it.
Review URL: http://codereview.chromium.org/46079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a text-field, even if the text-field is not empty.
BUG=6437
TEST=Open a form with several fields. Start entering text in a text field to bring-up the autocomplete popup. Click somewhere else (so the popup is closed). Click again in the text-field (at the end). On the 2nd click the autocomplete popup should show.
Review URL: http://codereview.chromium.org/42198
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11696 0039d316-1c4b-4281-b951-d872f2087c98
|