summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Rebaseline a few more of the repaint tests.dglazkov@chromium.org2009-11-1738-13/+507
| | | | | | | | | | | | | | The difference in upstream repaint areas as compared to upstream results is due the difference in repaint logic. Safari/Mac port uses NSView's native rectangle collection/unification, and we just unify all into one damage rect. Plus, our results don't fit on one page (scollbars appear), which in some cases repaints the entire scrolled area. R=jparent BUG=8630 TEST=none Review URL: http://codereview.chromium.org/402015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32219 0039d316-1c4b-4281-b951-d872f2087c98
* I've moved toolbar_controller_unittest over to CocoaTest which should be ↵dmaclach@chromium.org2009-11-171-23/+19
| | | | | | | | | | | | | better about cleaning things up properly. Let's see if this fixes the world. BUG=27920 TEST=none Review URL: http://codereview.chromium.org/399041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32218 0039d316-1c4b-4281-b951-d872f2087c98
* Add new failure to expectations on MAC.erikkay@chromium.org2009-11-171-1/+1
| | | | | | | | | | BUG=28034 TEST=LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny.html TBR=yaar,idana Review URL: http://codereview.chromium.org/399046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32217 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly set an icon color for Incognito on Mac.avi@google.com2009-11-171-12/+16
| | | | | | | | | BUG=http://crbug.com/27867 TEST=incognito icons should be black Review URL: http://codereview.chromium.org/405008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32216 0039d316-1c4b-4281-b951-d872f2087c98
* Strings to localize for the try-chrome again toastcpu@chromium.org2009-11-172-0/+40
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/397026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32215 0039d316-1c4b-4281-b951-d872f2087c98
* Style cleanups for BrowserThemeProvider. Move the globaltony@chromium.org2009-11-172-53/+64
| | | | | | | | | | | | stl containers into helper functions to defer init and to ensure we only initialize once. Move some consts into the namespace. TEST=none BUG=none Review URL: http://codereview.chromium.org/399042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32214 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race conditions where an object's constructor uses PostTask on itself. ↵jam@chromium.org2009-11-1712-46/+70
| | | | | | | | | This isn't safe since the posted task can execute before the constructor returns, leading to destruction of the object. BUG=27944 Review URL: http://codereview.chromium.org/399016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32213 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a problem where queued checks' clients would never be called back if ↵pkasting@chromium.org2009-11-172-44/+74
| | | | | | | | | | | | when the check finally ran it passed the prefix check (the common case). This was made more noticeable by r31950 since before that things wouldn't be queued unless we were resetting the database (rare) or caught a narrow timing window where |database_| was true but |database_loaded_| was false; after that, we could get this on startup, and with r32136, after closing the database as well. This also removes some unnecessary bits now that we don't queue during a reset. BUG=23400 TEST=none Review URL: http://codereview.chromium.org/402004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32212 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition in signal thread destructor.zork@google.com2009-11-172-2/+14
| | | | | | | | | BUG=23251 TEST=none Review URL: http://codereview.chromium.org/402026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32211 0039d316-1c4b-4281-b951-d872f2087c98
* Add CRASH to Linux expectations forerikkay@chromium.org2009-11-171-1/+1
| | | | | | | | | | | | LayoutTests/plugins/embed-attributes-setting.html BUG=15797 TEST=LayoutTests/plugins/embed-attributes-setting.html TBR=idana Review URL: http://codereview.chromium.org/400019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32210 0039d316-1c4b-4281-b951-d872f2087c98
* Added two suppressions for a leak and an invalid read in WebCore.idana@chromium.org2009-11-171-0/+52
| | | | | | | | | BUG=28026,28027 TEST=none TBR=erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32209 0039d316-1c4b-4281-b951-d872f2087c98
* Allow multiselection deletion of engines in the Manage Search Engines ↵pkasting@chromium.org2009-11-171-9/+15
| | | | | | | | | dialog. Original patch by Thiago Farina (see http://codereview.chromium.org/402020 ), r=me, tweaked. BUG=16842 TEST=Select multiple engines. "Remove" should be enabled iff the selected set does not include the default engine. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32208 0039d316-1c4b-4281-b951-d872f2087c98
* UI Changes for benchmark:mbelshe@google.com2009-11-171-5/+11
| | | | | | | | | | | | | a) Remove the "Config" button; instead, the configuration is always just applied to a run. b) Make the clear button work properly Put in UI when there are no results to display. BUG=none TEST=none Review URL: http://codereview.chromium.org/397025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32207 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Skia 424:428, and enable Skia SSE2 optimizations for Linux and ↵senorblanco@chromium.org2009-11-173-13/+58
| | | | | | | | | | | | | Mac. Due to unfortunate limitations in gcc and gyp, this required creating a new static library target, skia_sse2 (see skia.gyp for the gory details). I did a search-and-replace in all .gyp files in the tree, but if there are other projects outside this tree which refer to skia.gyp, they will have to be modified as well. This also required rolling DEPS for O3D Skia 376:428, since O3D uses chrome's skia.gyp file. Since this update brings ~25M of HTML docs, I pared the DEPS file down to just src/ and include/ (as we do in Chrome). I built O3D on 32bit Linux to test; hopefully other platforms will be ok. BUG=none TEST=green bots Review URL: http://codereview.chromium.org/402016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32206 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break on Mac release.jam@chromium.org2009-11-171-2/+3
| | | | | | | | BUG=6844 TBR=darin Review URL: http://codereview.chromium.org/405006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32205 0039d316-1c4b-4281-b951-d872f2087c98
* fix include orderjam@chromium.org2009-11-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32204 0039d316-1c4b-4281-b951-d872f2087c98
* Launch processes asynchronously so as not to block the UI thread. For now, ↵jam@chromium.org2009-11-1716-330/+481
| | | | | | | | | renderer only, I'll take care of plugin/worker/utility processes in a followup change. BUG=6844 Review URL: http://codereview.chromium.org/397002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32203 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Use TabSwitchPaintDuration in tab switching test."chase@chromium.org2009-11-171-21/+20
| | | | | | | | | | | | | | Turns vista perf red. Original review URL: http://codereview.chromium.org/385121. Original revision r32196. TBR=nsylvain BUG=4104 TEST=vista perf tab switching test goes green Review URL: http://codereview.chromium.org/402024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32202 0039d316-1c4b-4281-b951-d872f2087c98
* Do not open a new connection if one has already been opened.dumi@chromium.org2009-11-171-0/+5
| | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/405005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32201 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac/Linux] Fix WordIterator::GetWord() for UTF-16 surrogate pairs.shess@chromium.org2009-11-172-0/+63
| | | | | | | | | | | | | | | | For systems where !defined(WCHART_T_IS_UTF16), WordIterator transforms the input into UChar data. But GetWord() was using the resulting offsets as indices into the original string, so it could return incorrect data and/or attempt to index off the end of the input. This changes GetWord() to do do the inverse conversion from Init() for those systems. BUG=27698 TEST=See bug. Review URL: http://codereview.chromium.org/399010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32199 0039d316-1c4b-4281-b951-d872f2087c98
* Remove min/max values from averages in benchmark.mbelshe@google.com2009-11-171-1/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/399039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32198 0039d316-1c4b-4281-b951-d872f2087c98
* Remove new tabstrip code. Going to try doing this a different way.ben@chromium.org2009-11-1731-2498/+158
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/400005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32197 0039d316-1c4b-4281-b951-d872f2087c98
* Use TabSwitchPaintDuration in tab switching test.chase@chromium.org2009-11-171-20/+21
| | | | | | | | | | | | | | | | | | | | | | | | Modified the tab switching test to use the new tab switch paint duration histogram in place of the whiteout duration histogram. As a measure, whiteout duration would not carry a value if we kept the backing store around for a tab, and we would end up with a result of zero instead of a useful result. Local results with the new measure are consistent with the number of operations we perform on the tabs. The tab switching test now fails if it cannot locate the correct histogram. In that case, it will output the contents of the log file for remote debugging. BUG=4104 TEST=count of tab switch paint duration histogram results in tab switching test equals number of tabs used in test Review URL: http://codereview.chromium.org/385121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32196 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 51062:51075yaar@chromium.org2009-11-172-3/+14
| | | | | | Review URL: http://codereview.chromium.org/404008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32195 0039d316-1c4b-4281-b951-d872f2087c98
* Use plain strings instead of wstrings for UMA actionsevan@chromium.org2009-11-1759-363/+364
| | | | | | | | | | | | git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/ This cuts more than 10k off my binary. Which is nothing compared to the size of the binary, but that's a whole lot of zero bytes! This is less code this way anyway. Review URL: http://codereview.chromium.org/399026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
* Checks if the plugin has gone away inside of HandleURLRequestInternal()jamesr@chromium.org2009-11-171-0/+6
| | | | | | | | | TEST=Set up a plugin to race a destroy call against the sync IPC, run 20 times BUG=27924 Review URL: http://codereview.chromium.org/391085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32193 0039d316-1c4b-4281-b951-d872f2087c98
* Update bug number for color correction layout testsvictorw@chromium.org2009-11-171-13/+16
| | | | | | | | | | TBR=dglazkov TEST=none BUG=27551,27555,28005 Review URL: http://codereview.chromium.org/405004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32192 0039d316-1c4b-4281-b951-d872f2087c98
* ViewIDTest.Basic fixoshima@chromium.org2009-11-171-2/+7
| | | | | | | | | | | FindBar has to be created before the test. BUG=26192 TEST=Run browser_tests Review URL: http://codereview.chromium.org/387060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32191 0039d316-1c4b-4281-b951-d872f2087c98
* Call the new presubmit checks from chrome/ code, with a blacklist.erg@google.com2009-11-171-0/+51
| | | | | | Review URL: http://codereview.chromium.org/400014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32190 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at fixing white flash in switching between ntp and non-ntp.sky@chromium.org2009-11-171-17/+7
| | | | | | | | | | BUG=27898 TEST=make sure tab switching on chrome os doesn't result in any visual artifacts, especially when switching between ntp and non-ntp. Review URL: http://codereview.chromium.org/404005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32189 0039d316-1c4b-4281-b951-d872f2087c98
* The AutomationMsg_SetCookie IPC should be channeled to the automation cookie ↵ananta@chromium.org2009-11-171-1/+6
| | | | | | | | | | | | store for ChromeFrame. This ensures that the automation client would receive a callback when the cookie is set on the store. Bug=none Review URL: http://codereview.chromium.org/403004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32188 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crashing bug due to browser being NULL.chocobo@chromium.org2009-11-171-3/+3
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/400015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32187 0039d316-1c4b-4281-b951-d872f2087c98
* sync: add some "static"s to functionsevan@chromium.org2009-11-171-12/+14
| | | | | | | | | This is needed to work around a gcc bug when building with -Os. But it's more correct anyway. Review URL: http://codereview.chromium.org/395026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32186 0039d316-1c4b-4281-b951-d872f2087c98
* linux: set -fvisiblility-inlines-hidden when buildingevan@chromium.org2009-11-171-0/+3
| | | | | | | | This matches the Mac and shaves a surprising 300kb off the binary. Review URL: http://codereview.chromium.org/402003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32185 0039d316-1c4b-4281-b951-d872f2087c98
* Don't treat CF in privileged mode as an iframe for framebustingjoi@chromium.org2009-11-172-2/+5
| | | | | | | | | | | headers. BUG=none TEST=none Review URL: http://codereview.chromium.org/402013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32183 0039d316-1c4b-4281-b951-d872f2087c98
* Disable all of ToolbarControllerTest due to crashiness.erikkay@chromium.org2009-11-171-15/+17
| | | | | | | | | BUG=27920 TBR=idana Review URL: http://codereview.chromium.org/400013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32182 0039d316-1c4b-4281-b951-d872f2087c98
* Added suppressions for new Valgrind errors.idana@chromium.org2009-11-171-0/+234
| | | | | | | | | | BUG=27989,27991,27993 TEST=none TBR=erikkay Review URL: http://codereview.chromium.org/399038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32178 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks and fixes for NTP extension promo.mirandac@chromium.org2009-11-177-24/+37
| | | | | | | | | | Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing. BUG= 27814, 25258, 27815 TEST= see various bugs. Review URL: http://codereview.chromium.org/385135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32176 0039d316-1c4b-4281-b951-d872f2087c98
* Add histograms for data connection error types.phajdan.jr@chromium.org2009-11-172-0/+80
| | | | | | | | | | | | The plan is to see how many of them are possibly caused by the passive FTP mode being blocked in the network. TEST=none BUG=3073 Review URL: http://codereview.chromium.org/389023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32175 0039d316-1c4b-4281-b951-d872f2087c98
* Adds auto continue option on Debugger Agent to avoid pausing the.pfeldman@chromium.org2009-11-174-1/+16
| | | | | | | | | | Original review: http://codereview.chromium.org/395027. TBR=knorton Review URL: http://codereview.chromium.org/402014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32174 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Element styles manual testapavlov@chromium.org2009-11-171-0/+40
| | | | | | | | | BUG=none TEST=this Review URL: http://codereview.chromium.org/399034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32171 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 250.0 to 251.0chrome-bot@google.com2009-11-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32167 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 3798.hbono@chromium.org2009-11-171-0/+27
| | | | | | | | | | Some Chinese IMEs insert whitespace characters (U+3000) instead of input characters while they are composing text. So, trimming these whitespace characters (at the beginning of an omnibox) prevents from inputting text on these IMEs. As a quick fix, this change prevent our AutocompleteEditViewWin::OnImeComposition() from starting auto-complete when an omnibox starts with whitespace characters. BUG=3798 TEST=Type "google.com" on Omnibox, type "Tab" to start tab-to-search, type 'nihao' on Microsoft New Phonetic IME, and see we can see Chinese characters in the omnibox. Review URL: http://codereview.chromium.org/391070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32166 0039d316-1c4b-4281-b951-d872f2087c98
* Implement web app shortcuts natively per issue 25528xiyuan@chromium.org2009-11-1727-137/+1077
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Implement a CreateApplicationShortcutView similar to the current Gears-based one; - Add a few profile prefs to persist user's last checked shortcut locations - Implement a web_app::CreateShortcut that stores icon under "<profile>/Web Applications" in a similar layout as gears (i.e. <host>/<scheme_port>/<web_app_title>.ico) and calls file_util code to creates shortcut on Windows; - Add Win7 taskbar pin/unpin support function to file_util; - Update TabContents to replace gears with new code; Note: - Gears dialog is modaless but this one is a modal dialog. - Gear's icon store is not migrated because gears icons could still be used by shortcuts created by gears and thus we could not delete them even after migration. And we are not using the local ico files in the dialog even if they exists. - New CreateApplicationShortcutView is included when TOOLKIT_VIEW is defined. However on platforms other than Windows, the actual CreateShortCut code is not implemented. Right now it calls ShellIntegration's CreateDesktopShort if OS_LINUX is defined and NOTREACHED() for other platforms. BUG=25528 TEST=Verify the new UI provides the same functionality as gears under XP/Vista and support pinning on Win 7. Review URL: http://codereview.chromium.org/372012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32165 0039d316-1c4b-4281-b951-d872f2087c98
* Apply andrewbunn's patch for issue 19358xiyuan@chromium.org2009-11-171-6/+8
| | | | | | | | | | | The patch gives non-webapp chrome an app id so that win7 taskbar group the icons correctly. That is, webapp icons are grouped together based on app name and all chrome windows are grouped together. BUG=19358 TEST=verify fix for issue 19358 Review URL: http://codereview.chromium.org/385120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32164 0039d316-1c4b-4281-b951-d872f2087c98
* Add validation to extension packaging.aa@chromium.org2009-11-172-1/+31
| | | | | | | | BUG=27685,27690 Review URL: http://codereview.chromium.org/398001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32163 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ToolbarControllerTest.LoadingState which crashed a few times today.idana@chromium.org2009-11-171-1/+2
| | | | | | | | | | BUG=27920 TEST=ToolbarControllerTest.LoadingState TBR=dmaclach,erikkay Review URL: http://codereview.chromium.org/403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32162 0039d316-1c4b-4281-b951-d872f2087c98
* Fix thumb buildjoel@chromium.org2009-11-171-0/+5
| | | | | | | | | | | | | This fixes the following error seen when attempting to build with -mthumb on gcc-4.4: CXX(target) out/Release/obj.target/skia/third_party/skia/src/opts/SkBlitRow_opts_arm.o /tmp/ccINCRGl.s: Assembler messages: /tmp/ccINCRGl.s:105: Error: thumb conditional instruction should be in IT block -- `moveq ip,#8' make: *** [out/Release/obj.target/skia/third_party/skia/src/opts/SkBlitRow_opts_arm.o] Error 1 Review URL: http://codereview.chromium.org/399023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32161 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the ServerChangeProcessing test.nick@chromium.org2009-11-171-2/+1
| | | | | | Review URL: http://codereview.chromium.org/387066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32160 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: willchanwillchan@chromium.org2009-11-175-27/+21
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32159 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 06:45:42 +0000