summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert 85732 (broke build) - Move SystemMonitor to base/.willchan@chromium.org2011-05-1827-529/+46
| | | | | | | | | | | | | | | | I plan to use SystemMonitor in net/. Fix up the Mac implementation not to use Cocoa APIs since @interface is not allowed in base. BUG=none TEST=none Review URL: http://codereview.chromium.org/7015017 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/7042003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85734 0039d316-1c4b-4281-b951-d872f2087c98
* Add a prefix to another suppression rule.hbono@chromium.org2011-05-181-1/+1
| | | | | | | | | | | This change updates the suppression rules to fix unit tests. TBR=thestig,timurrrr,glider BUG=82715 TEST=none Review URL: http://codereview.chromium.org/7039032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85733 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to base/.willchan@chromium.org2011-05-1828-137/+147
| | | | | | | | | | | | | I plan to use SystemMonitor in net/. Fix up the Mac implementation not to use Cocoa APIs since @interface is not allowed in base. BUG=none TEST=none Review URL: http://codereview.chromium.org/7015017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85732 0039d316-1c4b-4281-b951-d872f2087c98
* Hide translate infobar on programmatic navigation.jeremy@chromium.org2011-05-189-19/+33
| | | | | | | | | | | | | | | In Google news, you can change the UI language through a popup menu [which does so by submitting a form programmatically]. The translation infobar wasn't being refreshed in this situation because the page navigation being performed is programmatic. Infobar hiding on navigation, goes through TabContents::ExpireInfoBars() which has an early return if the navigation just performed wasn't initiated by the user. After this, the code loops through the list of infobars and calls ShouldExpire() on each one to determine if it can be closed. This CL removes the early return and moves the code to determine dismissal to the ShouldExpire() method of the infobar delegates, thus allowing the translate infobar to indicate that it can be dismissed on page navigation. BUG=70261 TEST=See bug. Review URL: http://codereview.chromium.org/6883299 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85731 0039d316-1c4b-4281-b951-d872f2087c98
* Heapchecker: Update another suppression with the namespace after updating ↵thestig@chromium.org2011-05-181-2/+2
| | | | | | | | | | the Lucid bot. BUG=82715 TEST=none Review URL: http://codereview.chromium.org/7029024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85730 0039d316-1c4b-4281-b951-d872f2087c98
* Make clang plugin work with generated source files when ninja is used.thakis@chromium.org2011-05-181-0/+1
| | | | | | | | | | | | | ninja puts generated code into "ninja" instead of "out", so that directory needs to be added to the list of ignored directories. BUG=none TEST=none Review URL: http://codereview.chromium.org/7017039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85729 0039d316-1c4b-4281-b951-d872f2087c98
* Add namespaces to the suppression rules.hbono@chromium.org2011-05-181-4/+4
| | | | | | | | | | This change just added namespaces to some suppression rules so it works on the Lucid bot. BUG=82715 TEST=none Review URL: http://codereview.chromium.org/7036029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85728 0039d316-1c4b-4281-b951-d872f2087c98
* Heapchecker: change all fun:basic_string* suppressions to fun:*basic_string*.thestig@chromium.org2011-05-181-10/+10
| | | | | | | | BUG=82715 TEST=none Review URL: http://codereview.chromium.org/7038031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85727 0039d316-1c4b-4281-b951-d872f2087c98
* Backout FAILS_ BiDiChecker tests.jeremy@chromium.org2011-05-181-12/+0
| | | | | | | | | | Some of the new bidi tests marked as failing are not completing on release builders. TEST=None BUG=83016 TBR= git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85726 0039d316-1c4b-4281-b951-d872f2087c98
* Heapchecker: change all fun:basic_string suppressions to fun:basic_string*thestig@chromium.org2011-05-181-10/+10
| | | | | | | | BUG=82715 TEST=none Review URL: http://codereview.chromium.org/7039030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85725 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of crashes related to app-crashed balloon.sadrul@chromium.org2011-05-181-5/+15
| | | | | | | | | | | Close the crash-notification balloon if background contents is restarted for an app. And check for valid values when loading background contents. BUG=82492, 82505 TEST=manually Review URL: http://codereview.chromium.org/7012031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85724 0039d316-1c4b-4281-b951-d872f2087c98
* Use observer for an X message pump to intercept keyevents for volume control.sadrul@chromium.org2011-05-182-30/+61
| | | | | | | | | BUG=none TEST=Pressed F8/F9/F10 keys on chromeos builds with and without touchui on the desktop and saw the volume-control bubble show up. Review URL: http://codereview.chromium.org/7011005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85723 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure new gaia password gets picked up as the new passphrase.lipalani@chromium.org2011-05-181-6/+10
| | | | | | | | | BUG=76128 TEST= Review URL: http://codereview.chromium.org/7029023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85722 0039d316-1c4b-4281-b951-d872f2087c98
* Show error in the bookmarks bar if passphrase is not valid.lipalani@chromium.org2011-05-181-2/+5
| | | | | | | | | BUG=81492 TEST= Review URL: http://codereview.chromium.org/7019023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85721 0039d316-1c4b-4281-b951-d872f2087c98
* Added GetAvailableSpace to QuotaManagerkinuko@chromium.org2011-05-184-1/+65
| | | | | | | | | | BUG=61676 TEST=QuotaManagerTest.GetAvailableSpaceTest Review URL: http://codereview.chromium.org/7014042 Patch from Taiju Tsuiki <tzik@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85720 0039d316-1c4b-4281-b951-d872f2087c98
* Make NotifyHeadersComplete the last call in the function.aarya@google.com2011-05-181-2/+2
| | | | | | | BUG=82903 Review URL: http://codereview.chromium.org/7038017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85719 0039d316-1c4b-4281-b951-d872f2087c98
* Do not handle Enable and Disable signals of IBusInputContext.penghuang@chromium.org2011-05-182-27/+1
| | | | | | | | | | | | | | | Becasue Enable and Disable are for indicating if an IBusInputContext is associated with an input method engine and the engine is active. So InputMethodIBus should not use them to decide if the input method system is enabled or not. BUG=None TEST=Manually Review URL: http://codereview.chromium.org/6975013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85718 0039d316-1c4b-4281-b951-d872f2087c98
* This error has been fixenated.abarth@chromium.org2011-05-181-8/+0
| | | | | | Review URL: http://codereview.chromium.org/6975039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85717 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant MessageLoopProxy from LocalFilePathCallbackDispatcher.adamk@chromium.org2011-05-182-23/+9
| | | | | | | | | | | | | | | | From what I can see, callbacks from FileSystemOperation will always happen on the calling thread, which is already the IO thread. Thus, the io_loop_ member isn't needed, and the callbacks can be called directly. This change is in preparation for a further refactoring of the FileSystem URLRequestJobs. R=ericu@chromium.org Review URL: http://codereview.chromium.org/7017034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85713 0039d316-1c4b-4281-b951-d872f2087c98
* Updating nacl_revision in DEPS.ncbray@google.com2011-05-181-3/+4
| | | | | | | | | | BUG= none TEST= none Review URL: http://codereview.chromium.org/7019025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85712 0039d316-1c4b-4281-b951-d872f2087c98
* Synchronize window resize in MoveMouseToCenterAndPress on linux.oshima@google.com2011-05-183-29/+38
| | | | | | | | | | | | I tried to synchronize it in Show methods (in test mode), but it didn't work because next task is posted before show and running message loop executes the task before the window gets resized. For now, I decided to put the code in ui_controls. Let me know if you have suggestion where to put this code. BUG=82219 TEST=bookmark test and menu_item_view tests are no longer flaky without gtk hack. Review URL: http://codereview.chromium.org/6982031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85711 0039d316-1c4b-4281-b951-d872f2087c98
* Call SwapBuffersCallback multiple times if a frame was dropped.nduca@chromium.org2011-05-185-1/+24
| | | | | | | | BUG=82084 Review URL: http://codereview.chromium.org/7031028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85710 0039d316-1c4b-4281-b951-d872f2087c98
* Disable testNotificationOrderAfterClosingOne on winnirnimesh@google.com2011-05-181-0/+2
| | | | | | | | | | BUG=66072 TEST= Review URL: http://codereview.chromium.org/7039027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85709 0039d316-1c4b-4281-b951-d872f2087c98
* Disable context menu. Remove unused header div. achuith@chromium.org2011-05-181-32/+4
| | | | | | | | BUG=chromium-os:14962 TEST=Right click on download panel. Nothing should happen. Review URL: http://codereview.chromium.org/7013043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85708 0039d316-1c4b-4281-b951-d872f2087c98
* Update icons for file, photo and media.achuith@chromium.org2011-05-183-0/+0
| | | | | | | | BUG=chromium-os:15150 TEST=Download a photo, file and a mp3 and see the new icons. Review URL: http://codereview.chromium.org/7013036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85707 0039d316-1c4b-4281-b951-d872f2087c98
* wk roll: 86704-86718atwilson@chromium.org2011-05-181-1/+1
| | | | | | | | BUG=none TEST=none TBR=yuzo@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85706 0039d316-1c4b-4281-b951-d872f2087c98
* Supply the XMPP user login and token to connect().wez@chromium.org2011-05-181-1/+4
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7038027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85705 0039d316-1c4b-4281-b951-d872f2087c98
* Adding pngs for new imageburner uitbarzic@chromium.org2011-05-185-0/+0
| | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7039026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85704 0039d316-1c4b-4281-b951-d872f2087c98
* Move the little infobar code from TabContents to TabContentsWrapper.jam@chromium.org2011-05-1861-427/+497
| | | | | | | BUG=76792 Review URL: http://codereview.chromium.org/7010017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85703 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 85666 - Consolidate ↵ben@chromium.org2011-05-1835-130/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | ShouldUseNativeFrame/AlwaysUseNativeFrame/UseNativeFrame spaghetti. Now there is: ... window::ShouldUseNativeFrame() Which is basically just a pass-thru to WindowWin::ShouldUseNativeFrame() ... which can be overridden by subclasses. Native-Frame is a windows-only concept but keeping the API on Window means I don't have to update a lot of call sites. Window also gains a FrameType state member that toggles three states - default, force-native and force-custom. This supercedes the "AlwaysUseNativeFrame/AlwaysUseCustomFrame" methods on NonClientView. I have also hooked up a context menu item behind a command line flag --debug-enable-frame-toggle that allows the frame type for an individual window to be toggled, useful for debugging. BUG=none TEST=none Review URL: http://codereview.chromium.org/7036014 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/6975037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85702 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 85668 - These two un-reviewed lines made it into my last commit and ↵ben@chromium.org2011-05-181-1/+2
| | | | | | | | | weren't part of the change. Removing. TBR=ben@chromium.org Review URL: http://codereview.chromium.org/7039028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85701 0039d316-1c4b-4281-b951-d872f2087c98
* Mark several tests that seem flaky under TSAN.joi@chromium.org2011-05-182-3/+7
| | | | | | | | BUG=82991 TEST=none TBR=eroman@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85700 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Remove an obsolete suppression since we upgraded to Lucid.thestig@chromium.org2011-05-181-9/+0
| | | | | | | | | BUG=58874 TEST=none TBR=jochen Review URL: http://codereview.chromium.org/6975031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85699 0039d316-1c4b-4281-b951-d872f2087c98
* Plumbing Keyboard DOMView's TabContents with extention functions:varunjain@chromium.org2011-05-183-5/+65
| | | | | | | | | | | | | | | | | | | Problem: All Extention function requests to a tab contents are delegated through the ExtensionTabHelper. For a DOMView, there is no TabContentsWrapper, hence no ExtensionTabHelper. So all extension function requests reaching the TabContents of a DOMView are lost. Fix: We cannot use the ExtensionTabHelper here because of the absence of TabContentsWrapper. So we delegate extension function requests through TabContentsDelegate. BUG=none TEST=none Review URL: http://codereview.chromium.org/7021018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85698 0039d316-1c4b-4281-b951-d872f2087c98
* Move the chromeos implementation of WifiDataProvider back to chrome, since ↵jam@chromium.org2011-05-177-11/+8
| | | | | | | | | it has chrome dependencies. TBR=avi Review URL: http://codereview.chromium.org/6975030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85697 0039d316-1c4b-4281-b951-d872f2087c98
* Marking test DhcpProxyScriptAdapterFetcher.TimeoutDuringDhcp as FLAKY.gene@chromium.org2011-05-171-1/+1
| | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=82988 BUG=82988 TEST=none TBR=gene@chromium.org Review URL: http://codereview.chromium.org/7019026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85695 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Changes to not use the prerendered contents when window.opener needs ↵tessamac@chromium.org2011-05-1718-163/+43
| | | | | | | | | | | | | | to be set." This reverts commit c0b6f490edab857d1c5d3d79f8df2ba234939b51. TBR=shishir BUG= TEST= Review URL: http://codereview.chromium.org/7017033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85694 0039d316-1c4b-4281-b951-d872f2087c98
* Add the documentation from the WebUI tabs commit to its fileoverview.nduca@chromium.org2011-05-171-0/+23
| | | | | | Review URL: http://codereview.chromium.org/7039017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85693 0039d316-1c4b-4281-b951-d872f2087c98
* Add utility for converting SkCanvas to CGContextcaryclark@chromium.org2011-05-173-2/+136
| | | | | | | | | | | | | | | | | | | | | | | | | Skia on Mac uses Skia to render WebKit, and CG to render UI elements. The CG elements need a transcribed graphics context that preserves the canvas matrix, and the canvas clip. The BitLockerSkia utility class sets up a CGContext from the SkCanvas, locks the bitmap's bits, and releases the lock when the class goes out of scope. Each time the CGContext is retrieved, it is rebuilt. This permits the caller to modify the same canvas between calls. Outside of the unit test, there are no callers to this utility for now. BUG=79463 TEST=SkiaUtilsMacTest.* Review URL: http://codereview.chromium.org/7031006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85692 0039d316-1c4b-4281-b951-d872f2087c98
* Heapchecker: Widen the suppression for bug 82974 to cover more leaks in ↵thestig@chromium.org2011-05-171-9/+31
| | | | | | | | | | | net_unittests. BUG=82974 TEST=none TBR=hbono/glider/timurrrr Review URL: http://codereview.chromium.org/7038022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85691 0039d316-1c4b-4281-b951-d872f2087c98
* Change the PPAPI message loop to type IO (from type UI).viettrungluu@chromium.org2011-05-171-1/+1
| | | | | | | | | | | UI message pumps are special on Mac and won't work. BUG=none TEST=out-of-process Flapper continues to work on Linux and dies later on Mac Review URL: http://codereview.chromium.org/7036024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85690 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to not use the prerendered contents when window.opener needs to be set.shishir@chromium.org2011-05-1718-43/+163
| | | | | | | | | | | | BUG=79922 TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85394 Review URL: http://codereview.chromium.org/6915019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85689 0039d316-1c4b-4281-b951-d872f2087c98
* wk roll: 86644-86704atwilson@chromium.org2011-05-171-1/+1
| | | | | | | | BUG=none TEST=none TBR=yuzo@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85688 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove an obsolete unused function prototypeevan@chromium.org2011-05-171-9/+0
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/7034021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85687 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor ProxyConfigServiceLinux to use an enum of setting ids rather ↵mdm@chromium.org2011-05-173-227/+318
| | | | | | | | | | | | than gconf key names. This will make it easier to add a third way to get proxy settings, via the new gsettings API. BUG=80453 TEST=proxy settings still work as expected on linux Review URL: http://codereview.chromium.org/7027002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85686 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: Move some functions into the unnamed namespace.tfarina@chromium.org2011-05-171-76/+58
| | | | | | | | | | | | | Note: This was a TODO for jhawkins. BUG=None TEST=None R=jhawkins@chromium.org Review URL: http://codereview.chromium.org/7036015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85685 0039d316-1c4b-4281-b951-d872f2087c98
* Heapchecker: Suppress a remoting leak.thestig@chromium.org2011-05-171-0/+14
| | | | | | | | | BUG=82974 TEST=Heapchecker remoting goes green. TBR=hbono/glider/timurrrr Review URL: http://codereview.chromium.org/7031030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85684 0039d316-1c4b-4281-b951-d872f2087c98
* Reordering method definitions in imageburner_ui.cc so it is easier to follow ↵tbarzic@chromium.org2011-05-171-74/+74
| | | | | | | | | | burn workflow BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7038018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85683 0039d316-1c4b-4281-b951-d872f2087c98
* Fix comment I missed.thomasvl@chromium.org2011-05-171-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7039018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85679 0039d316-1c4b-4281-b951-d872f2087c98
* Heapchecker: Disable failing tests afte Lucid migration.thestig@chromium.org2011-05-173-0/+16
| | | | | | | | | BUG=82715 TEST=Heapchecker gets greener. TBR=glider/timurrrr/hbono Review URL: http://codereview.chromium.org/7017027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85678 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 20:22:07 +0000