summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix FlipSession cleanup to be unified through CloseSession. Because Flip ismbelshe@google.com2009-12-012-25/+45
| | | | | | | | | | | | | | | full duplex, a closed socket will cause both read and write completions. Unifying the cleanup code allows both codepaths to safely cleanup the socket. In the process, consolidated several flags on the session into a single State variable. BUG=29004 TEST=WriteError Review URL: http://codereview.chromium.org/450025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33404 0039d316-1c4b-4281-b951-d872f2087c98
* Update CloseIdleSockets to close out FLIP connections asmbelshe@google.com2009-12-011-0/+3
| | | | | | | | | | | well as HTTP connections. This is used for benchmarking. BUG=none TEST=none Review URL: http://codereview.chromium.org/454009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33402 0039d316-1c4b-4281-b951-d872f2087c98
* Porting the table view to Linux toolkit views.jcampan@chromium.org2009-12-0111-34/+466
| | | | | | | | | | | | | | It is the initial implementation, it is still missing: - row focusing - resizable columns - autosize columns BUG=None TEST=Run the unit-tests, play with the TableView2 tab in the view examples. Review URL: http://codereview.chromium.org/434066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33400 0039d316-1c4b-4281-b951-d872f2087c98
* Change the default sans-serif font back to Simsun from Simhei. Simhei is ↵jshin@chromium.org2009-12-011-1/+1
| | | | | | | | | | | | | more like sans-serif while Simsun is more like serif, but a lot of pages just specify 'arial, sans-serif' and SC Chrome ends up using Simhei which is less liked by SC speakers than Simsun. We'll reconsider this later. At least for Chrome 4, we'd better do what we used to do. BUG=28498 TEST=NONE TBR=laforge Review URL: http://codereview.chromium.org/456017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33399 0039d316-1c4b-4281-b951-d872f2087c98
* Allow preferences updates with Value. This is needed for:albertb@google.com2009-12-012-0/+19
| | | | | | | | <http://codereview.chromium.org/437028/show> Review URL: http://codereview.chromium.org/434096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33397 0039d316-1c4b-4281-b951-d872f2087c98
* Add a "// namespace" comment after the closing curly bracewtc@chromium.org2009-12-011-1/+1
| | | | | | | | | | | of a namespace to make cpplint happy. R=zork BUG=none TEST=no compilation errors Review URL: http://codereview.chromium.org/450027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33396 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize the rendering when there are pending key events.suzhe@chromium.org2009-12-012-97/+145
| | | | | | | | | BUG=27932: Regression: Forced rendering for every keystroke TEST=See the bug report. Review URL: http://codereview.chromium.org/435002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33395 0039d316-1c4b-4281-b951-d872f2087c98
* Appcache update support for pending master entries: jennb@chromium.org2009-12-016-84/+1103
| | | | | | | | | | | | | | | | | - Update process issues a URL request to fetch pending master entries. - Pending master entry fetch logic kept separate from regular url fetching as this will be the case in the long-term solution. - No optimizations to avoid issuing URL request if pending master entry is also listed in the manifest. (simpler) - Only optimized to prevent refetching something that has already been successfully fetched. Long-term optimized solution should be to siphon the responses as the master resource is downloaded instead of having the update job issue URL requests. TEST=new tests for update jobs with pending master entries BUG=none Review URL: http://codereview.chromium.org/402098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33394 0039d316-1c4b-4281-b951-d872f2087c98
* Adding and cleaning up screenshotskathyw@google.com2009-12-0125-84/+32
| | | | | | | | | | TBR=aa TEST=none BUG=27425 Review URL: http://codereview.chromium.org/457016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33393 0039d316-1c4b-4281-b951-d872f2087c98
* Plumping for taking LSID cookie from ProfileSyncService to GaiaAuthenticator.albertb@google.com2009-12-0110-29/+136
| | | | | | Review URL: http://codereview.chromium.org/366035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33391 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: add middle click and right click functionality to maximize button.estade@chromium.org2009-12-014-10/+64
| | | | | | | | | | | | If the user right clicks on the maximize button, it will horizontally maximize the window, and if the user middle clicks on the maximize button it will vertically maximize the window. At least on kde, the window manager supports more complicated behavior, e.g. right clicking on a window that is horizontally maximized will return it to its former size. It seems to keep track of multiple restored rects. However, we're not well equipped to replicate this behavior, so I just didn't add it. If the user wants it, they can disable the custom frame. BUG=28881 Review URL: http://codereview.chromium.org/455012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33389 0039d316-1c4b-4281-b951-d872f2087c98
* TBR=kbr@google.comgman@chromium.org2009-12-012-2/+2
| | | | | | | | | Fix for last CL I was testing in the wrong client :-( git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33388 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Skia 435:447. Some tests need rebaselines due to change in ↵senorblanco@chromium.org2009-12-013-3/+12
| | | | | | | | | | | line clipping algorithm. BUG=none TEST=none Review URL: http://codereview.chromium.org/450017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33386 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments and update bug numbers for some layout testsvictorw@chromium.org2009-12-011-3/+8
| | | | | | | | | | TBR=japhet TEST=none BUG=27555, 28605 Review URL: http://codereview.chromium.org/456015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33385 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Flip suppression more generic to cover mac too.willchan@chromium.org2009-12-011-1/+1
| | | | | | | | BUG=http://crbug.com/29026 Review URL: http://codereview.chromium.org/457015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33384 0039d316-1c4b-4281-b951-d872f2087c98
* NSS: sync with CVS version.agl@chromium.org2009-12-015-44/+40
| | | | | | http://codereview.chromium.org/450021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33383 0039d316-1c4b-4281-b951-d872f2087c98
* Remove passing accessibility test from expectations.dglazkov@chromium.org2009-12-011-3/+0
| | | | | | | | | | | | The test was fixed by http://src.chromium.org/viewvc/chrome?view=rev&revision=33368. TBR=victorw TEST=none BUG=29000 Review URL: http://codereview.chromium.org/456014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33381 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes an issue where view source on a local file would return agspencer@google.com2009-12-011-1/+1
| | | | | | | | | | | | | | | | blank page. This bug was introduced by the fix for issue 26129 (r30418), which was to limit view source so that it wouldn't be able to load javascript or data URLs, but that change forgot to allow file urls. This fixes the above omission by allowing file URLs again. TEST=works:view-source:file:///tmp/test.html, doesn't work:view-source:javascript:alert('foo') BUG=27409 Review URL: http://codereview.chromium.org/434094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33380 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the chevron throb after a user sync'ed his bookmarks (if the overflow ↵tim@chromium.org2009-11-303-46/+60
| | | | | | | | | | | | | | | | menu is shown) This also makes the chevron throb when no bookmarks is added during a sync and merge. BUG=24306 TEST=sync with over 10 bookmarks in the bookmark bar so that the chevron is visible. Patch by Bruno Calvignac<BrunoCalvignac@gmail.com> Original Review: http://codereview.chromium.org/306054/show Review URL: http://codereview.chromium.org/454010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33379 0039d316-1c4b-4281-b951-d872f2087c98
* Mark all accessibility tests that rely on platform-specific dump of ↵dglazkov@chromium.org2009-11-301-10/+10
| | | | | | | | | | | | | | properties in results as WONTFIX. These tests are marginally useful in test_shell context anyway, and it's not worth maintaining new baselines. BUG=29009 TEST=none R=dpranke Review URL: http://codereview.chromium.org/455010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33378 0039d316-1c4b-4281-b951-d872f2087c98
* When force-closing sessions we need to close them as abortedmbelshe@google.com2009-11-301-1/+1
| | | | | | | | | | | rather than as OK. BUG=none TEST=none Review URL: http://codereview.chromium.org/457014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33374 0039d316-1c4b-4281-b951-d872f2087c98
* Linux cookies view: ui cleanups to match win.mattm@chromium.org2009-11-303-16/+87
| | | | | | | | | | | | | | | Show tree lines. Domains are collapsed by default and expanding them expands all their children Don't show the column header in the tree view anymore. BUG=27657 TEST=compare to win Review URL: http://codereview.chromium.org/444010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33373 0039d316-1c4b-4281-b951-d872f2087c98
* Changed AudioRendererImplTest and DeferredResourceLoadingTest tests so they ↵apatrick@google.com2009-11-302-2/+17
| | | | | | | | | | | duplicate the shared memory before passing it to another object that takes ownership. Prevents same handle from being closed twice. TEST=none BUG=none Review URL: http://codereview.chromium.org/449026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33372 0039d316-1c4b-4281-b951-d872f2087c98
* Fix syntax error in suppressions filejamesr@chromium.org2009-11-301-1/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/449034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33371 0039d316-1c4b-4281-b951-d872f2087c98
* Marking one more as flaky test. This failed 3 times out of 20 invocations.oshima@chromium.org2009-11-301-0/+4
| | | | | | | | | BUG=28808 TEST=None Review URL: http://codereview.chromium.org/457012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33370 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33344 - Relocate plugin list fetching to PluginServicejamesr@chromium.org2009-11-308-138/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We fetch the plugin list from three places. Previously, each location had custom code to proxy the query to the file thread. This change moves the query to the PluginService, which then internally manages posting to the file thread and calling back. I experimented with some different approaches to handling the lifetimes of the requests and responses. The approach now is simple: The PluginService plugin methods are called and respond on the IO thread. Two of the three consumers of the plugin lists are already on the IO thread, so they don't need any complicated thread handling. None of the callers ever need to cancel their requests: one is a singleton, and the other two always wait (in terms of holding a ref on the object) for the requests to complete. This makes lifetime management a lot simpler than it would otherwise be. With this change in place, I can then look at refactoring the PluginService implementation on Linux to do more complicated plugin loading as needed in bug 17863. BUG=17863 Review URL: http://codereview.chromium.org/437069 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/456012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33369 0039d316-1c4b-4281-b951-d872f2087c98
* Implement AccessibilityUIElement::AttributesOfChildrenCallbackdglazkov@chromium.org2009-11-302-30/+50
| | | | | | | | | | R=victorw TEST=none BUG=29000 Review URL: http://codereview.chromium.org/456009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33368 0039d316-1c4b-4281-b951-d872f2087c98
* Make primitives and lineprimitives sharegman@chromium.org2009-11-302-131/+111
| | | | | | | | the implemtation of createShape Review URL: http://codereview.chromium.org/453010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33367 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 2 issues in docs buildinggman@chromium.org2009-11-302-28/+33
| | | | | | | | | | | 1) Object type specifications "Object<index, type>" were broken 2) The js compiler would create a partial base.js even on failure which means the next build would skip building the docs. Review URL: http://codereview.chromium.org/457011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33366 0039d316-1c4b-4281-b951-d872f2087c98
* Fix suppression to match new call signaturejamesr@chromium.org2009-11-301-1/+1
| | | | | | | | | BUG=28824 TBR=jparent,davemoore Review URL: http://codereview.chromium.org/450019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33365 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression with pasting images in Gmail.finnur@chromium.org2009-11-301-2/+8
| | | | | | | | | BUG=27708 TEST=Right-click an image on a web page and select copy. Paste it into a Gmail compose window. Picture should appear. Also try pasting the image into WordPad, it should appear. Review URL: http://codereview.chromium.org/450018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33364 0039d316-1c4b-4281-b951-d872f2087c98
* Add myself to the ipc watchlist.darin@chromium.org2009-11-301-1/+1
| | | | | | | | TBR=jam Review URL: http://codereview.chromium.org/454011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33363 0039d316-1c4b-4281-b951-d872f2087c98
* Fix text to match screenshot.kathyw@google.com2009-11-302-2/+2
| | | | | | | | | | TBR=aa TEST=none BUG=28786 Review URL: http://codereview.chromium.org/457013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33362 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Adds back the ability to filter cookies by origin in the cookies ↵mattm@chromium.org2009-11-305-11/+277
| | | | | | | | | | | options view BUG=27657 TEST=unittest passes, manually testing typing "google" in the search field pulls up origins containing "google" in their name Review URL: http://codereview.chromium.org/437075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33359 0039d316-1c4b-4281-b951-d872f2087c98
* Call SSL_SetSockPeerID for proper SSL session reuse, especially whenwtc@chromium.org2009-11-302-1/+12
| | | | | | | | | | | | we create SSL tunnels through a proxy. The patch is contributed by Kaspar Brand <googlecontrib@velox.ch>. R=hawk,wtc BUG=28732 TEST=none Review URL: http://codereview.chromium.org/437046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33358 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppression for FLIP test leakjamesr@chromium.org2009-11-301-0/+16
| | | | | | | | | BUG=29026 TBR=mbelshe Review URL: http://codereview.chromium.org/455009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33356 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Dynamically adjust width of download item dangerous warning.estade@chromium.org2009-11-303-15/+36
| | | | | | | | BUG=28707 Review URL: http://codereview.chromium.org/456003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33355 0039d316-1c4b-4281-b951-d872f2087c98
* Roll ICU DEPS to pickup the following:agl@chromium.org2009-11-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make ICU assembly portable to ARM This is a TBR reapplication of r26784, which was lost in r32640. The comment for the original change appears below: This patch fixes the following error: CC src/out/Release/obj/third_party/icu/linux/icudt42l_dat.o third_party/icu/linux/icudt42l_dat.s: Assembler messages: third_party/icu/linux/icudt42l_dat.s:5: Error: unrecognized symbol type "" make: *** [src/out/Release/obj/third_party/icu/linux/icudt42l_dat.o] Error 1 The problem is the assembly syntax that is used is not portable to ARM, where the '@' symbol is a comment: > Note on targets where the @ character is the start of a comment > (eg ARM) then another character is used instead. For example the > ARM port uses the % character. (from http://sourceware.org/binutils/docs-2.18/as/Section.html#Section) Using % instead of @ appears to work on both ARM and x64. BUG=22369 Patch by Joel Stanley <joel@jms.id.au> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33352 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reuse the initial IPC channel.mark@chromium.org2009-11-301-0/+10
| | | | | | | | | | | | | | | | | | | | I was seeing a non-initial IPC channel getting closed in a renderer, and then when someone tried to reuse that channel by name, IPC::Channel::ChannelImpl::CreatePipe would assign the initial pipe. The initial pipe was already in use, and things would fall apart pretty rapidly. I'm making this FATAL because the renderer's probably going to be unusable if it gets into this state anyway, and a sad tab is probably more useful than a tab that appears to be loading indefinitely. BUG=26754 TEST=Test case from bug 26754 comment 9 (affected machines only): a. Have lots of bookmarks (import Safari defaults) b. Rightclick on bookmark bar, and choose "Open All Bookmarks" Expect: no crash. Review URL: http://codereview.chromium.org/452021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33351 0039d316-1c4b-4281-b951-d872f2087c98
* win: change link color in crash page to white.kuan@chromium.org2009-11-301-1/+2
| | | | | | | | BUG=28996 TEST=verify that link in crash page is white. Review URL: http://codereview.chromium.org/453009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33350 0039d316-1c4b-4281-b951-d872f2087c98
* Remove another instance of using the transient pref service. This preftony@chromium.org2009-11-303-9/+7
| | | | | | | | | | | | is only read from the options dialog, the windows installer (a separate process) and a spot in safe browsing. The only one that matters is the safe browsing case. BUG=28992 Review URL: http://codereview.chromium.org/456004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33348 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes views/gtk build. ImporterView is windows specific.sky@chromium.org2009-11-303-4/+10
| | | | | | | | | BUG=none TEST=none TBR=jcampan@chromium.org Review URL: http://codereview.chromium.org/449024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33347 0039d316-1c4b-4281-b951-d872f2087c98
* Relocate plugin list fetching to PluginServiceevan@chromium.org2009-11-308-71/+138
| | | | | | | | | | | | | | | | | | | | | | | | | | | We fetch the plugin list from three places. Previously, each location had custom code to proxy the query to the file thread. This change moves the query to the PluginService, which then internally manages posting to the file thread and calling back. I experimented with some different approaches to handling the lifetimes of the requests and responses. The approach now is simple: - The PluginService plugin methods are called and respond on the IO thread. Two of the three consumers of the plugin lists are already on the IO thread, so they don't need any complicated thread handling. - None of the callers ever need to cancel their requests: one is a singleton, and the other two always wait (in terms of holding a ref on the object) for the requests to complete. This makes lifetime management a lot simpler than it would otherwise be. With this change in place, I can then look at refactoring the PluginService implementation on Linux to do more complicated plugin loading as needed in bug 17863. BUG=17863 Review URL: http://codereview.chromium.org/437069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33344 0039d316-1c4b-4281-b951-d872f2087c98
* Enable sync by default on all platforms.akalin@chromium.org2009-11-302-4/+8
| | | | | | | | | | | BUG=23073 TEST=ran without --enable-sync on OS X, made sure sync UI was still present Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33318 Review URL: http://codereview.chromium.org/438005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33342 0039d316-1c4b-4281-b951-d872f2087c98
* Mark GetJavaScriptURL2 as flaky.willchan@chromium.org2009-11-301-1/+2
| | | | | | | | BUG=http://crbug.com/29020 Review URL: http://codereview.chromium.org/450015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33340 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BugReportWindowController tests.willchan@chromium.org2009-11-301-2/+4
| | | | | | | | BUG=http://crbug.com/29019 Review URL: http://codereview.chromium.org/457008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33338 0039d316-1c4b-4281-b951-d872f2087c98
* Step 1 in getting rid of transient prefs. Move over --homepage totony@chromium.org2009-11-302-17/+15
| | | | | | | | | | not using a transient pref. BUG=28992 Review URL: http://codereview.chromium.org/457003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33337 0039d316-1c4b-4281-b951-d872f2087c98
* Adds link to bookmark bar that when clicked imports bookmarks. I alsosky@chromium.org2009-11-3017-36/+299
| | | | | | | | | | | | added support for baselines to GridLayout. BUG=4374 TEST=On a new profile make sure the bookmark bar has a link to import bookmarks, click the link and make sure you can import your bookmarks. Review URL: http://codereview.chromium.org/440029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33336 0039d316-1c4b-4281-b951-d872f2087c98
* Add -profile command line switchdavemoore@chromium.org2009-11-3021-371/+158
| | | | | | Review URL: http://codereview.chromium.org/384062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33335 0039d316-1c4b-4281-b951-d872f2087c98
* Updated valgrind suppression for 22923 to reflect function prototype change.atwilson@chromium.org2009-11-301-8/+0
| | | | | | | | | BUG=22923 TEST=existing tests suffice Review URL: http://codereview.chromium.org/457005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33331 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 08:17:26 +0000