| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2934006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
closing down.
TEST=net_unittests
BUG=47455,48503
Review URL: http://codereview.chromium.org/2841029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48712
TBR=jrg
Review URL: http://codereview.chromium.org/2971001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wasn't actually causing problems in release builds (presumably O3D was able to complete the re-entrant render action without problems), but we still don't want to do it.
TEST=loaded a debug build repeatedly in Chrome/Linux and verified no DCHECK failure, whereas previously it happened a fair amount
BUG=none
Review URL: http://codereview.chromium.org/2944006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
previously disabled in ChromeOS.
BUG=chrome-os:4073
TEST=open about:system, right mouse click and pick Save As menu item
Review URL: http://codereview.chromium.org/2880009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
FillRectInt and BeginPlatformPaint/EndPlatformPaint.http://crbug.com/48583TEST=see unittest
Review URL: http://codereview.chromium.org/2939001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Forward declare printing::PrintViewManager in TabContents
- tab_contents.h shouldn't depend on autocomplete_edit.h
- Pull logging out of Browser through PageTransitionTypes
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2934004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
match .grds which were recently sorted into order).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2941004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
standalone.
Example:
$ testserver --doc-root=net/data/url_request_unittest --http
Also supports --https and --ftp.
R=eroman
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2901006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:4659
TEST=none
Review URL: http://codereview.chromium.org/2957005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to run the sync integration tests on the chromium
buildbots, we need a way to load the GAIA credentials from a local password file
instead of via command line parameters.
This changelist implements a new command line parameter called
"--password-file-for-test" for this purpose.
==================================================
NOTE: This code was originally checked in as http://codereview.chromium.org/2899001, but checkin http://codereview.chromium.org/2850042 broke it, resulting in the original checkin being reverted with http://codereview.chromium.org/2905004.
This is a new attempt at checking in the code, where password_file_ is a FilePath instead of a wstring.
BUG=48525
TEST=sync_integration_tests;valid password file;invalid password file;blank password file;non-existent password file
Review URL: http://codereview.chromium.org/2899006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BINDSTATUS_MIMETYPEAVAILABLE.
BUG=48685
Review URL: http://codereview.chromium.org/2951006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=net_unittests pass
Review URL: http://codereview.chromium.org/2936002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Bug=45510
Review URL: http://codereview.chromium.org/2918003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46528
TEST=mini_installer.exe --installerdata=<file_path>
Review URL: http://codereview.chromium.org/2962004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2899012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the root view Layout code which does not give
the child views a chance to process the layout if a layout manager existed for the root view. The default layout manager for
the root view is the FillView.
Fix is to handle layout correctly in the ExternalTabContainer in the InfoBarSizeChanged notification by maintaining the current
grid view in a member and invoking layout on it.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=48569
Bug=48569
Review URL: http://codereview.chromium.org/2963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2836046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=evan,estade
BUG=51974
TEST=went green locally.
Review URL: http://codereview.chromium.org/2900004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If Renderer::max_fps has been set, rendering is driven by incoming new
textures. We draw on each new texture as long as not exceeding max_fps.
If we are in RENDERMODE_ON_DEMAND mode, Client::Render() can still set dirty
specifically.
If we are in ENDERMODE_CONTINUOUS mode, we do NOT set dirty on each tick any
more (since it is already driven by new textures.).
There is one problem here: what if new texture don't come in for some reason?
If that happened, no rendering callback will be invoked and this can cause
problem sometimes. For example, some UI may depend on the rendering callback
to work correctly.
So, in RENDERMODE_CONTINUOUS mode, if we have set max_fps but haven't
received any new texture for a while, we draw anyway to trigger the rendering
callback.
Review URL: http://codereview.chromium.org/2899008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
away from the default theme. This is to avoid the server-wins logic from
overwriting custom themes for new sync clients. With this patch, the first
non-default theme that gets synced will be propagated to all clients.
BUG=48155
TEST=manually tested
Review URL: http://codereview.chromium.org/2946001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm having a hard time reproing this hang locally -- I ran the test for several days on windows with no hangs. So this change should prevent any individual test in this test from hanging and hopefully help provide some helpful info when it hangs again.
And since the tests won't hang anymore, I believe we can make them FLAKY.
BUG=39070
Review URL: http://codereview.chromium.org/2864043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The heuristic should catch these. Keeping the list just makes it harder to find problems
with the heuristic.
BUG=none
TEST=Still no infobars for single-word queries on any networks.
Review URL: http://codereview.chromium.org/2917007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
being used until the maximum size is reached.
BUG=48494
TEST=create notifications of various sizes, watch for jitter
Review URL: http://codereview.chromium.org/2941003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and scripts to run on the Chrome Extensions Gallery site. There are
security concerns in enabling this and so it remains off by default,
but this is needed for automation testing of the gallery.
Cleanup: Have UserScriptSlave::InjectScripts() return void instead of a bogus bool.
TEST=Visit http://chrome.google.com/extensions, check that content scripts work when the command-line switch is given, and are not injected when the switch is not given.
BUG=none
Review URL: http://codereview.chromium.org/2912002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ThemeChangeProcessor, since the error will clear the profile_ without returning, and the profile is accessed later. Since the code discusses how to process deletes, I think this is the correct fix.
BUG=none
TEST=sync themes and then delete it
Review URL: http://codereview.chromium.org/2913006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The favicon used to be loaded from a png file in
the resources directory. Since the file is gone,
this no longer works. Instead, check for the bookmark
manager extension earlier and load the image from the
pak file.
BUG=48218
Review URL: http://codereview.chromium.org/2960002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This completes the linux implementation of the new wrench menu. Turning
on by default. Will watch how this goes.
BUG=45757
TEST=Look at the menu. The size of the "cut," "copy" and "paste" buttons
should be equal.
Review URL: http://codereview.chromium.org/2961001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44620
TEST=none
Review URL: http://codereview.chromium.org/2920004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for windows, linux platforms resp.
BUG=48597
TEST=None
Review URL: http://codereview.chromium.org/2958002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also correct a test description that became inaccurate when we supported a
reversed bypass list, and remove spaces from host rules earlier. (KDE actually
treats both comma and space as valid delimiters anyway.)
R=wtc,eroman
BUG=48486
TEST=ProxyConfigServiceLinuxTest.KDEConfigParser
Review URL: http://codereview.chromium.org/2848041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL contains the following:
-Use lower case names for enum values in the create/update properties (eg 'page' instead of 'PAGE')
-Make the top-level API name plural (contextMenus instead of contextMenu)
-Don't fire onclick handlers for a parent menu item when one of its children is clicked on.
-Remove the enabledContexts property for now, to eventually be replaced with a way to programmatically enable/disable.
There are a few more things in the bug that I'll be doing in subsequent CL's.
BUG=48198
TEST=Extensions using the context menu API should work with the changes described above.
Review URL: http://codereview.chromium.org/2887013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(and fix it for typed urls).
BUG=45883
TEST=sync extension/typed url/autofill, verify delete propagation
Review URL: http://codereview.chromium.org/2920002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes issue with Mac AddressBook "me" profiles where nil address returned was causing DCHECK.
BUG=48629
TEST=Manual, create AddressBook "me" card address with empty address fields but valid country, relaunch debug version of Chrome.
Review URL: http://codereview.chromium.org/2904007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the collection out into a separate class.
BUG=38736
TEST=existing unittests
Review URL: http://codereview.chromium.org/2914001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
plugins/plugin-initiate-popup-window.html
BUG=48033
TEST=plugins/plugin-initiate-popup-window.html
Review URL: http://codereview.chromium.org/2815041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=7721
TEST=PrintingLayoutTextTest.Complex
Review URL: http://codereview.chromium.org/2939003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=automation tests with --login-screen=login should work.
Review URL: http://codereview.chromium.org/2968001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
namespace.
This function is used in one place and is deprecated, so would be good to move
it there so no one can make other uses of it.
BUG=24672
TEST=trybots
Review URL: http://codereview.chromium.org/2809049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes case where DCHECK was failing in presence of Autocomplete cancel logic. The DCHECK in this case was erroneous. The new logic handles the cancel case
appropriately.
BUG=none
TEST=AutoFillManagerTest.GetFieldSuggestionsForAutocompleteOnly
Review URL: http://codereview.chromium.org/2945003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was marked as TEXT+IMAGE, but it doesn't give text mismatch on
all bots, so it should be FAIL.
BUG=48668
TEST=Webkit Mac10.5 goes green
TBR=ajwong
Review URL: http://codereview.chromium.org/2933006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2881013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Main change is here: http://codereview.chromium.org/2920001
BUG=crosbug.com/3178, crosbug.com/2884, crosbug.com/4332
TEST=none
Review URL: http://codereview.chromium.org/2925004
TBR=glotov@chromium.org
Review URL: http://codereview.chromium.org/2940002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Main change is here: http://codereview.chromium.org/2920001
BUG=crosbug.com/3178, crosbug.com/2884, crosbug.com/4332
TEST=none
Review URL: http://codereview.chromium.org/2925004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
And also improving the coverage analysis speed by not generating useless xml, and also making that the timeout option is always of the right type and not cause exceptions later on.
TEST=Run the coverage build.
BUG=0
Review URL: http://codereview.chromium.org/2927001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48671
TBR=suzhe
Review URL: http://codereview.chromium.org/2945008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Remaining one usage to be fixed, until we can remove it completly.)
BUG=24672
TEST=trybots
Review URL: http://codereview.chromium.org/2841039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(dbg)(3)
BUG=48668
TEST=Webkit Mac10.5 (dbg)(1) turns green.
TBR=ajwong
Review URL: http://codereview.chromium.org/2904008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48664
R=jar
Review URL: http://codereview.chromium.org/2958004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(https://bugs.webkit.org/show_bug.cgi?id=41697)
BUG=36438
TEST=DevToolsSanityTest.TestMessageLoopReentrant
Review URL: http://codereview.chromium.org/2965002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51949 0039d316-1c4b-4281-b951-d872f2087c98
|