| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to follow WebKit r42740.
- Add a WebNode parameter to WebViewDelegate::decidePolicyForNavigation()
TestWebViewDelegate prints the path of the node. RenderView ignores this parameter.
- Fix a bug of WebNode assignment.
BUG=11000
TEST=This change enables 3 layout tests.
Review URL: http://codereview.chromium.org/267003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is used for WebSocket protocol.
BUG=12497
TEST=none
Review URL: http://codereview.chromium.org/243077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
committing a bunch of local changes individually with
bad commit messages.
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also, implement cool spinning gmail icon when unread count changes.
Review URL: http://codereview.chromium.org/264021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the only test that is failing. (The test is still being investigated
but it is good to keep as much running as possible.)
BUG=23391
TEST=Enabling tests.
Review URL: http://codereview.chromium.org/266035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
synchronization.It does the item 5 of the BUG only.This add a button after |Tools| menu.
And it's showed all the time, with the current status of sync. The user should run 'chrome --enable-sync' to see it.
Patch by Thiago Farina, http://codereview.chromium.org/256017
BUG=23136
TEST=compiled and ran on Windows.
Review URL: http://codereview.chromium.org/268021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/265057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebView to RenderView.
R=mpcomplete
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/265044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to chrome threads.
BUG=19895
Review URL: http://codereview.chromium.org/265054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none yet, these are just API definitions stubbed out for now
BUG=none
Review URL: http://codereview.chromium.org/209071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move file accesses during initialization to file thread. Also fix a rare (and harmless) memory leak. Also introduce a rare (and harmless) memory leak.
TEST=added dchecks, ran spellcheck unit tests, clicked around, changed dictionaries, added words
BUG=22984
BUG=21924
BUG=1123096
Review URL: http://codereview.chromium.org/269020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If the SavePackage or SaveFileManager went down at the wrong time (most likely during shutdown), we potentially could have crashed. Avoid this race by using a specialized Task instaed of SaveFileManager, and by making the SavePackage callback task scoped.
BUG=none
TEST=downloads still work, whether or not the downloads dir exists.
Review URL: http://codereview.chromium.org/262019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=https://metafilter.com
BUG=23339
Review URL: http://codereview.chromium.org/261033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
as greylisted.
BUG=3628
Review URL: http://codereview.chromium.org/270006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the buildbot.
BUG=24400
TBR=thakis
Review URL: http://codereview.chromium.org/271030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since cmd-left/right should not do history if the omnibox is focussed, but cmd-1-9 should work if the omnibox is focussed, we have to differentiate between window- and browser-level shortcuts.
(Because performKeyEquivalent bubbles up from the window -- and if we let it bubble up to the omnibox, then the omnibox handles cmd-left/right just fine, but it swallows cmd-1 and doesn't give us a chance to intercept this. That means cmd-left doesn't work if you hit cmd-l tab, which focusses something that's neither omnibox nor tab contents. This behavior is consistent with safari and camino, and I think it's the best we can do without rewriting event dispatching.
Camino does this here:
http://mxr.mozilla.org/seamonkey/source/camino/src/browser/BrowserWindow.mm#128
http://mxr.mozilla.org/seamonkey/source/camino/src/browser/BrowserWrapper.mm#1031
)
BUG=12557
TEST=Focus text box on a web page. cmd-left/right should go to start/end of text. Focus webpage background. cmd-left/right \
should go history back/forward. When the omnibox is focussed, cmd-left/right should move the caret, but cmd-1-9 should still switch tabs.
Note that shortcuts still don't work if a subwindow (e.g. find bar, bookmark bubble) has focus.
Review URL: http://codereview.chromium.org/251069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Change to avoid race condition over size of popup windows in Chrome OS
Review URL: http://codereview.chromium.org/261025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Replace pthreads with chrome platform thread in syncable unittest.
TEST=unit tests included
BUG=19895
Review URL: http://codereview.chromium.org/265033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/264020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Added x11 dependency to view_examples. Looks like dependency has changed a bit.
BUG=none
TEST=build & run view_examples target.
Review URL: http://codereview.chromium.org/270032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoids setting the width of the contents vbox (so it can grow if the
combined width of the two buttons exceeds the estimated width of the
bubble's text) and fixes an issue where we were getting even-more-bogus
estimates due to using an unrealized widget.
Also adds a DCHECK() to catch future code that passes unrealized
widgets to gtk_util::GetWidgetSizeFromResources() (I checked the
existing calls to it and they all look fine).
BUG=23367
TEST=tested first-run bubble on displays with various DPIs (75, 120, 200, etc.)
Review URL: http://codereview.chromium.org/265023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23475
TEST=none
Review URL: http://codereview.chromium.org/267032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It does get invoked both on the ui and io threads.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was using:
FilePath("/")
This only works on linux/mac because it is an ascii string and can't be
coerced to a wide string.
Reworked the code to put the hack into the string portion.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/270035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Fix so that we show ethernet icon if connected even if wifi is connected.
BUG=23923
TEST=none
Review URL: http://codereview.chromium.org/262031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gmail checker:
a) fix the name an description
b) add an icon to the install dialog
c) make the icons in the toolbar a little nicer
d) put a question mark in a grey badge when not logged in
e) get rid of the blinking
Test browser action
a) Make it continuously animate since that is really the point of
this sample.
Review URL: http://codereview.chromium.org/270037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/changeset/49153.
Note that we have filters disabled, so these are the results for failing this test.
Upstream also has failures checked in and we've rebased the other filters tests too.
Also removes a non-existant test (iframe.html) from test_expectations, so the linter will be happy (test was removed with last webkit roll).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/269027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/268024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=hclam
Review URL: http://codereview.chromium.org/262032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This got triggered on the linux valgrind bot:
http://build.chromium.org/buildbot/waterfall/builders/Linux%20Tests%20(valgrind)(2)/builds/527/steps/valgrind%20test%3A%20ui/logs/stdio
And for whatever reason is constructing a different signature for KillProcessTask::Run().
BUG=23018
Review URL: http://codereview.chromium.org/266033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that icons larger than 16px can be used in browser actions.
This is not that useful until we fix the inset issue in the browser action buttons though, so I will not be checking it in.
Review URL: http://codereview.chromium.org/271029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/266009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
confusing, and we can easily unhide them while we're working on the doc
by editing the top rule in this .css file.
TBR=rafaelw
Review URL: http://codereview.chromium.org/266032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/261028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
doesn't complain when we're part of the Chrome build.
Review URL: http://codereview.chromium.org/267025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resize requests from Firefox.
When the fullscreen stuff was redone (r26489), we removed a
WM_SIZE handler that would call the plugin's "Resize" API, and
moved it into NPP_SetWindow, but at the same time a SetWindowPos
call was also added that would take the window size as gospel and
set it, but only if we're not in fullscreen mode. Turns out that
this is not necessary because the Resize API already checks to
see if we're in full-screen mode, and handles the spurious zero
height messages properly too. So I just took out the explicit
SetWindowPos.
Review URL: http://codereview.chromium.org/268022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/265051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Enable or disable bookmark commands based on whether we're actually going to be able to bookmark anything.
* Rename IDC_STAR to IDC_BOOKMARK_PAGE, which is more obvious.
BUG=2935
TEST=Hit ctrl-shift-d, make sure it bookmarks all tabs
Review URL: http://codereview.chromium.org/266029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Expose support for webkit canaries
2. Add views for all slow tests, all tests missing SLOW in text_expectations,
and all tests with incorrect expectations.
3. Chunk the generation of the invidivudal tests view so that it actually works
without killing your machine when loading large numbers of tests.
4. Fix race condition in handleLocation where we'd try to generate the page
twice.
Review URL: http://codereview.chromium.org/267033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome Helper.
BUG=24219
TEST=none
Review URL: http://codereview.chromium.org/269018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
revision numbers be the same as the revisions called
for by the Chrome DEPS file at the same rev as chomium_rev.
Review URL: http://codereview.chromium.org/265049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=6217
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/257039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sparse IO methods require exclusive use of the cache entry
and they complain when that requirement is violated. When the
user cancels a request and reissues another one to the same entry,
we may be waiting for the previous operation to finish when we
receive a new IO request, so we fail.
This CL add a way for the HTTP cache to cancel IO operations and
get a notification when the disk cache is able to operate on that
entry again.
BUG=23862
TEST=unittests
Review URL: http://codereview.chromium.org/256090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28475 0039d316-1c4b-4281-b951-d872f2087c98
|