summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Make KeyboardAccessTest.ReserveKeyboardAccelerator not failisherman@chromium.org2010-10-043-4/+5
| | | | | | | | | BUG=50760 TEST=interactive_ui_tests --gtest_filter=KeyboardAccessTest.ReserveKeyboardAccelerator Review URL: http://codereview.chromium.org/3527007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61411 0039d316-1c4b-4281-b951-d872f2087c98
* Simple fix correcting the lifetime scope of automated url request jobs ↵twiz@google.com2010-10-041-19/+49
| | | | | | | | | | | | | | | during chrome-initiated xmlhttprequest aborts. Two similar problems are fixed by this CL. I found a race condition during the early-termination processing of the NpapiUrlRequest objects. If NpapiUrlRequest::Stop is invoked before NpapiUrlRequest::OnStreamCreated, then it is possible that a new stream will be created on the Chrome-Frame side, for which an operation that has been officially cancelled within Chrome. The fix is to add a new parameter fo the NPAPIUrlRequest, stop_requested_ that is used to track this behaviour. If a new stream is created on a request that has been stopped, then that stream is immediately destroyed, without notification back to Chrome. If Chrome requests an abort of a url request, then Chrome-Frame should not send any notifications back to Chrome concerning the tear-down of that request. The delegate is revoked in NPAPIUrlRequest::Stop to achieve this behaviour. BUG=None TEST=None Review URL: http://codereview.chromium.org/3530002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61410 0039d316-1c4b-4281-b951-d872f2087c98
* Add a method to the private API to search text using ICU.jam@chromium.org2010-10-042-0/+61
| | | | | | Review URL: http://codereview.chromium.org/3607004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61409 0039d316-1c4b-4281-b951-d872f2087c98
* [dom ui content settings] show geolocation exceptions in the tableestade@chromium.org2010-10-046-47/+195
| | | | | | | | | | | | | | | This works with the following caveat: the view does not update as the model does. The view does update the model (when pressing remove), but not vice versa (the view is only updated once, when it is first opened). This is actually also true of the native dialog version. To fix this I will need to add an observer interface to the Geolocation settings map similar to the one in HostContentSettingsMap. I didn't use the GeolocationExceptionsTableModel because it doesn't seem helpful in this case, although I did copy some code from it. If we move to dom ui completely on all platforms, we can delete that file completely and the relevant parts will have migrated into ContentSettingsHandler. The GeolocationExceptionsTableModel allows for sorting, but I don't know if we care to keep that functionality as the mocks don't cover it, and if so it should probably be pageside. content_settings_handler is getting more unwieldy and will continue to do so, which motivated me to refactor a little and in particular to add better (or rather, any) comments to the header. I may eventually want to factor out even more functionality as new, special content types get added (plugins, notifications, geolocation, etc? are all non-standard). BUG=57457 TEST=manual Review URL: http://codereview.chromium.org/3520012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61408 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill browsertestisherman@chromium.org2010-10-0417-305/+507
| | | | | | | | | BUG=none TEST=interactive_ui_tests --gtest_filter=AutofillTest.* Review URL: http://codereview.chromium.org/3492009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61407 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit DEPS 68995:69022hclam@chromium.org2010-10-041-1/+1
| | | | | | | | | | | TBR=tkent BUG=None TEST=None Review URL: http://codereview.chromium.org/3578010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61406 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Fix the sizing of input elements on the AutoFill edit address overlayjhawkins@chromium.org2010-10-042-41/+108
| | | | | | | | | | | for the case where the overlay is small. BUG=53609 TEST=none Review URL: http://codereview.chromium.org/3556011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61405 0039d316-1c4b-4281-b951-d872f2087c98
* Initial pass for proxy server error message change.mmenke@chromium.org2010-10-042-0/+69
| | | | | | | | | | | CL began its life under rdsmith (http://codereview.chromium.org/3548001/show). BUG=55728 TEST=Run chrome with invalid proxy server and examine navigation error message. Review URL: http://codereview.chromium.org/3521010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61403 0039d316-1c4b-4281-b951-d872f2087c98
* This is a monster CL.ajwong@chromium.org2010-10-0448-1267/+909
| | | | | | | | | | | | | | | | | | | | It started as an attempt to put the decoder onto another thread. However, this became complicated due to multiple object ownership transfers and coupling between the decode layer and the network layer; the decoder's states were highly coupled with how the network packets were processed. This could probably be broken up slightly, but at this point, it's easier to just commit as a whole The refactor includes: 1) Making the decoder interface unaware of "network packet" types. 2) Making the network layer process packets in order. 3) Threading through asynchronous APIs all over the place. 4) Simplifying the rectangle update protocol. 5) Cleaning up object lifetime and ownership semantics between the decode layer and the renderer. As of right now, the Verbatim format is still broken on the encode side because it uses the old protocol. BUG=52883, 57351 TEST=still connects to chromoting_simple_host Review URL: http://codereview.chromium.org/3305001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61402 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Update AppendDataToBody to take a data pointer and length ...viettrungluu@chromium.org2010-10-042-7/+3
| | | | | | | | | | | | | (... instead of a PP_Var). This allows binary data to be appended to POSTs. This rolls DEPS to pick up PPAPI r269. BUG=none TEST=Pepper URLLoader tests Review URL: http://codereview.chromium.org/3548009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61401 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a downloads pyauto test on mac (testSaveDangerousFile)nirnimesh@chromium.org2010-10-041-0/+1
| | | | | | | | | | BUG=57875 TEST= Review URL: http://codereview.chromium.org/3552007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61400 0039d316-1c4b-4281-b951-d872f2087c98
* Makes TemplateURL::supports_instant persisted to the webdb.sky@chromium.org2010-10-044-13/+160
| | | | | | | | | BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3560008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61399 0039d316-1c4b-4281-b951-d872f2087c98
* PPAPITest: disable a test that always times out.evan@chromium.org2010-10-041-1/+2
| | | | | | | | BUG=51345 Review URL: http://codereview.chromium.org/3617003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61398 0039d316-1c4b-4281-b951-d872f2087c98
* WorkerTest.WorkerWebSocketLayoutTests: disable, as it always times out.evan@chromium.org2010-10-041-2/+2
| | | | | | | | BUG=49381 Review URL: http://codereview.chromium.org/3617004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61397 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cryptohome dir when removing userdavemoore@chromium.org2010-10-041-0/+27
| | | | | | | | | | | BUG=chromium-os:5860 TEST=Remove user from home screen. Ensure that directory in /home/.shadow is also removed. Can also check if non-synced data no longer appears when same user is recreated. Downloads are an example of this. Review URL: http://codereview.chromium.org/3290023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61396 0039d316-1c4b-4281-b951-d872f2087c98
* Only run the phishing classifier for GET requests.bryner@chromium.org2010-10-044-4/+31
| | | | | | | | | BUG=none TEST=PhishingClassifierTest Review URL: http://codereview.chromium.org/3572008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61395 0039d316-1c4b-4281-b951-d872f2087c98
* OpenSSL socket: Add SSLv3 fallback supportjoth@chromium.org2010-10-041-1/+37
| | | | | | | | | BUG=None TEST=Open https://internet-banking.dbs.com.sg/ Review URL: http://codereview.chromium.org/3515009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61394 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up message_box_handler.h.xiyuan@chromium.org2010-10-041-48/+1
| | | | | | | | | BUG=none. TEST=All build bots should still be happy. Review URL: http://codereview.chromium.org/3619001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61393 0039d316-1c4b-4281-b951-d872f2087c98
* Add background webapps to about:labs.atwilson@chromium.org2010-10-042-0/+13
| | | | | | | | | BUG=57608 TEST=Existing background mode tests suffice Review URL: http://codereview.chromium.org/3541009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61392 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 543.0 to 544.0chrome-release@google.com2010-10-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61390 0039d316-1c4b-4281-b951-d872f2087c98
* Unminimize app section on app install.thakis@chromium.org2010-10-041-2/+6
| | | | | | | | | BUG=55148 TEST=Minimize apps section. Install an app. Apps section should no longer be minimized. Review URL: http://codereview.chromium.org/3555010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61388 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Fix sort order in the task maanger.estade@chromium.org2010-10-041-2/+2
| | | | | | | | | | | | | | | | | | | | | | | In Linux, the sort ordering in the task manager is incorrect, as in when you click on a column header to sort the values the first time, it shows a triangle with the pointy head downwards, i.e. it should show the values from larger to smaller. But currently, the values are shown smaller to larger. So this small patch is a fix for that. This is also consistent with the behaviour on Windows. Also, this makes more sense. When a user is sorting, for example, the memory or the cpu column, it is more likely he is interested on the pages that are taking the most memory/cpu, so they should be at the top for the first sort. BUG=none TEST=after opening multiple tabs, bring up the task manager, then click on the memory column header. It should show the page using the most memory on top. patch by Sadrul Chowdhury <sadrul [at] chromium [dot] org> original review: http://codereview.chromium.org/3590009 Review URL: http://codereview.chromium.org/3615006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61387 0039d316-1c4b-4281-b951-d872f2087c98
* DownloadTest: disable just the tests that are timing out.evan@chromium.org2010-10-041-6/+6
| | | | | | | | | | | Many of the tests are failing, but these are taking 40 seconds to fail. BUG=existing bugs that these tests are failing Review URL: http://codereview.chromium.org/3533009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61385 0039d316-1c4b-4281-b951-d872f2087c98
* don't use pretty error page for packaged appserikkay@chromium.org2010-10-041-1/+1
| | | | | | | | | BUG=56589 TEST=go to a non-existent page in a packaged app. standard built-in 404 should show rather than the new pretty page. Review URL: http://codereview.chromium.org/3524003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61384 0039d316-1c4b-4281-b951-d872f2087c98
* clang/mac: Fix build.thakis@chromium.org2010-10-041-2/+2
| | | | | | | | | | Also return one value per reference. BUG=None TEST=None TBR=finnur git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61383 0039d316-1c4b-4281-b951-d872f2087c98
* Logs a number of possible ssl failures in NetLog.mmenke@chromium.org2010-10-042-30/+149
| | | | | | | | | BUG=47347 TEST=manual Review URL: http://codereview.chromium.org/3584003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61378 0039d316-1c4b-4281-b951-d872f2087c98
* Move the remoting gtest filter to the proper place.glider@chromium.org2010-10-041-0/+0
| | | | | | | BUG=57832 Review URL: http://codereview.chromium.org/3534009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61377 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of warnings.mbelshe@chromium.org2010-10-042-3/+3
| | | | | | | | | | | This patch on behalf of Jon Leighton (leighton@cis.udel.edu) BUG=none TEST=none Review URL: http://codereview.chromium.org/3550005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61376 0039d316-1c4b-4281-b951-d872f2087c98
* Added more logging and marked a test as FLAKY_.satish@chromium.org2010-10-042-1/+8
| | | | | | | | | | | This test times out regularly in the vista build bots and infrequently in others. I'm add some logs earlier and making progress, so adding more logs to narrow down the issue. BUG=51337 TEST=waterfall doesn't go read due to this test. TBR=bulach git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61375 0039d316-1c4b-4281-b951-d872f2087c98
* Less drama. Flaky PMs.thakis@chromium.org2010-10-041-1/+1
| | | | | | TBR=phajdan.jr git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61373 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the FLAKY mark from RepostFormWarningTest.TestLoginAfterRepostphajdan.jr@chromium.org2010-10-041-2/+2
| | | | | | | | | | | | | | | on Linux. There is some other Windows-specific (?) flake, http://crbug.com/47228 TBR=bauerb BUG=56401 TEST=none Review URL: http://codereview.chromium.org/3574007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61372 0039d316-1c4b-4281-b951-d872f2087c98
* implement certificate verification state machinejoth@chromium.org2010-10-042-35/+144
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3571011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61370 0039d316-1c4b-4281-b951-d872f2087c98
* Add more drama to the about:labs warning text.thakis@chromium.org2010-10-041-1/+1
| | | | | | | | | | | Requested by jeffrecy. BUG=None TEST=Go to about:labs, read text. Should've made you roll your eyes. Review URL: http://codereview.chromium.org/3521009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61369 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error.finnur@chromium.org2010-10-041-13/+0
| | | | | | | | | | TBR=thakis BUG=None TEST=None Review URL: http://codereview.chromium.org/3606007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61368 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the traces, as I believe I have found the cause for the failure.finnur@chromium.org2010-10-046-32/+1
| | | | | | | | | | TBR=aa BUG=None TEST=None Review URL: http://codereview.chromium.org/3534008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61367 0039d316-1c4b-4281-b951-d872f2087c98
* Disable JingleChromotingConnectionTest tests that are failing under TSan onglider@chromium.org2010-10-041-0/+5
| | | | | | | | | | | Win. BUG=57832 TBR=timurrrr Review URL: http://codereview.chromium.org/3534007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61366 0039d316-1c4b-4281-b951-d872f2087c98
* LoginPromptTest's are no longer flaky.cbentzel@chromium.org2010-10-041-42/+37
| | | | | | | | | | | Also, explicitly test NavigateToURL's return value instead of treating it like a boolean. BUG=56670 TEST=ui_tests --gtest_filter="*LoginPromptTest*" Review URL: http://codereview.chromium.org/3618001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61365 0039d316-1c4b-4281-b951-d872f2087c98
* Add one more trace.finnur@chromium.org2010-10-041-0/+7
| | | | | | | | | | | | I think I'm getting close to figuring out why the test fails only on the bots. TBR=aa BUG=None TEST=None Review URL: http://codereview.chromium.org/3578009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61364 0039d316-1c4b-4281-b951-d872f2087c98
* Remove spammy warning about reaching maximum socket count for the pool.cbentzel@chromium.org2010-10-041-1/+0
| | | | | | | | | | | | | When I run Chrome through a proxy, this WARNING log triggers very frequently. Typically immediately after it's called, CloseOneIdleSocket() is invoked and a connect job is still allowed to proceed. If this WARNING was useful in the past, I will add it to the call sites at appropriate places (such as when there are no idle sockets for the pool and a request must be queued) rather than inside ReachedMaxSocketsLimit(). BUG=None TEST=None Review URL: http://codereview.chromium.org/3526013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61363 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of warning.finnur@chromium.org2010-10-041-1/+1
| | | | | | | | | | BUG=None TEST=None TBR=aa Review URL: http://codereview.chromium.org/3533012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61362 0039d316-1c4b-4281-b951-d872f2087c98
* Adding tests for the AllUrls Extension feature.finnur@chromium.org2010-10-044-0/+137
| | | | | | | | | | | | | | | | These tests were already LGed here... http://codereview.chromium.org/3440027 ... but once checked in they failed on the build bots (despite working locally). I have added some temporary tracing to try to track down the cause. Will remove, after a run on the bots. TBR=aa BUG=36275 TEST=AllUrlsApiTest (two new) Review URL: http://codereview.chromium.org/3598007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61361 0039d316-1c4b-4281-b951-d872f2087c98
* Avoids double menu offset usage.altimofeev@chromium.org2010-10-043-26/+8
| | | | | | | | | | | | | | Menu position offset was implemented for menu button and language menu. So 2 magic number were used to position the menu. This CL removes offset handling from the language menu class, since this is not common for menu. BUG=none TEST=none Review URL: http://codereview.chromium.org/3610005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61360 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt2: Component extensions (and whitelisted extensions) specifying ↵finnur@chromium.org2010-10-0427-124/+425
| | | | | | | | | | | | | | | <all_urls> in their Extension match pattern should be allowed to run content scripts everywhere (including chrome://, chrome-extension://, about: and gallery pages. The intent was to also allow these extensions to specify more granular permissions, such as about:version instead of <all_urls>, but that didn't make the cut this time. This CL also enables <all_urls> for host permissions for regular extensions, which was disabled before. Note: That still doesn't give them permission to script the gallery and chrome:// pages, etc. BUG=36275 TEST=Working on it right now. Review URL: http://codereview.chromium.org/3585009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61359 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Get rid of the test server's /kill switchphajdan.jr@chromium.org2010-10-042-112/+0
| | | | | | | | | | | | | This also allows us to remove a quite complicated test. The lifetime of the test server is now fully controlled by its c++ launcher. BUG=49680 TEST=none Review URL: http://codereview.chromium.org/3479018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61358 0039d316-1c4b-4281-b951-d872f2087c98
* Renamed the suppression for bug 57799 into bug 57800 (leak atglider@chromium.org2010-10-042-0/+25
| | | | | | | | | | | | TabContents::AddSavePasswordInfoBar) Suppressed bug 57799 (leak at cricket::Transport::OnRemoteCandidate) on Valgrind and Heapcheck bots. TBR=timurrrr BUG=57799,57800 Review URL: http://codereview.chromium.org/3621002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61357 0039d316-1c4b-4281-b951-d872f2087c98
* Added more log messages to help track down an infrequent timeout in the test.satish@chromium.org2010-10-041-0/+4
| | | | | | | | | | The test which times out can be seen at http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=SpeechInputBrowserTest.TestBasicRecognition&testType=browser_tests BUG=none TEST=none, since we are just adding more logging. TBR=bulach git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61356 0039d316-1c4b-4281-b951-d872f2087c98
* Verify server cert using default host CA cert storejoth@chromium.org2010-10-042-8/+50
| | | | | | | | | BUG=none TEST=build with use_openssl=1 and open some https pages Review URL: http://codereview.chromium.org/3518004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61355 0039d316-1c4b-4281-b951-d872f2087c98
* Update v8 to version 2.4.8.ricow@chromium.org2010-10-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3581011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61354 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress bug 57799 (leak at cricket::Transport::OnRemoteCandidate)glider@chromium.org2010-10-041-0/+15
| | | | | | | | | BUG=57799 TBR=sergeyu Review URL: http://codereview.chromium.org/3599012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61353 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed an incorrectly removed frame-level wildcard for bug 57692 (Tsan failureglider@chromium.org2010-10-041-0/+1
| | | | | | | | | | | in remoting::TCPChannelTester::CheckResults()) TBR=rsesek BUG=57692 Review URL: http://codereview.chromium.org/3613006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61352 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 06:06:40 +0000