| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2086022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
same windowId.
For some reason (on windows, at least) BrowserList::SetLastActive seems to get called for every click in the content area of a window.
This ensures that ExtensionBrowserEventRouter only fires once when the focus changes.
BUG=39882
TEST=none
Review URL: http://codereview.chromium.org/2076013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resolution.
This reverts the histogram collection part of http://codereview.chromium.org/1605005.
BUG=21909
TEST=none
Review URL: http://codereview.chromium.org/2082016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=wrapper-map-gc.html leaks a WorkerProcessHost which this cleanup logic takes care of
Review URL: http://codereview.chromium.org/2063015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44485
TEST=tools/valgrind/chrome_tests.sh --tool=tsan -t test_shell --gtest_filter='AppCacheStorage*'
Review URL: http://codereview.chromium.org/2109012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* command id now has to be positive.
BUG=none
TEST=manual: clicking options menu on notification shows menu instead of crashing
Review URL: http://codereview.chromium.org/2066017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
2. first step to merge omx_decoder_engine/omx_codec by making omx_decoder_engine as simple as possible. Disable omx_codec_unittests during this process.
Review URL: http://codereview.chromium.org/2117020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This appears to resolve the regression that might have
been instigated in 44435.
This was very significant on Windows, as the derived
class held a lot of data in file_version_info_win.cc.
BUG=44320
r=mbelshe
Review URL: http://codereview.chromium.org/2131023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
actions/content settings, so we won't take as much space for users with a lot of these.
BUG=42856
TEST=Elided EV bubble should take less space when there are lots of icons in the omnibox.
Review URL: http://codereview.chromium.org/2073019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2113020
TBR=zhurunz@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromeium-os:3232
TEST=LoginProfileTest.UserNotPassed
Review URL: http://codereview.chromium.org/2094018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
appears that the crash occurs because we attempt to
unregister focus manager accelerators registered by the external tab container twice as the Uninitialize function gets invoked
twice in WM_DESTROY and in the destructor.
Fix is to set the focus_manager_ pointer to NULL after unregistering the accelerators.
Bug=42365
Review URL: http://codereview.chromium.org/2069015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
exception barrier version which only reports crashes
in ChromeFrame while calling the original function. We also use the other version of the ExceptionBarrier when we switch the mime
type from text/html. This is to prevent the vectored exception handler from handling this exception and reporting a false positive
if any stack based exception handler actually handles this exception.
The other change is to remove the IHttpNegotiate::OnResponse patch as it did not do anything useful and some crashes were being reported
while invoking the original function.
Fixes bugs http://code.google.com/p/chromium/issues/detail?id=44767 and http://code.google.com/p/chromium/issues/detail?id=44765
Bug=44767,44765
Review URL: http://codereview.chromium.org/2078030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and any OS errors that attempts failed with (windows implementation)
Note that this change is the same as r47764, but for the windows implementation.
BUG=44488
Review URL: http://codereview.chromium.org/2127011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2113020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Adding a way to generate custom WebURLLoader (so unit-tests can mock resource loading).
BUG=None
TEST=DumpRenderTree should work.
Review URL: http://codereview.chromium.org/2094017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Set to GTK+ theme and then try to change the system theme 4 times to 4 different themes. It shouldn't crash on the 2nd, 3rd or 4th time.
Review URL: http://codereview.chromium.org/2070020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=victorw
TEST=canaries and try servers
BUG=44792
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
file. Used this to save and read the cloud print proxy auth token and proxy id.
BUG=None.
TEST=Test Cloud Print Proxy (run it second time without LSID and ProxyId command-line args)
Review URL: http://codereview.chromium.org/2066018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This allows Chromium to build against libvpx as provided by the system.
Patch based on one from fta.
http://codereview.chromium.org/2075023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrap title with correctly bidi control characters in windows for display purpose.
BUG=43485
TEST=1. open RTL chrome.
2. install Google dictionary extension.
3. extension title "Google Dictionary (by Google)" should be displayed as is in chrome://extensions page,
4. right click the extension icon, title "Google Dictionary (by Google)" should be displayed in extension context menu,
5. extension title should be displayed correctly in other places, such as task manager, etc.
Review URL: http://codereview.chromium.org/2015004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
interface of the http/disk cache.
BUG=26729
TEST=none
Review URL: http://codereview.chromium.org/2063017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on willchan's patch here: http://codereview.chromium.org/2109009/show
BUG=40149
TEST=none
TBR=willchan
Review URL: http://codereview.chromium.org/2137010
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/2107016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before it would only try the next address in the list, for specific OS errors.
Also did a slight refactoring to use a state machine for Connect().
(This is the same patch as r47728, but for windows implementation).
BUG=44490
Review URL: http://codereview.chromium.org/2099010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Actually use our timeout code for running the unit tests (more
reliable killing of children), and make the timeout smaller.
Review URL: http://codereview.chromium.org/2084016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
really long.
This only counts the non-icon area of the location bar. Unlike the windows
implementation, the minimum size of the EV bubble is 10 characters instead of
150px.
BUG=42856
TEST=Visit https://www.barbican.org.uk/eticketing/index.asp and make the window smaller.
Review URL: http://codereview.chromium.org/2123015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically:
* Added assertions in most private methods of CookieMonster that the instance lock is held.
* Refactored locking out of FindCookiesForHostAndDomain and into
DeleteCookie(url,cookie_name) and GetCookiesWithOptions (its callers)
to protect DeleteCookie's call to InternalDeleteCookie.
* Protected SetCookieableSchemes() (public method that modifies
internal state directly).
* Shifted calls to HasCookieableScheme() around so that they were protected by the instance lock.
BUG=43188
TEST=Windows net_unittests ParsedCookieTest.*:CookieMonsterTest.* (Inserted assertions, confirmed crash in CookieMonsterTest.DeleteCookieByName, refactored, confirmed no failure). Windows net_perftests ParsedCookieTest.*:CookieMonsterTest.* run before and after change; noted minimal (but non-zero) performance degradation.
Review URL: http://codereview.chromium.org/2131002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
command line.
BUG=none
TEST=Go to about:net-internals click on dump to text, check if version and command line are good.
Patch contributed by malavv
Review URL: http://codereview.chromium.org/2104012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/1627007 /
http://codereview.chromium.org/1527030 . Ensure the renderer is
initialized before attempting to use it. Only enable new code path if
actually uploading textures via IMC.
Tested in Safari 4 on Mac OS X 10.6.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2103014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
user. This will be used to determine if the tab should be restored on
startup or not.
BUG=4923
TEST=none
Review URL: http://codereview.chromium.org/2087012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser and then converted to MSAA roles - this is both because the
logic needs to be more complicated, and so we can support Mac accessibility,
too. 2. The serializable object used to pass accessibility info from the
renderer to the browser now uses a map for uncommon attributes, rather than
having a bunch of fields that are almost always empty. 3. Handles the
accSelect method with TAKE_FOCUS, allowing assistive technology to set focus
to a particular control. 4. Implements several other IAccessible2 interfaces.
BUG=25564
BUG=13291
TEST=None
Review URL: http://codereview.chromium.org/2121004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixing download case, adding new method to download manager to support chromeos downloads.
Original Review: http://codereview.chromium.org/2109011
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2112012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable XML output for children
Output XML file with failed, disabled and timing information in the
parent launcher process.
BUG=40473,42781
TEST=run the browser_tests (or other tests that uses outofproctest runner) with 1) gtest_output=xml 2) gtest_output=xml:test.xml 3) gtest_output=xml:/tmp/ and see if the output XML file (test_detail.xml for 1), test.xml for 2), /tmp/browser_tests.xml for 3)) contains correct information.
Review URL: http://codereview.chromium.org/2071001
TBR=kinuko@chromium.org
Review URL: http://codereview.chromium.org/2119016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=skrul,phajdan.jr
Review URL: http://codereview.chromium.org/2109013
TBR=kinuko@chromium.org
Review URL: http://codereview.chromium.org/2079017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=skrul,phajdan.jr
Review URL: http://codereview.chromium.org/2109013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Disable XML output for children
- Output XML file with failed, disabled and timing information in the
parent launcher process.
BUG=40473,42781
TEST=run the browser_tests (or other tests that uses out-of-proc-test runner) with 1) --gtest_output=xml 2) --gtest_output=xml:test.xml 3) --gtest_output=xml:/tmp/ and see if the output XML file (test_detail.xml for 1), test.xml for 2), /tmp/browser_tests.xml for 3)) contains correct information.
Review URL: http://codereview.chromium.org/2071001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
JsonPrefStore and PrefStore to chrome/common. This is because JsonPrefStore is needed in the service process
BUG=None.
TEST=Updated unit-tests
Review URL: http://codereview.chromium.org/2066015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
timeout.
BUG=43440
TEST=ExtensionApiTest.Tab*
Review URL: http://codereview.chromium.org/2072007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome UI blinks after replacement of gtk_widget_set_size_request with
gtk_widget_size_allocate on resizing or infobar appearing animation.
It happens because gtk_widget_size_allocate results in background resizing
on message loop idle. It looks like we can't use gtk_widget_size_allocate at
this place at all.
Review URL: http://codereview.chromium.org/2131021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42640
TEST=--gtest_filter=WinConfigurationPolicyProviderTest*
Review URL: http://codereview.chromium.org/2119005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running tcmalloc under Valgrind.
Review URL: http://codereview.chromium.org/1735024
TBR=willchan,antonm
Review URL: http://codereview.chromium.org/2138002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
That entry is at index=0.
BUG=cros:3361
TEST=Select secure network and cancel dialog. Select first entry at network combobox. It should not crash.
Review URL: http://codereview.chromium.org/2074020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The Chromium side of https://bugs.webkit.org/show_bug.cgi?id=39216 which (among other things) switches WebCore/WebKit to use SecurityOrigin/WebSecurityOrigins. I'm also switching it to use databaseIdentifiers (rather than just toString) since its semantics match HTML5's origins (and toStrings do not).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2097005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change is just for catching up with your SpdyFramer change (r47886).
TBR=mbelshe
BUG=30667
TEST=make the "Linux Tests (valgrind)(3)" bot green.
Review URL: http://codereview.chromium.org/2078027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/2068006 for details.
BUG=none
TEST=none
TBR=jcivelli@chromium.org, sky@chromium.org
Review URL: http://codereview.chromium.org/2135010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added DIRECT_INPUT for ibus-mozc.
- Removed ROMAN and KANA since they're for ibus-anthy.
BUG=chromium-os:3452
TEST=Checked ../chrome_log manually.
Review URL: http://codereview.chromium.org/2110018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47901 0039d316-1c4b-4281-b951-d872f2087c98
|