| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
If a ConnectingSocket fails, we need to try to process a pending request.
BUG=http://crbug.com/14814
TEST=See bug for repro steps.
Review URL: http://codereview.chromium.org/146037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pure_call crash.
TEST=reliability test passes
BUG=NONE
Review URL: http://codereview.chromium.org/146051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/144006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly these are fixes to warnings (signed/unsigned mismatches
were the most common), and some changes to include paths.
I've updated the build.scons files and DEPS file to match these
changes so that the scons build will still function with these
changes.
Review URL: http://codereview.chromium.org/146047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crbug.com/14941
TEST=install an extension, verify that only one toolbar is visible
Review URL: http://codereview.chromium.org/147026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
thrown in worker context. This is one of two patches needed for the fix. The other patch is https://bugs.webkit.org/show_bug.cgi?id=26626.
BUG=14753
TEST=WebKit layout tests should cover this.
Review URL: http://codereview.chromium.org/144008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=14669
TEST=navigate to a webpage that takes a while to load (I used yahoo.com). As soon as you press enter in the url box, right click in the render view (so that the context menu is popped up for your current page rather than yahoo). After yahoo is loaded, dismiss the context menu. No crash.
Review URL: http://codereview.chromium.org/146011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I am not sure why we had split install.h functions into setup.cc and install.cc.
I think we only need install.{h|cc} just like we have uninstall.{h|cc}.
BUG=12849
Review URL: http://codereview.chromium.org/147016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/fast/dynamic/window-resize-scrollbars-test.html
LayoutTests/fast/dynamic/window-scrollbars-test.html
BUG=12753
Patch by Min-Yu Huang <minyu.huang@gmail.com> via
http://codereview.chromium.org/147003
Review URL: http://codereview.chromium.org/146048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with the Equals method.
R=eroman
BUG=http://crbug.com/318
TEST=none
Review URL: http://codereview.chromium.org/146040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Renamed CoreCommand -> EditCommand
Renamed the ViewMsg_HandleExecuteEditCommand IPC message to ViewMsg_ExecuteEditCommand
Review URL: http://codereview.chromium.org/147034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=nsylvain
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/132074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/13228
Review URL: http://codereview.chromium.org/147023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open the browser with --lang=he and make sure the tabs are ordered starting from the right. Also, the UI elements in the tabs should be reversed as well.
Review URL: http://codereview.chromium.org/147020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Google Chrome build.
Note that the inclusion of this value is contingent upon the user having opted to send up anonymous usage information.
BUG=b/1484308
TEST=Verify uninstall survey URL contains &client=<client-string>
Review URL: http://codereview.chromium.org/146014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=15046
TEST=unit_tests --gtest_filter=IPCSyncChannelTest.NoHang
should complete and not be taken down by SIGPIPE; when EPIPE occurs,
a harmless "broken pipe" message should be logged.
Review URL: http://codereview.chromium.org/147019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
setup to finish fast.
- Added new cmd line flag to setup.exe: --inactive-user-toast
BUG= b/1484308
TEST = see the bug
Review URL: http://codereview.chromium.org/144015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/141037 .
BUG=http://crbug.com/14020
TEST=none
Review URL: http://codereview.chromium.org/146003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crash when running LayoutTests/security/block-test.html.
TBR=jshin
BUG=http://crbug.com/4965
TEST=none
Review URL: http://codereview.chromium.org/147036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The unit test file has become very unwieldy, and I no longer believe that the
Keychain mock is temporary code that should be replaced with GMock (since the
dummy implementation makes certain tests much easier).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base path.
This make it possible to actually build all.sln!
BUG=None
TEST=None
TBR=gspencer
Review URL: http://codereview.chromium.org/147030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tests to the build bot.
BUG=None
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/146042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
order to be able to run browser tests on the main build bots).
BUG=None
TEST=Run the SSL browser tests
Review URL: http://codereview.chromium.org/146039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Note: the new FTP is still work in progress.
R=dank
BUG=http://crbug.com/4965
TEST=none
Review URL: http://codereview.chromium.org/119342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/147031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Crash reporting broke on Linux when we enabled the zygote model a
couple of weeks ago.
We can't just add "zygote" to the check for the process type because
the crash signal fd is set at the same time and that will change when
a renderer is forked from the zygote.
This fixes it for now, but it will need to be redone when we enable
sandboxing.
http://codereview.chromium.org/147004
BUG=14969
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
implementationof the privacy blacklist. The --privacy-blacklist option was addedwhich will eventually is used to activate the code.This is work-in-progress code which effectively makes a couple morepointer-checks when the --privacy-blacklist is not specified. Whenit is specified, some of the blacklist code is executed but theblacklist is always empty and therefore has no impact on browsing.
BUG=none
TEST=Blacklist*
Review URL: http://codereview.chromium.org/119313
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fixed at 500 units which caused the margins to be huge for low DPI (low quality) printing output.
BUG=http://crbug.com/14502
TEST=Print with different DPI settings and notice how the margins stay the same physical width.
Review URL: http://codereview.chromium.org/145008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/147024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix the alert when no printer is installed.
BUG=http://crbug.com/6833
TEST=Print to a printer that fails to print (e.g. MS XPS printer and cancel save). Try to print when no printer is installed.
Review URL: http://codereview.chromium.org/141060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=eroman
BUG=http://crbug.com/318
TEST=none
Review URL: http://codereview.chromium.org/140034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds an UpdateExtension method to ExtensionsService along with a completion
callback for when the install is complete (or failed).
BUG=http://crbug.com/12117
BUG=http://crbug.com/12764
TEST=none
Review URL: http://codereview.chromium.org/140022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
need, and modify MockKeychain slightly to allow unit testing it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
correct fix is).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/145023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Run browser_tests.exe from the command line from a directory that is not the directory containing it.
Review URL: http://codereview.chromium.org/146018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/141008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=davemoore
BUG=none
TEST=build works
Review URL: http://codereview.chromium.org/146033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11650
TEST=none
Review URL: http://codereview.chromium.org/140010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Cannot reproduce locally but fails consistently on the mac buildbot in debug mode.
TBR=kasperl@chromium.org
Review URL: http://codereview.chromium.org/148001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
ScopeChainPropertiesSection is refactored to support scope resolution
Review URL: http://codereview.chromium.org/147012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=evan
BUG=10953 "IME support"
BUG=11226 "Dead keys and accents input not working"
BUG=13604 "Hotkeys not working in non-us keyboard layout"
TEST=none
Review URL: http://codereview.chromium.org/147010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/146023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This version contains a couple of regular expression bugfixes as well
as a string analysis bug fix. Also, there are a number of general
performance improvements.
Review URL: http://codereview.chromium.org/147009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
saving/retrieving/adjusting window positions.
TEST=Open Chrome windows and see if they are placed properly.
TESTED=gcl try, manually
BUG=none
Review URL: http://codereview.chromium.org/141039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If LOAD_VERIFY_EV_CERT is requested on load_flags
and revokation checking is performed, Verify() peforms
EV certificate verification as well, and sets
CERT_STATUS_IS_EV in verify_result.
Eliminate X509Certificate::IsEV()
BUG=3592
TEST=net_unittests with ALLOW_EXTERNAL_ACCESS=1, \
visit https://www.thawte.com/ and shows EV info.
Review URL: http://codereview.chromium.org/125120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions.enable pref was not being honored. Add tests.
This is intended to be submitted after:
http://codereview.chromium.org/132003
BUG=13467
TEST=Added unit tests
Review URL: http://codereview.chromium.org/132045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19010 0039d316-1c4b-4281-b951-d872f2087c98
|