summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fixes bug in file browser.sky@chromium.org2009-11-122-2/+2
| | | | | | | | TBR=dhg BUG=none Review URL: http://codereview.chromium.org/385081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31858 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31839 - Notifications permission infobar should only be shown in ↵scherkus@chromium.org2009-11-126-102/+7
| | | | | | | | | | | | | | | | response to a user gesture, not arbitrary script. Includes UI test which verify the infobar is shown from a gesture, and not shown from raw script. BUG=27215 TEST=included Review URL: http://codereview.chromium.org/387011 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/385080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31857 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31814 - Testing to see if it caused performance problems.dmaclach@chromium.org2009-11-122-71/+3
| | | | | | | | | | | | | | | | | | | | Add support for observing tracking areas so that when tabs are moved underneath our cursor, we highlight them correctly. BUG=27458, 13208, 21448 TEST=Create a pile of tabs. Select a middle one. Put your cursor in some other tab. Hit cmdw a couple of times Watch to make sure highlights occur correctly in both the tabs and the close buttons. Review URL: http://codereview.chromium.org/386021 TBR=dmaclach@chromium.org Review URL: http://codereview.chromium.org/384100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31856 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup new expectations from my time gardening. Rebaseline 2 tests.japhet@chromium.org2009-11-126-81/+26
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/387040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31855 0039d316-1c4b-4281-b951-d872f2087c98
* Moved all gpu plugin and command buffer tests into a single executable prior ↵apatrick@google.com2009-11-125-52/+70
| | | | | | | | to move to Chrome tree. Review URL: http://codereview.chromium.org/392017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31854 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly schedule empty parent directories for deletion when Chrome Frame ↵robertshield@chromium.org2009-11-123-6/+38
| | | | | | | | | | | is uninstalled while in use. BUG=27483,23999 TEST=Uninstall Chrome Frame while it is in use. Verify that all Chrome Frame folders are removed. Review URL: http://codereview.chromium.org/392013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31853 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in ChromeActiveDocument::IEExec() when m_spClientSite is null.robertshield@chromium.org2009-11-121-1/+1
| | | | | | | | | | BUG=27414 TEST=None Review URL: http://codereview.chromium.org/384094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31852 0039d316-1c4b-4281-b951-d872f2087c98
* Mark redirect-cross-origin-tripmine.html as timing out.scherkus@chromium.org2009-11-121-0/+3
| | | | | | | | | | | | | Partial revert of http://codereview.chromium.org/387034 BUG=none TEST=none TBR=dpranke Review URL: http://codereview.chromium.org/391038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31851 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in treeview. The code for removing a node was notsky@chromium.org2009-11-121-2/+3
| | | | | | | | | | | | | | correctly updating internal data structures, which could lead to a future crash. When recursively deleting items we need to get the next item before removing from the tree, otherwise the tree returns null. BUG=27290 TEST=make sure no problems in using bookmark manager, especially when adding/removing urls/folders. Review URL: http://codereview.chromium.org/384092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31850 0039d316-1c4b-4281-b951-d872f2087c98
* Add python script that generates gmock_mutant.hstoyan@chromium.org2009-11-122-306/+1539
| | | | | | | | | | | Resolve ambiguity - error C2782 in VisualC or "no matching function to call" in gcc - when attempt to create functor for base class member function. Support for free (non class members) functions. BUG=none TEST=none Review URL: http://codereview.chromium.org/371046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31848 0039d316-1c4b-4281-b951-d872f2087c98
* Potential fix for duplicate crash reports on Windows.kuchhal@chromium.org2009-11-121-11/+19
| | | | | | | | | BUG=24638 TEST=Not sure how the duplicate crash reports were getting generated so can not test that but made sure that the crash reporting works fine. Review URL: http://codereview.chromium.org/385030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31847 0039d316-1c4b-4281-b951-d872f2087c98
* After draining the body of a 401/407 response, verify thatwtc@chromium.org2009-11-124-11/+127
| | | | | | | | | | | | | | | | | the keep-alive connection is still connected and idle before reusing it for authentication restart. An impatient server may have closed the connection while waiting for the user to enter the username and password. In socket_test_util.cc, return the mock ERR_UNEXPECTED error synchronously. R=eroman BUG=21675 TEST=new unit test Review URL: http://codereview.chromium.org/389007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31846 0039d316-1c4b-4281-b951-d872f2087c98
* Always call NPP_SetWindow, even for 0x0 plugins, on the Macstuartmorgan@chromium.org2009-11-121-3/+0
| | | | | | | | | | | QuickTime can be embedded for audio, with a 0x0 plugin, but it still expects to get information about the window via SetWindow. Windows in fact made this same fix a while ago, for the same reason, but in the Windowed version of this method. BUG=25883 TEST=Open a site like the one in the bug with a 0x0 QuickTime plugin; the plugin should not crash. Review URL: http://codereview.chromium.org/389026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31845 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in ExtensionMessageService when a source renderer closed.mpcomplete@chromium.org2009-11-121-0/+6
| | | | | | | | BUG=27554 Review URL: http://codereview.chromium.org/384097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31844 0039d316-1c4b-4281-b951-d872f2087c98
* minor edits to autoupdate, hosting docskathyw@google.com2009-11-124-18/+14
| | | | | | | | | TEST=none BUG=none TBR=aa Review URL: http://codereview.chromium.org/387041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31843 0039d316-1c4b-4281-b951-d872f2087c98
* Improve text on management UI. Still waiting for a treatmentaa@chromium.org2009-11-125-3/+33
| | | | | | | | | from the design team, but I wanted to at least get the words in before the string freeze. Review URL: http://codereview.chromium.org/385075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31842 0039d316-1c4b-4281-b951-d872f2087c98
* Created o3djs Plane and Translate2 classes.simonrad@chromium.org2009-11-122-91/+731
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/382001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31841 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in BrowserActionButton::OnImageLoaded.mpcomplete@chromium.org2009-11-121-0/+4
| | | | | | | | BUG=27167 Review URL: http://codereview.chromium.org/385072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31840 0039d316-1c4b-4281-b951-d872f2087c98
* Notifications permission infobar should only be shown in response to a user ↵johnnyg@chromium.org2009-11-126-7/+102
| | | | | | | | | | | | | gesture, not arbitrary script. Includes UI test which verify the infobar is shown from a gesture, and not shown from raw script. BUG=27215 TEST=included Review URL: http://codereview.chromium.org/387011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31839 0039d316-1c4b-4281-b951-d872f2087c98
* Minor copyedits.kathyw@google.com2009-11-1212-55/+490
| | | | | | | | | | BUG=none TEST=none TBR=aa Review URL: http://codereview.chromium.org/385077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31838 0039d316-1c4b-4281-b951-d872f2087c98
* Add a simple perf extension that times messaging roundtrips between contentmpcomplete@chromium.org2009-11-124-0/+94
| | | | | | | | | | scripts and extensions. BUG=no Review URL: http://codereview.chromium.org/384093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31837 0039d316-1c4b-4281-b951-d872f2087c98
* Render Extension Docs.rafaelw@chromium.org2009-11-126-330/+278
| | | | | | | | | | (No code changes). Includes rendered extension docs that should have been included with r31834. TBR=aa Review URL: http://codereview.chromium.org/384096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31836 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where crossing events (mouse enter, mouse leave) were being sentestade@chromium.org2009-11-121-2/+16
| | | | | | | | | | | | | | | | when the mouse button is down, causing duplicate events that caused serious problems with drag and drop of selections in gmail, plus other problems. The crossing events should still be sent when the mouse button is not down. BUG=27264 TEST=confirmed that gmail bug is no longer reproducible; trybot succeeded patch by Dominic Mazzoni <dmazzoni at goog> original review: http://codereview.chromium.org/387038 Review URL: http://codereview.chromium.org/389024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31835 0039d316-1c4b-4281-b951-d872f2087c98
* JsonSchema support for declaring "object" constructors.rafaelw@chromium.org2009-11-129-81/+169
| | | | | | | | | | | | | | | | | This adds support for an optional declaration of "isInstanceOf" on "type":"object". If present, the candidate object will be tested for js:instanceof window[schema.isInstanceOf]. Several api functions are modified to take advantage of declaring their "class". Also, support added to docs for modules, methods & events to declare "nodocs":"true" to be excluded from the docs. Also, check to warn on an attempt to use cygwin python to generate docs. BUG=27213 TEST=NONE Review URL: http://codereview.chromium.org/389005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31834 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix leaking NativeImageSkia in webkit_glue::DecodeImage.mattm@chromium.org2009-11-123-13/+57
| | | | | | | | | | CID=5406 BUG=none TEST=tools/valgrind/chrome_tests.sh -t test_shell --gtest_filter=WebkitGlueTest.\* Review URL: http://codereview.chromium.org/391026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31833 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a comment.eroman@chromium.org2009-11-121-1/+1
| | | | | | Review URL: http://codereview.chromium.org/393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31832 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Explicitly use underlines in cookies dialog to fix display in Karmic.erg@google.com2009-11-121-0/+2
| | | | | | | | BUG=25635 Review URL: http://codereview.chromium.org/385073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31831 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up test_expectations.txt to track bugs that were marked as WONTFIXdpranke@google.com2009-11-121-12/+5
| | | | | | | | | | | | | | in issue tracker. A couple of tests don't seem to fail any more so I deleted them (in this change). The rest are bugs that need to be reopened. R=dglazkov@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/387034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31830 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the gaia captcha state and unlock capability in the sync setup wizard.tim@chromium.org2009-11-1216-80/+253
| | | | | | | | | | | BUG=19738 TEST=Get a Google Account into captcha state. Start syncing. You should be presented with a captcha image and textbox to answer the challenge. Doing so correctly shoud unlock your account and proceed with sync setup. Review URL: http://codereview.chromium.org/389017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31829 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Coverity defects in the FLIP code.wtc@chromium.org2009-11-123-5/+5
| | | | | | | | | | | | | CID=6816 PASS_BY_VALUE CID=6817 PASS_BY_VALUE CID=7523 UNINIT_CTOR R=mbelshe BUG=none TEST=none Review URL: http://codereview.chromium.org/392012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31828 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the last of the old samples.erikkay@chromium.org2009-11-129-589/+0
| | | | | | | | | | BUG=26106 TEST=none TBR=finnur Review URL: http://codereview.chromium.org/386023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31827 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly get ExtensionService out of EXTENSION_PROCESS_CRASHED notification.estade@chromium.org2009-11-121-1/+1
| | | | | | | | | | | Source is Profile*, not ExtensionsService*. BUG=27199 TEST=load gmail browser action extension, crash it with task manager, press reload button. Review URL: http://codereview.chromium.org/385076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31826 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Ignore incorrect focus notifications in Omnibox.shess@chromium.org2009-11-121-0/+9
| | | | | | | | | | | | | | | | | | | | | | | After the user runs a Print or Page Layout panel, autocomplete_edit_view_mac.mm starts seeing -controlTextDidBeginEditing: notifications when the field does not have a field editor. The code thoroughly depends on having a field editor when it has focus, so this breaks things badly. -controlTextDidBeginEditing: appears to be sent multiple times when in this state, once inappropriately, and later when everything is set up correctly (when the user edits), so this simply ignores the inappropriate notification. In the case that is being ignored, AutocompleteEditViewMac will fire DCHECKs all over the place, so it's somewhat unlikely that this case is happening in correct operation. BUG=19116, 17803 TEST=Login to gmail, select a message, j, k, and other keys should work (and not send you to the omnibox). Bring up the Print panel and cancel. Bring up a new tab and close it. gmail's accelerator keys should still work right (not send focus to omnibox). Review URL: http://codereview.chromium.org/391001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31825 0039d316-1c4b-4281-b951-d872f2087c98
* Added presubmit checks to verify that files have the svn:eol-style=LF property.apatrick@google.com2009-11-121-0/+18
| | | | | | | | | | | Use this command to set it: svn propset svn:eol-style LF <path> Review URL: http://codereview.chromium.org/384095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31824 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Hide "Make this my home page" after setting the home page.arv@chromium.org2009-11-127-30/+113
| | | | | | | | | | | | | | | | | | | | This also fixes an l10n issue where the string was hard coded in English. Instead of using the tips infrastructure, after setting the home page we send an ack to the NTP and show a notification. In this way the user will see the notification even if they have hidden the tips. Added a ui test that clicks on the link and checks the state of the UI afterwards. BUG=25101 TEST=Set your home page to non NTP. Go the the NTP by opening a new tab. Click on the link "Make this my home page" at the bottom. You should see a banner at the top. Pressing Alt-Home should now go to the NTP. Review URL: http://codereview.chromium.org/392005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31823 0039d316-1c4b-4281-b951-d872f2087c98
* Print allocation callstacks to LOG(ERROR) rather than std err, since ↵eroman@chromium.org2009-11-121-1/+1
| | | | | | | | otherwise it doesn't show up inline in the log file. Review URL: http://codereview.chromium.org/391029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31822 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash during shutdown where SafeBrowsingProtocolManager could end up ↵eroman@chromium.org2009-11-125-21/+49
| | | | | | | | | | | | | | | getting back NULL for Profile::GetDefaultRequestContext() and consequently URLFetcher would crash. During shutdown the Profile is first deleted, and THEN the IO thread is torn down. This means there is a window of time when Profile::GetDefaultRequestContext() will return NULL, but tasks are still running on the IO thread. Instead, SafeBrowsingProtocolManager now gets passed an explicit context, and holds a reference throughout its lifetime. This way it is guaranteed a valid pointer throughout the lifetime of the IO thread, even if the default Profile has already been deleted. BUG=27074 Review URL: http://codereview.chromium.org/392010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31821 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mediator_thread_impl.cc to run timer tasks when the task runner iszork@google.com2009-11-122-9/+15
| | | | | | | | | | | | | | | otherwise idle. BUG=19784, 26988 TEST=1. Enable sync and log in. 2. Go to about:sync 3. Check that notifications are enabled. 4. Disable all network adapters, and wait 15 seconds. 5. Refresh about:sync, and ensure that notifications are disabled. Review URL: http://codereview.chromium.org/391027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31820 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure OOM is a killer on the Mac.avi@chromium.org2009-11-125-0/+103
| | | | | | | | | BUG=http://crbug.com/12673 TEST=as in bug Review URL: http://codereview.chromium.org/385054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31819 0039d316-1c4b-4281-b951-d872f2087c98
* * Fix a bug with the applicationCache.status return value. The wrong status ↵michaeln@google.com2009-11-123-5/+22
| | | | | | | | | | | | | value was visible via applicationCache.status after a swap because we sample GetStatus() before swappable_cache_ was cleared out. * Pull the plug on support for file:// urls in DEBUG builds for now. TEST=added to appcache_host_unittest.cc BUG=none Review URL: http://codereview.chromium.org/385071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31818 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/386015 for dhg:sky@chromium.org2009-11-123-28/+90
| | | | | | | | | | | | | Changing the dom_ui so that it has a new call which allows the javascript of the page to open a new window. BUG=none TEST=none Review URL: http://codereview.chromium.org/385074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31816 0039d316-1c4b-4281-b951-d872f2087c98
* Move benchmark extension example to new location and clean it up to use ↵erikkay@chromium.org2009-11-1212-63/+70
| | | | | | | | | | | browser actions rather than toolstrips. BUG=26106 TEST=none Review URL: http://codereview.chromium.org/384065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31815 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for observing tracking areas so that when tabs are moved underneathdmaclach@chromium.org2009-11-122-3/+71
| | | | | | | | | | | | | | | | our cursor, we highlight them correctly. BUG=27458, 13208, 21448 TEST=Create a pile of tabs. Select a middle one. Put your cursor in some other tab. Hit cmd-w a couple of times Watch to make sure highlights occur correctly in both the tabs and the close buttons. Review URL: http://codereview.chromium.org/386021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31814 0039d316-1c4b-4281-b951-d872f2087c98
* Missed some files that should have been in 31811.apatrick@google.com2009-11-122-152/+152
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31813 0039d316-1c4b-4281-b951-d872f2087c98
* Made all line endings consistently LF and added svn:eol-style=LF property to ↵apatrick@google.com2009-11-1241-8816/+8816
| | | | | | | | | | | | | | | | | | | | | | | | | | files with these names / extensions. c cc h mm txt idl py js html css gyp gypi xml shader json htm README DEPS git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31811 0039d316-1c4b-4281-b951-d872f2087c98
* Focus fix for compact navigation bar.oshima@chromium.org2009-11-128-3/+49
| | | | | | | | | | | | * Make focusable so that focus can be moved to compact navigation bar by tab. * Ctrl-L should focus the compact navigation bar (and select all texts) BUG=51 (chrome-os) TEST=switch to compact navigation bar mode, hit tab or ctrl-L to move focus to compact navigation bar. Review URL: http://codereview.chromium.org/384079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31808 0039d316-1c4b-4281-b951-d872f2087c98
* disable toolstrip test for chromeos/linux_viewoshima@chromium.org2009-11-121-0/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/391033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31807 0039d316-1c4b-4281-b951-d872f2087c98
* Add the sync options to the preferences dialog on Linux.zork@chromium.org2009-11-122-2/+202
| | | | | | | | | BUG=none TEST=With bookmark sync enabled, go to Wrench Menu->Sync my bookmarks. Ensure that the Bookmark Sync section is there and useable. Review URL: http://codereview.chromium.org/385026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31805 0039d316-1c4b-4281-b951-d872f2087c98
* Initial change for the implementation of browser actions on the mac.andybons@chromium.org2009-11-128-67/+1464
| | | | | | | | | | Popups are not implemented within this change. BUG=23881 TEST=Install a browser action extension on the mac. Observe that something actually happens in the UI. Review URL: http://codereview.chromium.org/366029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31803 0039d316-1c4b-4281-b951-d872f2087c98
* Moves the animation for the download_started into an overlay window to getdmaclach@chromium.org2009-11-121-102/+132
| | | | | | | | | | | | | | | | | rid of jankyness on 10.6. It really shouldn't have worked right on 10.5 either. The layer needed to be hosted in a view. Views should not overlap. The only ways to do this correctly are: a) Turn on setWantsLayer for the browser view and make a subview to host our animation. b) An overlay window Went with 'b', because 'a' may be a big memory hit, and I'm not sure how webkit works in a layered environment. BUG=23500 TEST=see bug Review URL: http://codereview.chromium.org/385053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31802 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 16:36:04 +0000